{"thread":{"id":"61258","subject":"Subject: [PATCH 3/9] refs/reftable: skip duplicate name checks","startedAt":"2024-04-03T09:47:22Z","lastAt":"2024-04-03T16:21:26Z","messageCount":3,"participants":["Han-Wen Nienhuys","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":9},"messages":[{"id":"492146","messageId":"CAOw_e7YspBkOo7QE0Z3QqWXd6P1OVnF9j3q7ircrce25KNbKLw@mail.gmail.com","threadId":"61258","inReplyTo":null,"subject":"Subject: [PATCH 3/9] refs/reftable: skip duplicate name checks","fromName":"Han-Wen Nienhuys","fromEmail":"hanwenn@gmail.com","sentAt":"2024-04-03T09:47:10Z","receivedAt":"2024-04-03T09:47:22Z","isPatch":true,"sender":{"key":"hanwenn@gmail.com","avatar":"https://gravatar.com/avatar/058832acb8d613baeb6ce9d21b009d9772424a309b9a521330423daef909a27a?d=mp&s=160"},"body":"I can't remember why I did not rely on the available routine (did it\nnot exist at the time? or maybe I assumed the files backend relied on\nthe file system to enforce well-formedness).  If the functionality is\ncovered by refs_verify_refname_available, it's probably better to rip\nout of the reftable library (essentially, just delete refname.c and\nfriends) rather than disable it. I am assuming libgit2 will have an\nequivalent routine as well.\n\n-- \nHan-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen\n"},{"id":"492154","messageId":"Zg07vKzkeXt7l8RW@tanuki","threadId":"61258","inReplyTo":"CAOw_e7YspBkOo7QE0Z3QqWXd6P1OVnF9j3q7ircrce25KNbKLw@mail.gmail.com","subject":"Re: Subject: [PATCH 3/9] refs/reftable: skip duplicate name checks","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-04-03T11:21:32Z","receivedAt":"2024-04-03T11:21:39Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Wed, Apr 03, 2024 at 11:47:10AM +0200, Han-Wen Nienhuys wrote:\n> I can't remember why I did not rely on the available routine (did it\n> not exist at the time? or maybe I assumed the files backend relied on\n> the file system to enforce well-formedness).  If the functionality is\n> covered by refs_verify_refname_available, it's probably better to rip\n> out of the reftable library (essentially, just delete refname.c and\n> friends) rather than disable it. I am assuming libgit2 will have an\n> equivalent routine as well.\n\nYeah, I was on the fence whether I do or don't want to delete the\ncorresponding code. In any case, without Git as a user it's much more\nlikely to start bitrotting even though we do have some unit tests in\nthis area. Whether libgit2 does have a similar generic D/F check I\ncannot remember though -- it's been a very long time since I have\nwritten the reftable backend for libgit2, and the pull request is\nbitrotting.\n\nMy assumption is that as soon as there is going to be a second user of\nthis library we'll have to do some cleanups regardless. So I'm inclined\nto delete the code now and potentially bring it back if we ever see that\nit's indeed important for external users.\n\nPatrick\n"},{"id":"492170","messageId":"xmqq7chea03i.fsf@gitster.g","threadId":"61258","inReplyTo":"Zg07vKzkeXt7l8RW@tanuki","subject":"Re: Subject: [PATCH 3/9] refs/reftable: skip duplicate name checks","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-04-03T16:21:21Z","receivedAt":"2024-04-03T16:21:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> My assumption is that as soon as there is going to be a second user of\n> this library we'll have to do some cleanups regardless. So I'm inclined\n> to delete the code now and potentially bring it back if we ever see that\n> it's indeed important for external users.\n\nThe less code we need to carry, the better.\n\nThanks for the suggestion (and renewed involvement), Han-Wen.\n"}]}