{"thread":{"id":"61208","subject":"GSoC 2024 [PATCH]","startedAt":"2024-03-27T09:36:11Z","lastAt":"2024-03-27T15:23:58Z","messageCount":3,"participants":["Aishwarya Narayanan","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"491676","messageId":"CAHCXyj3Now+ZrA+w+L-sQAtAMZ8REru=3uF_Y3Xdt=7CSf=pYQ@mail.gmail.com","threadId":"61208","inReplyTo":null,"subject":"GSoC 2024 [PATCH]","fromName":"Aishwarya Narayanan","fromEmail":"aishnana.03@gmail.com","sentAt":"2024-03-27T09:35:57Z","receivedAt":"2024-03-27T09:36:11Z","isPatch":true,"sender":{"key":"aishnana.03@gmail.com","avatar":null},"body":"Dear Git Organization,\n\nI hope this email finds you well. I've prepared a patch to address an\nissue related to the handling of exit codes in our test suite\nconcerning the Microproject idea Avoid suppressing Git’s exit code in\ntest scripts. The changes ensure that the exit code of the write_utf16\nand write_utf32 functions is properly captured and not suppressed,\nimproving the reliability of our testing process.\nI kindly request your review and any remarks or changes you may have.\nPlease accept my apologies for any mistakes or oversights. Thank you\nfor your time and attention.\n\nBest regards,\n Aishwarya Narayanan\n\n\nFrom 1493c834b2373226992d6c58f88549e7bc8dfd40 Mon Sep 17 00:00:00 2001\nFrom: Aishwarya Narayanan <aishnana.03@gmail.com>\nDate: Wed, 27 Mar 2024 14:47:40 +0530\nSubject: [PATCH] The change ensures that the exit code of  write_utf16 and\n write_utf32 is properly captured and not suppressed.\n\n---\n t/t0028-working-tree-encoding.sh | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t0028-working-tree-encoding.sh b/t/t0028-working-tree-encoding.sh\nindex ad151a3467..f372c14bc0 100755\n--- a/t/t0028-working-tree-encoding.sh\n+++ b/t/t0028-working-tree-encoding.sh\n@@ -19,10 +19,13 @@ test_expect_success 'setup test files' '\n \techo \"*.utf16 text working-tree-encoding=utf-16\" >.gitattributes &&\n \techo \"*.utf16lebom text working-tree-encoding=UTF-16LE-BOM\" >>.gitattributes &&\n \tprintf \"$text\" >test.utf8.raw &&\n-\tprintf \"$text\" | write_utf16 >test.utf16.raw &&\n-\tprintf \"$text\" | write_utf32 >test.utf32.raw &&\n-\tprintf \"\\377\\376\"                         >test.utf16lebom.raw &&\n-\tprintf \"$text\" | iconv -f UTF-8 -t UTF-16LE >>test.utf16lebom.raw &&\n+\ttest_utf16_raw=$(printf \"$text\" | write_utf16) &&\n+\ttest_utf32_raw=$(printf \"$text\" | write_utf32) &&\n+\ttest_utf16lebom_raw=$(printf \"\\377\\376\"; printf \"$text\" | iconv -f UTF-8 -t UTF-16LE) &&\n+\techo \"$test_utf16_raw\" > test.utf16.raw &&\n+\techo \"$test_utf32_raw\" > test.utf32.raw &&\n+\techo \"$test_utf16lebom_raw\" > test.utf16lebom.raw &&\n+\n \n \t# Line ending tests\n \tprintf \"one\\ntwo\\nthree\\n\" >lf.utf8.raw &&\n-- \n2.44.0.windows.1\n\n"},{"id":"491678","messageId":"ZgPrLXjB5mVXitXu@tanuki","threadId":"61208","inReplyTo":"CAHCXyj3Now+ZrA+w+L-sQAtAMZ8REru=3uF_Y3Xdt=7CSf=pYQ@mail.gmail.com","subject":"Re: GSoC 2024 [PATCH]","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-03-27T09:47:25Z","receivedAt":"2024-03-27T09:47:30Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Wed, Mar 27, 2024 at 03:05:57PM +0530, Aishwarya Narayanan wrote:\n> Dear Git Organization,\n> \n> I hope this email finds you well. I've prepared a patch to address an\n> issue related to the handling of exit codes in our test suite\n> concerning the Microproject idea Avoid suppressing Git’s exit code in\n> test scripts. The changes ensure that the exit code of the write_utf16\n> and write_utf32 functions is properly captured and not suppressed,\n> improving the reliability of our testing process.\n> I kindly request your review and any remarks or changes you may have.\n> Please accept my apologies for any mistakes or oversights. Thank you\n> for your time and attention.\n\nPlease not that patches are supposed to be sent as mails directly\ninstead of being attached to mails. You can use e.g. git-send-email(1)\nto achieve this.\n\nI would recommend to have a look \"Documentation/MyFirstContribution.txt\"\nand \"Documentation/SubmittingPatches\". These resources should get you a\nbetter picture of how a typical workflow would look like here.\n\nThanks!\n\nPatrick\n"},{"id":"491699","messageId":"xmqqfrwb4s1g.fsf@gitster.g","threadId":"61208","inReplyTo":"ZgPrLXjB5mVXitXu@tanuki","subject":"Re: GSoC 2024 [PATCH]","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-27T15:23:55Z","receivedAt":"2024-03-27T15:23:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> Please not that patches are supposed to be sent as mails directly\n> instead of being attached to mails. You can use e.g. git-send-email(1)\n> to achieve this.\n>\n> I would recommend to have a look \"Documentation/MyFirstContribution.txt\"\n> and \"Documentation/SubmittingPatches\". These resources should get you a\n> better picture of how a typical workflow would look like here.\n\nThanks.  It is very good that you recommended the documentation on\nthe contribution process.\n\nThe tasks for microproject are designed to be easy to solve and the\nchanges in the patches themselves would not be the interesting part\nfor new contributors.  Rather, it is designed for a new contributor\nto experience the contribution process from the beginning to the\nend, from coming up with an initial patch and explaining it well,\nsending it to the list in the established way, receiving and\nresponding to review comments, and move on to the next iteration.\n"}]}