{"thread":{"id":"61194","subject":"[PATCH v2 0/3] Assorted improvements salvaged from an earlier series","startedAt":"2024-03-24T17:51:23Z","lastAt":"2024-03-25T21:28:15Z","messageCount":11,"participants":["Dragan Simic","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":3},"messages":[{"id":"491368","messageId":"cover.1711302588.git.dsimic@manjaro.org","threadId":"61194","inReplyTo":null,"subject":"[PATCH v2 0/3] Assorted improvements salvaged from an earlier series","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-03-24T17:51:10Z","receivedAt":"2024-03-24T17:51:23Z","isPatch":true,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"This series contains patches salvaged from my earlier series, [1] for\nwhich it has been concluded to be not acceptable for merging, because of\npossible issues with various git scripts. [2]\n\nChanges introduced to the patches are described separately in each patch.\n\nLink to v1: https://lore.kernel.org/git/cover.1710968761.git.dsimic@manjaro.org/T/#u\n\n[1] https://lore.kernel.org/git/cover.1710781235.git.dsimic@manjaro.org/T/#u\n[2] https://lore.kernel.org/git/d8475579f014a90b27efaf6207bc6fb0@manjaro.org/\n\nDragan Simic (3):\n grep: perform some minor code and comment cleanups\n grep docs: describe --recurse-submodules further and improve\n formatting a bit\n grep docs: describe --no-index further and improve formatting a bit\n\n Documentation/config/grep.txt | 2 +-\n Documentation/git-grep.txt | 36 +++++++++++++++++++++--------------\n builtin/grep.c | 21 ++++++++------------\n 3 files changed, 31 insertions(+), 28 deletions(-)\n\n"},{"id":"491370","messageId":"55867253d2925892f5192dbc3145f7bc9221b791.1711302588.git.dsimic@manjaro.org","threadId":"61194","inReplyTo":"cover.1711302588.git.dsimic@manjaro.org","subject":"[PATCH v2 1/3] grep: perform some minor code and comment cleanups","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-03-24T17:51:11Z","receivedAt":"2024-03-24T17:51:23Z","isPatch":true,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"Move some variable definitions around, and reflow one comment block, to\nmake the code a bit neater after spotting those slightly unpolished areas.\nThere are no functional changes to the source code.\n\nSigned-off-by: Dragan Simic \n---\n\nNotes:\n Changes in v2:\n - No changes were introduced\n \n This patch is salvaged from my earlier series, [1] for which it has been\n concluded to be not acceptable for merging, because of possible issues\n with various git scripts. [2]\n \n Compared to the version in the earlies series, there are no changes in\n this version. As expected and as already discussed, patches like this one\n inevitably raise a few eyebrows. [3][4][5]\n \n [1] https://lore.kernel.org/git/cover.1710781235.git.dsimic@manjaro.org/T/#u\n [2] https://lore.kernel.org/git/d8475579f014a90b27efaf6207bc6fb0@manjaro.org/\n [3] https://lore.kernel.org/git/CAPig+cQ6Y2oOaPkKFsD41beXLHjhD++nmf59xrcswpb6_Q-sdA@mail.gmail.com/\n [4] https://lore.kernel.org/git/xmqqjzlzt61d.fsf@gitster.g/#t\n [5] https://lore.kernel.org/git/24093dca675c49cfde39f6d6efca2342@manjaro.org/\n\n builtin/grep.c | 21 ++++++++-------------\n 1 file changed, 8 insertions(+), 13 deletions(-)\n\ndiff --git a/builtin/grep.c b/builtin/grep.c\nindex 982bcfc4b1df..af89c8b5cb19 100644\n--- a/builtin/grep.c\n+++ b/builtin/grep.c\n@@ -623,13 +623,13 @@ static int grep_tree(struct grep_opt *opt, const struct pathspec *pathspec,\n \t\t struct tree_desc *tree, struct strbuf *base, int tn_len,\n \t\t int check_attr)\n {\n-\tstruct repository *repo = opt->repo;\n-\tint hit = 0;\n+\tint hit = 0, name_base_len = 0;\n+\tint old_baselen = base->len;\n \tenum interesting match = entry_not_interesting;\n+\tstruct repository *repo = opt->repo;\n \tstruct name_entry entry;\n-\tint old_baselen = base->len;\n \tstruct strbuf name = STRBUF_INIT;\n-\tint name_base_len = 0;\n+\n \tif (repo->submodule_prefix) {\n \t\tstrbuf_addstr(&name, repo->submodule_prefix);\n \t\tname_base_len = name.len;\n@@ -890,19 +890,15 @@ static int pattern_callback(const struct option *opt, const char *arg,\n \n int cmd_grep(int argc, const char **argv, const char *prefix)\n {\n-\tint hit = 0;\n+\tint hit = 0, seen_dashdash = 0, use_index = 1;\n \tint cached = 0, untracked = 0, opt_exclude = -1;\n-\tint seen_dashdash = 0;\n \tint external_grep_allowed__ignored;\n+\tint i, dummy, allow_revs;\n \tconst char *show_in_pager = NULL, *default_pager = \"dummy\";\n \tstruct grep_opt opt;\n \tstruct object_array list = OBJECT_ARRAY_INIT;\n \tstruct pathspec pathspec;\n \tstruct string_list path_list = STRING_LIST_INIT_DUP;\n-\tint i;\n-\tint dummy;\n-\tint use_index = 1;\n-\tint allow_revs;\n \n \tstruct option options[] = {\n \t\tOPT_BOOL(0, \"cached\", &cached,\n@@ -1059,9 +1055,8 @@ int cmd_grep(int argc, const char **argv, const char *prefix)\n \t\trecurse_submodules = 0;\n \n \t/*\n-\t * skip a -- separator; we know it cannot be\n-\t * separating revisions from pathnames if\n-\t * we haven't even had any patterns yet\n+\t * skip a -- separator; we know it cannot be separating revisions\n+\t * from pathnames if we haven't even had any patterns yet\n \t */\n \tif (argc > 0 && !opt.pattern_list && !strcmp(argv[0], \"--\")) {\n \t\targv++;\n"},{"id":"491371","messageId":"cf9d3f4833f121b271fd8aacf4c0e2e4a9920585.1711302588.git.dsimic@manjaro.org","threadId":"61194","inReplyTo":"cover.1711302588.git.dsimic@manjaro.org","subject":"[PATCH v2 2/3] grep docs: describe --recurse-submodules further and improve formatting a bit","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-03-24T17:51:12Z","receivedAt":"2024-03-24T17:51:24Z","isPatch":true,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"Clarify that --recurse-submodules cannot be used together with --untracked,\nand improve the formatting in a couple of places, to make it visually clear\nthat those are the commands or the names of configuration options.\n\nWhile there, change a couple of \"\" placeholders to \"__\", to help\nwith an ongoing translation improvement effort. [1]\n\n[1] https://lore.kernel.org/git/CAPig+cQc8W4JOpB+TMP=czketU1U7wcY_x9bsP5T=3-XjGLhRQ@mail.gmail.com/\n\nSigned-off-by: Dragan Simic \n---\n\nNotes:\n Changes in v2:\n - No changes were introduced\n \n This patch is salvaged from my earlier series, [2] for which it has been\n concluded to be not acceptable for merging, because of possible issues\n with various git scripts. [3]\n \n Compared to the version in the earlier series, this version adds some more\n small formatting improvements of the same kind, and also changes a couple\n of \"\" placeholders to \"__\", as suggested by Eric Sunshine. [1]\n \n [2] https://lore.kernel.org/git/cover.1710781235.git.dsimic@manjaro.org/T/#u\n [3] https://lore.kernel.org/git/d8475579f014a90b27efaf6207bc6fb0@manjaro.org/\n\n Documentation/config/grep.txt | 2 +-\n Documentation/git-grep.txt | 10 +++++-----\n 2 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/config/grep.txt b/Documentation/config/grep.txt\nindex e521f20390ce..10041f27b0c8 100644\n--- a/Documentation/config/grep.txt\n+++ b/Documentation/config/grep.txt\n@@ -24,5 +24,5 @@ grep.fullName::\n \tIf set to true, enable `--full-name` option by default.\n \n grep.fallbackToNoIndex::\n-\tIf set to true, fall back to git grep --no-index if git grep\n+\tIf set to true, fall back to `git grep --no-index` if `git grep`\n \tis executed outside of a git repository. Defaults to false.\ndiff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt\nindex 0d0103c780af..f64f40e9775a 100644\n--- a/Documentation/git-grep.txt\n+++ b/Documentation/git-grep.txt\n@@ -64,9 +64,9 @@ OPTIONS\n --recurse-submodules::\n \tRecursively search in each submodule that is active and\n \tchecked out in the repository. When used in combination with the\n-\t option the prefix of all submodule output will be the name of\n-\tthe parent project's object. This option has no effect\n-\tif `--no-index` is given.\n+\t__ option the prefix of all submodule output will be the name of\n+\tthe parent project's __ object. This option cannot be used together\n+\twith `--untracked`, and it has no effect if `--no-index` is specified.\n \n -a::\n --text::\n@@ -178,7 +178,7 @@ providing this option will cause it to die.\n \tUse \\0 as the delimiter for pathnames in the output, and print\n \tthem verbatim. Without this option, pathnames with \"unusual\"\n \tcharacters are quoted as explained for the configuration\n-\tvariable core.quotePath (see linkgit:git-config[1]).\n+\tvariable `core.quotePath` (see linkgit:git-config[1]).\n \n -o::\n --only-matching::\n@@ -332,7 +332,7 @@ EXAMPLES\n NOTES ON THREADS\n ----------------\n \n-The `--threads` option (and the grep.threads configuration) will be ignored when\n+The `--threads` option (and the `grep.threads` configuration) will be ignored when\n `--open-files-in-pager` is used, forcing a single-threaded execution.\n \n When grepping the object store (with `--cached` or giving tree objects), running\n"},{"id":"491369","messageId":"a7e5151fa615d572ab4ed05519dd277048ce935c.1711302588.git.dsimic@manjaro.org","threadId":"61194","inReplyTo":"cover.1711302588.git.dsimic@manjaro.org","subject":"[PATCH v2 3/3] grep docs: describe --no-index further and improve formatting a bit","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-03-24T17:51:13Z","receivedAt":"2024-03-24T17:51:25Z","isPatch":true,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"Improve the description of --no-index, to make it more clear to the users\nwhat this option actually does under the hood, and what's its purpose.\nDescribe the dependency between --no-index and either of the --cached and\n--untracked options, which cannot be used together.\n\nAs part of that, shuffle a couple of the options, to make the documentation\nflow a bit better, because it makes more sense to describe first the options\nthat have something in common, and to after that describe an option that does\nsomething differently. In more detail, --cached and --untracked both leave\ngit-grep(1) in the usual state, in which it treats the directory as a local\ngit repository, unlike --no-index that makes git-grep(1) treat the directory\nnot as a git repository.\n\nWhile there, improve the descriptions of grep worker threads a bit, to give\nthem better context. Adjust the language a bit, to avoid addressing the\nreader directly, which is in general preferred in technical documentation,\nbecause it eliminates the possible element of persuading the user to do\nsomething. In other words, we should be telling the user what our software\ncan do, instead of telling the user what to do.\n\nAlso perform some minor formatting improvements, to make it clear it's the\ngit commands, command parameters, and configuration option names.\n\nSigned-off-by: Dragan Simic \n---\n\nNotes:\n Changes in v2:\n - Improved the patch description a bit, to make it more clear why\n this patch shuffles some of the options around, and why it changes\n some of the wording to passive voice\n - Reworded the description of --no-index a bit, to not mention the\n name of the utility we're describing, which avoids any possible\n confusion, as pointed out by Jean-Noel Avila [1]\n \n This patch is salvaged from my earlier series, [2] for which it has been\n concluded to be not acceptable for merging, because of possible issues\n with various git scripts. [3]\n \n Compared to the version in the earlier series, this version continues\n the effort to improve the description of --no-index, by also incorporating\n the possible improvements pointed out by Junio. [4] This version also\n improves the wording of some related descriptions, mainly related to\n grep.threads, and performs some additional small formatting improvements.\n \n [1] https://lore.kernel.org/git/ed050f2d496a6db07e698fd2f1094b81@manjaro.org/\n [2] https://lore.kernel.org/git/cover.1710781235.git.dsimic@manjaro.org/T/#u\n [3] https://lore.kernel.org/git/d8475579f014a90b27efaf6207bc6fb0@manjaro.org/\n [4] https://lore.kernel.org/git/xmqqwmpzrqfv.fsf@gitster.g/\n\n Documentation/git-grep.txt | 26 +++++++++++++++++---------\n 1 file changed, 17 insertions(+), 9 deletions(-)\n\ndiff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt\nindex f64f40e9775a..bfa87ba22ed5 100644\n--- a/Documentation/git-grep.txt\n+++ b/Documentation/git-grep.txt\n@@ -28,7 +28,7 @@ SYNOPSIS\n \t [-f ] [-e] \n \t [--and|--or|--not|(|)|-e ...]\n \t [--recurse-submodules] [--parent-basename ]\n-\t [ [--[no-]exclude-standard] [--cached | --no-index | --untracked] | ...]\n+\t [ [--[no-]exclude-standard] [--cached | --untracked | --no-index] | ...]\n \t [--] [...]\n \n DESCRIPTION\n@@ -45,13 +45,20 @@ OPTIONS\n \tInstead of searching tracked files in the working tree, search\n \tblobs registered in the index file.\n \n---no-index::\n-\tSearch files in the current directory that is not managed by Git.\n-\n --untracked::\n \tIn addition to searching in the tracked files in the working\n \ttree, search also in untracked files.\n \n+--no-index::\n+\tSearch files in the current directory that is not managed by Git,\n+\tor by ignoring that the current directory is managed by Git. This\n+\tis rather similar to running the regular `grep(1)` utility with its\n+\t`-r` option specified, but with some additional benefits, such as\n+\tusing multiple worker threads to speed up searches.\n++\n+This option cannot be used together with `--cached` or `--untracked`.\n+See also `grep.fallbackToNoIndex` in 'CONFIGURATION' below.\n+\n --no-exclude-standard::\n \tAlso search in ignored files by not honoring the `.gitignore`\n \tmechanism. Only useful with `--untracked`.\n@@ -248,8 +255,9 @@ providing this option will cause it to die.\n \ta non-zero status.\n \n --threads ::\n-\tNumber of grep worker threads to use.\n-\tSee `grep.threads` in 'CONFIGURATION' for more information.\n+\tNumber of `grep` worker threads to use, to speed up searches.\n+\tSee 'NOTES ON THREADS' and `grep.threads` in 'CONFIGURATION'\n+\tfor more information.\n \n -f ::\n \tRead patterns from , one per line.\n@@ -336,9 +344,9 @@ The `--threads` option (and the `grep.threads` configuration) will be ignored wh\n `--open-files-in-pager` is used, forcing a single-threaded execution.\n \n When grepping the object store (with `--cached` or giving tree objects), running\n-with multiple threads might perform slower than single threaded if `--textconv`\n-is given and there are too many text conversions. So if you experience low\n-performance in this case, it might be desirable to use `--threads=1`.\n+with multiple threads might perform slower than single-threaded if `--textconv`\n+is given and there are too many text conversions. Thus, if low performance is\n+experienced in this case, it might be desirable to use `--threads=1`.\n \n CONFIGURATION\n -------------\n"},{"id":"491492","messageId":"xmqqo7b2jfms.fsf@gitster.g","threadId":"61194","inReplyTo":"cf9d3f4833f121b271fd8aacf4c0e2e4a9920585.1711302588.git.dsimic@manjaro.org","subject":"Re: [PATCH v2 2/3] grep docs: describe --recurse-submodules further and improve formatting a bit","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-25T19:06:03Z","receivedAt":"2024-03-25T19:06:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dragan Simic writes:\n\n> Clarify that --recurse-submodules cannot be used together with --untracked,\n> and improve the formatting in a couple of places, to make it visually clear\n> that those are the commands or the names of configuration options.\n>\n> While there, change a couple of \"\" placeholders to \"__\", to help\n> with an ongoing translation improvement effort. [1]\n\nThese are all clear improvements. Will queue. Thanks\n\n"},{"id":"491493","messageId":"xmqqa5mmjf2f.fsf@gitster.g","threadId":"61194","inReplyTo":"a7e5151fa615d572ab4ed05519dd277048ce935c.1711302588.git.dsimic@manjaro.org","subject":"Re: [PATCH v2 3/3] grep docs: describe --no-index further and improve formatting a bit","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-25T19:18:16Z","receivedAt":"2024-03-25T19:18:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dragan Simic writes:\n\n> +--no-index::\n> +\tSearch files in the current directory that is not managed by Git,\n> +\tor by ignoring that the current directory is managed by Git. This\n> +\tis rather similar to running the regular `grep(1)` utility with its\n> +\t`-r` option specified, but with some additional benefits, such as\n> +\tusing multiple worker threads to speed up searches.\n\nSorry for not mentioning this earlier, but I do not think\nmulti-threaded grep has to be something we own and others cannot\nimplement. A richer pathspec globbing [*1*] and logical operation\non match results may be better examples of \"additional benefits\" if\nwe really wanted to mention why people might want to use\n\"--no-index\" in a directory that is outside Git.\n\n[Footnote]\n\n *1* When you want to look for something in files whose name begins\n with \"g\" but does not have \"rc\" in it, you'd do\n\n $ git grep --no-index -c . ':(exclude)*rc*' 'g*'\n\n> ++\n> +This option cannot be used together with `--cached` or `--untracked`.\n> +See also `grep.fallbackToNoIndex` in 'CONFIGURATION' below.\n> +\n\nOK.\n\n> --threads ::\n> -\tNumber of grep worker threads to use.\n> -\tSee `grep.threads` in 'CONFIGURATION' for more information.\n> +\tNumber of `grep` worker threads to use, to speed up searches.\n> +\tSee 'NOTES ON THREADS' and `grep.threads` in 'CONFIGURATION'\n> +\tfor more information.\n\nI actually do not think adding \", to speed up searches\" is an\nimprovement. But referring to NOTES ON THREADS is a good idea, and\nby reading that NOTES ON THREADS section, readers can tell why it\nsometimes does not speed things up or even slow them down.\n\nOther than that, looking great.\n\nThanks.\n"},{"id":"491496","messageId":"b9001537c3cdd44ef91d323f2b54cae7@manjaro.org","threadId":"61194","inReplyTo":"xmqqo7b2jfms.fsf@gitster.g","subject":"Re: [PATCH v2 2/3] grep docs: describe --recurse-submodules further and improve formatting a bit","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-03-25T19:46:21Z","receivedAt":"2024-03-25T19:46:24Z","isPatch":true,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"On 2024-03-25 20:06, Junio C Hamano wrote:\n> Dragan Simic writes:\n> \n>> Clarify that --recurse-submodules cannot be used together with \n>> --untracked,\n>> and improve the formatting in a couple of places, to make it visually \n>> clear\n>> that those are the commands or the names of configuration options.\n>> \n>> While there, change a couple of \"\" placeholders to \"__\", \n>> to help\n>> with an ongoing translation improvement effort. [1]\n> \n> These are all clear improvements. Will queue. Thanks\n\nGreat, thanks.\n"},{"id":"491497","messageId":"d741fe83f01b0a7b19ba5e1871855737@manjaro.org","threadId":"61194","inReplyTo":"xmqqa5mmjf2f.fsf@gitster.g","subject":"Re: [PATCH v2 3/3] grep docs: describe --no-index further and improve formatting a bit","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-03-25T19:53:36Z","receivedAt":"2024-03-25T19:53:38Z","isPatch":true,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"On 2024-03-25 20:18, Junio C Hamano wrote:\n> Dragan Simic writes:\n> \n>> +--no-index::\n>> +\tSearch files in the current directory that is not managed by Git,\n>> +\tor by ignoring that the current directory is managed by Git. This\n>> +\tis rather similar to running the regular `grep(1)` utility with its\n>> +\t`-r` option specified, but with some additional benefits, such as\n>> +\tusing multiple worker threads to speed up searches.\n> \n> Sorry for not mentioning this earlier, but I do not think\n> multi-threaded grep has to be something we own and others cannot\n> implement. A richer pathspec globbing [*1*] and logical operation\n> on match results may be better examples of \"additional benefits\" if\n> we really wanted to mention why people might want to use\n> \"--no-index\" in a directory that is outside Git.\n\nNo worries. Furthermore, multi-threaded searches may actually not\nbe faster for some workloads, or on some systems (the resulting speed\ndepends heavily on the I/O speed and available CPU power, which not\nall systems have plenty of), so I agree that it's better not to mention\nit. I'll send the v3 with adjusted wording.\n\n> [Footnote]\n> \n> *1* When you want to look for something in files whose name begins\n> with \"g\" but does not have \"rc\" in it, you'd do\n> \n> $ git grep --no-index -c . ':(exclude)*rc*' 'g*'\n> \n>> --threads ::\n>> -\tNumber of grep worker threads to use.\n>> -\tSee `grep.threads` in 'CONFIGURATION' for more information.\n>> +\tNumber of `grep` worker threads to use, to speed up searches.\n>> +\tSee 'NOTES ON THREADS' and `grep.threads` in 'CONFIGURATION'\n>> +\tfor more information.\n> \n> I actually do not think adding \", to speed up searches\" is an\n> improvement. But referring to NOTES ON THREADS is a good idea, and\n> by reading that NOTES ON THREADS section, readers can tell why it\n> sometimes does not speed things up or even slow them down.\n\nAgreed, as noted above. Will be adjusted in the v3.\n\n> Other than that, looking great.\n\nNice, that makes me happy. :)\n"},{"id":"491518","messageId":"xmqq5xxahvmi.fsf@gitster.g","threadId":"61194","inReplyTo":"55867253d2925892f5192dbc3145f7bc9221b791.1711302588.git.dsimic@manjaro.org","subject":"Re: [PATCH v2 1/3] grep: perform some minor code and comment cleanups","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-25T21:03:33Z","receivedAt":"2024-03-25T21:03:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dragan Simic writes:\n\n> Move some variable definitions around, and reflow one comment block, to\n> make the code a bit neater after spotting those slightly unpolished areas.\n> There are no functional changes to the source code.\n\nIt cannot be objectively better than the original as \"neater\" and\n'unpolished\" are fairly subjective. Let's leave this out and take\nthe two \"obviously good\" documentation improvements for now.\n\nThanks.\n"},{"id":"491522","messageId":"ab5145b696565ba170c90e2fc1b9a7e1@manjaro.org","threadId":"61194","inReplyTo":"xmqq5xxahvmi.fsf@gitster.g","subject":"Re: [PATCH v2 1/3] grep: perform some minor code and comment cleanups","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-03-25T21:17:40Z","receivedAt":"2024-03-25T21:17:42Z","isPatch":true,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"On 2024-03-25 22:03, Junio C Hamano wrote:\n> Dragan Simic writes:\n> \n>> Move some variable definitions around, and reflow one comment block, \n>> to\n>> make the code a bit neater after spotting those slightly unpolished \n>> areas.\n>> There are no functional changes to the source code.\n> \n> It cannot be objectively better than the original as \"neater\" and\n> 'unpolished\" are fairly subjective. Let's leave this out and take\n> the two \"obviously good\" documentation improvements for now.\n\nThat's fine with me. This \"experiment\", so to speak, has also taught me\nnot to pay attention to making the code \"neater\".\n"},{"id":"491525","messageId":"xmqqr0fygfx1.fsf@gitster.g","threadId":"61194","inReplyTo":"ab5145b696565ba170c90e2fc1b9a7e1@manjaro.org","subject":"Re: [PATCH v2 1/3] grep: perform some minor code and comment cleanups","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-25T21:28:10Z","receivedAt":"2024-03-25T21:28:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dragan Simic writes:\n\n> That's fine with me. This \"experiment\", so to speak, has also taught me\n> not to pay attention to making the code \"neater\".\n\nTrue. You should not give too much weight in your sense of what is\n\"neater\". Spending cycles on something you can measure is more\nproductive.\n\nThanks.\n"}]}