{"thread":{"id":"61131","subject":"[PATCH 1/2] docs: clarify file options in git-config `--edit`","startedAt":"2024-03-16T05:02:18Z","lastAt":"2024-03-21T16:23:18Z","messageCount":4,"participants":["Brian Lyles","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"490758","messageId":"20240316050149.1182867-1-brianmlyles@gmail.com","threadId":"61131","inReplyTo":null,"subject":"[PATCH 1/2] docs: clarify file options in git-config `--edit`","fromName":"Brian Lyles","fromEmail":"brianmlyles@gmail.com","sentAt":"2024-03-16T05:01:24Z","receivedAt":"2024-03-16T05:02:18Z","isPatch":true,"sender":{"key":"brianmlyles@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1123282?v=4"},"body":"The description for the `-e`/`--edit` option references scopes\ninconsistently: system and global are referenced by their option name\n(`--system`/`--global`), but repository (`--local` is not. Additionally,\nneither `--worktree` nor `--file` are referenced at all, despite also\nbeing a valid options.\n\nUpdate the description to mention all four available scopes as well as\n`--file`, referencing each consistently by their option name.\n\nSigned-off-by: Brian Lyles \n---\n Documentation/git-config.txt | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex dff39093b5..6876803253 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -275,7 +275,8 @@ Valid ``'s include:\n -e::\n --edit::\n \tOpens an editor to modify the specified config file; either\n-\t`--system`, `--global`, or repository (default).\n+\t`--system`, `--global`, `--local` (default), `--worktree`, or\n+\t`--file `.\n \n --[no-]includes::\n \tRespect `include.*` directives in config files when looking up\n-- \n2.43.0\n\n"},{"id":"490759","messageId":"20240316050149.1182867-2-brianmlyles@gmail.com","threadId":"61131","inReplyTo":"20240316050149.1182867-1-brianmlyles@gmail.com","subject":"[PATCH 2/2] docs: fix typo in git-config `--default`","fromName":"Brian Lyles","fromEmail":"brianmlyles@gmail.com","sentAt":"2024-03-16T05:01:25Z","receivedAt":"2024-03-16T05:02:19Z","isPatch":true,"sender":{"key":"brianmlyles@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1123282?v=4"},"body":"Signed-off-by: Brian Lyles \n---\n Documentation/git-config.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 6876803253..a6e82b871b 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -286,7 +286,7 @@ Valid ``'s include:\n \n --default ::\n When using `--get`, and the requested variable is not found, behave as if\n- were the value assigned to the that variable.\n+ were the value assigned to that variable.\n \n CONFIGURATION\n -------------\n-- \n2.43.0\n\n"},{"id":"491115","messageId":"ZfwFKyE-eOJo0zl4@tanuki","threadId":"61131","inReplyTo":"20240316050149.1182867-1-brianmlyles@gmail.com","subject":"Re: [PATCH 1/2] docs: clarify file options in git-config `--edit`","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-03-21T10:00:11Z","receivedAt":"2024-03-21T10:00:15Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sat, Mar 16, 2024 at 12:01:24AM -0500, Brian Lyles wrote:\n> The description for the `-e`/`--edit` option references scopes\n> inconsistently: system and global are referenced by their option name\n> (`--system`/`--global`), but repository (`--local` is not. Additionally,\n> neither `--worktree` nor `--file` are referenced at all, despite also\n> being a valid options.\n> \n> Update the description to mention all four available scopes as well as\n> `--file`, referencing each consistently by their option name.\n> \n> Signed-off-by: Brian Lyles \n\nI know that this series has been merged to `next` already, but as it\ndidn't get any on-list review I just wanted to mention that this series\nlooks good to me.\n\nPatrick\n\n> ---\n> Documentation/git-config.txt | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\n> index dff39093b5..6876803253 100644\n> --- a/Documentation/git-config.txt\n> +++ b/Documentation/git-config.txt\n> @@ -275,7 +275,8 @@ Valid ``'s include:\n> -e::\n> --edit::\n> \tOpens an editor to modify the specified config file; either\n> -\t`--system`, `--global`, or repository (default).\n> +\t`--system`, `--global`, `--local` (default), `--worktree`, or\n> +\t`--file `.\n> \n> --[no-]includes::\n> \tRespect `include.*` directives in config files when looking up\n> -- \n> 2.43.0\n> \n> \n"},{"id":"491157","messageId":"xmqqcyrnbll8.fsf@gitster.g","threadId":"61131","inReplyTo":"ZfwFKyE-eOJo0zl4@tanuki","subject":"Re: [PATCH 1/2] docs: clarify file options in git-config `--edit`","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-21T16:23:15Z","receivedAt":"2024-03-21T16:23:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt writes:\n\n> On Sat, Mar 16, 2024 at 12:01:24AM -0500, Brian Lyles wrote:\n>> The description for the `-e`/`--edit` option references scopes\n>> inconsistently: system and global are referenced by their option name\n>> (`--system`/`--global`), but repository (`--local` is not. Additionally,\n>> neither `--worktree` nor `--file` are referenced at all, despite also\n>> being a valid options.\n>> \n>> Update the description to mention all four available scopes as well as\n>> `--file`, referencing each consistently by their option name.\n>> \n>> Signed-off-by: Brian Lyles \n>\n> I know that this series has been merged to `next` already, but as it\n> didn't get any on-list review I just wanted to mention that this series\n> looks good to me.\n>\n> Patrick\n\nYeah, thanks, both of you.\n\n>\n>> ---\n>> Documentation/git-config.txt | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>> \n>> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\n>> index dff39093b5..6876803253 100644\n>> --- a/Documentation/git-config.txt\n>> +++ b/Documentation/git-config.txt\n>> @@ -275,7 +275,8 @@ Valid ``'s include:\n>> -e::\n>> --edit::\n>> \tOpens an editor to modify the specified config file; either\n>> -\t`--system`, `--global`, or repository (default).\n>> +\t`--system`, `--global`, `--local` (default), `--worktree`, or\n>> +\t`--file `.\n>> \n>> --[no-]includes::\n>> \tRespect `include.*` directives in config files when looking up\n>> -- \n>> 2.43.0\n>> \n>> \n"}]}