{"thread":{"id":"61087","subject":"[PATCH] ci(github): make Windows test artifacts name unique","startedAt":"2024-03-10T20:05:00Z","lastAt":"2024-03-10T20:05:00Z","messageCount":1,"participants":["Philippe Blain via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"490348","messageId":"pull.1688.git.1710101097072.gitgitgadget@gmail.com","threadId":"61087","inReplyTo":null,"subject":"[PATCH] ci(github): make Windows test artifacts name unique","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-03-10T20:04:56Z","receivedAt":"2024-03-10T20:05:00Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain <levraiphilippeblain@gmail.com>\n\nIf several jobs in the windows-test or vs-test matrices fail, the\nupload-artifact action in each job tries to upload the test directories\nof the failed tests as \"failed-tests-windows.zip\", which fails for all\njobs except the one which finishes first with the following error:\n\n    Error: Failed to CreateArtifact: Received non-retryable error:\n    Failed request: (409) Conflict: an artifact with this name\n    already exists on the workflow run\n\nMake the artifacts name unique by using the 'matrix.nr' token, and\ndisambiguate the vs-test artifacts from the windows-test ones.\n\nSigned-off-by: Philippe Blain <levraiphilippeblain@gmail.com>\n---\n    ci(github): make Windows test artifacts name unique\n    \n    I noticed this while working on another series and thought it deserved a\n    quick fix.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1688%2Fphil-blain%2Fci-unique-windows-artifacts-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1688/phil-blain/ci-unique-windows-artifacts-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1688\n\n .github/workflows/main.yml | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 683a2d633ed..3428773b096 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -159,7 +159,7 @@ jobs:\n       if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n       uses: actions/upload-artifact@v4\n       with:\n-        name: failed-tests-windows\n+        name: failed-tests-windows-${{ matrix.nr }}\n         path: ${{env.FAILED_TEST_ARTIFACTS}}\n   vs-build:\n     name: win+VS build\n@@ -250,7 +250,7 @@ jobs:\n       if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n       uses: actions/upload-artifact@v4\n       with:\n-        name: failed-tests-windows\n+        name: failed-tests-windows-vs-${{ matrix.nr }}\n         path: ${{env.FAILED_TEST_ARTIFACTS}}\n   regular:\n     name: ${{matrix.vector.jobname}} (${{matrix.vector.pool}})\n\nbase-commit: e09f1254c54329773904fe25d7c545a1fb4fa920\n-- \ngitgitgadget\n"}]}