{"thread":{"id":"60971","subject":"[PATCH] git-remote.txt: fix typo","startedAt":"2024-02-21T08:42:03Z","lastAt":"2024-02-21T18:18:31Z","messageCount":2,"participants":["Jakub Wilk","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"489055","messageId":"20240221083554.5255-1-jwilk@jwilk.net","threadId":"60971","inReplyTo":null,"subject":"[PATCH] git-remote.txt: fix typo","fromName":"Jakub Wilk","fromEmail":"jwilk@jwilk.net","sentAt":"2024-02-21T08:35:54Z","receivedAt":"2024-02-21T08:42:03Z","isPatch":true,"sender":{"key":"jwilk@jwilk.net","avatar":"https://avatars.githubusercontent.com/u/141546?v=4"},"body":"Signed-off-by: Jakub Wilk <jwilk@jwilk.net>\n---\n Documentation/git-remote.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt\nindex 1dec314834..932a5c3ea4 100644\n--- a/Documentation/git-remote.txt\n+++ b/Documentation/git-remote.txt\n@@ -35,7 +35,7 @@ OPTIONS\n -v::\n --verbose::\n \tBe a little more verbose and show remote url after name.\n-\tFor promisor remotes, also show which filter (`blob:none` etc.)\n+\tFor promisor remotes, also show which filters (`blob:none` etc.)\n \tare configured.\n \tNOTE: This must be placed between `remote` and subcommand.\n \n-- \n2.39.2\n\n"},{"id":"489103","messageId":"xmqqfrxlof4b.fsf@gitster.g","threadId":"60971","inReplyTo":"20240221083554.5255-1-jwilk@jwilk.net","subject":"Re: [PATCH] git-remote.txt: fix typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-21T18:18:28Z","receivedAt":"2024-02-21T18:18:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Wilk <jwilk@jwilk.net> writes:\n\n> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>\n> ---\n>  Documentation/git-remote.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt\n> index 1dec314834..932a5c3ea4 100644\n> --- a/Documentation/git-remote.txt\n> +++ b/Documentation/git-remote.txt\n> @@ -35,7 +35,7 @@ OPTIONS\n>  -v::\n>  --verbose::\n>  \tBe a little more verbose and show remote url after name.\n> -\tFor promisor remotes, also show which filter (`blob:none` etc.)\n> +\tFor promisor remotes, also show which filters (`blob:none` etc.)\n>  \tare configured.\n>  \tNOTE: This must be placed between `remote` and subcommand.\n\nWhen you give more than one filters to \"git clone\", they are used to\ncreate a single \"combined\" filter, so strictly speaking, \"also show\nwhich filter is configured\" is a grammatically valid that might be\nmore technically correct.  E.g. the user may see\n\n    $ git clone --filter=blob:none --filter=tree:2 $there sample-repo\n    $ git -C sample-repo remote -v show\n    origin ... (fetch) [combine:blob:none+tree:2]\n    origin ... (push)\n\nin the output.  It may not be a bad idea to update the code to show\nthe filter information in a way that is more clear that we are\nseeing a list of filters (perhaps showing the above as \"[blob:none\ntree:2]\" might be a good starting point, as a totally separate topic\n(#leftoverbits).\n\nAfter taking your patch as-is, that is.  In user's mind, they\nconsider they gave two filters, and making a single combined filter\nis something Git did without being asked for its own convenience,\nso \"which filters are configured\" is, while it may be technically\nless correct, much closer to what the end-user perceives.\n\nThanks.\n\n"}]}