{"thread":{"id":"6093","subject":"[PATCH 1/7] Rename gitfakemmap to git_mmap.","startedAt":"2006-12-24T05:45:37Z","lastAt":"2006-12-24T05:45:37Z","messageCount":1,"participants":["Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":7},"messages":[{"id":"30220","messageId":"20061224054537.GA8146@spearce.org","threadId":"6093","inReplyTo":null,"subject":"[PATCH 1/7] Rename gitfakemmap to git_mmap.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2006-12-24T05:45:37Z","receivedAt":"2006-12-24T05:45:37Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"This minor cleanup was suggested by Johannes Schindelin.\n\nThe mmap is still fake in the sense that we don't support PROT_WRITE\nor MAP_SHARED with external modification at all, but that hasn't\nstopped us from using mmap() thoughout the Git code.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n compat/mmap.c     |    6 +++---\n git-compat-util.h |    8 ++++----\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/compat/mmap.c b/compat/mmap.c\nindex 0fd46e7..bb34c7e 100644\n--- a/compat/mmap.c\n+++ b/compat/mmap.c\n@@ -1,12 +1,12 @@\n #include \"../git-compat-util.h\"\n \n-void *gitfakemmap(void *start, size_t length, int prot , int flags, int fd, off_t offset)\n+void *git_mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset)\n {\n \tint n = 0;\n \toff_t current_offset = lseek(fd, 0, SEEK_CUR);\n \n \tif (start != NULL || !(flags & MAP_PRIVATE))\n-\t\tdie(\"Invalid usage of gitfakemmap.\");\n+\t\tdie(\"Invalid usage of mmap when built with NO_MMAP\");\n \n \tif (lseek(fd, offset, SEEK_SET) < 0) {\n \t\terrno = EINVAL;\n@@ -44,7 +44,7 @@ void *gitfakemmap(void *start, size_t length, int prot , int flags, int fd, off_\n \treturn start;\n }\n \n-int gitfakemunmap(void *start, size_t length)\n+int git_munmap(void *start, size_t length)\n {\n \tfree(start);\n \treturn 0;\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex f79365b..5d9eb26 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -87,10 +87,10 @@ extern void set_warn_routine(void (*routine)(const char *warn, va_list params));\n #define MAP_FAILED ((void*)-1)\n #endif\n \n-#define mmap gitfakemmap\n-#define munmap gitfakemunmap\n-extern void *gitfakemmap(void *start, size_t length, int prot , int flags, int fd, off_t offset);\n-extern int gitfakemunmap(void *start, size_t length);\n+#define mmap git_mmap\n+#define munmap git_munmap\n+extern void *git_mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset);\n+extern int git_munmap(void *start, size_t length);\n \n #else /* NO_MMAP */\n \n-- \n1.4.4.3.g2e63\n"}]}