{"thread":{"id":"60823","subject":"[PATCH] This PR enables a successful git build on z/OS.","startedAt":"2024-01-31T14:21:05Z","lastAt":"2024-03-06T16:10:29Z","messageCount":18,"participants":["Haritha via GitGitGadget","Kristoffer Haugsbakk","Junio C Hamano","Haritha D via GitGitGadget","Haritha D","Ghanshyam Thakkar","rsbecker@nexbridge.com"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"487643","messageId":"pull.1663.git.git.1706710861778.gitgitgadget@gmail.com","threadId":"60823","inReplyTo":null,"subject":"[PATCH] This PR enables a successful git build on z/OS.","fromName":"Haritha via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-01-31T14:21:01Z","receivedAt":"2024-01-31T14:21:05Z","isPatch":true,"sender":{"key":"name:Haritha","avatar":null},"body":"From: Haritha D <harithamma.d@ibm.com>\n\nSince the z/OS linker does not support searching dynamic libraries,\nand the current setting of CC_LD_DYNPATH results in a directory\nto be supplied to the link step with no option as the suffix,\nit causes a linker error because the z/OS LD linker\ndoes not accept directories as input.\nTherefore, we workaround this by adding the -L option.\nAnd, Introduced z/OS (OS/390) as a platform in config.mak.uname\n\nSigned-off-by: Haritha D <harithamma.d@ibm.com>\n---\n    This PR enables a successful git build on z/OS.\n    \n    Since the z/OS linker does not support searching dynamic libraries, and\n    the current setting of CC_LD_DYNPATH results in a directory to be\n    supplied to the link step with no option as the suffix, it causes a\n    linker error because the z/OS LD linker does not accept directories as\n    input. Therefore, we workaround this by adding the -L option. And,\n    Introduced z/OS (OS/390) as a platform in config.mak.uname\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1663%2FHarithaIBM%2Fzos-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1663/HarithaIBM/zos-v1\nPull-Request: https://github.com/git/git/pull/1663\n\n config.mak.uname | 12 ++++++++++++\n configure.ac     |  3 +++\n 2 files changed, 15 insertions(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex dacc95172dc..c8006f854e5 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n \tSHELL_PATH = /usr/coreutils/bin/bash\n endif\n+ifeq ($(uname_S),OS/390)\n+        NO_SYS_POLL_H = YesPlease\n+        NO_STRCASESTR = YesPlease\n+        NO_REGEX = YesPlease\n+        NO_MMAP = YesPlease\n+        NO_NSEC = YesPlease\n+        NO_STRLCPY = YesPlease\n+        NO_MEMMEM = YesPlease\n+        NO_GECOS_IN_PWENT = YesPlease\n+        HAVE_STRINGS_H = YesPlease\n+        NEEDS_MODE_TRANSLATION = YesPlease\n+endif\n ifeq ($(uname_S),MINGW)\n \tifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n \t\t$(error \"Building with MSys is no longer supported\")\ndiff --git a/configure.ac b/configure.ac\nindex d1a96da14eb..64569a80d53 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -463,6 +463,9 @@ else\n             CC_LD_DYNPATH=-Wl,+b,\n           else\n              CC_LD_DYNPATH=\n+\t     if test \"$(uname -s)\" = \"OS/390\"; then\n+\t\t     CC_LD_DYNPATH=-L\n+\t     fi\n              AC_MSG_WARN([linker does not support runtime path to dynamic libraries])\n           fi\n       fi\n\nbase-commit: bc7ee2e5e16f0d1e710ef8fab3db59ab11f2bbe7\n-- \ngitgitgadget\n"},{"id":"487645","messageId":"4d0efd0f-f35d-4a3a-aea1-e08cc55bd2d9@app.fastmail.com","threadId":"60823","inReplyTo":"pull.1663.git.git.1706710861778.gitgitgadget@gmail.com","subject":"Re: [PATCH] This PR enables a successful git build on z/OS.","fromName":"Kristoffer Haugsbakk","fromEmail":"code@khaugsbakk.name","sentAt":"2024-01-31T16:12:27Z","receivedAt":"2024-01-31T16:12:48Z","isPatch":true,"sender":{"key":"code@khaugsbakk.name","avatar":"https://avatars.githubusercontent.com/u/2229597?v=4"},"body":"Hi\n\n> [PATCH] This PR enables a successful git build on z/OS.\n\nMaybe the subject could be:\n\n> [PATCH] build: support z/OS (OS/390)\n\nThere’s some indirectly related things in `SubmittingPatches`:\n\n “  Describe your changes in imperative mood, e.g. \"make xyzzy do frotz\"\n    instead of \"[This patch] makes xyzzy do frotz\" or \"[I] changed xyzzy\n    to do frotz\", as if you are giving orders to the codebase to change\n    its behavior.  Try to make sure your explanation can be understood\n    without external resources. Instead of giving a URL to a mailing\n    list archive, summarize the relevant points of the discussion.\n\nFrom which I infer that “This PR” is considered redundant.\n\nAs for the `build:` prefix: many different prefixes have been used for\nthis file (`git log --no-merges -- config.mak.uname`).\n\n-- \nKristoffer Haugsbakk\n"},{"id":"487648","messageId":"xmqqr0hx77ga.fsf@gitster.g","threadId":"60823","inReplyTo":"pull.1663.git.git.1706710861778.gitgitgadget@gmail.com","subject":"Re: [PATCH] This PR enables a successful git build on z/OS.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-01-31T17:12:37Z","receivedAt":"2024-01-31T17:12:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Haritha  via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> Subject: Re: [PATCH] This PR enables a successful git build on z/OS.\n\nPlease think with longer term effects in mind when formulating the\ntitle of the commit.  What title will your next patch have if we\nbreak the build for z/OS next time, after this fix goes in?\n\"enables a successful build again\"?  How would one tell which commit\nchanged what aspect of the build procedure to adjust to z/OS?\n\nPerhaps\n\n    [PATCH] Makefile: adjust for z/OS that lack dynamic library support\n\nor something would be specific enough.\n\n> From: Haritha D <harithamma.d@ibm.com>\n>\n> Since the z/OS linker does not support searching dynamic libraries,\n> and the current setting of CC_LD_DYNPATH results in a directory\n> to be supplied to the link step with no option as the suffix,\n> it causes a linker error because the z/OS LD linker\n> does not accept directories as input.\n\nHmph, it is not quite clear to me where that \"current setting of\nCC_LD_DYNPATH\" comes from and what exact value it is set to.\n\nHere is my attempt (blind guesses are involved, so please correct\nwhatever errors you spot):\n\n    The autoconf generated configuration gives an empty string to\n    CC_LD_DYNPATH when it cannot find a way to use a shared library\n    and gives up with \"linker does not support runtime path to\n    dynamic libraries\" message.  This leaves the directory path that\n    is usually appended to -Wl,-rpath, or -R, or whatever alone on\n    the command line of the linker, e.g. \"-L/usr/lib /usr/lib\", which\n    breaks the linker.\n\n    Work it around by setting CD_LD_DYNPATH to -L; we will end up\n    giving the same directory twice, e.g., \"-L/usr/lib -L/usr/lib\",\n    but it is only ugly without breaking anything.\n\n    While at it, define appropriate settings for z/OS (OS/390) in\n    the config.mak.uname file.\n\n> Therefore, we workaround this by adding the -L option.\n> And, Introduced z/OS (OS/390) as a platform in config.mak.uname\n>\n> Signed-off-by: Haritha D <harithamma.d@ibm.com>\n> ---\n>     This PR enables a successful git build on z/OS.\n>     \n>     Since the z/OS linker does not support searching dynamic libraries, and\n>     the current setting of CC_LD_DYNPATH results in a directory to be\n>     supplied to the link step with no option as the suffix, it causes a\n>     linker error because the z/OS LD linker does not accept directories as\n>     input. Therefore, we workaround this by adding the -L option. And,\n>     Introduced z/OS (OS/390) as a platform in config.mak.uname\n\nYou do not have to write the same thing twice.  The text under \"---\"\nis meant for extra explanation that does not need to become part of\nthe final commit log message.\n\n> diff --git a/config.mak.uname b/config.mak.uname\n> index dacc95172dc..c8006f854e5 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n>  \tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n>  \tSHELL_PATH = /usr/coreutils/bin/bash\n>  endif\n> +ifeq ($(uname_S),OS/390)\n> +        NO_SYS_POLL_H = YesPlease\n> +        NO_STRCASESTR = YesPlease\n> +        NO_REGEX = YesPlease\n> +        NO_MMAP = YesPlease\n> +        NO_NSEC = YesPlease\n> +        NO_STRLCPY = YesPlease\n> +        NO_MEMMEM = YesPlease\n> +        NO_GECOS_IN_PWENT = YesPlease\n> +        HAVE_STRINGS_H = YesPlease\n> +        NEEDS_MODE_TRANSLATION = YesPlease\n> +endif\n\nI cannot tell if these are reasonable for z/OS myself and I'll take\nyour word for it ;-)  After all you're the expert.\n\n> diff --git a/configure.ac b/configure.ac\n> index d1a96da14eb..64569a80d53 100644\n> --- a/configure.ac\n> +++ b/configure.ac\n> @@ -463,6 +463,9 @@ else\n>              CC_LD_DYNPATH=-Wl,+b,\n>            else\n>               CC_LD_DYNPATH=\n> +\t     if test \"$(uname -s)\" = \"OS/390\"; then\n> +\t\t     CC_LD_DYNPATH=-L\n> +\t     fi\n>               AC_MSG_WARN([linker does not support runtime path to dynamic libraries])\n>            fi\n>        fi\n\nThe use of \"uname -s\" looks totally out of place.\n\nWouldn't it be a better approach to set it in config.mak.uname for\nOS/390 above and leave this part untouched, I wonder?\n"},{"id":"487655","messageId":"xmqqmssl75bx.fsf@gitster.g","threadId":"60823","inReplyTo":"4d0efd0f-f35d-4a3a-aea1-e08cc55bd2d9@app.fastmail.com","subject":"Re: [PATCH] This PR enables a successful git build on z/OS.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-01-31T17:58:26Z","receivedAt":"2024-01-31T17:58:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kristoffer Haugsbakk\" <code@khaugsbakk.name> writes:\n\n> Hi\n>\n>> [PATCH] This PR enables a successful git build on z/OS.\n>\n> Maybe the subject could be:\n>\n>> [PATCH] build: support z/OS (OS/390)\n\nNice.  This is nicer than what I came up with, that placed too much\nstress on the runtime path to the dynamic library.  With all the\nstuff added to config.mak.uname, yours is much more appropriate.\n\nThanks.\n"},{"id":"489212","messageId":"pull.1663.v2.git.git.1708660111.gitgitgadget@gmail.com","threadId":"60823","inReplyTo":"pull.1663.git.git.1706710861778.gitgitgadget@gmail.com","subject":"[PATCH v2 0/2] This PR enables a successful git build on z/OS.","fromName":"Haritha via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-02-23T03:48:29Z","receivedAt":"2024-02-23T03:48:36Z","isPatch":true,"sender":{"key":"name:Haritha","avatar":null},"body":"Since the z/OS linker does not support searching dynamic libraries, and the\ncurrent setting of CC_LD_DYNPATH results in a directory to be supplied to\nthe link step with no option as the suffix, it causes a linker error because\nthe z/OS LD linker does not accept directories as input. Therefore, we\nworkaround this by adding the -L option. And, Introduced z/OS (OS/390) as a\nplatform in config.mak.uname\n\nThanks for taking the time to contribute to Git! Please be advised that the\nGit community does not use github.com for their contributions. Instead, we\nuse a mailing list (git@vger.kernel.org) for code submissions, code reviews,\nand bug reports. Nevertheless, you can use GitGitGadget\n(https://gitgitgadget.github.io/) to conveniently send your Pull Requests\ncommits to our mailing list.\n\nPlease read the \"guidelines for contributing\" linked above!\n\nHaritha D (2):\n  build: support z/OS (OS/390).\n  an improvement: removed configure.ac changes\n\n config.mak.uname | 12 ++++++++++++\n 1 file changed, 12 insertions(+)\n\n\nbase-commit: f41f85c9ec8d4d46de0fd5fded88db94d3ec8c11\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1663%2FHarithaIBM%2Fzos-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1663/HarithaIBM/zos-v2\nPull-Request: https://github.com/git/git/pull/1663\n\nRange-diff vs v1:\n\n 1:  2eddc8f8860 ! 1:  53e211d7a65 This PR enables a successful git build on z/OS.\n     @@ Metadata\n      Author: Haritha D <harithamma.d@ibm.com>\n      \n       ## Commit message ##\n     -    This PR enables a successful git build on z/OS.\n     +    build: support z/OS (OS/390).\n      \n          Since the z/OS linker does not support searching dynamic libraries,\n          and the current setting of CC_LD_DYNPATH results in a directory\n          to be supplied to the link step with no option as the suffix,\n          it causes a linker error because the z/OS LD linker\n          does not accept directories as input.\n     -    Therefore, we workaround this by adding the -L option.\n     -    And, Introduced z/OS (OS/390) as a platform in config.mak.uname\n     +    Therefore, -L option is added.\n     +    Also introduced z/OS (OS/390) as a platform in config.mak.uname\n      \n          Signed-off-by: Haritha D <harithamma.d@ibm.com>\n      \n -:  ----------- > 2:  05df5d7e2d5 an improvement: removed configure.ac changes\n\n-- \ngitgitgadget\n"},{"id":"489213","messageId":"53e211d7a6551c5d86ea6ecba0ab0e9f6592843f.1708660111.git.gitgitgadget@gmail.com","threadId":"60823","inReplyTo":"pull.1663.v2.git.git.1708660111.gitgitgadget@gmail.com","subject":"[PATCH v2 1/2] build: support z/OS (OS/390).","fromName":"Haritha D via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-02-23T03:48:30Z","receivedAt":"2024-02-23T03:48:39Z","isPatch":true,"sender":{"key":"harithamma.d@ibm.com","avatar":"https://avatars.githubusercontent.com/u/112700353?v=4"},"body":"From: Haritha D <harithamma.d@ibm.com>\n\nSince the z/OS linker does not support searching dynamic libraries,\nand the current setting of CC_LD_DYNPATH results in a directory\nto be supplied to the link step with no option as the suffix,\nit causes a linker error because the z/OS LD linker\ndoes not accept directories as input.\nTherefore, -L option is added.\nAlso introduced z/OS (OS/390) as a platform in config.mak.uname\n\nSigned-off-by: Haritha D <harithamma.d@ibm.com>\n---\n config.mak.uname | 12 ++++++++++++\n configure.ac     |  3 +++\n 2 files changed, 15 insertions(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex dacc95172dc..c8006f854e5 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n \tSHELL_PATH = /usr/coreutils/bin/bash\n endif\n+ifeq ($(uname_S),OS/390)\n+        NO_SYS_POLL_H = YesPlease\n+        NO_STRCASESTR = YesPlease\n+        NO_REGEX = YesPlease\n+        NO_MMAP = YesPlease\n+        NO_NSEC = YesPlease\n+        NO_STRLCPY = YesPlease\n+        NO_MEMMEM = YesPlease\n+        NO_GECOS_IN_PWENT = YesPlease\n+        HAVE_STRINGS_H = YesPlease\n+        NEEDS_MODE_TRANSLATION = YesPlease\n+endif\n ifeq ($(uname_S),MINGW)\n \tifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n \t\t$(error \"Building with MSys is no longer supported\")\ndiff --git a/configure.ac b/configure.ac\nindex d1a96da14eb..64569a80d53 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -463,6 +463,9 @@ else\n             CC_LD_DYNPATH=-Wl,+b,\n           else\n              CC_LD_DYNPATH=\n+\t     if test \"$(uname -s)\" = \"OS/390\"; then\n+\t\t     CC_LD_DYNPATH=-L\n+\t     fi\n              AC_MSG_WARN([linker does not support runtime path to dynamic libraries])\n           fi\n       fi\n-- \ngitgitgadget\n\n"},{"id":"489214","messageId":"05df5d7e2d50cba77f53273c781f97d24144efc6.1708660111.git.gitgitgadget@gmail.com","threadId":"60823","inReplyTo":"pull.1663.v2.git.git.1708660111.gitgitgadget@gmail.com","subject":"[PATCH v2 2/2] an improvement: removed configure.ac changes","fromName":"Haritha D via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-02-23T03:48:31Z","receivedAt":"2024-02-23T03:48:40Z","isPatch":true,"sender":{"key":"harithamma.d@ibm.com","avatar":"https://avatars.githubusercontent.com/u/112700353?v=4"},"body":"From: Haritha D <harithamma.d@ibm.com>\n\nHello Reviewers, as an improvement, I have\nremoved the CC_LD_DYNPATH changes because\nI was able to achieve the desired outcome\nby passing it to the make step.\n\nSigned-off-by: Haritha D <harithamma.d@ibm.com>\n---\n configure.ac | 3 ---\n 1 file changed, 3 deletions(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex 64569a80d53..d1a96da14eb 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -463,9 +463,6 @@ else\n             CC_LD_DYNPATH=-Wl,+b,\n           else\n              CC_LD_DYNPATH=\n-\t     if test \"$(uname -s)\" = \"OS/390\"; then\n-\t\t     CC_LD_DYNPATH=-L\n-\t     fi\n              AC_MSG_WARN([linker does not support runtime path to dynamic libraries])\n           fi\n       fi\n-- \ngitgitgadget\n"},{"id":"489219","messageId":"xmqqsf1j1vhl.fsf@gitster.g","threadId":"60823","inReplyTo":"pull.1663.v2.git.git.1708660111.gitgitgadget@gmail.com","subject":"Re: [PATCH v2 0/2] This PR enables a successful git build on z/OS.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-23T07:37:58Z","receivedAt":"2024-02-23T07:38:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Haritha  via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> Since the z/OS linker does not support searching dynamic libraries, and the\n> current setting of CC_LD_DYNPATH results in a directory to be supplied to\n> the link step with no option as the suffix, it causes a linker error because\n> the z/OS LD linker does not accept directories as input. Therefore, we\n> workaround this by adding the -L option.\n\nHmph, do we still need that CC_LD_DYNPATH hack, with 07bbe4ca (Merge\nbranch 'jc/make-libpath-template', 2024-02-06) already in 'master'?\n\n> And, Introduced z/OS (OS/390) as a\n> platform in config.mak.uname\n\n\tAdd support for z/OS (OS/390) in config.mak.uname.\n\nor something (cf. Documentation/SubmittingPatches)?\n\n> Thanks for taking the time to contribute to Git! Please be advised that the\n> Git community does not use github.com for their contributions. Instead, we\n> use a mailing list (git@vger.kernel.org) for code submissions, code reviews,\n> and bug reports. Nevertheless, you can use GitGitGadget\n> (https://gitgitgadget.github.io/) to conveniently send your Pull Requests\n> commits to our mailing list.\n>\n> Please read the \"guidelines for contributing\" linked above!\n\nFor whom is the above message addressed?  Who is expected to read\nthat guidelines?\n"},{"id":"489220","messageId":"xmqqmsrr1vhg.fsf@gitster.g","threadId":"60823","inReplyTo":"05df5d7e2d50cba77f53273c781f97d24144efc6.1708660111.git.gitgitgadget@gmail.com","subject":"Re: [PATCH v2 2/2] an improvement: removed configure.ac changes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-23T07:38:03Z","receivedAt":"2024-02-23T07:38:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Haritha D via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Haritha D <harithamma.d@ibm.com>\n>\n> Hello Reviewers, as an improvement, I have\n> removed the CC_LD_DYNPATH changes because\n> I was able to achieve the desired outcome\n> by passing it to the make step.\n>\n> Signed-off-by: Haritha D <harithamma.d@ibm.com>\n> ---\n>  configure.ac | 3 ---\n>  1 file changed, 3 deletions(-)\n\nWe frown upon a patch series that makes mistakes in an earlier step,\nonly to fix them in a later step.  The \"git rebase -i\" command helps\nus pretend to be more perfect developers than we actually are,\nwhipping your patch series into a shape that builds one small step\non top of another in a logical succession.  Such a patch series is\neasier to understand than a history that faithfully records all the\nstumbles the developer made until they reached the final solution.\n\nIn this case, if you know before you sent these two patches that you\ndo not need to touch configure.ac for CC_LD_DYNPATH at all, you can\n\"git rebase -i\" to whip the first patch into the desired shape, i.e.\nno changes to configure.ac, and drop this second patch, I think.\n\n> diff --git a/configure.ac b/configure.ac\n> index 64569a80d53..d1a96da14eb 100644\n> --- a/configure.ac\n> +++ b/configure.ac\n> @@ -463,9 +463,6 @@ else\n>              CC_LD_DYNPATH=-Wl,+b,\n>            else\n>               CC_LD_DYNPATH=\n> -\t     if test \"$(uname -s)\" = \"OS/390\"; then\n> -\t\t     CC_LD_DYNPATH=-L\n> -\t     fi\n>               AC_MSG_WARN([linker does not support runtime path to dynamic libraries])\n>            fi\n>        fi\n"},{"id":"489299","messageId":"pull.1663.v3.git.git.1708841439516.gitgitgadget@gmail.com","threadId":"60823","inReplyTo":"pull.1663.v2.git.git.1708660111.gitgitgadget@gmail.com","subject":"[PATCH v3] build: support z/OS (OS/390).","fromName":"Haritha via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-02-25T06:10:39Z","receivedAt":"2024-02-25T06:10:43Z","isPatch":true,"sender":{"key":"name:Haritha","avatar":null},"body":"From: Haritha D <harithamma.d@ibm.com>\n\nSince the z/OS linker does not support searching dynamic libraries,\nand the current setting of CC_LD_DYNPATH results in a directory\nto be supplied to the link step with no option as the suffix,\nit causes a linker error because the z/OS LD linker\ndoes not accept directories as input.\nTherefore, -L option is added.\nAlso introduced z/OS (OS/390) as a platform in config.mak.uname\n\nSigned-off-by: Haritha D <harithamma.d@ibm.com>\n---\n    This PR enables a successful git build on z/OS.\n    \n    Since the z/OS linker does not support searching dynamic libraries, and\n    the current setting of CC_LD_DYNPATH results in a directory to be\n    supplied to the link step with no option as the suffix, it causes a\n    linker error because the z/OS LD linker does not accept directories as\n    input. Therefore, we workaround this by adding the -L option. And,\n    Introduced z/OS (OS/390) as a platform in config.mak.uname\n    \n    Thanks for taking the time to contribute to Git! Please be advised that\n    the Git community does not use github.com for their contributions.\n    Instead, we use a mailing list (git@vger.kernel.org) for code\n    submissions, code reviews, and bug reports. Nevertheless, you can use\n    GitGitGadget (https://gitgitgadget.github.io/) to conveniently send your\n    Pull Requests commits to our mailing list.\n    \n    Please read the \"guidelines for contributing\" linked above!\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1663%2FHarithaIBM%2Fzos-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1663/HarithaIBM/zos-v3\nPull-Request: https://github.com/git/git/pull/1663\n\nRange-diff vs v2:\n\n 1:  53e211d7a65 ! 1:  2f1ad41bc14 build: support z/OS (OS/390).\n     @@ config.mak.uname: ifeq ($(uname_S),NONSTOP_KERNEL)\n      +        NO_MEMMEM = YesPlease\n      +        NO_GECOS_IN_PWENT = YesPlease\n      +        HAVE_STRINGS_H = YesPlease\n     -+        NEEDS_MODE_TRANSLATION = YesPlease\n     ++       NEEDS_MODE_TRANSLATION = YesPlease\n      +endif\n       ifeq ($(uname_S),MINGW)\n       \tifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n       \t\t$(error \"Building with MSys is no longer supported\")\n     -\n     - ## configure.ac ##\n     -@@ configure.ac: else\n     -             CC_LD_DYNPATH=-Wl,+b,\n     -           else\n     -              CC_LD_DYNPATH=\n     -+\t     if test \"$(uname -s)\" = \"OS/390\"; then\n     -+\t\t     CC_LD_DYNPATH=-L\n     -+\t     fi\n     -              AC_MSG_WARN([linker does not support runtime path to dynamic libraries])\n     -           fi\n     -       fi\n 2:  05df5d7e2d5 < -:  ----------- an improvement: removed configure.ac changes\n\n\n config.mak.uname | 12 ++++++++++++\n 1 file changed, 12 insertions(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex dacc95172dc..03ee2b74525 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n \tSHELL_PATH = /usr/coreutils/bin/bash\n endif\n+ifeq ($(uname_S),OS/390)\n+        NO_SYS_POLL_H = YesPlease\n+        NO_STRCASESTR = YesPlease\n+        NO_REGEX = YesPlease\n+        NO_MMAP = YesPlease\n+        NO_NSEC = YesPlease\n+        NO_STRLCPY = YesPlease\n+        NO_MEMMEM = YesPlease\n+        NO_GECOS_IN_PWENT = YesPlease\n+        HAVE_STRINGS_H = YesPlease\n+       NEEDS_MODE_TRANSLATION = YesPlease\n+endif\n ifeq ($(uname_S),MINGW)\n \tifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n \t\t$(error \"Building with MSys is no longer supported\")\n\nbase-commit: f41f85c9ec8d4d46de0fd5fded88db94d3ec8c11\n-- \ngitgitgadget\n"},{"id":"489394","messageId":"xmqq7circevo.fsf@gitster.g","threadId":"60823","inReplyTo":"pull.1663.v3.git.git.1708841439516.gitgitgadget@gmail.com","subject":"Re: [PATCH v3] build: support z/OS (OS/390).","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-26T17:30:19Z","receivedAt":"2024-02-26T17:30:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Haritha  via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Haritha D <harithamma.d@ibm.com>\n>\n> Since the z/OS linker does not support searching dynamic libraries,\n> and the current setting of CC_LD_DYNPATH results in a directory\n> to be supplied to the link step with no option as the suffix,\n> it causes a linker error because the z/OS LD linker\n> does not accept directories as input.\n> Therefore, -L option is added.\n\nShouldn't all of the above removed by now, with 07bbe4ca (Merge\nbranch 'jc/make-libpath-template', 2024-02-06) that merged the\nsupport for platforms whose linker does not have a way to specify\nthe path used at runtime to locate dynamic libraries and is already\nin the Git 2.44 release?  The autoconf-generated config.mak.autogen\nwould leave CC_LD_DYNPATH to empty on such a platform, which then\nadds only one \"-L $where\" (instead of the usual \"-L $where -R\n$where\") on the linker command line, making your earlier workaround\nto use \"-L $where -L $where\" unnecessary?\n\n> Also introduced z/OS (OS/390) as a platform in config.mak.uname\n\n\"Introduce z/OS ...\" (cf. Documentation/SubmittingPatches)\n\nOr perhaps\n\n\tAdd platform specific settings in config.mak.uname for zOS\n\t(OS/390).\n\n> diff --git a/config.mak.uname b/config.mak.uname\n> index dacc95172dc..03ee2b74525 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n>  \tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n>  \tSHELL_PATH = /usr/coreutils/bin/bash\n>  endif\n> +ifeq ($(uname_S),OS/390)\n> +        NO_SYS_POLL_H = YesPlease\n> +        NO_STRCASESTR = YesPlease\n> +        NO_REGEX = YesPlease\n> +        NO_MMAP = YesPlease\n> +        NO_NSEC = YesPlease\n> +        NO_STRLCPY = YesPlease\n> +        NO_MEMMEM = YesPlease\n> +        NO_GECOS_IN_PWENT = YesPlease\n> +        HAVE_STRINGS_H = YesPlease\n> +       NEEDS_MODE_TRANSLATION = YesPlease\n\nAll of the above should be indented with TAB to imitate the support\nfor other platforms, I think.\n\nThanks.\n\n> +endif\n>  ifeq ($(uname_S),MINGW)\n>  \tifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n>  \t\t$(error \"Building with MSys is no longer supported\")\n>\n> base-commit: f41f85c9ec8d4d46de0fd5fded88db94d3ec8c11\n"},{"id":"489732","messageId":"B3775704-6FCE-4994-8682-309D521FD2CB@ibm.com","threadId":"60823","inReplyTo":"xmqq7circevo.fsf@gitster.g","subject":"RE: [PATCH v3] build: support z/OS (OS/390).","fromName":"Haritha D","fromEmail":"harithamma.d@ibm.com","sentAt":"2024-03-01T09:09:17Z","receivedAt":"2024-03-01T09:09:24Z","isPatch":true,"sender":{"key":"harithamma.d@ibm.com","avatar":"https://avatars.githubusercontent.com/u/112700353?v=4"},"body":"Hi Team,\n\nThe win test(7) test case failed stating the reason as \"The Operation cancelled\". I saw that it failed after 5 hours 59 minutes of running the test cases(build). How do I handle this?\n\nPlease suggest.\n\nBest regards\nHaritha\n\nOn 26/02/24, 11:15 PM, \"Junio C Hamano\" <gitster@pobox.com <mailto:gitster@pobox.com>> wrote:\n\n\n\"Haritha via GitGitGadget\" <gitgitgadget@gmail.com <mailto:gitgitgadget@gmail.com>> writes:\n\n\n> From: Haritha D <harithamma.d@ibm.com <mailto:harithamma.d@ibm.com>>\n>\n> Since the z/OS linker does not support searching dynamic libraries,\n> and the current setting of CC_LD_DYNPATH results in a directory\n> to be supplied to the link step with no option as the suffix,\n> it causes a linker error because the z/OS LD linker\n> does not accept directories as input.\n> Therefore, -L option is added.\n\n\nShouldn't all of the above removed by now, with 07bbe4ca (Merge\nbranch 'jc/make-libpath-template', 2024-02-06) that merged the\nsupport for platforms whose linker does not have a way to specify\nthe path used at runtime to locate dynamic libraries and is already\nin the Git 2.44 release? The autoconf-generated config.mak.autogen\nwould leave CC_LD_DYNPATH to empty on such a platform, which then\nadds only one \"-L $where\" (instead of the usual \"-L $where -R\n$where\") on the linker command line, making your earlier workaround\nto use \"-L $where -L $where\" unnecessary?\n\n\n> Also introduced z/OS (OS/390) as a platform in config.mak.uname\n\n\n\"Introduce z/OS ...\" (cf. Documentation/SubmittingPatches)\n\n\nOr perhaps\n\n\nAdd platform specific settings in config.mak.uname for zOS\n(OS/390).\n\n\n> diff --git a/config.mak.uname b/config.mak.uname\n> index dacc95172dc..03ee2b74525 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> SANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n> SHELL_PATH = /usr/coreutils/bin/bash\n> endif\n> +ifeq ($(uname_S),OS/390)\n> + NO_SYS_POLL_H = YesPlease\n> + NO_STRCASESTR = YesPlease\n> + NO_REGEX = YesPlease\n> + NO_MMAP = YesPlease\n> + NO_NSEC = YesPlease\n> + NO_STRLCPY = YesPlease\n> + NO_MEMMEM = YesPlease\n> + NO_GECOS_IN_PWENT = YesPlease\n> + HAVE_STRINGS_H = YesPlease\n> + NEEDS_MODE_TRANSLATION = YesPlease\n\n\nAll of the above should be indented with TAB to imitate the support\nfor other platforms, I think.\n\n\nThanks.\n\n\n> +endif\n> ifeq ($(uname_S),MINGW)\n> ifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n> $(error \"Building with MSys is no longer supported\")\n>\n> base-commit: f41f85c9ec8d4d46de0fd5fded88db94d3ec8c11\n\n\n\n"},{"id":"489740","messageId":"CZIHOPD4IVXH.32HVLZ4K0YNXY@gmail.com","threadId":"60823","inReplyTo":"B3775704-6FCE-4994-8682-309D521FD2CB@ibm.com","subject":"Re: [PATCH v3] build: support z/OS (OS/390).","fromName":"Ghanshyam Thakkar","fromEmail":"shyamthakkar001@gmail.com","sentAt":"2024-03-01T14:39:25Z","receivedAt":"2024-03-01T14:39:30Z","isPatch":true,"sender":{"key":"shyamthakkar001@gmail.com","avatar":"https://avatars.githubusercontent.com/u/72698233?v=4"},"body":"On Fri Mar 1, 2024 at 2:39 PM IST, Haritha D wrote:\n> Hi Team,\n>\n> The win test(7) test case failed stating the reason as \"The Operation cancelled\". I saw that it failed after 5 hours 59 minutes of running the test cases(build). How do I handle this?\n>\n> Please suggest.\n\nHey,\n\nThis seems to be a recurring issue, as this happens to me majority\nof the time. Seems as though the vm just sits idle after finishing tests\nas 360 minutes is the timeout for github acitons.\n\nUsually, rerunning the failed tests from the actions tab works for me.\n\nThanks.\n"},{"id":"489751","messageId":"xmqqbk7x6cox.fsf@gitster.g","threadId":"60823","inReplyTo":"B3775704-6FCE-4994-8682-309D521FD2CB@ibm.com","subject":"Re: [PATCH v3] build: support z/OS (OS/390).","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-01T18:15:26Z","receivedAt":"2024-03-01T18:15:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Haritha D <Harithamma.D@ibm.com> writes:\n\n> The win test(7) test case failed stating the reason as \"The\n> Operation cancelled\". I saw that it failed after 5 hours 59\n> minutes of running the test cases(build). How do I handle this?\n\nThose \"win test (n)\", at least some of them, seem to have been\nsomewhat flaky [*1*].  If you are certain you did not break them\nwith your change, you do not have to fix them yourself.\n\nI am a wrong person to ask how the test failure that may [*2*] block\nGGG submission can be circumvented, as I am not involved in that\nmachinery at all.\n\nThanks.\n\n\n[Footnotes]\n\n*1* Also I've seen osx-clang job time-out from time to time, without\n    failing any specific test.  Re-running failed jobs from the menu\n    often make them pass, which is why I said \"somewhat flaky\".\n\n*2* I do not even know if GGG refuses to submit a series with a test\n    failure, let alone if it allows to override such a safety if\n    exists.\n"},{"id":"489752","messageId":"04df01da6c05$caaa5dd0$5fff1970$@nexbridge.com","threadId":"60823","inReplyTo":"xmqqbk7x6cox.fsf@gitster.g","subject":"RE: [PATCH v3] build: support z/OS (OS/390).","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2024-03-01T18:25:03Z","receivedAt":"2024-03-01T18:25:22Z","isPatch":true,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On Friday, March 1, 2024 1:15 PM, Junio C Hamano wrote:\n>Haritha D <Harithamma.D@ibm.com> writes:\n>\n>> The win test(7) test case failed stating the reason as \"The Operation\n>> cancelled\". I saw that it failed after 5 hours 59 minutes of running\n>> the test cases(build). How do I handle this?\n>\n>Those \"win test (n)\", at least some of them, seem to have been somewhat\nflaky [*1*].  If you are certain you did not break them with\n>your change, you do not have to fix them yourself.\n>\n>I am a wrong person to ask how the test failure that may [*2*] block GGG\nsubmission can be circumvented, as I am not involved in that\n>machinery at all.\n>\n>Thanks.\n>\n>\n>[Footnotes]\n>\n>*1* Also I've seen osx-clang job time-out from time to time, without\n>    failing any specific test.  Re-running failed jobs from the menu\n>    often make them pass, which is why I said \"somewhat flaky\".\n>\n>*2* I do not even know if GGG refuses to submit a series with a test\n>    failure, let alone if it allows to override such a safety if\n>    exists.\n\nWhich tests have been hanging on S390? We have occasional hangs on NonStop\nthat end up being attributed to our CI build system not supplying pipes\nproperly to git. It would be interesting if the same tests are having issues\non different platforms.\n--Randall\n\n"},{"id":"489831","messageId":"9BAA31E9-858B-4F6F-9334-316C428EEE32@ibm.com","threadId":"60823","inReplyTo":"04df01da6c05$caaa5dd0$5fff1970$@nexbridge.com","subject":"RE: [PATCH v3] build: support z/OS (OS/390).","fromName":"Haritha D","fromEmail":"harithamma.d@ibm.com","sentAt":"2024-03-04T04:19:49Z","receivedAt":"2024-03-04T04:19:55Z","isPatch":true,"sender":{"key":"harithamma.d@ibm.com","avatar":"https://avatars.githubusercontent.com/u/112700353?v=4"},"body":"Looks like , I do not have sufficient permissions to rerun the tests. How do I proceed?\n\nPlease suggest.\n \nThank you\nHaritha\n\nOn 01/03/24, 11:55 PM, \"rsbecker@nexbridge.com <mailto:rsbecker@nexbridge.com>\" <rsbecker@nexbridge.com <mailto:rsbecker@nexbridge.com>> wrote:\n\n\nOn Friday, March 1, 2024 1:15 PM, Junio C Hamano wrote:\n>Haritha D <Harithamma.D@ibm.com <mailto:Harithamma.D@ibm.com>> writes:\n>\n>> The win test(7) test case failed stating the reason as \"The Operation\n>> cancelled\". I saw that it failed after 5 hours 59 minutes of running\n>> the test cases(build). How do I handle this?\n>\n>Those \"win test (n)\", at least some of them, seem to have been somewhat\nflaky [*1*]. If you are certain you did not break them with\n>your change, you do not have to fix them yourself.\n>\n>I am a wrong person to ask how the test failure that may [*2*] block GGG\nsubmission can be circumvented, as I am not involved in that\n>machinery at all.\n>\n>Thanks.\n>\n>\n>[Footnotes]\n>\n>*1* Also I've seen osx-clang job time-out from time to time, without\n> failing any specific test. Re-running failed jobs from the menu\n> often make them pass, which is why I said \"somewhat flaky\".\n>\n>*2* I do not even know if GGG refuses to submit a series with a test\n> failure, let alone if it allows to override such a safety if\n> exists.\n\n\nWhich tests have been hanging on S390? We have occasional hangs on NonStop\nthat end up being attributed to our CI build system not supplying pipes\nproperly to git. It would be interesting if the same tests are having issues\non different platforms.\n--Randall\n\n\n\n\n\n"},{"id":"490059","messageId":"pull.1663.v4.git.git.1709703857881.gitgitgadget@gmail.com","threadId":"60823","inReplyTo":"pull.1663.v3.git.git.1708841439516.gitgitgadget@gmail.com","subject":"[PATCH v4] build: support z/OS (OS/390).","fromName":"Haritha via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-03-06T05:44:17Z","receivedAt":"2024-03-06T05:44:21Z","isPatch":true,"sender":{"key":"name:Haritha","avatar":null},"body":"From: Haritha D <harithamma.d@ibm.com>\n\nIntroduced z/OS (OS/390) as a platform in config.mak.uname\n\nSigned-off-by: Haritha D <harithamma.d@ibm.com>\n---\n    This PR enables a successful git build on z/OS.\n    \n    Introduced z/OS (OS/390) as a platform in config.mak.uname\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1663%2FHarithaIBM%2Fzos-v4\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1663/HarithaIBM/zos-v4\nPull-Request: https://github.com/git/git/pull/1663\n\nRange-diff vs v3:\n\n 1:  2f1ad41bc14 ! 1:  cbc38a801e9 build: support z/OS (OS/390).\n     @@ Metadata\n       ## Commit message ##\n          build: support z/OS (OS/390).\n      \n     -    Since the z/OS linker does not support searching dynamic libraries,\n     -    and the current setting of CC_LD_DYNPATH results in a directory\n     -    to be supplied to the link step with no option as the suffix,\n     -    it causes a linker error because the z/OS LD linker\n     -    does not accept directories as input.\n     -    Therefore, -L option is added.\n     -    Also introduced z/OS (OS/390) as a platform in config.mak.uname\n     +    Introduced z/OS (OS/390) as a platform in config.mak.uname\n      \n          Signed-off-by: Haritha D <harithamma.d@ibm.com>\n      \n     @@ config.mak.uname: ifeq ($(uname_S),NONSTOP_KERNEL)\n       \tSHELL_PATH = /usr/coreutils/bin/bash\n       endif\n      +ifeq ($(uname_S),OS/390)\n     -+        NO_SYS_POLL_H = YesPlease\n     -+        NO_STRCASESTR = YesPlease\n     -+        NO_REGEX = YesPlease\n     -+        NO_MMAP = YesPlease\n     -+        NO_NSEC = YesPlease\n     -+        NO_STRLCPY = YesPlease\n     -+        NO_MEMMEM = YesPlease\n     -+        NO_GECOS_IN_PWENT = YesPlease\n     -+        HAVE_STRINGS_H = YesPlease\n     -+       NEEDS_MODE_TRANSLATION = YesPlease\n     ++\tNO_SYS_POLL_H = YesPlease\n     ++\tNO_STRCASESTR = YesPlease\n     ++\tNO_REGEX = YesPlease\n     ++\tNO_MMAP = YesPlease\n     ++\tNO_NSEC = YesPlease\n     ++\tNO_STRLCPY = YesPlease\n     ++\tNO_MEMMEM = YesPlease\n     ++\tNO_GECOS_IN_PWENT = YesPlease\n     ++\tHAVE_STRINGS_H = YesPlease\n     ++\tNEEDS_MODE_TRANSLATION = YesPlease\n      +endif\n       ifeq ($(uname_S),MINGW)\n       \tifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n\n\n config.mak.uname | 12 ++++++++++++\n 1 file changed, 12 insertions(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex dacc95172dc..d0dcca2ec55 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n \tSHELL_PATH = /usr/coreutils/bin/bash\n endif\n+ifeq ($(uname_S),OS/390)\n+\tNO_SYS_POLL_H = YesPlease\n+\tNO_STRCASESTR = YesPlease\n+\tNO_REGEX = YesPlease\n+\tNO_MMAP = YesPlease\n+\tNO_NSEC = YesPlease\n+\tNO_STRLCPY = YesPlease\n+\tNO_MEMMEM = YesPlease\n+\tNO_GECOS_IN_PWENT = YesPlease\n+\tHAVE_STRINGS_H = YesPlease\n+\tNEEDS_MODE_TRANSLATION = YesPlease\n+endif\n ifeq ($(uname_S),MINGW)\n \tifeq ($(shell expr \"$(uname_R)\" : '1\\.'),2)\n \t\t$(error \"Building with MSys is no longer supported\")\n\nbase-commit: b387623c12f3f4a376e4d35a610fd3e55d7ea907\n-- \ngitgitgadget\n"},{"id":"490093","messageId":"xmqqle6vtk7k.fsf@gitster.g","threadId":"60823","inReplyTo":"pull.1663.v4.git.git.1709703857881.gitgitgadget@gmail.com","subject":"Re: [PATCH v4] build: support z/OS (OS/390).","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-06T16:10:23Z","receivedAt":"2024-03-06T16:10:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Haritha  via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Haritha D <harithamma.d@ibm.com>\n>\n> Introduced z/OS (OS/390) as a platform in config.mak.uname\n>\n> Signed-off-by: Haritha D <harithamma.d@ibm.com>\n> ---\n>     This PR enables a successful git build on z/OS.\n\nGood.\n\n>  config.mak.uname | 12 ++++++++++++\n>  1 file changed, 12 insertions(+)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index dacc95172dc..d0dcca2ec55 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -638,6 +638,18 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n>  \tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n>  \tSHELL_PATH = /usr/coreutils/bin/bash\n>  endif\n> +ifeq ($(uname_S),OS/390)\n> +\tNO_SYS_POLL_H = YesPlease\n> +\tNO_STRCASESTR = YesPlease\n> +\tNO_REGEX = YesPlease\n> +\tNO_MMAP = YesPlease\n> +\tNO_NSEC = YesPlease\n> +\tNO_STRLCPY = YesPlease\n> +\tNO_MEMMEM = YesPlease\n> +\tNO_GECOS_IN_PWENT = YesPlease\n> +\tHAVE_STRINGS_H = YesPlease\n> +\tNEEDS_MODE_TRANSLATION = YesPlease\n> +endif\n\nI somehow expected you to throw in the -L thing in this block,\nperhaps like\n\n\tCC_LD_DYNPATH =\n\nto help those who are on OS/390 but do not run configure (made from\nconfigure.ac) to create the config.mak.autogen file, but if you are\nalways building with configure and not testing such a configuration,\nthen doing so and shipping an untested code would not be prudent, so\nlet's accept this patch as-is.\n\nThanks for working on this.  Will queue.\n"}]}