{"thread":{"id":"60755","subject":"[PATCH v2] rebase: Fix documentation about used shell in -x","startedAt":"2024-01-17T08:54:56Z","lastAt":"2024-01-17T22:38:44Z","messageCount":2,"participants":["Nikolay Borisov","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"486913","messageId":"20240117085347.948960-1-nik.borisov@suse.com","threadId":"60755","inReplyTo":null,"subject":"[PATCH v2] rebase: Fix documentation about used shell in -x","fromName":"Nikolay Borisov","fromEmail":"nik.borisov@suse.com","sentAt":"2024-01-17T08:53:47Z","receivedAt":"2024-01-17T08:54:56Z","isPatch":true,"sender":{"key":"nik.borisov@suse.com","avatar":null},"body":"The shell used when using the -x option is erroneously documented to be\nthe one pointed to by the $SHELL environmental variable. This was true\nwhen rebase was implemented as a shell script but this is no longer\ntrue.\n\nSigned-off-by: Nikolay Borisov <nik.borisov@suse.com>\n---\n Documentation/git-rebase.txt | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt\nindex 25516c45d8b8..2cd55aedc0f9 100644\n--- a/Documentation/git-rebase.txt\n+++ b/Documentation/git-rebase.txt\n@@ -963,10 +963,9 @@ The interactive rebase will stop when a command fails (i.e. exits with\n non-0 status) to give you an opportunity to fix the problem. You can\n continue with `git rebase --continue`.\n\n-The \"exec\" command launches the command in a shell (the one specified\n-in `$SHELL`, or the default shell if `$SHELL` is not set), so you can\n-use shell features (like \"cd\", \">\", \";\" ...). The command is run from\n-the root of the working tree.\n+The \"exec\" command launches the command in a shell (the default one, usually\n+/bin/sh), so you can use shell features (like \"cd\", \">\", \";\" ...). The command\n+is run from the root of the working tree.\n\n ----------------------------------\n $ git rebase -i --exec \"make test\"\n--\n2.34.1\n\n"},{"id":"486943","messageId":"xmqqr0iftwk0.fsf@gitster.g","threadId":"60755","inReplyTo":"20240117085347.948960-1-nik.borisov@suse.com","subject":"Re: [PATCH v2] rebase: Fix documentation about used shell in -x","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-01-17T22:38:39Z","receivedAt":"2024-01-17T22:38:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nikolay Borisov <nik.borisov@suse.com> writes:\n\n> The shell used when using the -x option is erroneously documented to be\n> the one pointed to by the $SHELL environmental variable. This was true\n> when rebase was implemented as a shell script but this is no longer\n> true.\n>\n> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>\n> ---\n\nAh, our mails crossed, and this is much better than my \"tentative\"\none.  Let me replace it with this one and queue.\n\nThanks.\n\n>  Documentation/git-rebase.txt | 7 +++----\n>  1 file changed, 3 insertions(+), 4 deletions(-)\n>\n> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt\n> index 25516c45d8b8..2cd55aedc0f9 100644\n> --- a/Documentation/git-rebase.txt\n> +++ b/Documentation/git-rebase.txt\n> @@ -963,10 +963,9 @@ The interactive rebase will stop when a command fails (i.e. exits with\n>  non-0 status) to give you an opportunity to fix the problem. You can\n>  continue with `git rebase --continue`.\n>\n> -The \"exec\" command launches the command in a shell (the one specified\n> -in `$SHELL`, or the default shell if `$SHELL` is not set), so you can\n> -use shell features (like \"cd\", \">\", \";\" ...). The command is run from\n> -the root of the working tree.\n> +The \"exec\" command launches the command in a shell (the default one, usually\n> +/bin/sh), so you can use shell features (like \"cd\", \">\", \";\" ...). The command\n> +is run from the root of the working tree.\n>\n>  ----------------------------------\n>  $ git rebase -i --exec \"make test\"\n> --\n> 2.34.1\n"}]}