{"thread":{"id":"60664","subject":"[PATCH 1/1] doc: use singular form of repeatable path arg","startedAt":"2023-12-27T20:55:09Z","lastAt":"2023-12-28T00:10:57Z","messageCount":3,"participants":["Britton Leo Kerin","Eric Sunshine","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"486060","messageId":"3d46bca1-96d4-43ba-a912-1f7c76942287@smtp-relay.sendinblue.com","threadId":"60664","inReplyTo":"20231227205340.9886-1-britton.kerin@gmail.com","subject":"[PATCH 1/1] doc: use singular form of repeatable path arg","fromName":"Britton Leo Kerin","fromEmail":"britton.kerin@gmail.com","sentAt":"2023-12-27T20:53:40Z","receivedAt":"2023-12-27T20:55:09Z","isPatch":true,"sender":{"key":"britton.kerin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/7434164?v=4"},"body":"This is more correct because the ... doc syntax already indicates\nthat the arg is \"array-type\". It's how other tools do it. Finally, the\nlater document text mentions 'path' arguments, while it doesn't mention\n'paths'.\n\nSigned-off-by: Britton L Kerin \n---\n Documentation/git-bisect.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\nindex 191b4a42b6..58821f7e11 100644\n--- a/Documentation/git-bisect.txt\n+++ b/Documentation/git-bisect.txt\n@@ -17,7 +17,7 @@ The command takes various subcommands, and different options depending\n on the subcommand:\n \n git bisect start [--term-(new|bad)= --term-(old|good)=]\n-\t\t [--no-checkout] [--first-parent] [ [...]] [--] [...]\n+\t\t [--no-checkout] [--first-parent] [ [...]] [--] [...]\n git bisect (bad|new|) []\n git bisect (good|old|) [...]\n git bisect terms [--term-good | --term-bad]\n-- \n2.43.0\n\n\n"},{"id":"486063","messageId":"CAPig+cShsSSd-jpvSW_sq3-R++zjtHU-m2PmTsz-Nx9YVRStug@mail.gmail.com","threadId":"60664","inReplyTo":"3d46bca1-96d4-43ba-a912-1f7c76942287@smtp-relay.sendinblue.com","subject":"Re: [PATCH 1/1] doc: use singular form of repeatable path arg","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2023-12-27T22:29:20Z","receivedAt":"2023-12-27T22:29:32Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Wed, Dec 27, 2023 at 3:55 PM Britton Leo Kerin\n wrote:\n> This is more correct because the ... doc syntax already indicates\n> that the arg is \"array-type\". It's how other tools do it. Finally, the\n> later document text mentions 'path' arguments, while it doesn't mention\n> 'paths'.\n\nYep, makes sense.\n\n> Signed-off-by: Britton L Kerin \n> ---\n> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\n> @@ -17,7 +17,7 @@ The command takes various subcommands, and different options depending\n> git bisect start [--term-(new|bad)= --term-(old|good)=]\n> - [--no-checkout] [--first-parent] [ [...]] [--] [...]\n> + [--no-checkout] [--first-parent] [ [...]] [--] [...]\n\nLooking good.\n\nIn builtin/bisect.c, the \"usage\" string says \"[...]\" rather\nthan \"[...]\". Perhaps it makes sense to unify these?\n\nAlso, there are a few more documentation files that could use the\n\"\" to \"...\" fixup (though not always in the synopsis). A\n'grep' indicates that git-checkout.txt, git-diff.txt, and\ngit-rev-list-options.txt also mention \"\". Those may be outside\nthe scope of this patch, although they could easily be included, as\nwell, or made part of a patch series if you feel inclined.\n"},{"id":"486065","messageId":"xmqq5y0jkwz9.fsf@gitster.g","threadId":"60664","inReplyTo":"CAPig+cShsSSd-jpvSW_sq3-R++zjtHU-m2PmTsz-Nx9YVRStug@mail.gmail.com","subject":"Re: [PATCH 1/1] doc: use singular form of repeatable path arg","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-12-28T00:10:50Z","receivedAt":"2023-12-28T00:10:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Sunshine writes:\n\n> On Wed, Dec 27, 2023 at 3:55 PM Britton Leo Kerin\n> wrote:\n>> This is more correct because the ... doc syntax already indicates\n>> that the arg is \"array-type\". It's how other tools do it. Finally, the\n>> later document text mentions 'path' arguments, while it doesn't mention\n>> 'paths'.\n>\n> Yep, makes sense.\n>\n>> Signed-off-by: Britton L Kerin \n\nMicronit. This should be identical to how From: line identifies the\nauthor. s/L/Leo/ should be sufficient, I presume?\n\n>> ---\n>> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\n>> @@ -17,7 +17,7 @@ The command takes various subcommands, and different options depending\n>> git bisect start [--term-(new|bad)= --term-(old|good)=]\n>> - [--no-checkout] [--first-parent] [ [...]] [--] [...]\n>> + [--no-checkout] [--first-parent] [ [...]] [--] [...]\n>\n> Looking good.\n>\n> In builtin/bisect.c, the \"usage\" string says \"[...]\" rather\n> than \"[...]\". Perhaps it makes sense to unify these?\n\nYup, and that would be a good thing to do in a single patch, and\nalso it would be a good place to stop. Further clean-up you\nsuggested below are very much worth doing, but it probably is good\nto leave out of this single focused fix we are reviewing here and\ninstead be done as separate patch(es).\n\nThanks.\n\n> Also, there are a few more documentation files that could use the\n> \"\" to \"...\" fixup (though not always in the synopsis). A\n> 'grep' indicates that git-checkout.txt, git-diff.txt, and\n> git-rev-list-options.txt also mention \"\". Those may be outside\n> the scope of this patch, although they could easily be included, as\n> well, or made part of a patch series if you feel inclined.\n"}]}