{"thread":{"id":"60663","subject":"[PATCH 0/1] doc: git-bisect: change plural form to singular","startedAt":"2023-12-27T20:54:58Z","lastAt":"2024-01-10T22:38:19Z","messageCount":6,"participants":["Britton Leo Kerin","Taylor Blau","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"486059","messageId":"a5a8c257-8550-492e-a6fa-e88ee59d4d66@smtp-relay.sendinblue.com","threadId":"60663","inReplyTo":null,"subject":"[PATCH 0/1] doc: git-bisect: change plural form to singular","fromName":"Britton Leo Kerin","fromEmail":"britton.kerin@gmail.com","sentAt":"2023-12-27T20:53:39Z","receivedAt":"2023-12-27T20:54:58Z","isPatch":true,"sender":{"key":"britton.kerin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/7434164?v=4"},"body":"Correct the usage in git-bisect documentation to use singular form for a\nrepeatable argument as other commands do.\n\nI reported this tiny issue previously but didn't see a response so I\nthought I'd use it as a chance to get up to speed on the patch\nsubmission process. Sorry if no response meant no interest on this\nissue.\n\nBritton Leo Kerin (1):\n doc: use singular form of repeatable path arg\n\n Documentation/git-bisect.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 055bb6e9969085777b7fab83e3fee0017654f134\n--\n2.43.0\n\n\n"},{"id":"486228","messageId":"ff15fe5d-9877-46c4-bb09-33267bdc64e2@smtp-relay.sendinblue.com","threadId":"60663","inReplyTo":"20240103040207.661413-1-britton.kerin@gmail.com","subject":"[PATCH v2 2/2] doc: refer to pathspec instead of path","fromName":"Britton Leo Kerin","fromEmail":"britton.kerin@gmail.com","sentAt":"2024-01-03T04:02:07Z","receivedAt":"2024-01-03T04:02:13Z","isPatch":true,"sender":{"key":"britton.kerin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/7434164?v=4"},"body":"Signed-off-by: Britton Leo Kerin \n---\n Documentation/git-bisect.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\nindex b798282788..8e01f1d618 100644\n--- a/Documentation/git-bisect.txt\n+++ b/Documentation/git-bisect.txt\n@@ -17,7 +17,7 @@ The command takes various subcommands, and different options depending\n on the subcommand:\n \n git bisect start [--term-(new|bad)= --term-(old|good)=]\n-\t\t [--no-checkout] [--first-parent] [ [...]] [--] [...]\n+\t\t [--no-checkout] [--first-parent] [ [...]] [--] [...]\n git bisect (bad|new|) []\n git bisect (good|old|) [...]\n git bisect terms [--term-good | --term-bad]\n@@ -299,7 +299,7 @@ Cutting down bisection by giving more parameters to bisect start\n \n You can further cut down the number of trials, if you know what part of\n the tree is involved in the problem you are tracking down, by specifying\n-path parameters when issuing the `bisect start` command:\n+pathspec parameters when issuing the `bisect start` command:\n \n ------------\n $ git bisect start -- arch/i386 include/asm-i386\n-- \n2.43.0\n\n\n"},{"id":"486229","messageId":"95ced208-fa2d-4e0f-9887-7c861db598b3@smtp-relay.sendinblue.com","threadId":"60663","inReplyTo":"20240103040207.661413-1-britton.kerin@gmail.com","subject":"[PATCH v2 1/2] doc: use singular form of repeatable path arg","fromName":"Britton Leo Kerin","fromEmail":"britton.kerin@gmail.com","sentAt":"2024-01-03T04:02:06Z","receivedAt":"2024-01-03T04:02:13Z","isPatch":true,"sender":{"key":"britton.kerin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/7434164?v=4"},"body":"This is more correct because the ... doc syntax already indicates\nthat the arg is \"array-type\". It's how other tools do it. Finally, the\nlater document text mentions 'path' arguments, while it doesn't mention\n'paths'.\n\nSigned-off-by: Britton Leo Kerin \n---\n Documentation/git-bisect.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\nindex aa02e46224..b798282788 100644\n--- a/Documentation/git-bisect.txt\n+++ b/Documentation/git-bisect.txt\n@@ -17,7 +17,7 @@ The command takes various subcommands, and different options depending\n on the subcommand:\n \n git bisect start [--term-(new|bad)= --term-(old|good)=]\n-\t\t [--no-checkout] [--first-parent] [ [...]] [--] [...]\n+\t\t [--no-checkout] [--first-parent] [ [...]] [--] [...]\n git bisect (bad|new|) []\n git bisect (good|old|) [...]\n git bisect terms [--term-good | --term-bad]\n-- \n2.43.0\n\n\n"},{"id":"486230","messageId":"6bcbd017-968e-4ac8-a56b-164b163c76d4@smtp-relay.sendinblue.com","threadId":"60663","inReplyTo":"a5a8c257-8550-492e-a6fa-e88ee59d4d66@smtp-relay.sendinblue.com","subject":"[PATCH v2 0/2] doc: bisect: change plural paths to singular pathspec","fromName":"Britton Leo Kerin","fromEmail":"britton.kerin@gmail.com","sentAt":"2024-01-03T04:02:05Z","receivedAt":"2024-01-03T04:02:13Z","isPatch":true,"sender":{"key":"britton.kerin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/7434164?v=4"},"body":"Britton Leo Kerin (2):\n doc: use singular form of repeatable path arg\n doc: refer to pathspec instead of path\n\n Documentation/git-bisect.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\nRange-diff against v1:\n1: 90c081dcab ! 1: da40e4736b doc: use singular form of repeatable path arg\n @@ Commit message\n later document text mentions 'path' arguments, while it doesn't mention\n 'paths'.\n\n - Signed-off-by: Britton L Kerin \n + Signed-off-by: Britton Leo Kerin \n\n ## Documentation/git-bisect.txt ##\n @@ Documentation/git-bisect.txt: The command takes various subcommands, and different options depending\n-: ---------- > 2: d932b6d501 doc: refer to pathspec instead of path\n--\n2.43.0\n\n\n"},{"id":"486267","messageId":"ZZWWmXHa8ebtkZQ8@nand.local","threadId":"60663","inReplyTo":"6bcbd017-968e-4ac8-a56b-164b163c76d4@smtp-relay.sendinblue.com","subject":"Re: [PATCH v2 0/2] doc: bisect: change plural paths to singular pathspec","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-01-03T17:17:13Z","receivedAt":"2024-01-03T17:17:15Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Jan 02, 2024 at 07:02:05PM -0900, Britton Leo Kerin wrote:\n> Britton Leo Kerin (2):\n> doc: use singular form of repeatable path arg\n> doc: refer to pathspec instead of path\n>\n> Documentation/git-bisect.txt | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> Range-diff against v1:\n> 1: 90c081dcab ! 1: da40e4736b doc: use singular form of repeatable path arg\n> @@ Commit message\n> later document text mentions 'path' arguments, while it doesn't mention\n> 'paths'.\n>\n> - Signed-off-by: Britton L Kerin \n> + Signed-off-by: Britton Leo Kerin \n>\n> ## Documentation/git-bisect.txt ##\n> @@ Documentation/git-bisect.txt: The command takes various subcommands, and different options depending\n> -: ---------- > 2: d932b6d501 doc: refer to pathspec instead of path\n> --\n> 2.43.0\n\nHmm. The end-state of these two patches looks good to me, but I probably\nwould have written this change as a single change from \"paths\" ->\n\"pathspec\", not \"paths\" -> \"path\" -> \"pathspec\".\n\nThanks,\nTaylor\n"},{"id":"486574","messageId":"xmqqbk9s95lz.fsf@gitster.g","threadId":"60663","inReplyTo":"ZZWWmXHa8ebtkZQ8@nand.local","subject":"Re: [PATCH v2 0/2] doc: bisect: change plural paths to singular pathspec","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-01-10T22:38:16Z","receivedAt":"2024-01-10T22:38:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> On Tue, Jan 02, 2024 at 07:02:05PM -0900, Britton Leo Kerin wrote:\n>> Britton Leo Kerin (2):\n>> doc: use singular form of repeatable path arg\n>> doc: refer to pathspec instead of path\n>>\n>> Documentation/git-bisect.txt | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> Range-diff against v1:\n>> 1: 90c081dcab ! 1: da40e4736b doc: use singular form of repeatable path arg\n>> @@ Commit message\n>> later document text mentions 'path' arguments, while it doesn't mention\n>> 'paths'.\n>>\n>> - Signed-off-by: Britton L Kerin \n>> + Signed-off-by: Britton Leo Kerin \n>>\n>> ## Documentation/git-bisect.txt ##\n>> @@ Documentation/git-bisect.txt: The command takes various subcommands, and different options depending\n>> -: ---------- > 2: d932b6d501 doc: refer to pathspec instead of path\n>> --\n>> 2.43.0\n>\n> Hmm. The end-state of these two patches looks good to me, but I probably\n> would have written this change as a single change from \"paths\" ->\n> \"pathspec\", not \"paths\" -> \"path\" -> \"pathspec\".\n\nHave we seen a resolution to this comment? I _think_ it is an OK\napproach to take to do this in two steps, if the use of technical\nterm \"pathspec\" could be controversial, but since it is not, I am\nfine with either one or two patches. Since we already have the\ntwo-patch version, let's take it.\n\nThanks.\n"}]}