{"thread":{"id":"60615","subject":"completing an existing patch","startedAt":"2023-12-14T13:21:05Z","lastAt":"2023-12-14T18:37:54Z","messageCount":2,"participants":["Marzi Esipreh","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"485643","messageId":"CAN0Ui1RM-R+yX=LK+ir_WEzAYRJnT-WTn427JbNJjTNTiQfa4w@mail.gmail.com","threadId":"60615","inReplyTo":null,"subject":"completing an existing patch","fromName":"Marzi Esipreh","fromEmail":"marzi.esipreh@uber.com","sentAt":"2023-12-14T13:20:51Z","receivedAt":"2023-12-14T13:21:05Z","isPatch":false,"sender":{"key":"marzi.esipreh@uber.com","avatar":null},"body":"Hi all,\nI hope you are well.\nI'm working in a company where most of our developers are using linux\nas a development environment, so the performance of git on linux\nplatforms is important for us.\nWe came across this PR: https://github.com/git/git/pull/1352 that is\nimproving git status performance on linux platforms, we tried it out,\nand we are happy with the result.\nI was in contact with the author of this patch, and I addressed the PR\ncomments as well.\nPlease let me know how I can proceed? Shall I create a new fresh PR,\nand refer to existing one in the descriptions?\nBest regards,\nMarzi\n"},{"id":"485662","messageId":"CAPig+cRt4A3xtXGQCApNY8H+DFjGmFQuPh4hGcurHCkX4U5Rvw@mail.gmail.com","threadId":"60615","inReplyTo":"CAN0Ui1RM-R+yX=LK+ir_WEzAYRJnT-WTn427JbNJjTNTiQfa4w@mail.gmail.com","subject":"Re: completing an existing patch","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2023-12-14T18:37:42Z","receivedAt":"2023-12-14T18:37:54Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Dec 14, 2023 at 8:21 AM Marzi Esipreh <marzi.esipreh@uber.com> wrote:\n> We came across this PR: https://github.com/git/git/pull/1352 that is\n> improving git status performance on linux platforms, we tried it out,\n> and we are happy with the result.\n> I was in contact with the author of this patch, and I addressed the PR\n> comments as well.\n> Please let me know how I can proceed? Shall I create a new fresh PR,\n> and refer to existing one in the descriptions?\n\nThe general answer is that you can take over a stalled patch series in\norder to move it forward by rerolling the series with changes which\naddress reviewer comments from the previous rounds, and send the\nseries to the mailing list with a cover letter explaining the\nsituation and enumerating the changes you made since the previous\nversion. Standard practice is to retain the original authorship of the\npatches[1] and keep the original author's Signed-off-by:. Add your\nSigned-off-by: below the author's Signed-of-by: on all patches, not\njust the patches you changed. After submitting, respond to reviewer\ncomments on the new version, and reroll as necessary to address those\ncomments.\n\nSomebody more familiar with GitHub and/or GitGitGadget will have to\nanswer the more specific part of your question about whether you can\npush your version to the same PR or if you instead need to open a new\nPR. If you are able to push to the existing PR, then you also need to\nupdate the PR's description since that becomes the cover letter for\nthe series. Or you can just send the patch series directly to the\nmailing list, skipping GitGitGadget altogether.\n\n[1]: That is, unless you change a patch so substantially that little\nof the author's original work is present, in which case you make\nyourself the author and typically credit the original author with an\nOriginal-patch-by: or Helped-by:.\n"}]}