{"thread":{"id":"60572","subject":"Consider dropping the decimal places for KiB/s 52.00 KiB/s","startedAt":"2023-11-30T18:14:07Z","lastAt":"2023-11-30T20:19:13Z","messageCount":4,"participants":["Jonny Grant","Taylor Blau","Dragan Simic"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"485276","messageId":"637be919-0b04-4e5c-8f2e-43340521e6d1@jguk.org","threadId":"60572","inReplyTo":null,"subject":"Consider dropping the decimal places for KiB/s 52.00 KiB/s","fromName":"Jonny Grant","fromEmail":"jg@jguk.org","sentAt":"2023-11-30T18:11:57Z","receivedAt":"2023-11-30T18:14:07Z","isPatch":false,"sender":{"key":"jg@jguk.org","avatar":null},"body":"Hello\n\nMay I suggest taking off the .00 KiB/s suffix, has that been considered? As the decimal places don't appear to change, they're stuck on .00.\n\nI noticed the KiB/s is neatly rounded to the kibibyte.\n\nApologies I'm not using latest release. \ngit version 2.40.1\n\n\n$ git clone git://gcc.gnu.org/git/gcc.git git_1\nCloning into 'git_1'...\nremote: Enumerating objects: 2949348, done.\nremote: Counting objects: 100% (209238/209238), done.\nremote: Compressing objects: 100% (14579/14579), done.\nReceiving objects:   7% (210878/2949348), 76.33 MiB | 52.00 KiB/s\n\n\nMeanwhile I'll keep waiting for this slow server.\n\nKind regards, Jonny\n"},{"id":"485278","messageId":"ZWjdatp3SRb4mN6G@nand.local","threadId":"60572","inReplyTo":"637be919-0b04-4e5c-8f2e-43340521e6d1@jguk.org","subject":"Re: Consider dropping the decimal places for KiB/s 52.00 KiB/s","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-11-30T19:07:22Z","receivedAt":"2023-11-30T19:07:24Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Nov 30, 2023 at 06:11:57PM +0000, Jonny Grant wrote:\n> Hello\n>\n> May I suggest taking off the .00 KiB/s suffix, has that been\n> considered? As the decimal places don't appear to change, they're\n> stuck on .00.\n\nI wonder if you have a throttled connection that is locked to 52KiB/s\nexactly. The progress code that generates the throughput is in\nprogress.c::display_throughput(), which computes the rate. It's computed\nin bytes/misec, and then passed to throughput_string() (really,\n`strbuf_humanise_rate()`), which formats it appropriately.\n\nIf you're in the KiB range, it will print the decimal component, which\nis:\n\n    ((bytes & ((1<<10)-1)) * 100) >> 10\n\n> $ git clone git://gcc.gnu.org/git/gcc.git git_1\n> Cloning into 'git_1'...\n> remote: Enumerating objects: 2949348, done.\n> remote: Counting objects: 100% (209238/209238), done.\n> remote: Compressing objects: 100% (14579/14579), done.\n> Receiving objects:   7% (210878/2949348), 76.33 MiB | 52.00 KiB/s\n\nOn my machine:\n\n    $ git.compile clone git://gcc.gnu.org/git/gcc.git\n    [...]\n    Receiving objects:  11% (342176/2949348), 108.09 MiB | 24.01 MiB/s\n\nI suppose we could consider dropping the decimal component if it's a\nround number, but I think that it may produce awkward flickering if the\nrate oscillates between a round number and a non-round number.\n\nThanks,\nTaylor\n"},{"id":"485283","messageId":"9c93eba836a22ba8dfb46c43e5b325ac@manjaro.org","threadId":"60572","inReplyTo":"ZWjdatp3SRb4mN6G@nand.local","subject":"Re: Consider dropping the decimal places for KiB/s 52.00 KiB/s","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2023-11-30T19:28:29Z","receivedAt":"2023-11-30T19:28:32Z","isPatch":false,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"On 2023-11-30 20:07, Taylor Blau wrote:\n> On Thu, Nov 30, 2023 at 06:11:57PM +0000, Jonny Grant wrote:\n>> $ git clone git://gcc.gnu.org/git/gcc.git git_1\n>> Cloning into 'git_1'...\n>> remote: Enumerating objects: 2949348, done.\n>> remote: Counting objects: 100% (209238/209238), done.\n>> remote: Compressing objects: 100% (14579/14579), done.\n>> Receiving objects:   7% (210878/2949348), 76.33 MiB | 52.00 KiB/s\n> \n> On my machine:\n> \n>     $ git.compile clone git://gcc.gnu.org/git/gcc.git\n>     [...]\n>     Receiving objects:  11% (342176/2949348), 108.09 MiB | 24.01 MiB/s\n> \n> I suppose we could consider dropping the decimal component if it's a\n> round number, but I think that it may produce awkward flickering if the\n> rate oscillates between a round number and a non-round number.\n\nYou're right, the resulting flickering would look really annoying.  In \nfact, I already modified the reported download speed in another project \nto avoid pretty much the same kind of flickering, and it looked much \nbetter without it.\n"},{"id":"485288","messageId":"c3efb95a-7317-421a-bc87-fcc234be16c0@jguk.org","threadId":"60572","inReplyTo":"ZWjdatp3SRb4mN6G@nand.local","subject":"Re: Consider dropping the decimal places for KiB/s 52.00 KiB/s","fromName":"Jonny Grant","fromEmail":"jg@jguk.org","sentAt":"2023-11-30T20:19:09Z","receivedAt":"2023-11-30T20:19:13Z","isPatch":false,"sender":{"key":"jg@jguk.org","avatar":null},"body":"\n\nOn 30/11/2023 19:07, Taylor Blau wrote:\n> On Thu, Nov 30, 2023 at 06:11:57PM +0000, Jonny Grant wrote:\n>> Hello\n>>\n>> May I suggest taking off the .00 KiB/s suffix, has that been\n>> considered? As the decimal places don't appear to change, they're\n>> stuck on .00.\n> \n> I wonder if you have a throttled connection that is locked to 52KiB/s\n> exactly.\n\nYou're right - I changed to https and it went to 6 MiB/s. Seems throttled on git://\nI should have checked that first.\n\n>  The progress code that generates the throughput is in\n> progress.c::display_throughput(), which computes the rate. It's computed\n> in bytes/misec, and then passed to throughput_string() (really,\n> `strbuf_humanise_rate()`), which formats it appropriately.\n> \n> If you're in the KiB range, it will print the decimal component, which\n> is:\n> \n>     ((bytes & ((1<<10)-1)) * 100) >> 10\n> \n>> $ git clone git://gcc.gnu.org/git/gcc.git git_1\n>> Cloning into 'git_1'...\n>> remote: Enumerating objects: 2949348, done.\n>> remote: Counting objects: 100% (209238/209238), done.\n>> remote: Compressing objects: 100% (14579/14579), done.\n>> Receiving objects:   7% (210878/2949348), 76.33 MiB | 52.00 KiB/s\n> \n> On my machine:\n> \n>     $ git.compile clone git://gcc.gnu.org/git/gcc.git\n>     [...]\n>     Receiving objects:  11% (342176/2949348), 108.09 MiB | 24.01 MiB/s\n> \n> I suppose we could consider dropping the decimal component if it's a\n> round number, but I think that it may produce awkward flickering if the\n> rate oscillates between a round number and a non-round number.\n\nNow I can see the advantage of it as it is. wget is similar.\nKind regards, Jonny\n\n\n"}]}