{"thread":{"id":"60460","subject":"[PATCH] strvec: drop unnecessary include of hex.h","startedAt":"2023-11-02T20:51:24Z","lastAt":"2023-11-02T23:26:03Z","messageCount":2,"participants":["Linus Arver via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"484376","messageId":"pull.1608.git.1698958277454.gitgitgadget@gmail.com","threadId":"60460","inReplyTo":null,"subject":"[PATCH] strvec: drop unnecessary include of hex.h","fromName":"Linus Arver via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-11-02T20:51:17Z","receivedAt":"2023-11-02T20:51:24Z","isPatch":true,"sender":{"key":"linus@ucla.edu","avatar":null},"body":"From: Linus Arver <linusa@google.com>\n\nIn 41771fa435 (cache.h: remove dependence on hex.h; make other files\ninclude it explicitly, 2023-02-24) we added this as part of a larger\nmechanical refactor. But strvec doesn't actually depend on hex.h, so\nremove it.\n\nSigned-off-by: Linus Arver <linusa@google.com>\n---\n    strvec: drop unnecessary include of hex.h\n    \n    In 41771fa435 (cache.h: remove dependence on hex.h; make other files\n    include it explicitly, 2023-02-24) we added this as part of a larger\n    mechanical refactor. But strvec doesn't actually depend on hex.h, so\n    remove it.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1608\n\n strvec.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/strvec.c b/strvec.c\nindex 89dc9e7e753..178f4f37480 100644\n--- a/strvec.c\n+++ b/strvec.c\n@@ -1,6 +1,5 @@\n #include \"git-compat-util.h\"\n #include \"strvec.h\"\n-#include \"hex.h\"\n #include \"strbuf.h\"\n \n const char *empty_strvec[] = { NULL };\n\nbase-commit: bc5204569f7db44d22477485afd52ea410d83743\n-- \ngitgitgadget\n"},{"id":"484380","messageId":"xmqq7cmzlov2.fsf@gitster.g","threadId":"60460","inReplyTo":"pull.1608.git.1698958277454.gitgitgadget@gmail.com","subject":"Re: [PATCH] strvec: drop unnecessary include of hex.h","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-11-02T23:25:21Z","receivedAt":"2023-11-02T23:26:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Linus Arver via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Linus Arver <linusa@google.com>\n>\n> In 41771fa435 (cache.h: remove dependence on hex.h; make other files\n> include it explicitly, 2023-02-24) we added this as part of a larger\n> mechanical refactor. But strvec doesn't actually depend on hex.h, so\n> remove it.\n>\n> Signed-off-by: Linus Arver <linusa@google.com>\n> ---\n>     strvec: drop unnecessary include of hex.h\n>     \n>     In 41771fa435 (cache.h: remove dependence on hex.h; make other files\n>     include it explicitly, 2023-02-24) we added this as part of a larger\n>     mechanical refactor. But strvec doesn't actually depend on hex.h, so\n>     remove it.\n\nThis change somehow looks familiar.\n\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/1608\n>\n>  strvec.c | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/strvec.c b/strvec.c\n> index 89dc9e7e753..178f4f37480 100644\n> --- a/strvec.c\n> +++ b/strvec.c\n> @@ -1,6 +1,5 @@\n>  #include \"git-compat-util.h\"\n>  #include \"strvec.h\"\n> -#include \"hex.h\"\n>  #include \"strbuf.h\"\n\nMakes sense.\nWill queue.\n\nThanks.\n"}]}