{"thread":{"id":"60383","subject":"[PATCH v2 1/1] [OUTREACHY] add: standardize die() messages output.","startedAt":"2023-10-17T11:40:25Z","lastAt":"2023-10-17T19:41:30Z","messageCount":2,"participants":["Naomi Ibe","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":1},"messages":[{"id":"483341","messageId":"20231017113946.747-1-naomi.ibeh69@gmail.com","threadId":"60383","inReplyTo":null,"subject":"[PATCH v2 1/1] [OUTREACHY] add: standardize die() messages output.","fromName":"Naomi Ibe","fromEmail":"naomi.ibeh69@gmail.com","sentAt":"2023-10-17T11:39:45Z","receivedAt":"2023-10-17T11:40:25Z","isPatch":true,"sender":{"key":"naomi.ibeh69@gmail.com","avatar":"https://avatars.githubusercontent.com/u/104323769?v=4"},"body":" builtin/add.c: clean up die() messages\n\n    As described in the CodingGuidelines document, a single line\n    message given to die() and its friends should not capitalize its\n    first word, and should not add full-stop at the end.\n\nSigned-off-by: Naomi Ibe <naomi.ibeh69@gmail.com>\n---\n builtin/add.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/builtin/add.c b/builtin/add.c\nindex c27254a5cd..5126d2ede3 100644\n--- a/builtin/add.c\n+++ b/builtin/add.c\n@@ -182,7 +182,7 @@ static int edit_patch(int argc, const char **argv, const char *prefix)\n \tgit_config(git_diff_basic_config, NULL); /* no \"diff\" UI options */\n \n \tif (repo_read_index(the_repository) < 0)\n-\t\tdie(_(\"Could not read the index\"));\n+\t\tdie(_(\"could not read the index\"));\n \n \trepo_init_revisions(the_repository, &rev, prefix);\n \trev.diffopt.context = 7;\n@@ -200,15 +200,15 @@ static int edit_patch(int argc, const char **argv, const char *prefix)\n \t\tdie(_(\"editing patch failed\"));\n \n \tif (stat(file, &st))\n-\t\tdie_errno(_(\"Could not stat '%s'\"), file);\n+\t\tdie_errno(_(\"could not stat '%s'\"), file);\n \tif (!st.st_size)\n-\t\tdie(_(\"Empty patch. Aborted.\"));\n+\t\tdie(_(\"empty patch. aborted\"));\n \n \tchild.git_cmd = 1;\n \tstrvec_pushl(&child.args, \"apply\", \"--recount\", \"--cached\", file,\n \t\t     NULL);\n \tif (run_command(&child))\n-\t\tdie(_(\"Could not apply '%s'\"), file);\n+\t\tdie(_(\"could not apply '%s'\"), file);\n \n \tunlink(file);\n \tfree(file);\n@@ -568,7 +568,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)\n finish:\n \tif (write_locked_index(&the_index, &lock_file,\n \t\t\t       COMMIT_LOCK | SKIP_IF_UNCHANGED))\n-\t\tdie(_(\"Unable to write new index file\"));\n+\t\tdie(_(\"unable to write new index file\"));\n \n \tdir_clear(&dir);\n \tclear_pathspec(&pathspec);\n-- \n2.36.1.windows.1\n\n"},{"id":"483357","messageId":"xmqqfs29hw9l.fsf@gitster.g","threadId":"60383","inReplyTo":"20231017113946.747-1-naomi.ibeh69@gmail.com","subject":"Re: [PATCH v2 1/1] [OUTREACHY] add: standardize die() messages output.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-10-17T19:41:26Z","receivedAt":"2023-10-17T19:41:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Naomi Ibe <naomi.ibeh69@gmail.com> writes:\n\n>  builtin/add.c: clean up die() messages\n>\n>     As described in the CodingGuidelines document, a single line\n>     message given to die() and its friends should not capitalize its\n>     first word, and should not add full-stop at the end.\n>\n> Signed-off-by: Naomi Ibe <naomi.ibeh69@gmail.com>\n\nThat's a strange formatting.  I think you meant to make the first\nline (i.e. \"builtin/add.c:...\") as the Subject: of the e-mail, and\nthe three lines of text as the body, without any indentation.\n\nWill queue with such a fix locally to save time, but please make\nsure you know what in your workflow to produce a patch and send it\nout caused this strange formatting, so that you can fix it and send\nyour patches correctly when you need to do so for real.\n\nThanks.\n"}]}