{"thread":{"id":"60329","subject":"[PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635","startedAt":"2023-10-09T01:17:19Z","lastAt":"2023-10-09T08:23:11Z","messageCount":4,"participants":["Naomi Ibe","Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"482836","messageId":"20231009011652.1791-1-naomi.ibeh69@gmail.com","threadId":"60329","inReplyTo":null,"subject":"[PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635","fromName":"Naomi Ibe","fromEmail":"naomi.ibeh69@gmail.com","sentAt":"2023-10-09T01:16:51Z","receivedAt":"2023-10-09T01:17:19Z","isPatch":true,"sender":{"key":"naomi.ibeh69@gmail.com","avatar":"https://avatars.githubusercontent.com/u/104323769?v=4"},"body":"From: Naomi \n\nSigned-off-by: Naomi Ibe \n---\n builtin/add.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/builtin/add.c b/builtin/add.c\nindex c27254a5cd..5126d2ede3 100644\n--- a/builtin/add.c\n+++ b/builtin/add.c\n@@ -182,7 +182,7 @@ static int edit_patch(int argc, const char **argv, const char *prefix)\n \tgit_config(git_diff_basic_config, NULL); /* no \"diff\" UI options */\n \n \tif (repo_read_index(the_repository) < 0)\n-\t\tdie(_(\"Could not read the index\"));\n+\t\tdie(_(\"could not read the index\"));\n \n \trepo_init_revisions(the_repository, &rev, prefix);\n \trev.diffopt.context = 7;\n@@ -200,15 +200,15 @@ static int edit_patch(int argc, const char **argv, const char *prefix)\n \t\tdie(_(\"editing patch failed\"));\n \n \tif (stat(file, &st))\n-\t\tdie_errno(_(\"Could not stat '%s'\"), file);\n+\t\tdie_errno(_(\"could not stat '%s'\"), file);\n \tif (!st.st_size)\n-\t\tdie(_(\"Empty patch. Aborted.\"));\n+\t\tdie(_(\"empty patch. aborted\"));\n \n \tchild.git_cmd = 1;\n \tstrvec_pushl(&child.args, \"apply\", \"--recount\", \"--cached\", file,\n \t\t NULL);\n \tif (run_command(&child))\n-\t\tdie(_(\"Could not apply '%s'\"), file);\n+\t\tdie(_(\"could not apply '%s'\"), file);\n \n \tunlink(file);\n \tfree(file);\n@@ -568,7 +568,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)\n finish:\n \tif (write_locked_index(&the_index, &lock_file,\n \t\t\t COMMIT_LOCK | SKIP_IF_UNCHANGED))\n-\t\tdie(_(\"Unable to write new index file\"));\n+\t\tdie(_(\"unable to write new index file\"));\n \n \tdir_clear(&dir);\n \tclear_pathspec(&pathspec);\n-- \n2.36.1.windows.1\n\n"},{"id":"482843","messageId":"CAP8UFD35DBBwQ1Mgc+NGVoh1ReLncAz9OJF3Yj++FFrESw8rtw@mail.gmail.com","threadId":"60329","inReplyTo":"20231009011652.1791-1-naomi.ibeh69@gmail.com","subject":"Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2023-10-09T07:27:49Z","receivedAt":"2023-10-09T07:28:12Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Mon, Oct 9, 2023 at 3:17 AM Naomi Ibe wrote:\n>\n> From: Naomi \n\nFirst the subject should start, after \"[PATCH 1/1][Outreachy]\", with\nthe area of the code you are changing followed by \":\", so here \"add:\"\n(no need for \".c\").\n\nAlso even if the subject gives a lot of information already, it's\nbetter to use the body of the commit message to give a bit more\ncontext and details. For example here either the subject or the body\nof the commit message should say which specific guideline(s) the patch\nis enforcing.\n\n> Signed-off-by: Naomi Ibe \n> ---\n> builtin/add.c | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n\nOtherwise the patch looks good to me.\n\nThanks!\n"},{"id":"482846","messageId":"CACS=G2zcU+o6av=CQy7WAG7DZmNEERcPqB_W3Cmub4w25V3K4g@mail.gmail.com","threadId":"60329","inReplyTo":"CAP8UFD35DBBwQ1Mgc+NGVoh1ReLncAz9OJF3Yj++FFrESw8rtw@mail.gmail.com","subject":"Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635","fromName":"Naomi Ibe","fromEmail":"naomi.ibeh69@gmail.com","sentAt":"2023-10-09T07:57:11Z","receivedAt":"2023-10-09T07:57:26Z","isPatch":true,"sender":{"key":"naomi.ibeh69@gmail.com","avatar":"https://avatars.githubusercontent.com/u/104323769?v=4"},"body":"Thank you very much for the feedback Christian, I'd definitely keep\nthis in mind the next time I'm creating/sending a patch.\nYou also said asides working on my commit message, the patch looks\ngood, but as I'm applying to Outreachy, I need to send in my proof of\ncontribution as a link of a task I worked on.\nWould sending a link of the mailing list , with the url of this patch\nI just worked on suffice?Something like this :\nhttps://public-inbox.org/git/20231009011652.1791-1-naomi.ibeh69@gmail.com/T/#u\nI ask because since I used patches to send to Git , I have no pull\nrequest link to submit.\n\nOn Mon, Oct 9, 2023 at 8:28 AM Christian Couder\n wrote:\n>\n> On Mon, Oct 9, 2023 at 3:17 AM Naomi Ibe wrote:\n> >\n> > From: Naomi \n>\n> First the subject should start, after \"[PATCH 1/1][Outreachy]\", with\n> the area of the code you are changing followed by \":\", so here \"add:\"\n> (no need for \".c\").\n>\n> Also even if the subject gives a lot of information already, it's\n> better to use the body of the commit message to give a bit more\n> context and details. For example here either the subject or the body\n> of the commit message should say which specific guideline(s) the patch\n> is enforcing.\n>\n> > Signed-off-by: Naomi Ibe \n> > ---\n> > builtin/add.c | 10 +++++-----\n> > 1 file changed, 5 insertions(+), 5 deletions(-)\n> >\n>\n> Otherwise the patch looks good to me.\n>\n> Thanks!\n"},{"id":"482849","messageId":"CAP8UFD2hCPh2cVZ_xUeJU0OLw9RzJwGiT9TperzRyYwcw4uvPQ@mail.gmail.com","threadId":"60329","inReplyTo":"CACS=G2zcU+o6av=CQy7WAG7DZmNEERcPqB_W3Cmub4w25V3K4g@mail.gmail.com","subject":"Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2023-10-09T08:22:53Z","receivedAt":"2023-10-09T08:23:11Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Mon, Oct 9, 2023 at 9:57 AM Naomi Ibe wrote:\n>\n> Thank you very much for the feedback Christian, I'd definitely keep\n> this in mind the next time I'm creating/sending a patch.\n\nGreat!\n\n> You also said asides working on my commit message, the patch looks\n> good,\n\nYeah, but first others might find some issues in the patch itself,\nalso, as I say elsewhere, I think it's worth it for you to send a\nversion 2 of the patch that fixes the commit message issues I pointed\nout.\n\n> but as I'm applying to Outreachy, I need to send in my proof of\n> contribution as a link of a task I worked on.\n> Would sending a link of the mailing list , with the url of this patch\n> I just worked on suffice?Something like this :\n> https://public-inbox.org/git/20231009011652.1791-1-naomi.ibeh69@gmail.com/T/#u\n> I ask because since I used patches to send to Git , I have no pull\n> request link to submit.\n\nYeah, links to the emails you sent in a mailing list archive (Public\nInbox or lore.kernel.org/git) are fine.\n"}]}