{"thread":{"id":"60237","subject":"What's cooking in git.git (Sep 2023, #05; Fri, 15)","startedAt":"2023-09-16T01:42:02Z","lastAt":"2023-09-25T23:06:26Z","messageCount":10,"participants":["Junio C Hamano","Taylor Blau","Linus Arver","SZEDER Gábor"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"481900","messageId":"xmqqmsxmdhdw.fsf@gitster.g","threadId":"60237","inReplyTo":null,"subject":"What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-09-16T01:41:15Z","receivedAt":"2023-09-16T01:42:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking in my tree. Commits\nprefixed with '+' are in 'next' (being in 'next' is a sign that a\ntopic is stable enough to be used and are candidate to be in a\nfuture release). Commits prefixed with '-' are only in 'seen', and\naren't considered \"accepted\" at all and may be annotated with an URL\nto a message that raises issues but they are no means exhaustive. A\ntopic without enough support may be discarded after a long period of\nno activity (of course they can be resubmit when new interests\narise).\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into or their mirrors. Some\nrepositories have only a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://github.com/git/git/\n\thttps://gitlab.com/git-vcs/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/gitster/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are published in these repositories for\nconvenience (replace \"htmldocs\" with \"manpages\" for the manual\npages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\nRelease tarballs are available at:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[Graduated to 'master']\n\n* ak/pretty-decorate-more (2023-08-21) 8 commits\n (merged to 'next' on 2023-09-07 at 6f5e14cef2)\n + decorate: use commit color for HEAD arrow\n + pretty: add pointer and tag options to %(decorate)\n + pretty: add %(decorate[:]) format\n + decorate: color each token separately\n + decorate: avoid some unnecessary color overhead\n + decorate: refactor format_decorations()\n + pretty-formats: enclose options in angle brackets\n + pretty-formats: define \"literal formatting code\"\n\n \"git log --format\" has been taught the %(decorate) placeholder.\n source: <20230820185009.20095-1-andy.koppe@gmail.com>\n\n\n* bc/more-git-var (2023-09-05) 1 commit\n (merged to 'next' on 2023-09-06 at d8af32874c)\n + var: avoid a segmentation fault when `HOME` is unset\n\n Fix-up for a topic that already has graduated.\n source: \n\n\n* ew/hash-with-openssl-evp (2023-08-31) 1 commit\n (merged to 'next' on 2023-09-05 at 1ddc0078c8)\n + treewide: fix various bugs w/ OpenSSL 3+ EVP API\n\n Fix-up new-ish code to support OpenSSL EVP API.\n source: <20230901020928.M610756@dcvr>\n\n\n* jk/tree-name-and-depth-limit (2023-08-31) 10 commits\n (merged to 'next' on 2023-09-07 at 7ad767ab0d)\n + lower core.maxTreeDepth default to 2048\n + tree-diff: respect max_allowed_tree_depth\n + list-objects: respect max_allowed_tree_depth\n + read_tree(): respect max_allowed_tree_depth\n + traverse_trees(): respect max_allowed_tree_depth\n + add core.maxTreeDepth config\n + fsck: detect very large tree pathnames\n + tree-walk: rename \"error\" variable\n + tree-walk: drop MAX_TRAVERSE_TREES macro\n + tree-walk: reduce stack size for recursive functions\n\n We now limit depth of the tree objects and maximum length of\n pathnames recorded in tree objects.\n source: <20230831061735.GA2702156@coredump.intra.peff.net>\n\n\n* jk/unused-post-2.42-part2 (2023-09-05) 10 commits\n (merged to 'next' on 2023-09-05 at 308ca3a052)\n + parse-options: mark unused parameters in noop callback\n + interpret-trailers: mark unused \"unset\" parameters in option callbacks\n + parse-options: add more BUG_ON() annotations\n + merge: do not pass unused opt->value parameter\n + parse-options: mark unused \"opt\" parameter in callbacks\n + parse-options: prefer opt->value to globals in callbacks\n + checkout-index: delay automatic setting of to_tempfile\n + format-patch: use OPT_STRING_LIST for to/cc options\n + merge: simplify parsing of \"-n\" option\n + merge: make xopts a strvec\n\n Unused parameters to functions are marked as such, and/or removed,\n in order to bring us closer to -Wunused-parameter clean.\n source: <20230831211637.GA949188@coredump.intra.peff.net>\n\n\n* ks/ref-filter-sort-numerically (2023-09-05) 1 commit\n (merged to 'next' on 2023-09-06 at aa4d156366)\n + ref-filter: sort numerically when \":size\" is used\n\n \"git for-each-ref --sort='contents:size'\" sorts the refs according\n to size numerically, giving a ref that points at a blob twelve-byte\n (12) long before showing a blob hundred-byte (100) long.\n source: <20230902090155.8978-1-five231003@gmail.com>\n\n\n* ob/revert-of-revert-is-reapply (2023-09-02) 2 commits\n (merged to 'next' on 2023-09-07 at 9a54f66511)\n + git-revert.txt: add discussion\n + sequencer: beautify subject of reverts of reverts\n\n The default log message created by \"git revert\", when reverting a\n commit that records a revert, has been tweaked.\n source: <20230821170720.577850-1-oswald.buddenhagen@gmx.de>\n source: <20230902072035.652549-1-oswald.buddenhagen@gmx.de>\n\n\n* ob/sequencer-reword-error-message (2023-09-05) 1 commit\n (merged to 'next' on 2023-09-06 at c5154b7aa2)\n + sequencer: fix error message on failure to copy SQUASH_MSG\n\n Update an error message (which would probably never been seen).\n source: <20230903151132.739136-1-oswald.buddenhagen@gmx.de>\n\n\n* pw/rebase-i-after-failure (2023-09-06) 7 commits\n (merged to 'next' on 2023-09-07 at 3cbc3c4d63)\n + rebase -i: fix adding failed command to the todo list\n + rebase --continue: refuse to commit after failed command\n + rebase: fix rewritten list for failed pick\n + sequencer: factor out part of pick_commits()\n + sequencer: use rebase_path_message()\n + rebase -i: remove patch file after conflict resolution\n + rebase -i: move unlink() calls\n\n Various fixes to the behaviour of \"rebase -i\" when the command got\n interrupted by conflicting changes.\n cf. <6b927687-cf6e-d73e-78fb-bd4f46736928@gmx.de>\n source: \n\n\n* rs/grep-parseopt-simplify (2023-09-05) 1 commit\n (merged to 'next' on 2023-09-06 at 249b69cfd2)\n + grep: use OPT_INTEGER_F for --max-depth\n\n Simplify use of parse-options API a bit.\n source: <4d2eb736-4f34-18f8-2eb7-20e7f7b8c2f8@web.de>\n\n\n* rs/name-rev-use-opt-hidden-bool (2023-09-05) 1 commit\n (merged to 'next' on 2023-09-06 at 9b251a5392)\n + name-rev: use OPT_HIDDEN_BOOL for --peel-tag\n\n Simplify use of parse-options API a bit.\n source: <5a86c8f8-fcdc-fee9-8af5-aa5ecb036d2e@web.de>\n\n\n* so/diff-doc-for-patch-update (2023-09-06) 1 commit\n (merged to 'next' on 2023-09-07 at 6da5e9defd)\n + doc/diff-options: fix link to generating patch section\n\n References from description of the `--patch` option in various\n manual pages have been simplified and improved.\n source: <87msxzpybo.fsf_-_@osv.gnss.ru>\n\n--------------------------------------------------\n[New Topics]\n\n* ob/sequencer-remove-dead-code (2023-09-12) 1 commit\n (merged to 'next' on 2023-09-13 at 1f6c2b336b)\n + sequencer: remove unreachable exit condition in pick_commits()\n\n Code clean-up.\n\n Will merge to 'master'.\n source: <20230912105541.272917-1-oswald.buddenhagen@gmx.de>\n\n\n* ob/t3404-typofix (2023-09-12) 1 commit\n (merged to 'next' on 2023-09-13 at b17fa78c3f)\n + t3404-rebase-interactive.sh: fix typos in title of a rewording test\n\n Code clean-up.\n\n Will merge to 'master'.\n source: <20230912104237.271616-1-oswald.buddenhagen@gmx.de>\n\n\n* jk/ort-unused-parameter-cleanups (2023-09-14) 4 commits\n - merge-ort: drop unused \"opt\" parameter from merge_check_renames_reusable()\n - merge-ort: drop unused parameters from detect_and_process_renames()\n - merge-ort: stop passing \"opt\" to read_oid_strbuf()\n - merge-ort: drop custom err() function\n\n Code clean-up.\n\n Needs review.\n source: <20230914093409.GA2254811@coredump.intra.peff.net>\n\n\n* jc/fake-lstat (2023-09-14) 1 commit\n - cache: add fake_lstat()\n\n A new helper to let us pretend that we called lstat() when we know\n our cache_entry is up-to-date via fsmonitor.\n\n Needs review.\n source: \n\n\n* jk/redact-h2h3-headers-fix (2023-09-15) 2 commits\n - http: update curl http/2 info matching for curl 8.3.0\n - http: factor out matching of curl http/2 trace lines\n\n HTTP Header redaction code has been adjusted for a newer version of\n cURL library that shows its traces differently from earlier\n versions.\n\n Will merge to 'next'.\n source: <20230915113237.GA3531328@coredump.intra.peff.net>\n\n\n* ch/clean-docfix (2023-09-15) 1 commit\n - git-clean doc: fix \"without do cleaning\" typo\n\n Typofix.\n\n Will merge to 'next'.\n source: \n\n\n* eg/config-type-path-docfix (2023-09-15) 1 commit\n - git-config: fix misworded --type=path explanation\n\n Typofix.\n\n Will merge to 'next'.\n source: <20230915202610.21206-1-evan.gates@gmail.com>\n\n\n* kn/rev-list-ignore-missing-links (2023-09-15) 1 commit\n - revision: add `--ignore-missing-links` user option\n\n Surface the .ignore_missing_links bit that stops the revision\n traversal from stopping and dying when encountering a missing\n object to a new command line option of \"git rev-list\", so that the\n objects that are required but are missing can be enumerated.\n\n Waiting for review response.\n source: <20230915083415.263187-1-knayak@gitlab.com>\n\n--------------------------------------------------\n[Stalled]\n\n* tk/cherry-pick-sequence-requires-clean-worktree (2023-06-01) 1 commit\n - cherry-pick: refuse cherry-pick sequence if index is dirty\n\n \"git cherry-pick A\" that replays a single commit stopped before\n clobbering local modification, but \"git cherry-pick A..B\" did not,\n which has been corrected.\n\n Expecting a reroll.\n cf. <999f12b2-38d6-f446-e763-4985116ad37d@gmail.com>\n source: \n\n--------------------------------------------------\n[Cooking]\n\n* js/systemd-timers-wsl-fix (2023-09-11) 1 commit\n (merged to 'next' on 2023-09-12 at 71c4cbb1df)\n + maintenance(systemd): support the Windows Subsystem for Linux\n\n Update \"git maintainance\" timers' implementation based on systemd\n timers to work with WSL.\n\n Will merge to 'master'.\n source: \n\n\n* kh/range-diff-notes (2023-09-11) 1 commit\n - range-diff: treat notes like `log`\n\n \"git range-diff --notes=foo\" compared \"log --notes=foo --notes\" of\n the two ranges, instead of using just the specified notes tree.\n\n Expecting a reroll.\n cf. \n source: \n\n\n* pw/diff-no-index-from-named-pipes (2023-09-11) 1 commit\n (merged to 'next' on 2023-09-12 at 135ecd136f)\n + diff --no-index: fix -R with stdin\n\n \"git diff --no-index -R <(one) <(two)\" did not work correctly,\n which has been corrected.\n\n Will merge to 'master'.\n source: <22fdfa3b-f90e-afcc-667c-705fb7670245@web.de>\n\n\n* rs/parse-options-value-int (2023-09-11) 2 commits\n - parse-options: use and require int pointer for OPT_CMDMODE\n - parse-options: add int value pointer to struct option\n\n A bit of type safety for the \"value\" pointer used in the\n parse-options API.\n\n What's the status of this one?\n source: \n\n\n* so/diff-merges-d (2023-09-11) 2 commits\n - diff-merges: introduce '-d' option\n - diff-merges: improve --diff-merges documentation\n\n Teach a new \"-d\" option that shows the patch against the first\n parent for merge commits (which is \"--diff-merges=first-parent -p\").\n\n Needs more work.\n source: <20230909125446.142715-1-sorganov@gmail.com>\n\n\n* js/diff-cached-fsmonitor-fix (2023-09-11) 1 commit\n (merged to 'next' on 2023-09-12 at 7479278da0)\n + diff-lib: fix check_removed when fsmonitor is on\n\n \"git diff --cached\" codepath did not fill the necessary stat\n information for a file when fsmonitor knows it is clean and ended\n up behaving as if it is not clean, which has been corrected.\n\n Will merge to 'master'.\n source: <20230911170901.49050-2-sokcevic@google.com>\n\n\n* pb/completion-aliases-doc (2023-09-12) 1 commit\n (merged to 'next' on 2023-09-13 at b248a5bc26)\n + completion: improve doc for complex aliases\n\n Clarify how \"alias.foo = : git cmd ; aliased-command-string\" should\n be spelled with necessary whitespaces around punctuation marks to\n work.\n\n Will merge to 'master'.\n source: \n\n\n* cc/repack-sift-filtered-objects-to-separate-pack (2023-09-11) 9 commits\n . gc: add `gc.repackFilterTo` config option\n . repack: implement `--filter-to` for storing filtered out objects\n . gc: add `gc.repackFilter` config option\n . repack: add `--filter=` option\n . pack-bitmap-write: rebuild using new bitmap when remapping\n . repack: refactor finding pack prefix\n . repack: refactor finishing pack-objects command\n . t/helper: add 'find-pack' test-tool\n . pack-objects: allow `--filter` without `--stdout`\n\n \"git repack\" machinery learns to pay attention to the \"--filter=\"\n option.\n\n May need to wait until tb/repack-existing-packs-cleanup stablizes.\n source: <20230911150618.129737-1-christian.couder@gmail.com>\n\n\n* la/trailer-cleanups (2023-09-11) 6 commits\n (merged to 'next' on 2023-09-12 at 779c4a097a)\n + trailer: use offsets for trailer_start/trailer_end\n + trailer: rename *_DEFAULT enums to *_UNSPECIFIED\n + trailer: teach find_patch_start about --no-divider\n + trailer: split process_command_line_args into separate functions\n + trailer: split process_input_file into separate pieces\n + trailer: separate public from internal portion of trailer_iterator\n\n Code clean-up.\n\n Will merge to 'master'.\n source: \n\n\n* tb/repack-existing-packs-cleanup (2023-09-13) 8 commits\n (merged to 'next' on 2023-09-14 at bb8065e89c)\n + builtin/repack.c: extract common cruft pack loop\n + builtin/repack.c: avoid directly inspecting \"util\"\n + builtin/repack.c: store existing cruft packs separately\n + builtin/repack.c: extract `has_existing_non_kept_packs()`\n + builtin/repack.c: extract redundant pack cleanup for existing packs\n + builtin/repack.c: extract redundant pack cleanup for --geometric\n + builtin/repack.c: extract marking packs for deletion\n + builtin/repack.c: extract structure to store existing packs\n\n The code to keep track of existing packs in the repository while\n repacking has been refactored.\n\n Will merge to 'master'.\n source: \n\n\n* pb/complete-commit-trailers (2023-09-12) 2 commits\n (merged to 'next' on 2023-09-13 at 9a0ec17606)\n + completion: commit: complete trailers tokens more robustly\n (merged to 'next' on 2023-09-08 at 842587016d)\n + completion: commit: complete configured trailer tokens\n\n The command-line complation support (in contrib/) learned to\n complete \"git commit --trailer=\" for possible trailer keys.\n\n Will merge to 'master'.\n source: \n\n\n* pw/rebase-sigint (2023-09-07) 1 commit\n - rebase -i: ignore signals when forking subprocesses\n\n If the commit log editor or other external programs (spawned via\n \"exec\" insn in the todo list) receive internactive signal during\n \"git rebase -i\", it caused not just the spawned program but the\n \"Git\" process that spawned them, which is often not what the end\n user intended. \"git\" learned to ignore SIGINT and SIGQUIT while\n waiting for these subprocesses.\n\n Expecting a reroll.\n cf. <12c956ea-330d-4441-937f-7885ab519e26@gmail.com>\n source: \n\n\n* rs/grep-no-no-or (2023-09-07) 1 commit\n (merged to 'next' on 2023-09-08 at 33849032bc)\n + grep: reject --no-or\n\n \"git grep -e A --no-or -e B\" is accepted, even though the negation\n of \"or\" did not mean anything, which has been tightened.\n\n Will merge to 'master'.\n source: <6aeb0ebe-0fea-ccd3-089a-ee0b5b5baf10@web.de>\n\n\n* js/complete-checkout-t (2023-09-08) 1 commit\n (merged to 'next' on 2023-09-08 at 461bb28fbd)\n + completion(switch/checkout): treat --track and -t the same\n\n The completion script (in contrib/) has been taught to treat the\n \"-t\" option to \"git checkout\" and \"git switch\" just like the\n \"--track\" option, to complete remote-tracking branches.\n\n Will merge to 'master'.\n source: \n\n\n* cw/git-std-lib (2023-09-11) 7 commits\n - SQUASH???\n - git-std-lib: add test file to call git-std-lib.a functions\n - git-std-lib: introduce git standard library\n - parse: create new library for parsing strings and env values\n - config: correct bad boolean env value error message\n - wrapper: remove dependency to Git-specific internal file\n - hex-ll: split out functionality from hex\n\n Another libification effort.\n\n Needs more work.\n cf. \n cf. <20230915183927.1597414-1-jonathantanmy@google.com>\n source: <20230908174134.1026823-1-calvinwan@google.com>\n\n\n* cc/git-replay (2023-09-07) 15 commits\n - replay: stop assuming replayed branches do not diverge\n - replay: add --contained to rebase contained branches\n - replay: add --advance or 'cherry-pick' mode\n - replay: disallow revision specific options and pathspecs\n - replay: use standard revision ranges\n - replay: make it a minimal server side command\n - replay: remove HEAD related sanity check\n - replay: remove progress and info output\n - replay: add an important FIXME comment about gpg signing\n - replay: don't simplify history\n - replay: introduce pick_regular_commit()\n - replay: die() instead of failing assert()\n - replay: start using parse_options API\n - replay: introduce new builtin\n - t6429: remove switching aspects of fast-rebase\n\n Waiting for review response.\n cf. <52277471-4ddd-b2e0-62ca-c2a5b59ae418@gmx.de>\n cf. <58daa706-7efb-51dd-9061-202ef650b96a@gmx.de>\n cf. \n May want to wait until tb/repack-existing-packs-cleanup stabilizes.\n source: <20230907092521.733746-1-christian.couder@gmail.com>\n\n\n* la/trailer-test-and-doc-updates (2023-09-07) 13 commits\n - trailer doc: is a or , not both\n - trailer doc: separator within key suppresses default separator\n - trailer doc: emphasize the effect of configuration variables\n - trailer --unfold help: prefer \"reformat\" over \"join\"\n - trailer --parse docs: add explanation for its usefulness\n - trailer --only-input: prefer \"configuration variables\" over \"rules\"\n - trailer --parse help: expose aliased options\n - trailer --no-divider help: describe usual \"---\" meaning\n - trailer: trailer location is a place, not an action\n - trailer doc: narrow down scope of --where and related flags\n - trailer: add tests to check defaulting behavior with --no-* flags\n - trailer test description: this tests --where=after, not --where=before\n - trailer tests: make test cases self-contained\n\n Test coverage for trailers has been improved.\n source: \n\n\n* js/doc-unit-tests (2023-08-17) 3 commits\n - ci: run unit tests in CI\n - unit tests: add TAP unit test framework\n - unit tests: Add a project plan document\n (this branch is used by js/doc-unit-tests-with-cmake.)\n\n Process to add some form of low-level unit tests has started.\n\n Waiting for review response.\n cf. \n source: \n\n\n* js/doc-unit-tests-with-cmake (2023-08-31) 4 commits\n - artifacts-tar: when including `.dll` files, don't forget the unit-tests\n - unit-tests: do show relative file paths\n - unit-tests: do not mistake `.pdb` files for being executable\n - cmake: also build unit tests\n (this branch uses js/doc-unit-tests.)\n\n Update the base topic to work with CMake builds.\n\n Waiting for the base topic to settle.\n source: \n\n\n* tb/path-filter-fix (2023-08-30) 15 commits\n - bloom: introduce `deinit_bloom_filters()`\n - commit-graph: reuse existing Bloom filters where possible\n - object.h: fix mis-aligned flag bits table\n - commit-graph: drop unnecessary `graph_read_bloom_data_context`\n - commit-graph.c: unconditionally load Bloom filters\n - t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()`\n - bloom: prepare to discard incompatible Bloom filters\n - bloom: annotate filters with hash version\n - commit-graph: new filter ver. that fixes murmur3\n - repo-settings: introduce commitgraph.changedPathsVersion\n - t4216: test changed path filters with high bit paths\n - t/helper/test-read-graph: implement `bloom-filters` mode\n - bloom.h: make `load_bloom_filter_from_graph()` public\n - t/helper/test-read-graph.c: extract `dump_graph_info()`\n - gitformat-commit-graph: describe version 2 of BDAT\n\n The Bloom filter used for path limited history traversal was broken\n on systems whose \"char\" is unsigned; update the implementation and\n bump the format version to 2.\n\n Needs more work.\n cf. <20230830200218.GA5147@szeder.dev>\n source: \n\n\n* js/config-parse (2023-08-23) 4 commits\n - config-parse: split library out of config.[c|h]\n - config.c: accept config_parse_options in git_config_from_stdin\n - config: report config parse errors using cb\n - config: split out config_parse_options\n\n The parsing routines for the configuration files have been split\n into a separate file.\n\n Needs review.\n source: \n\n\n* jc/update-index-show-index-version (2023-09-12) 3 commits\n (merged to 'next' on 2023-09-13 at b754554df8)\n + test-tool: retire \"index-version\"\n + update-index: add --show-index-version\n + update-index doc: v4 is OK with JGit and libgit2\n\n \"git update-index\" learns \"--show-index-version\" to inspect\n the index format version used by the on-disk index file.\n\n Will merge to 'master'.\n source: <20230912193235.776292-1-gitster@pobox.com>\n\n\n* jc/rerere-cleanup (2023-08-25) 4 commits\n - rerere: modernize use of empty strbuf\n - rerere: try_merge() should use LL_MERGE_ERROR when it means an error\n - rerere: fix comment on handle_file() helper\n - rerere: simplify check_one_conflict() helper function\n (this branch uses jc/unresolve-removal.)\n\n Code clean-up.\n\n Not ready to be reviewed yet.\n source: <20230731224409.4181277-1-gitster@pobox.com>\n\n\n* jc/unresolve-removal (2023-07-31) 7 commits\n - checkout: allow \"checkout -m path\" to unmerge removed paths\n - checkout/restore: add basic tests for --merge\n - checkout/restore: refuse unmerging paths unless checking out of the index\n - update-index: remove stale fallback code for \"--unresolve\"\n - update-index: use unmerge_index_entry() to support removal\n - resolve-undo: allow resurrecting conflicted state that resolved to deletion\n - update-index: do not read HEAD and MERGE_HEAD unconditionally\n (this branch is used by jc/rerere-cleanup.)\n\n \"checkout --merge -- path\" and \"update-index --unresolve path\" did\n not resurrect conflicted state that was resolved to remove path,\n but now they do.\n\n Needs review.\n source: <20230731224409.4181277-1-gitster@pobox.com>\n\n\n* rj/status-bisect-while-rebase (2023-08-01) 1 commit\n - status: fix branch shown when not only bisecting\n\n \"git status\" is taught to show both the branch being bisected and\n being rebased when both are in effect at the same time.\n\n Needs review.\n cf. \n source: <48745298-f12b-8efb-4e48-90d2c22a8349@gmail.com>\n"},{"id":"482026","messageId":"ZQnpIBR4hEbOLCwP@nand.local","threadId":"60237","inReplyTo":"xmqqmsxmdhdw.fsf@gitster.g","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-09-19T18:32:00Z","receivedAt":"2023-09-19T18:32:07Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Fri, Sep 15, 2023 at 06:41:15PM -0700, Junio C Hamano wrote:\n> * tb/repack-existing-packs-cleanup (2023-09-13) 8 commits\n> (merged to 'next' on 2023-09-14 at bb8065e89c)\n> + builtin/repack.c: extract common cruft pack loop\n> + builtin/repack.c: avoid directly inspecting \"util\"\n> + builtin/repack.c: store existing cruft packs separately\n> + builtin/repack.c: extract `has_existing_non_kept_packs()`\n> + builtin/repack.c: extract redundant pack cleanup for existing packs\n> + builtin/repack.c: extract redundant pack cleanup for --geometric\n> + builtin/repack.c: extract marking packs for deletion\n> + builtin/repack.c: extract structure to store existing packs\n>\n> The code to keep track of existing packs in the repository while\n> repacking has been refactored.\n>\n> Will merge to 'master'.\n> source: \n\nNice, I'm happy to see that this is moving along. Thanks, everybody, for\nparticipating in the review :-). It's very nice to have a second set of\neyes when touching the repack machinery.\n\n> * cc/repack-sift-filtered-objects-to-separate-pack (2023-09-11) 9 commits\n> . gc: add `gc.repackFilterTo` config option\n> . repack: implement `--filter-to` for storing filtered out objects\n> . gc: add `gc.repackFilter` config option\n> . repack: add `--filter=` option\n> . pack-bitmap-write: rebuild using new bitmap when remapping\n> . repack: refactor finding pack prefix\n> . repack: refactor finishing pack-objects command\n> . t/helper: add 'find-pack' test-tool\n> . pack-objects: allow `--filter` without `--stdout`\n>\n> \"git repack\" machinery learns to pay attention to the \"--filter=\"\n> option.\n>\n> May need to wait until tb/repack-existing-packs-cleanup stablizes.\n> source: <20230911150618.129737-1-christian.couder@gmail.com>\n\nI sent Christian a draft of what I think the conflict resolution should\nlook like when rebasing on top of tb/repack-existing-packs-cleanup [1].\n\nI've looked over all but one of the previous rounds, and have seen the\nmost recent round and am happy with the result. So I think that this\ncould go in relatively quickly following merging the above.\n\nI have a couple of other repacking-related topics that are in my queue,\nbut I've been holding off on sending them until Christian's series has\nstabilized. They are:\n\n - tb/cruft-max-size (git@github.com:ttaylorr/git.git)\n - tb/cruft-preferred-inference (git@github.com:ttaylorr/git.git)\n\nThe former is on the list at [2], and needs a bit of work before\nqueueing again. The latter isn't on the list, but fixes a performance\nbug where it is possible in rare circumstances to select the cruft pack\nas preferred when generating a MIDX bitmap during repacking.\n\nThe second isn't crucial to get in any time soon, but I would love to\nget it off of my queue before we start cutting pre-releases. At this\nrate, I doubt it will be a problem.\n\n[1]: https://lore.kernel.org/git/ZQNKkn0YYLUyN5Ih@nand.local/\n[2]: https://lore.kernel.org/git/cover.1694123506.git.me@ttaylorr.com/\n\n> * tb/path-filter-fix (2023-08-30) 15 commits\n> - bloom: introduce `deinit_bloom_filters()`\n> - commit-graph: reuse existing Bloom filters where possible\n> - object.h: fix mis-aligned flag bits table\n> - commit-graph: drop unnecessary `graph_read_bloom_data_context`\n> - commit-graph.c: unconditionally load Bloom filters\n> - t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()`\n> - bloom: prepare to discard incompatible Bloom filters\n> - bloom: annotate filters with hash version\n> - commit-graph: new filter ver. that fixes murmur3\n> - repo-settings: introduce commitgraph.changedPathsVersion\n> - t4216: test changed path filters with high bit paths\n> - t/helper/test-read-graph: implement `bloom-filters` mode\n> - bloom.h: make `load_bloom_filter_from_graph()` public\n> - t/helper/test-read-graph.c: extract `dump_graph_info()`\n> - gitformat-commit-graph: describe version 2 of BDAT\n>\n> The Bloom filter used for path limited history traversal was broken\n> on systems whose \"char\" is unsigned; update the implementation and\n> bump the format version to 2.\n>\n> Needs more work.\n> cf. <20230830200218.GA5147@szeder.dev>\n> source: \n\nI think that Jonathan's most recent round of this is ready to get merged\nup, cf. [3]. The outstanding issue you note in\n<20230830200218.GA5147@szeder.dev> can be addressed separately, I\nbelieve. To that end, I have a RFC-level patch proposed here [4].\n\n[3]: https://lore.kernel.org/git/xmqqo7io8gmo.fsf@gitster.g/\n[4]: https://lore.kernel.org/git/ZQnmTXUO94%2FQy8mq@nand.local/\n\nThanks,\nTaylor\n"},{"id":"482033","messageId":"owly7comj5ll.fsf@fine.c.googlers.com","threadId":"60237","inReplyTo":"xmqqmsxmdhdw.fsf@gitster.g","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Linus Arver","fromEmail":"linusa@google.com","sentAt":"2023-09-19T20:00:38Z","receivedAt":"2023-09-19T20:00:47Z","isPatch":false,"sender":{"key":"linus@ucla.edu","avatar":null},"body":"Junio C Hamano writes:\n\n> [Cooking]\n>\n> [...]\n>\n> * la/trailer-cleanups (2023-09-11) 6 commits\n> (merged to 'next' on 2023-09-12 at 779c4a097a)\n> + trailer: use offsets for trailer_start/trailer_end\n> + trailer: rename *_DEFAULT enums to *_UNSPECIFIED\n> + trailer: teach find_patch_start about --no-divider\n> + trailer: split process_command_line_args into separate functions\n> + trailer: split process_input_file into separate pieces\n> + trailer: separate public from internal portion of trailer_iterator\n>\n> Code clean-up.\n>\n> Will merge to 'master'.\n> source: \n\nThis isn't ready yet (still need to reroll).\n\n> [...]\n>\n> * la/trailer-test-and-doc-updates (2023-09-07) 13 commits\n> - trailer doc: is a or , not both\n> - trailer doc: separator within key suppresses default separator\n> - trailer doc: emphasize the effect of configuration variables\n> - trailer --unfold help: prefer \"reformat\" over \"join\"\n> - trailer --parse docs: add explanation for its usefulness\n> - trailer --only-input: prefer \"configuration variables\" over \"rules\"\n> - trailer --parse help: expose aliased options\n> - trailer --no-divider help: describe usual \"---\" meaning\n> - trailer: trailer location is a place, not an action\n> - trailer doc: narrow down scope of --where and related flags\n> - trailer: add tests to check defaulting behavior with --no-* flags\n> - trailer test description: this tests --where=after, not --where=before\n> - trailer tests: make test cases self-contained\n>\n> Test coverage for trailers has been improved.\n> source: \n\nDid you forget to add \"Need more reviews\"? Not sure what the status is\nfor the overall series (modulo your targetd comments for some of the\npatches).\n"},{"id":"482034","messageId":"xmqq7colgbpk.fsf@gitster.g","threadId":"60237","inReplyTo":"owly7comj5ll.fsf@fine.c.googlers.com","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-09-19T20:16:55Z","receivedAt":"2023-09-19T20:17:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Arver writes:\n\n> Junio C Hamano writes:\n>\n>> [Cooking]\n>>\n>> [...]\n>>\n>> * la/trailer-cleanups (2023-09-11) 6 commits\n>> (merged to 'next' on 2023-09-12 at 779c4a097a)\n>> + trailer: use offsets for trailer_start/trailer_end\n>> + trailer: rename *_DEFAULT enums to *_UNSPECIFIED\n>> + trailer: teach find_patch_start about --no-divider\n>> + trailer: split process_command_line_args into separate functions\n>> + trailer: split process_input_file into separate pieces\n>> + trailer: separate public from internal portion of trailer_iterator\n>>\n>> Code clean-up.\n>>\n>> Will merge to 'master'.\n>> source: \n>\n> This isn't ready yet (still need to reroll).\n>\n>> [...]\n>>\n>> * la/trailer-test-and-doc-updates (2023-09-07) 13 commits\n>> - trailer doc: is a or , not both\n>> - trailer doc: separator within key suppresses default separator\n>> - trailer doc: emphasize the effect of configuration variables\n>> - trailer --unfold help: prefer \"reformat\" over \"join\"\n>> - trailer --parse docs: add explanation for its usefulness\n>> - trailer --only-input: prefer \"configuration variables\" over \"rules\"\n>> - trailer --parse help: expose aliased options\n>> - trailer --no-divider help: describe usual \"---\" meaning\n>> - trailer: trailer location is a place, not an action\n>> - trailer doc: narrow down scope of --where and related flags\n>> - trailer: add tests to check defaulting behavior with --no-* flags\n>> - trailer test description: this tests --where=after, not --where=before\n>> - trailer tests: make test cases self-contained\n>>\n>> Test coverage for trailers has been improved.\n>> source: \n>\n> Did you forget to add \"Need more reviews\"? Not sure what the status is\n> for the overall series (modulo your targetd comments for some of the\n> patches).\n\nI do not have status comment for this one because I do not know what\nits status is.\n"},{"id":"482037","messageId":"xmqq34z9g8jz.fsf@gitster.g","threadId":"60237","inReplyTo":"owly7comj5ll.fsf@fine.c.googlers.com","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-09-19T21:25:04Z","receivedAt":"2023-09-19T21:25:14Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Arver writes:\n\n> Junio C Hamano writes:\n>\n>> [Cooking]\n>>\n>> [...]\n>>\n>> * la/trailer-cleanups (2023-09-11) 6 commits\n>> (merged to 'next' on 2023-09-12 at 779c4a097a)\n>> + trailer: use offsets for trailer_start/trailer_end\n>> + trailer: rename *_DEFAULT enums to *_UNSPECIFIED\n>> + trailer: teach find_patch_start about --no-divider\n>> + trailer: split process_command_line_args into separate functions\n>> + trailer: split process_input_file into separate pieces\n>> + trailer: separate public from internal portion of trailer_iterator\n>>\n>> Code clean-up.\n>>\n>> Will merge to 'master'.\n>> source: \n>\n> This isn't ready yet (still need to reroll).\n\nWhoa, wait. I wasn't aware of any more comments that needed\naddressing. Whatever improvements you have in mind, if they are\nminor, letting the above graduate (they have been in 'next' for a\nweek without anybody complaining) and doing them as a follow-up\nseries would be sensible, I would think.\n\nThanks.\n"},{"id":"482047","messageId":"owly1qetjqo1.fsf@fine.c.googlers.com","threadId":"60237","inReplyTo":"xmqq34z9g8jz.fsf@gitster.g","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Linus Arver","fromEmail":"linusa@google.com","sentAt":"2023-09-20T06:37:50Z","receivedAt":"2023-09-20T06:37:58Z","isPatch":false,"sender":{"key":"linus@ucla.edu","avatar":null},"body":"Junio C Hamano writes:\n\n> Linus Arver writes:\n>\n>> Junio C Hamano writes:\n>>\n>>> [Cooking]\n>>>\n>>> [...]\n>>>\n>>> * la/trailer-cleanups (2023-09-11) 6 commits\n>>> (merged to 'next' on 2023-09-12 at 779c4a097a)\n>>> + trailer: use offsets for trailer_start/trailer_end\n>>> + trailer: rename *_DEFAULT enums to *_UNSPECIFIED\n>>> + trailer: teach find_patch_start about --no-divider\n>>> + trailer: split process_command_line_args into separate functions\n>>> + trailer: split process_input_file into separate pieces\n>>> + trailer: separate public from internal portion of trailer_iterator\n>>>\n>>> Code clean-up.\n>>>\n>>> Will merge to 'master'.\n>>> source: \n>>\n>> This isn't ready yet (still need to reroll).\n>\n> Whoa, wait. I wasn't aware of any more comments that needed\n> addressing.\n\nPerhaps you missed my comment [1]?\n\n> Whatever improvements you have in mind, if they are\n> minor, letting the above graduate (they have been in 'next' for a\n> week without anybody complaining) and doing them as a follow-up\n> series would be sensible, I would think.\n>\n> Thanks.\n\nHmm, I don't think they are minor? See\nhttps://github.com/listx/git/tree/trailer-libification-prep for the\ncurrent state of things.\n\nI need to still follow up to your last comment on \"trailer: rename\n*_DEFAULT enums to *_UNSPECIFIED\" [2] (I was going to see if we needed\nthe \"obvious solution\" as you described).\n\nIf it's too painful to move this out of 'next' now, I'm OK with it\ngraduating as is and doing a separate follow-up (I expect several more\nof these to happen anyway). Up to you.\n\nSorry for not noticing that this was in 'next' sooner and communicating\naccordingly.\n\n[1] https://lore.kernel.org/git/pull.1563.git.1691211879.gitgitgadget@gmail.com/T/#m0131f9829c35d8e0103ffa88f07d8e0e43dd732c\n[2] https://lore.kernel.org/git/pull.1563.git.1691211879.gitgitgadget@gmail.com/T/#md4ff2235720e921a2e031665f4da054d82edd506 \n"},{"id":"482067","messageId":"xmqqjzskdh9t.fsf@gitster.g","threadId":"60237","inReplyTo":"owly1qetjqo1.fsf@fine.c.googlers.com","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-09-20T14:57:18Z","receivedAt":"2023-09-20T14:57:26Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Arver writes:\n\n>> Whatever improvements you have in mind, if they are\n>> minor, letting the above graduate (they have been in 'next' for a\n>> week without anybody complaining) and doing them as a follow-up\n>> series would be sensible, I would think.\n>>\n>> Thanks.\n>\n> Hmm, I don't think they are minor? See\n> https://github.com/listx/git/tree/trailer-libification-prep for the\n> current state of things.\n\nThey do not look like \"oops the patches I sent to the list was\ntotally bogus and they need replacing\"; aren't they rather \"these\nare not yet complete and there are some of the follow-on work on top\nof them\"?\n\n> I need to still follow up to your last comment on \"trailer: rename\n> *_DEFAULT enums to *_UNSPECIFIED\" [2] (I was going to see if we needed\n> the \"obvious solution\" as you described).\n>\n> If it's too painful to move this out of 'next' now, I'm OK with it\n> graduating as is and doing a separate follow-up (I expect several more\n> of these to happen anyway). Up to you.\n\nLet's mark the topic as \"waiting for follow-up updates\" and keep it\nin 'next' until the follow-up patches become ready, then.\n\n> Sorry for not noticing that this was in 'next' sooner and communicating\n> accordingly.\n\nGotchas happen. Let's try to communicate better the next time.\n\nThanks.\n"},{"id":"482085","messageId":"owlyv8c4irci.fsf@fine.c.googlers.com","threadId":"60237","inReplyTo":"xmqqjzskdh9t.fsf@gitster.g","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Linus Arver","fromEmail":"linusa@google.com","sentAt":"2023-09-20T19:20:45Z","receivedAt":"2023-09-20T19:20:50Z","isPatch":false,"sender":{"key":"linus@ucla.edu","avatar":null},"body":"Junio C Hamano writes:\n\n> Linus Arver writes:\n>\n>>> Whatever improvements you have in mind, if they are\n>>> minor, letting the above graduate (they have been in 'next' for a\n>>> week without anybody complaining) and doing them as a follow-up\n>>> series would be sensible, I would think.\n>>>\n>>> Thanks.\n>>\n>> Hmm, I don't think they are minor? See\n>> https://github.com/listx/git/tree/trailer-libification-prep for the\n>> current state of things.\n>\n> They do not look like \"oops the patches I sent to the list was\n> totally bogus and they need replacing\"; aren't they rather \"these\n> are not yet complete and there are some of the follow-on work on top\n> of them\"?\n\nYes, precisely.\n\n>> I need to still follow up to your last comment on \"trailer: rename\n>> *_DEFAULT enums to *_UNSPECIFIED\" [2] (I was going to see if we needed\n>> the \"obvious solution\" as you described).\n>>\n>> If it's too painful to move this out of 'next' now, I'm OK with it\n>> graduating as is and doing a separate follow-up (I expect several more\n>> of these to happen anyway). Up to you.\n>\n> Let's mark the topic as \"waiting for follow-up updates\" and keep it\n> in 'next' until the follow-up patches become ready, then.\n\nSounds good.\n\n>> Sorry for not noticing that this was in 'next' sooner and communicating\n>> accordingly.\n>\n> Gotchas happen. Let's try to communicate better the next time.\n>\n> Thanks.\n\nThanks!\n"},{"id":"482231","messageId":"20230924195900.GA1156862@szeder.dev","threadId":"60237","inReplyTo":"ZQnpIBR4hEbOLCwP@nand.local","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2023-09-24T19:59:00Z","receivedAt":"2023-09-24T19:59:07Z","isPatch":false,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Tue, Sep 19, 2023 at 02:32:00PM -0400, Taylor Blau wrote:\n> > * tb/path-filter-fix (2023-08-30) 15 commits\n> > - bloom: introduce `deinit_bloom_filters()`\n> > - commit-graph: reuse existing Bloom filters where possible\n> > - object.h: fix mis-aligned flag bits table\n> > - commit-graph: drop unnecessary `graph_read_bloom_data_context`\n> > - commit-graph.c: unconditionally load Bloom filters\n> > - t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()`\n> > - bloom: prepare to discard incompatible Bloom filters\n> > - bloom: annotate filters with hash version\n> > - commit-graph: new filter ver. that fixes murmur3\n> > - repo-settings: introduce commitgraph.changedPathsVersion\n> > - t4216: test changed path filters with high bit paths\n> > - t/helper/test-read-graph: implement `bloom-filters` mode\n> > - bloom.h: make `load_bloom_filter_from_graph()` public\n> > - t/helper/test-read-graph.c: extract `dump_graph_info()`\n> > - gitformat-commit-graph: describe version 2 of BDAT\n> >\n> > The Bloom filter used for path limited history traversal was broken\n> > on systems whose \"char\" is unsigned; update the implementation and\n> > bump the format version to 2.\n> >\n> > Needs more work.\n> > cf. <20230830200218.GA5147@szeder.dev>\n> > source: \n> \n> I think that Jonathan's most recent round of this is ready to get merged\n> up, cf. [3]. The outstanding issue you note in\n> <20230830200218.GA5147@szeder.dev> can be addressed separately, I\n> believe. To that end, I have a RFC-level patch proposed here [4].\n\nBesides the issue of not reading Bloom filter for root commits, that\nmessage of mine also includes a test demonstrating that handling split\ncommit graph with layers containing different versions of Bloom\nfilters is broken. That test still fails with the current version of\nthis patch series, i.e. what is currently in seen. Jonathan provided\na patch that makes that test pass, and also noted that that test did\npass with his original design:\n\n https://public-inbox.org/git/20230901205616.3572722-1-jonathantanmy@google.com/\n\nI maintain that without test cases thoroughly covering the interaction\nof different Bloom filter versions with split commit graphs this\nseries should not be merged.\n\n\n> [3]: https://lore.kernel.org/git/xmqqo7io8gmo.fsf@gitster.g/\n> [4]: https://lore.kernel.org/git/ZQnmTXUO94%2FQy8mq@nand.local/\n> \n> Thanks,\n> Taylor\n"},{"id":"482313","messageId":"ZRISbdyy1OhcOKgj@nand.local","threadId":"60237","inReplyTo":"20230924195900.GA1156862@szeder.dev","subject":"Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-09-25T23:06:21Z","receivedAt":"2023-09-25T23:06:26Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sun, Sep 24, 2023 at 09:59:00PM +0200, SZEDER Gábor wrote:\n> Besides the issue of not reading Bloom filter for root commits, that\n> message of mine also includes a test demonstrating that handling split\n> commit graph with layers containing different versions of Bloom\n> filters is broken. That test still fails with the current version of\n> this patch series, i.e. what is currently in seen. Jonathan provided\n> a patch that makes that test pass, and also noted that that test did\n> pass with his original design:\n>\n> https://public-inbox.org/git/20230901205616.3572722-1-jonathantanmy@google.com/\n\nI am not sure whether you are pointing out an existing breakage which\nremains unfixed, or pointing out a new bug introduced by this series. I\nthink that it is the former, but I wrote up some of my confusion in:\n\n https://lore.kernel.org/git/ZRIRtlbsYadg7EUx@nand.local/\n\n> I maintain that without test cases thoroughly covering the interaction\n> of different Bloom filter versions with split commit graphs this\n> series should not be merged.\n\nAgreed. We should wait for the discussion in the linked thread to settle\nbefore merging this down.\n\nThanks,\nTaylor\n"}]}