{"thread":{"id":"60236","subject":"[PATCH] git-config: fix misworded --type=path explanation","startedAt":"2023-09-15T20:26:49Z","lastAt":"2023-09-16T17:46:23Z","messageCount":3,"participants":["Evan Gates","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"481894","messageId":"20230915202610.21206-1-evan.gates@gmail.com","threadId":"60236","inReplyTo":null,"subject":"[PATCH] git-config: fix misworded --type=path explanation","fromName":"Evan Gates","fromEmail":"evan.gates@gmail.com","sentAt":"2023-09-15T20:24:59Z","receivedAt":"2023-09-15T20:26:49Z","isPatch":true,"sender":{"key":"evan.gates@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4196295?v=4"},"body":"When `--type=` was added as a prefered alias for `--`\nthe explanation for the path type was reworded. Whereas the previous\nexplanation said \"expand a leading `~`\" this was changed to \"adding a\nleading `~`\". Change \"adding\" to \"expanding\" to correctly explain the\ncanonicalization.\n\nFixes: fb0dc3bac1 (builtin/config.c: support `--type=` as preferred alias for `--`)\nSigned-off-by: Evan Gates \n---\n\nTurns out --type=path is exactly what I had been looking for, but\nit took some experimentation as I found the documentation confusing.\nIn hindsight it's obvious, but I hope this simple fix helps someone else\nfigure it out faster in the future.\n\n Documentation/git-config.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 7a2bcb2f6c..b1caac887a 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -201,7 +201,7 @@ Valid ``'s include:\n 1073741824 upon input.\n - 'bool-or-int': canonicalize according to either 'bool' or 'int', as described\n above.\n-- 'path': canonicalize by adding a leading `~` to the value of `$HOME` and\n+- 'path': canonicalize by expanding a leading `~` to the value of `$HOME` and\n `~user` to the home directory for the specified user. This specifier has no\n effect when setting the value (but you can use `git config section.variable\n ~/` from the command line to let your shell do the expansion.)\n-- \n2.42.0\n\n"},{"id":"481922","messageId":"20230916061604.GA628367@coredump.intra.peff.net","threadId":"60236","inReplyTo":"20230915202610.21206-1-evan.gates@gmail.com","subject":"Re: [PATCH] git-config: fix misworded --type=path explanation","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2023-09-16T06:16:04Z","receivedAt":"2023-09-16T06:16:48Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Sep 15, 2023 at 02:24:59PM -0600, Evan Gates wrote:\n\n> When `--type=` was added as a prefered alias for `--`\n> the explanation for the path type was reworded. Whereas the previous\n> explanation said \"expand a leading `~`\" this was changed to \"adding a\n> leading `~`\". Change \"adding\" to \"expanding\" to correctly explain the\n> canonicalization.\n\nYeah, the sentence as-is does not make any sense. Your suggested wording\nlooks good to me. Thanks.\n\n-Peff\n"},{"id":"481931","messageId":"xmqqh6nuau73.fsf@gitster.g","threadId":"60236","inReplyTo":"20230915202610.21206-1-evan.gates@gmail.com","subject":"Re: [PATCH] git-config: fix misworded --type=path explanation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-09-16T17:45:04Z","receivedAt":"2023-09-16T17:46:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Evan Gates writes:\n\n> When `--type=` was added as a prefered alias for `--`\n> the explanation for the path type was reworded. Whereas the previous\n> explanation said \"expand a leading `~`\" this was changed to \"adding a\n> leading `~`\". Change \"adding\" to \"expanding\" to correctly explain the\n> canonicalization.\n\nNice spotting (and good archaeology, too).\n\nThanks.\n"}]}