{"thread":{"id":"6016","subject":"[PATCH] Fix regression tests on Cygwin","startedAt":"2006-10-23T19:34:33Z","lastAt":"2006-10-25T06:39:36Z","messageCount":5,"participants":["Lars Hjemli","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"29751","messageId":"11616320733093-git-send-email-hjemli@gmail.com","threadId":"6016","inReplyTo":null,"subject":"[PATCH] Fix regression tests on Cygwin","fromName":"Lars Hjemli","fromEmail":"hjemli@gmail.com","sentAt":"2006-10-23T19:34:33Z","receivedAt":"2006-10-23T19:34:33Z","isPatch":true,"sender":{"key":"hjemli@gmail.com","avatar":null},"body":"On Cygwin, \"make test\" failes due to missing \".exe\" a couple of places.\n\nThis fixes it, in a somewhat ugly way....\n\nSigned-off-by: Lars Hjemli \n---\n t/t0000-basic.sh | 9 ++++++++-\n t/test-lib.sh | 10 +++++++++-\n 2 files changed, 17 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t0000-basic.sh b/t/t0000-basic.sh\nindex 2c9bbb5..41d53be 100755\n--- a/t/t0000-basic.sh\n+++ b/t/t0000-basic.sh\n@@ -25,7 +25,14 @@ # or have too old python without subproc\n # out before running any tests. Also catch the bogosity of trying\n # to run tests without building while we are at it.\n \n-../git >/dev/null\n+X=\n+uname=$(uname -o)\n+if test \"$uname\" = \"Cygwin\"\n+then\n+\tX=\".exe\"\n+fi\n+\n+../git$X >/dev/null\n if test $? != 1\n then\n \techo >&2 'You do not seem to have built git yet.'\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 2488e6e..8a64f6e 100755\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -43,6 +43,14 @@ case $(echo $GIT_TRACE |tr \"[A-Z]\" \"[a-z\n \t\t;;\n esac\n \n+X=\n+uname=$(uname -o)\n+if test \"$uname\" = \"Cygwin\"\n+then\n+\tX=\".exe\"\n+fi\n+\n+\n # Each test should start with something like this, after copyright notices:\n #\n # test_description='Description of this test...\n@@ -175,7 +183,7 @@ test_create_repo () {\n \trepo=\"$1\"\n \tmkdir \"$repo\"\n \tcd \"$repo\" || error \"Cannot setup test environment\"\n-\t\"$GIT_EXEC_PATH/git\" init-db --template=$GIT_EXEC_PATH/templates/blt/ 2>/dev/null ||\n+\t\"$GIT_EXEC_PATH/git$X\" init-db --template=$GIT_EXEC_PATH/templates/blt/ 2>/dev/null ||\n \terror \"cannot run git init-db -- have you built things yet?\"\n \tmv .git/hooks .git/hooks-disabled\n \tcd \"$owd\"\n-- \n1.4.3.1.g1688\n"},{"id":"29863","messageId":"Pine.LNX.4.63.0610241653020.2106@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6016","inReplyTo":"11616320733093-git-send-email-hjemli@gmail.com","subject":"Re: [PATCH] Fix regression tests on Cygwin","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-10-24T14:53:36Z","receivedAt":"2006-10-24T14:53:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 23 Oct 2006, Lars Hjemli wrote:\n\n> On Cygwin, \"make test\" failes due to missing \".exe\" a couple of places.\n\nLast time I made \"test\" on cygwin, it did not complain. \"../git\" works \nperfectly here.\n\nCiao,\nDscho\n"},{"id":"297268","messageId":"7vwt6pdn46.fsf@assigned-by-dhcp.cox.net","threadId":"6016","inReplyTo":"Pine.LNX.4.63.0610241653020.2106@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Fix regression tests on Cygwin","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-25T04:40:25Z","receivedAt":"2006-10-25T04:40:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> On Mon, 23 Oct 2006, Lars Hjemli wrote:\n>\n>> On Cygwin, \"make test\" failes due to missing \".exe\" a couple of places.\n>\n> Last time I made \"test\" on cygwin, it did not complain.\n\nSame here (W2k, fairly up-to-date git, installed on local NTFS\ndisk).\n\n"},{"id":"297052","messageId":"7vods1dmnu.fsf@assigned-by-dhcp.cox.net","threadId":"6016","inReplyTo":"7vwt6pdn46.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix regression tests on Cygwin","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-25T04:50:13Z","receivedAt":"2006-10-25T04:50:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Johannes Schindelin writes:\n>\n>> On Mon, 23 Oct 2006, Lars Hjemli wrote:\n>>\n>>> On Cygwin, \"make test\" failes due to missing \".exe\" a couple of places.\n>>\n>> Last time I made \"test\" on cygwin, it did not complain.\n>\n> Same here (W2k, fairly up-to-date git, installed on local NTFS\n> disk).\n\n... and more importantly, with fairly up-to-date Cygwin.\n"},{"id":"294789","messageId":"8c5c35580610242339r7c2501dh7165dea49965632b@mail.gmail.com","threadId":"6016","inReplyTo":"7vods1dmnu.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix regression tests on Cygwin","fromName":"Lars Hjemli","fromEmail":"hjemli@gmail.com","sentAt":"2006-10-25T06:39:36Z","receivedAt":"2006-10-25T06:39:36Z","isPatch":true,"sender":{"key":"hjemli@gmail.com","avatar":null},"body":"On 10/25/06, Junio C Hamano wrote:\n> Junio C Hamano writes:\n>\n> > Johannes Schindelin writes:\n> >\n> >> On Mon, 23 Oct 2006, Lars Hjemli wrote:\n> >>\n> >>> On Cygwin, \"make test\" failes due to missing \".exe\" a couple of places.\n> >>\n> >> Last time I made \"test\" on cygwin, it did not complain.\n> >\n> > Same here (W2k, fairly up-to-date git, installed on local NTFS\n> > disk).\n\nWell, then it's probably my cygwin-environment that is broken (make\ntest used to work for me too...)\n\nSorry for the noise\n\n--\n"}]}