{"thread":{"id":"6015","subject":"[PATCH] git-cherry should show \"+\" instead of \"-\" and vice versa","startedAt":"2006-10-23T19:03:08Z","lastAt":"2006-10-23T20:22:10Z","messageCount":3,"participants":["Andy Parkins","Petr Baudis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"29746","messageId":"200610232003.08861.andyparkins@gmail.com","threadId":"6015","inReplyTo":null,"subject":"[PATCH] git-cherry should show \"+\" instead of \"-\" and vice versa","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2006-10-23T19:03:08Z","receivedAt":"2006-10-23T19:03:08Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"In git-cherry.sh:\n\n  if test -f \"$patch/$2\"\n  then\n    sign=-\n  else\n    sign=+\n  fi\n\nDocumentation says 'If the change seems to be in the upstream, it is shown on\nthe standard output with prefix \"+\"', however the above does the reverse.  \nWhen\nthe file $patch/$2 exists it is because the patch /is/ in upstream so the sign\nshould be \"+\".\nSigned-off-by: Andy Parkins <andyparkins@gmail.com>\n---\n git-cherry.sh |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-cherry.sh b/git-cherry.sh\nindex 8832573..1cc48e8 100755\n--- a/git-cherry.sh\n+++ b/git-cherry.sh\n@@ -71,9 +71,9 @@ do\n \tthen\n \t\tif test -f \"$patch/$2\"\n \t\tthen\n-\t\t\tsign=-\n-\t\telse\n \t\t\tsign=+\n+\t\telse\n+\t\t\tsign=-\n \t\tfi\n \t\tcase \"$verbose\" in\n \t\tt)\n-- \n1.4.2.3\n"},{"id":"29750","messageId":"20061023193326.GS20017@pasky.or.cz","threadId":"6015","inReplyTo":"200610232003.08861.andyparkins@gmail.com","subject":"Re: [PATCH] git-cherry should show \"+\" instead of \"-\" and vice versa","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-23T19:33:26Z","receivedAt":"2006-10-23T19:33:26Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Mon, Oct 23, 2006 at 09:03:08PM CEST, I got a letter\nwhere Andy Parkins <andyparkins@gmail.com> said that...\n> In git-cherry.sh:\n> \n>   if test -f \"$patch/$2\"\n>   then\n>     sign=-\n>   else\n>     sign=+\n>   fi\n> \n> Documentation says 'If the change seems to be in the upstream, it is shown on\n> the standard output with prefix \"+\"', however the above does the reverse.  \n> When\n> the file $patch/$2 exists it is because the patch /is/ in upstream so the sign\n> should be \"+\".\n> Signed-off-by: Andy Parkins <andyparkins@gmail.com>\n\nSee also\n\n\thttp://news.gmane.org/find-root.php?message_id=<Pine.LNX.4.58.0608071328200.22971@kivilampi-30.cs.helsinki.fi>\n\nDid the documentation ever get fixed or noone cared enough? ;-)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj\n$/=unpack('H*',$_);$_=`echo 16dio\\U$k\"SK$/SM$n\\EsN0p[lN*1\nlK[d2%Sa2/d0$^Ixp\"|dc`;s/\\W//g;$_=pack('H*',/((..)*)$/)\n"},{"id":"29757","messageId":"200610232122.17268.andyparkins@gmail.com","threadId":"6015","inReplyTo":"20061023193326.GS20017@pasky.or.cz","subject":"Re: [PATCH] git-cherry should show \"+\" instead of \"-\" and vice versa","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2006-10-23T20:22:10Z","receivedAt":"2006-10-23T20:22:10Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Monday 2006, October 23 20:33, Petr Baudis wrote:\n\n> Did the documentation ever get fixed or noone cared enough? ;-)\n\nMy patch makes git-cherry match the documentation.\n\nPersonally I think that the documentation is correct.  git-cherry is, to me, \nterribly useful.  I've got a few patches in my own branch and it's very \nuseful to be able to check to see if those emailed patches have been accepted \nupstream with a simple\n\ngit-cherry -v upstream\n\nWhich makes it natural to see\n \"-\" = patch not in upstream\n \"+\" = patch in upstream\n\nI read the thread you pointed at, and didn't really understand what the downer \non git-cherry was, or why the patch wasn't accepted.  Have I misunderstood \nsomething?\n\n\n\nAndy\n-- \nDr Andrew Parkins, M Eng (Hons), AMIEE\nandyparkins@gmail.com\n"}]}