{"thread":{"id":"60125","subject":"[PATCH] update-index doc: v4 is OK with JGit and libgit2","startedAt":"2023-08-18T18:17:43Z","lastAt":"2023-08-18T19:10:20Z","messageCount":3,"participants":["Junio C Hamano","Oswald Buddenhagen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"480783","messageId":"xmqqil9cusfn.fsf@gitster.g","threadId":"60125","inReplyTo":null,"subject":"[PATCH] update-index doc: v4 is OK with JGit and libgit2","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-08-18T18:16:44Z","receivedAt":"2023-08-18T18:17:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Being invented in late 2012 no longer makes the index v4 format\n\"relatively young\".\n\nThe support for the index version 4 was added to libgit2 with their\n5625d86b (index: support index v4, 2016-05-17) and to JGit with\ntheir e9cb0a8e (DirCache: support index V4, 2020-08-10).\n\nLet's update the paragraph that discouraged its use for folks overly\ncautious about cross-tool compatibility.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n Documentation/git-update-index.txt | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\nindex f4bb9c5daf..3d90d6f9ab 100644\n--- a/Documentation/git-update-index.txt\n+++ b/Documentation/git-update-index.txt\n@@ -166,9 +166,12 @@ you will need to handle the situation manually.\n +\n Version 4 performs a simple pathname compression that reduces index\n size by 30%-50% on large repositories, which results in faster load\n-time. Version 4 is relatively young (first released in 1.8.0 in\n-October 2012). Other Git implementations such as JGit and libgit2\n-may not support it yet.\n+time. The first version to support it was Git 1.8.0 released in\n+October 2012, and support for it was added to libgit2 in 2016 and\n+JGit in 2020, respectively.  Older editions of this manual page called\n+it \"relatively young\", but it should be considered mature technology\n+these days.\n+\n \n -z::\n \tOnly meaningful with `--stdin` or `--index-info`; paths are\n-- \n2.42.0-rc2-7-gf9972720e9\n\n"},{"id":"480784","messageId":"ZN+/vJysYcri/iBz@ugly","threadId":"60125","inReplyTo":"xmqqil9cusfn.fsf@gitster.g","subject":"Re: [PATCH] update-index doc: v4 is OK with JGit and libgit2","fromName":"Oswald Buddenhagen","fromEmail":"oswald.buddenhagen@gmx.de","sentAt":"2023-08-18T19:00:12Z","receivedAt":"2023-08-18T19:01:03Z","isPatch":true,"sender":{"key":"oswald.buddenhagen@gmx.de","avatar":"https://avatars.githubusercontent.com/u/812380?v=4"},"body":"On Fri, Aug 18, 2023 at 11:16:44AM -0700, Junio C Hamano wrote:\n>+time. The first version to support it was Git 1.8.0 released in\n>+October 2012,\n\n\"Git supports it since version 1.8.0[, which was] released in October \n2012, and ...\" would be probably easier to read.\n\n>and support for it was added to libgit2 in 2016 and\n\n+to\n\n>+JGit in 2020,\n\n>respectively.\n>\nthis use of \"respectively\" is bogus; just leave it off. it would make \nsense if you wrote \"was added to libgit2 and jgit in 2016 and 2020, \nrespectively\", but this would just complicate matters.\n\nregards\n"},{"id":"480786","messageId":"xmqqa5uouq07.fsf@gitster.g","threadId":"60125","inReplyTo":"ZN+/vJysYcri/iBz@ugly","subject":"Re: [PATCH] update-index doc: v4 is OK with JGit and libgit2","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-08-18T19:09:12Z","receivedAt":"2023-08-18T19:10:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:\n\n> On Fri, Aug 18, 2023 at 11:16:44AM -0700, Junio C Hamano wrote:\n>>+time. The first version to support it was Git 1.8.0 released in\n>>+October 2012,\n>\n> \"Git supports it since version 1.8.0[, which was] released in October\n> 2012, and ...\" would be probably easier to read.\n>\n>>and support for it was added to libgit2 in 2016 and\n>\n> +to\n>\n>>+JGit in 2020,\n>\n>>respectively.\n>>\n> this use of \"respectively\" is bogus; just leave it off.\n\nAll good corrections.  Thanks.\n"}]}