{"thread":{"id":"60083","subject":"[PATCH] t0040: declare non-tab indentation to be okay in this script","startedAt":"2023-08-08T19:45:35Z","lastAt":"2023-08-08T20:44:26Z","messageCount":2,"participants":["Johannes Schindelin via GitGitGadget","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"480314","messageId":"pull.1568.git.1691491054706.gitgitgadget@gmail.com","threadId":"60083","inReplyTo":null,"subject":"[PATCH] t0040: declare non-tab indentation to be okay in this script","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-08-08T10:37:34Z","receivedAt":"2023-08-08T19:45:35Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nBy necessity, this script needs to verify that certain Git output\nmatches expectations, including text indented with spaces instead of\ntabs.\n\nMost recently, such a check was introduced in 448abbba6347 (short help:\nallow multi-line opthelp, 2023-07-18) which is reported by `git diff\n--check 448abbba6347^!` as having whitespace issues.\n\nLet's not complain about this because it is intentional.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    t0040: declare non-tab indentation to be okay in this script\n    \n    When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the\n    Pull Request's check-whitespace run failed. Let's prevent having future\n    contributors from also running into this type of issue when modifying\n    t0040.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1568%2Fdscho%2Fsuppress-t0040-whitespace-error-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1568/dscho/suppress-t0040-whitespace-error-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1568\n\n t/.gitattributes | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/.gitattributes b/t/.gitattributes\nindex 9930e283512..b9cea1795d8 100644\n--- a/t/.gitattributes\n+++ b/t/.gitattributes\n@@ -22,3 +22,4 @@ t[0-9][0-9][0-9][0-9]/* -whitespace\n /t7500/* eol=lf\n /t8005/*.txt eol=lf\n /t9*/*.dump eol=lf\n+/t0040*.sh whitespace=-indent-with-non-tab\n\nbase-commit: 448abbba63471153df6ba520a5621595557ce3c8\n-- \ngitgitgadget\n"},{"id":"480334","messageId":"ZNKjTfhOUpnxrw/L@nand.local","threadId":"60083","inReplyTo":"pull.1568.git.1691491054706.gitgitgadget@gmail.com","subject":"Re: [PATCH] t0040: declare non-tab indentation to be okay in this script","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-08-08T20:19:25Z","receivedAt":"2023-08-08T20:44:26Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Aug 08, 2023 at 10:37:34AM +0000, Johannes Schindelin via GitGitGadget wrote:\n> ---\n>     t0040: declare non-tab indentation to be okay in this script\n>\n>     When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the\n>     Pull Request's check-whitespace run failed. Let's prevent having future\n>     contributors from also running into this type of issue when modifying\n>     t0040.\n\nThanks for hardening these up. This looks obviously correct to me!\n\nThanks,\nTaylor\n"}]}