{"thread":{"id":"60045","subject":"What's cooking in git.git (Jul 2023, #07; Mon, 31)","startedAt":"2023-07-31T17:57:31Z","lastAt":"2023-08-01T20:35:31Z","messageCount":5,"participants":["Junio C Hamano","Emily Shaffer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"480008","messageId":"xmqqmszcynem.fsf@gitster.g","threadId":"60045","inReplyTo":null,"subject":"What's cooking in git.git (Jul 2023, #07; Mon, 31)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-07-31T17:57:21Z","receivedAt":"2023-07-31T17:57:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking in my tree. Commits\nprefixed with '+' are in 'next' (being in 'next' is a sign that a\ntopic is stable enough to be used and are candidate to be in a\nfuture release). Commits prefixed with '-' are only in 'seen', and\naren't considered \"accepted\" at all and may be annotated with an URL\nto a message that raises issues but they are no means exhaustive. A\ntopic without enough support may be discarded after a long period of\nno activity (of course they can be resubmit when new interests\narise).\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into or their mirrors. Some\nrepositories have only a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://github.com/git/git/\n\thttps://gitlab.com/git-vcs/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/gitster/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are published in these repositories for\nconvenience (replace \"htmldocs\" with \"manpages\" for the manual\npages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\nRelease tarballs are available at:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[New Topics]\n\n* jc/checkout-merge-fix (2023-07-28) 2 commits\n - checkout/restore: add basic tests for --merge\n - checkout/restore: refuse unmerging paths unless checking out of the index\n\n \"git checkout/restore --merge -- $path\" improvements.\n\n Needs review.\n source: \n\n\n* ew/sha256-gcrypt-leak-fixes (2023-07-31) 3 commits\n - sha256/gcrypt: die on gcry_md_open failures\n - sha256/gcrypt: fix memory leak with SHA-256 repos\n - sha256/gcrypt: fix build with SANITIZE=leak\n\n Leakfixes.\n\n Will merge to 'next'.\n source: <20230731120808.1230210-1-e@80x24.org>\n\n\n* rs/bundle-parseopt-cleanup (2023-07-31) 1 commit\n - bundle: use OPT_PASSTHRU_ARGV\n\n Code clean-up.\n\n Will merge to 'next'.\n source: <2dcb915f-b926-e024-6394-23aff200955c@web.de>\n\n--------------------------------------------------\n[Graduated to 'master']\n\n* bb/trace2-comment-fix (2023-07-19) 1 commit\n (merged to 'next' on 2023-07-21 at f77aeba1b5)\n + trace2: fix a comment\n\n In-code comment fix.\n source: <20230719232444.555838-1-dev+git@drbeat.li>\n\n\n* rs/describe-parseopt-fix (2023-07-21) 1 commit\n (merged to 'next' on 2023-07-21 at e74749af0c)\n + describe: fix --no-exact-match\n\n Command line parser fix.\n source: <4eea7e15-6594-93e2-27b5-3d6e3c0baac6@web.de>\n\n\n* rs/pack-objects-parseopt-fix (2023-07-21) 2 commits\n (merged to 'next' on 2023-07-21 at acdf84416c)\n + pack-objects: fix --no-quiet\n + pack-objects: fix --no-keep-true-parents\n\n Command line parser fix.\n source: \n\n--------------------------------------------------\n[Stalled]\n\n* tk/cherry-pick-sequence-requires-clean-worktree (2023-06-01) 1 commit\n - cherry-pick: refuse cherry-pick sequence if index is dirty\n\n \"git cherry-pick A\" that replays a single commit stopped before\n clobbering local modification, but \"git cherry-pick A..B\" did not,\n which has been corrected.\n\n Expecting a reroll.\n cf. <999f12b2-38d6-f446-e763-4985116ad37d@gmail.com>\n source: \n\n\n* ab/tag-object-type-errors (2023-05-10) 4 commits\n - tag: don't emit potentially incorrect \"object is a X, not a Y\"\n - tag: don't misreport type of tagged objects in errors\n - object tests: add test for unexpected objects in tags\n - Merge branch 'jk/parse-object-type-mismatch' into ab/tag-object-type-errors\n\n Hardening checks around mismatched object types when one of those\n objects is a tag.\n\n Will discard.\n Stalled for too long.\n source: \n\n\n* ob/revert-of-revert (2023-05-05) 1 commit\n - sequencer: beautify subject of reverts of reverts\n\n Instead of \"Revert \"Revert \"original\"\", give \"Reapply \"original\"\"\n as the title for a revert of a revert.\n\n Will discard.\n Have been expecting a hopefully final reroll for too long.\n Looking much better, except for minor cosmetic issues.\n cf. \n source: <20230428083528.1699221-1-oswald.buddenhagen@gmx.de>\n\n\n* pw/rebase-i-after-failure (2023-04-21) 6 commits\n - rebase -i: fix adding failed command to the todo list\n - rebase: fix rewritten list for failed pick\n - rebase --continue: refuse to commit after failed command\n - sequencer: factor out part of pick_commits()\n - rebase -i: remove patch file after conflict resolution\n - rebase -i: move unlink() calls\n\n Various fixes to the behaviour of \"rebase -i\" when the command got\n interrupted by conflicting changes.\n\n Will discard.\n Have been expecting a reroll for too long.\n cf. \n cf. <1fd54422-b66a-c2e4-7cd7-934ea01190ad@gmail.com>\n cf. <55dd6194-25e5-1a66-9c39-27cb19bfbb3c@gmail.com>\n source: \n\n--------------------------------------------------\n[Cooking]\n\n* pv/doc-submodule-update-settings (2023-07-25) 1 commit\n (merged to 'next' on 2023-07-27 at e27b5b7ba8)\n + doc: highlight that .gitmodules does not support !command\n\n Rewrite the description of giving a custom command to the\n submodule..update configuraiton variable.\n\n Will merge to 'master'.\n source: <20230725212218.711116-1-pvutov@imap.cc>\n\n\n* la/doc-choose-starting-point-fixup (2023-07-27) 3 commits\n (merged to 'next' on 2023-07-28 at 047dcae31c)\n + SubmittingPatches: use of older maintenance tracks is an exception\n + SubmittingPatches: explain why 'next' and above are inappropriate base\n + SubmittingPatches: choice of base for fixing an older maintenance track\n (this branch uses la/doc-choose-starting-point.)\n\n Clarify how to pick a starting point for a new topic in the\n SubmittingPatches document.\n\n Will merge to 'master', together with the underlying topic.\n source: \n source: \n\n\n* jc/resolve-undo-fixes (2023-07-28) 4 commits\n - update-index: remove stale fallback code for \"--unresolve\"\n - update-index: use unmerge_index_entry() to support removal\n - resolve-undo: allow resurrecting conflicted state that resolved to deletion\n - update-index: do not read HEAD and MERGE_HEAD unconditionally\n\n Assorted fixes and clean-up around resolve-undo data.\n\n Needs review.\n source: \n\n\n* ah/sequencer-rewrite-todo-fix (2023-07-24) 1 commit\n (merged to 'next' on 2023-07-26 at 24e74d9eda)\n + sequencer: finish parsing the todo list despite an invalid first line\n\n When the user edits \"rebase -i\" todo file so that it starts with a\n \"fixup\", which would make it invalid, the command truncated the\n rest of the file before giving an error and returning the control\n back to the user. Stop truncating to make it easier to correct\n such a malformed todo file.\n\n Will merge to 'master'.\n cf. \n source: <20230722212830.132135-2-alexhenrie24@gmail.com>\n\n\n* ks/ref-filter-describe (2023-07-24) 2 commits\n (merged to 'next' on 2023-07-26 at f4b3b3b7ef)\n + ref-filter: add new \"describe\" atom\n + ref-filter: add multiple-option parsing functions\n\n \"git branch --list --format=\" and friends are taught\n a new \"%(describe)\" placeholder.\n\n Will merge to 'master'.\n source: <20230723162717.68123-1-five231003@gmail.com>\n\n\n* bb/use-trace2-counters-for-fsync-stats (2023-07-20) 1 commit\n (merged to 'next' on 2023-07-26 at f2c2e3f2b9)\n + wrapper: use trace2 counters to collect fsync stats\n\n Instead of inventing a custom counter variables for debugging,\n use existing trace2 facility in the fsync customization codepath.\n\n Will merge to 'master'.\n source: <20230720164823.625815-1-dev+git@drbeat.li>\n\n\n* am/doc-sha256 (2023-07-31) 1 commit\n - doc: sha256 is no longer experimental\n\n Tone down the warning on SHA-256 repositories being an experimental\n curiosity. We do not have support for them to interoperate with\n traditional SHA-1 repositories, but at this point, we do not plan\n to make breaking changes to SHA-256 repositories and there is no\n longer need for such a strongly phrased warning.\n\n Will merge to 'next'.\n source: \n\n\n* hy/blame-in-bare-with-contents (2023-07-21) 1 commit\n (merged to 'next' on 2023-07-31 at 39ac96d8d8)\n + blame: allow --contents to work with bare repo\n\n \"git blame --contents=file\" has been taught to work in a bare\n repository.\n\n Will merge to 'master'.\n source: <20230721035758.61956-1-hanyang.tony@bytedance.com>\n\n\n* ja/worktree-orphan-fix (2023-07-26) 3 commits\n (merged to 'next' on 2023-07-27 at e475016065)\n + t2400: rewrite regex to avoid unintentional PCRE\n + builtin/worktree.c: convert tab in advice to space\n + t2400: drop no-op `--sq` from rev-parse call\n\n Fix tests with unportable regex patterns.\n\n Will merge to 'master'.\n source: <20230726214202.15775-1-jacobabel@nullpo.dev>\n\n\n* jc/retire-get-sha1-hex (2023-07-24) 1 commit\n (merged to 'next' on 2023-07-27 at eeb9cc37f5)\n + hex: retire get_sha1_hex()\n\n The implementation of \"get_sha1_hex()\" that reads a hexadecimal\n string that spells a full object name has been extended to cope\n with any hash function used in the repository, but the \"sha1\" in\n its name survived. Rename it to get_hash_hex(), a name that is\n more consistent within its friends like get_hash_hex_algop().\n\n Will merge to 'master'.\n source: \n\n\n* rs/parse-options-negation-help (2023-07-24) 5 commits\n - parse-options: show negatability of options in short help\n - t1502: test option negation\n - t1502: move optionspec help output to a file\n - t1502, docs: disallow --no-help\n - subtree: disallow --no-{help,quiet,debug,branch,message}\n\n \"git cmd -h\" learned to signal which options can be negated by\n listing such options like \"--[no-]opt\".\n\n Comments?\n Would showing \"--[[no-]no-]opt\" for \"no-opt\" be worth it?\n cf. <9e8225dd-1e8b-8af2-c3e1-0c5834694244@web.de>\n source: <4d01e971-07cb-4f11-3cc6-9d9f21e590c1@web.de>\n\n\n* tb/commit-graph-tests (2023-07-24) 5 commits\n (merged to 'next' on 2023-07-31 at 740a260315)\n + t/lib-commit-graph.sh: avoid sub-shell in `graph_git_behavior()`\n + t5328: avoid top-level directory changes\n + t5318: avoid top-level directory changes\n + t/lib-commit-graph.sh: avoid directory change in `graph_git_behavior()`\n + t/lib-commit-graph.sh: allow `graph_read_expect()` in sub-directories\n\n Test updates.\n\n Will merge to 'master'.\n source: \n\n\n* la/doc-choose-starting-point (2023-07-14) 5 commits\n (merged to 'next' on 2023-07-19 at 5a807cae46)\n + SubmittingPatches: simplify guidance for choosing a starting point\n + SubmittingPatches: emphasize need to communicate non-default starting points\n + SubmittingPatches: de-emphasize branches as starting points\n + SubmittingPatches: discuss subsystems separately from git.git\n + SubmittingPatches: reword awkward phrasing\n (this branch is used by la/doc-choose-starting-point-fixup.)\n\n Clarify how to choose the starting point for a new topic in\n developer guidance document.\n\n Will merge to 'master' together with the follow-on topic.\n source: \n\n\n* jc/doc-sent-patch-now-what (2023-07-27) 1 commit\n (merged to 'next' on 2023-07-31 at 51f5d9d465)\n + MyFirstContribution: refrain from self-iterating too much\n\n Process document update.\n\n Will merge to 'master'.\n source: \n\n\n* jc/parse-options-short-help (2023-07-19) 3 commits\n (merged to 'next' on 2023-07-31 at e076d1f497)\n + short help: allow a gap smaller than USAGE_GAP\n + remote: simplify \"remote add --tags\" help text\n + short help: allow multi-line opthelp\n\n Command line parser fix, and a small parse-options API update.\n\n Will merge to 'master'.\n source: \n\n\n* sl/sparse-check-attr (2023-07-18) 3 commits\n - check-attr: integrate with sparse-index\n - attr.c: read attributes in a sparse directory\n - t1092: add tests for 'git check-attr'\n\n Teach \"git check-attr\" work better with sparse-index.\n\n Expecting a reroll.\n cf. \n cf. <5e478d8b-9ef4-864b-41e4-e0a79877d278@github.com>\n source: <20230718232916.31660-1-cheskaqiqi@gmail.com>\n\n\n* ah/autoconf-fixes (2023-07-19) 3 commits\n (merged to 'next' on 2023-07-25 at 35ff66e0cb)\n + configure.ac: always save NO_ICONV to config.status\n + configure.ac: don't overwrite NO_CURL option\n + configure.ac: don't overwrite NO_EXPAT option\n\n \"./configure --with-expat=no\" did not work as a way to refuse use\n of the expat library on a system with the library installed, which\n has been corrected.\n\n Will merge to 'master'.\n source: <20230719145211.17854-2-aherrmann@suse.de>\n\n\n* jc/branch-in-use-error-message (2023-07-21) 1 commit\n (merged to 'next' on 2023-07-31 at 22f17d131b)\n + branch: update the message to refuse touching a branch in-use\n\n \"git branch -f X\" to repoint the branch X seid that X was \"checked\n out\" in another worktree, even when branch X was not and instead\n being bisected or rebased. The message was reworded to say the\n branch was \"in use\".\n\n Will merge to 'master'.\n source: \n\n\n* jc/tree-walk-drop-base-offset (2023-07-07) 2 commits\n (merged to 'next' on 2023-07-25 at cc050c60a6)\n + tree-walk: drop unused base_offset from do_match()\n + tree-walk: lose base_offset that is never used in tree_entry_interesting\n\n Code simplification.\n\n Will merge to 'master'.\n source: <20230707222116.4129415-1-gitster@pobox.com>\n\n\n* mh/credential-erase-improvements-more (2023-07-26) 2 commits\n - credential/wincred: erase matching creds only\n - credential/libsecret: erase matching creds only\n\n Update two credential helpers to correctly match which credential\n to erase; they dropped not the ones with stale password.\n\n Needs review.\n source: \n source: \n\n\n* cc/repack-sift-filtered-objects-to-separate-pack (2023-07-24) 8 commits\n . gc: add `gc.repackFilterTo` config option\n . repack: implement `--filter-to` for storing filtered out objects\n . gc: add `gc.repackFilter` config option\n . repack: add `--filter=` option\n . repack: refactor finding pack prefix\n . repack: refactor finishing pack-objects command\n . t/helper: add 'find-pack' test-tool\n . pack-objects: allow `--filter` without `--stdout`\n\n \"git repack\" machinery learns to pay attention to the \"--filter=\"\n option.\n\n Breaks CI with some environment variables configured.\n cf. \n source: <20230724085909.3831831-1-christian.couder@gmail.com>\n\n\n* js/doc-unit-tests (2023-06-30) 1 commit\n - unit tests: Add a project plan document\n\n Process to add some form of low-level unit tests has started.\n\n Still filling in blanks.\n source: <0169ce6fb9ccafc089b74ae406db0d1a8ff8ac65.1688165272.git.steadmon@google.com>\n\n\n* jt/path-filter-fix (2023-07-25) 7 commits\n - commit-graph: new filter ver. that fixes murmur3\n - repo-settings: introduce commitgraph.changedPathsVersion\n - t4216: test changed path filters with high bit paths\n - t/helper/test-read-graph: implement `bloom-filters` mode\n - bloom.h: make `load_bloom_filter_from_graph()` public\n - t/helper/test-read-graph.c: extract `dump_graph_info()`\n - gitformat-commit-graph: describe version 2 of BDAT\n\n The Bloom filter used for path limited history traversal was broken\n on systems whose \"char\" is unsigned; update the implementation and\n bump the format version to 2.\n\n Still under discussion.\n cf. <20230727205308.401364-1-jonathantanmy@google.com>\n source: \n\n\n* mh/credential-libsecret-attrs (2023-06-16) 1 commit\n - credential/libsecret: store new attributes\n\n The way authentication related data other than passwords (e.g.\n oath token and password expiration data) are stored in libsecret\n keyrings has been rethought.\n\n Needs review.\n source: \n\n\n* cc/git-replay (2023-06-03) 15 commits\n - replay: stop assuming replayed branches do not diverge\n - replay: add --contained to rebase contained branches\n - replay: add --advance or 'cherry-pick' mode\n - replay: disallow revision specific options and pathspecs\n - replay: use standard revision ranges\n - replay: make it a minimal server side command\n - replay: remove HEAD related sanity check\n - replay: remove progress and info output\n - replay: add an important FIXME comment about gpg signing\n - replay: don't simplify history\n - replay: introduce pick_regular_commit()\n - replay: die() instead of failing assert()\n - replay: start using parse_options API\n - replay: introduce new builtin\n - t6429: remove switching aspects of fast-rebase\n\n What's the status of this thing?\n source: <20230602102533.876905-1-christian.couder@gmail.com>\n\n--------------------------------------------------\n[Discarded]\n\n* jc/doc-submodule-update-settings (2023-07-13) 1 commit\n . submodule: clarify that \"!custom command\" is the only oddball\n\n Rewrite the description of giving a custom command to the\n submodule..update configuraiton variable.\n\n Superseded by pv/doc-submodule-update-settings topic.\n source: \n\n\n* jc/rerere-read-rr-fix (2023-07-21) 1 commit\n . rerere: match the hash algorithm with its length\n\n SHA-256 fix.\n\n Superseded by jc/retire-get-sha1-hex\n source: \n\n\n* cb/checkout-same-branch-twice (2023-03-22) 2 commits\n . SQUASH??? the test marked to expect failure passes from day one\n . checkout/switch: disallow checking out same branch in multiple worktrees\n\n \"git checkout -B $branch\" failed to protect against checking out\n a branch that is checked out elsewhere, unlike \"git branch -f\" did.\n\n Have been expecting a hopefully minor and final reroll for too long.\n cf. \n source: <20230120113553.24655-1-carenas@gmail.com>\n\n\n* ed/fsmonitor-windows-named-pipe (2023-03-24) 1 commit\n . fsmonitor: handle differences between Windows named pipe functions\n\n Fix fsmonitor on Windows when the filesystem path contains certain\n characters.\n\n Have been expecting a reroll for too long.\n cf. \n source: \n\n\n* rn/sparse-diff-index (2023-04-10) 1 commit\n . diff-index: enable sparse index\n\n \"git diff-index\" command has been taught to work better with the\n sparse index.\n\n Have been expecting a reroll for too long.\n cf. <62821012-4fc3-5ad8-695c-70f7ab14a8c9@github.com>\n source: <20230408112342.404318-1-nanth.raghul@gmail.com>\n\n\n* es/recurse-submodules-option-is-a-bool (2023-04-10) 1 commit\n . usage: clarify --recurse-submodules as a boolean\n\n The \"--[no-]recurse-submodules\" option of \"git checkout\" and others\n supported an undocumented syntax --recurse-submodules= where\n the value can spell a Boolean in various ways. The support for the\n syntax is being dropped.\n\n Have been expecting a reroll for too long.\n cf. \n source: \n"},{"id":"480058","messageId":"CAJoAoZk1WiCSDqFXccG4FiwYhWUuWWmFz+ZqiXhacmfjZuE6FA@mail.gmail.com","threadId":"60045","inReplyTo":"xmqqmszcynem.fsf@gitster.g","subject":"Re: What's cooking in git.git (Jul 2023, #07; Mon, 31)","fromName":"Emily Shaffer","fromEmail":"nasamuffin@google.com","sentAt":"2023-08-01T17:38:17Z","receivedAt":"2023-08-01T17:38:34Z","isPatch":false,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Mon, Jul 31, 2023 at 10:57 AM Junio C Hamano wrote:\n> * es/recurse-submodules-option-is-a-bool (2023-04-10) 1 commit\n> . usage: clarify --recurse-submodules as a boolean\n>\n> The \"--[no-]recurse-submodules\" option of \"git checkout\" and others\n> supported an undocumented syntax --recurse-submodules= where\n> the value can spell a Boolean in various ways. The support for the\n> syntax is being dropped.\n>\n> Have been expecting a reroll for too long.\n> cf. \n> source: \n\nYeah, sorry about the annoying wait. It's not something I have time to\nreroll soon - but it's on the short list for \"up next\" bugs for my\nteam to get a reroll. We still intend to reroll and push through, but\nI don't have an ETA. I'll leave it up to you to decide whether to keep\nit in seen or drop it with that information.\n\n - Emily\n"},{"id":"480061","messageId":"xmqqzg3abpis.fsf@gitster.g","threadId":"60045","inReplyTo":"CAJoAoZk1WiCSDqFXccG4FiwYhWUuWWmFz+ZqiXhacmfjZuE6FA@mail.gmail.com","subject":"Re: What's cooking in git.git (Jul 2023, #07; Mon, 31)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-08-01T18:12:27Z","receivedAt":"2023-08-01T18:12:36Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Emily Shaffer writes:\n\n> On Mon, Jul 31, 2023 at 10:57 AM Junio C Hamano wrote:\n>> * es/recurse-submodules-option-is-a-bool (2023-04-10) 1 commit\n>> . usage: clarify --recurse-submodules as a boolean\n>>\n>> The \"--[no-]recurse-submodules\" option of \"git checkout\" and others\n>> supported an undocumented syntax --recurse-submodules= where\n>> the value can spell a Boolean in various ways. The support for the\n>> syntax is being dropped.\n>>\n>> Have been expecting a reroll for too long.\n>> cf. \n>> source: \n>\n> Yeah, sorry about the annoying wait. It's not something I have time to\n> reroll soon - but it's on the short list for \"up next\" bugs for my\n> team to get a reroll. We still intend to reroll and push through, but\n> I don't have an ETA. I'll leave it up to you to decide whether to keep\n> it in seen or drop it with that information.\n\nI actually do not quite understand this ;-) It wouldn't take more\nthan 20 seconds to read the \"minimally touched-up version\" sent\nmonths ago https://lore.kernel.org/git/xmqqfs97cozz.fsf@gitster.g/\nand say \"yeah, that is perfect and please queue with the fixup\" ;-)\n\nOr are there still further changes in behaviours planned?\n\nThanks.\n"},{"id":"480082","messageId":"CAJoAoZngMcN-0-5q1y-zX5552QhgRHCrKULQ7hKyJgcCoSQJNQ@mail.gmail.com","threadId":"60045","inReplyTo":"xmqqzg3abpis.fsf@gitster.g","subject":"Re: What's cooking in git.git (Jul 2023, #07; Mon, 31)","fromName":"Emily Shaffer","fromEmail":"nasamuffin@google.com","sentAt":"2023-08-01T20:27:33Z","receivedAt":"2023-08-01T20:27:54Z","isPatch":false,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Tue, Aug 1, 2023 at 11:12 AM Junio C Hamano wrote:\n>\n> Emily Shaffer writes:\n>\n> > On Mon, Jul 31, 2023 at 10:57 AM Junio C Hamano wrote:\n> >> * es/recurse-submodules-option-is-a-bool (2023-04-10) 1 commit\n> >> . usage: clarify --recurse-submodules as a boolean\n> >>\n> >> The \"--[no-]recurse-submodules\" option of \"git checkout\" and others\n> >> supported an undocumented syntax --recurse-submodules= where\n> >> the value can spell a Boolean in various ways. The support for the\n> >> syntax is being dropped.\n> >>\n> >> Have been expecting a reroll for too long.\n> >> cf. \n> >> source: \n> >\n> > Yeah, sorry about the annoying wait. It's not something I have time to\n> > reroll soon - but it's on the short list for \"up next\" bugs for my\n> > team to get a reroll. We still intend to reroll and push through, but\n> > I don't have an ETA. I'll leave it up to you to decide whether to keep\n> > it in seen or drop it with that information.\n>\n> I actually do not quite understand this ;-) It wouldn't take more\n> than 20 seconds to read the \"minimally touched-up version\" sent\n> months ago https://lore.kernel.org/git/xmqqfs97cozz.fsf@gitster.g/\n> and say \"yeah, that is perfect and please queue with the fixup\" ;-)\n>\n> Or are there still further changes in behaviours planned?\n\nHuh, I thought that you wanted further changes. In\nhttps://lore.kernel.org/git/ZDSTFwMFO7vbj%2Fdu@google.com/ I was\nasking for opinions on adding tests; if you're fine to take it without\ntests, then of course I don't have an objection to an identical patch\nwith objectively improved grammar in the commit message. But since you\nwere asking for a reroll in the What's Cooking, I figured there was\nmore you were unhappy with in the patch. If that's not the case, by\nall means, go ahead and take it.\n\n - Emily\n"},{"id":"480083","messageId":"xmqqy1iua4c4.fsf@gitster.g","threadId":"60045","inReplyTo":"CAJoAoZngMcN-0-5q1y-zX5552QhgRHCrKULQ7hKyJgcCoSQJNQ@mail.gmail.com","subject":"Re: What's cooking in git.git (Jul 2023, #07; Mon, 31)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-08-01T20:35:23Z","receivedAt":"2023-08-01T20:35:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Emily Shaffer writes:\n\n>> Or are there still further changes in behaviours planned?\n>\n> Huh, I thought that you wanted further changes. In\n> https://lore.kernel.org/git/ZDSTFwMFO7vbj%2Fdu@google.com/ I was\n> asking for opinions on adding tests; if you're fine to take it without\n> tests, then of course I don't have an objection to an identical patch\n> with objectively improved grammar in the commit message. But since you\n> were asking for a reroll in the What's Cooking, I figured there was\n> more you were unhappy with in the patch. If that's not the case, by\n> all means, go ahead and take it.\n\nWell, this is why an overly slow reaction is bad for everybody.\n\nI quite honestly do not recall what was suggested and with what\nseverity (was it a good to have? was it a showstopper?).\n\nAnyway, if it is not urgent and nobody else is jumping up and down\nand asking for an immediate inclusion of the current iteration, we\ncan wait a bit longer without hurting anybody ;-)\n\nThanks.\n"}]}