{"thread":{"id":"60025","subject":"[PATCH] t4002: fix test #63 (missing whitespace)","startedAt":"2023-07-25T06:34:52Z","lastAt":"2023-07-25T16:50:50Z","messageCount":3,"participants":["Andreas Herrmann","Eric Sunshine","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"479836","messageId":"20230725063516.27242-1-aherrmann@suse.de","threadId":"60025","inReplyTo":null,"subject":"[PATCH] t4002: fix test #63 (missing whitespace)","fromName":"Andreas Herrmann","fromEmail":"aherrmann@suse.de","sentAt":"2023-07-25T06:34:10Z","receivedAt":"2023-07-25T06:34:52Z","isPatch":true,"sender":{"key":"aherrmann@suse.de","avatar":null},"body":"Add missing whitespace between 'test_expect_success' and test case\ndescription for last test. Without this, we get:\n\nt4002-diff-basic.sh: line 412: test_expect_successdiff can read from stdin: command not found\n\nSigned-off-by: Andreas Herrmann <aherrmann@suse.de>\n---\n t/t4002-diff-basic.sh | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh\nindex d524d4057d..e6b6739426 100755\n--- a/t/t4002-diff-basic.sh\n+++ b/t/t4002-diff-basic.sh\n@@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '\n test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '\n \tgit diff-tree -r $tree_B $tree_A >.test-a &&\n \tgit diff-tree -r -R $tree_A $tree_B >.test-b &&\n-\tcmp -s .test-a .test-b'\n+\tcmp -s .test-a .test-b\n+'\n \n-test_expect_success'diff can read from stdin' '\n+test_expect_success 'diff can read from stdin' '\n \ttest_must_fail git diff --no-index -- MN - < NN |\n \t\tgrep -v \"^index\" | sed \"s#/-#/NN#\" >.test-a &&\n \ttest_must_fail git diff --no-index -- MN NN |\n-- \n2.41.0\n\n"},{"id":"479837","messageId":"CAPig+cS8=iJD4fwvSacvWTK0WUH_DyjkQuMVP00aV+e4Q4TL3g@mail.gmail.com","threadId":"60025","inReplyTo":"20230725063516.27242-1-aherrmann@suse.de","subject":"Re: [PATCH] t4002: fix test #63 (missing whitespace)","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2023-07-25T07:10:15Z","receivedAt":"2023-07-25T07:10:31Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Tue, Jul 25, 2023 at 2:48 AM Andreas Herrmann <aherrmann@suse.de> wrote:\n> Add missing whitespace between 'test_expect_success' and test case\n> description for last test. Without this, we get:\n>\n> t4002-diff-basic.sh: line 412: test_expect_successdiff can read from stdin: command not found\n>\n> Signed-off-by: Andreas Herrmann <aherrmann@suse.de>\n\nThanks for finding this problem and submitting a fix. You're the\nsecond person to do so[1].\n\n[1]: https://lore.kernel.org/git/pull.1545.git.git.1689341410476.gitgitgadget@gmail.com/\n\n> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh\n> @@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '\n>  test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '\n>         git diff-tree -r $tree_B $tree_A >.test-a &&\n>         git diff-tree -r -R $tree_A $tree_B >.test-b &&\n> -       cmp -s .test-a .test-b'\n> +       cmp -s .test-a .test-b\n> +'\n\nThis minor style fixup could be resubmitted as a standalone patch,\nthough it might be too minor to worry about.\n\n> -test_expect_success'diff can read from stdin' '\n> +test_expect_success 'diff can read from stdin' '\n>         test_must_fail git diff --no-index -- MN - < NN |\n>                 grep -v \"^index\" | sed \"s#/-#/NN#\" >.test-a &&\n>         test_must_fail git diff --no-index -- MN NN |\n"},{"id":"479843","messageId":"xmqqwmyolywy.fsf@gitster.g","threadId":"60025","inReplyTo":"CAPig+cS8=iJD4fwvSacvWTK0WUH_DyjkQuMVP00aV+e4Q4TL3g@mail.gmail.com","subject":"Re: [PATCH] t4002: fix test #63 (missing whitespace)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-07-25T16:49:01Z","receivedAt":"2023-07-25T16:50:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Sunshine <sunshine@sunshineco.com> writes:\n\n> Thanks for finding this problem and submitting a fix. You're the\n> second person to do so[1].\n>\n> [1]: https://lore.kernel.org/git/pull.1545.git.git.1689341410476.gitgitgadget@gmail.com/\n>\n>> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh\n>> @@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '\n>>  test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '\n>>         git diff-tree -r $tree_B $tree_A >.test-a &&\n>>         git diff-tree -r -R $tree_A $tree_B >.test-b &&\n>> -       cmp -s .test-a .test-b'\n>> +       cmp -s .test-a .test-b\n>> +'\n>\n> This minor style fixup could be resubmitted as a standalone patch,\n> though it might be too minor to worry about.\n\nThanks for a quick review and encouraging words.  I do not mind a\npatch with only the above hunk but of course the title and the log\nmessage would have to be updated ;-).\n"}]}