{"thread":{"id":"59983","subject":"[PATCH] i18n: mark more bundle.c strings for translation","startedAt":"2023-07-13T22:01:31Z","lastAt":"2023-07-13T22:24:42Z","messageCount":2,"participants":["D. Ben Knoble via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"479492","messageId":"pull.1550.git.1689285683013.gitgitgadget@gmail.com","threadId":"59983","inReplyTo":null,"subject":"[PATCH] i18n: mark more bundle.c strings for translation","fromName":"D. Ben Knoble via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-07-13T22:01:22Z","receivedAt":"2023-07-13T22:01:31Z","isPatch":true,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"From: \"D. Ben Knoble\" <ben.knoble+github@gmail.com>\n\nThese two messages were introduced in 8ba221e245 (bundle: output hash\ninformation in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse\nfilter capability, 2022-03-09) but never for translation.\n\nSigned-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>\n---\n    i18n: mark more bundle.c strings for translation\n    \n    I noticed that git bundle output contained some untranslated messages\n    for LC_ALL=fr_FR.UTF-8; in order to add translations for these messages,\n    they need to be marked for translation.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1550%2Fbenknoble%2Fbundle-translations-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1550/benknoble/bundle-translations-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1550\n\n bundle.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/bundle.c b/bundle.c\nindex 8d5936c4212..a9744da255c 100644\n--- a/bundle.c\n+++ b/bundle.c\n@@ -271,10 +271,10 @@ int verify_bundle(struct repository *r,\n \t\t\tlist_refs(r, 0, NULL);\n \t\t}\n \n-\t\tprintf_ln(\"The bundle uses this hash algorithm: %s\",\n+\t\tprintf_ln(_(\"The bundle uses this hash algorithm: %s\"),\n \t\t\t  header->hash_algo->name);\n \t\tif (header->filter.choice)\n-\t\t\tprintf_ln(\"The bundle uses this filter: %s\",\n+\t\t\tprintf_ln(_(\"The bundle uses this filter: %s\"),\n \t\t\t\t  list_objects_filter_spec(&header->filter));\n \t}\n cleanup:\n\nbase-commit: aa9166bcc0ba654fc21f198a30647ec087f733ed\n-- \ngitgitgadget\n"},{"id":"479494","messageId":"xmqqh6q7lahl.fsf@gitster.g","threadId":"59983","inReplyTo":"pull.1550.git.1689285683013.gitgitgadget@gmail.com","subject":"Re: [PATCH] i18n: mark more bundle.c strings for translation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-07-13T22:20:22Z","receivedAt":"2023-07-13T22:24:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"D. Ben Knoble via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: \"D. Ben Knoble\" <ben.knoble+github@gmail.com>\n>\n> These two messages were introduced in 8ba221e245 (bundle: output hash\n> information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse\n> filter capability, 2022-03-09) but never for translation.\n\nThanks for catching and reporting.\n\n> diff --git a/bundle.c b/bundle.c\n> index 8d5936c4212..a9744da255c 100644\n> --- a/bundle.c\n> +++ b/bundle.c\n> @@ -271,10 +271,10 @@ int verify_bundle(struct repository *r,\n>  \t\t\tlist_refs(r, 0, NULL);\n>  \t\t}\n>  \n> -\t\tprintf_ln(\"The bundle uses this hash algorithm: %s\",\n> +\t\tprintf_ln(_(\"The bundle uses this hash algorithm: %s\"),\n>  \t\t\t  header->hash_algo->name);\n>  \t\tif (header->filter.choice)\n> -\t\t\tprintf_ln(\"The bundle uses this filter: %s\",\n> +\t\t\tprintf_ln(_(\"The bundle uses this filter: %s\"),\n>  \t\t\t\t  list_objects_filter_spec(&header->filter));\n\nLooking good.  Will queue.\n\nThanks.\n"}]}