{"thread":{"id":"59895","subject":"[PATCH] docs: add git-hash-object -t option's possible values","startedAt":"2023-06-22T00:46:47Z","lastAt":"2023-06-29T18:15:39Z","messageCount":10,"participants":["John Cai via GitGitGadget","brian m. carlson","Taylor Blau","Junio C Hamano","John Cai"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"478673","messageId":"pull.1533.git.git.1687394795009.gitgitgadget@gmail.com","threadId":"59895","inReplyTo":null,"subject":"[PATCH] docs: add git-hash-object -t option's possible values","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-06-22T00:46:34Z","receivedAt":"2023-06-22T00:46:47Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nFor newer users of Git, the possible values of -t in git-hash-object may\nnot be apparent. In fact the current verbiage under NAME could\nlead one to conclude that git-hash-object(1) can only be used to create\nblobs.\n\nUpdate the verbiage to make it clear the command can be used to write\nobjects, not just blobs. Also add the possible values for -t.\n\nSigned-off-by: John Cai \n---\n docs: add git-hash-object -t option's possible values\n \n For newer users of Git, the possible values of -t in git-hash-object may\n not be apparent. In fact the current verbiage under NAME could lead one\n to conclude that git-hash-object(1) can only be used to create blobs.\n \n Update the verbiage to make it clear the command can be used to write\n objects, not just blobs. Also add the possible values for -t.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1533%2Fjohn-cai%2Fjc%2Fhash-object-documentation-update-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1533/john-cai/jc/hash-object-documentation-update-v1\nPull-Request: https://github.com/git/git/pull/1533\n\n Documentation/git-hash-object.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-hash-object.txt b/Documentation/git-hash-object.txt\nindex 472b5bb995b..404e339e170 100644\n--- a/Documentation/git-hash-object.txt\n+++ b/Documentation/git-hash-object.txt\n@@ -3,7 +3,7 @@ git-hash-object(1)\n \n NAME\n ----\n-git-hash-object - Compute object ID and optionally creates a blob from a file\n+git-hash-object - Compute object ID and optionally creates an object from a file\n \n \n SYNOPSIS\n@@ -25,7 +25,8 @@ OPTIONS\n -------\n \n -t ::\n-\tSpecify the type (default: \"blob\").\n+\tSpecify the type (default: \"blob\"). Possible values are `commit`,\n+\t`tree`, `blob`, and `tag`.\n \n -w::\n \tActually write the object into the object database.\n\nbase-commit: 6640c2d06d112675426cf436f0594f0e8c614848\n-- \ngitgitgadget\n"},{"id":"478674","messageId":"ZJOc3Kd0vEEO6bUr@tapette.crustytoothpaste.net","threadId":"59895","inReplyTo":"pull.1533.git.git.1687394795009.gitgitgadget@gmail.com","subject":"Re: [PATCH] docs: add git-hash-object -t option's possible values","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2023-06-22T00:59:08Z","receivedAt":"2023-06-22T00:59:15Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2023-06-22 at 00:46:34, John Cai via GitGitGadget wrote:\n> From: John Cai \n> \n> For newer users of Git, the possible values of -t in git-hash-object may\n> not be apparent. In fact the current verbiage under NAME could\n> lead one to conclude that git-hash-object(1) can only be used to create\n> blobs.\n> \n> Update the verbiage to make it clear the command can be used to write\n> objects, not just blobs. Also add the possible values for -t.\n\nSure, I think this is a good change. I'm of the opinion we should tell\npeople explicitly what the valid values are whenever there are a\nreasonable number.\n-- \nbrian m. carlson (he/him or they/them)\nToronto, Ontario, CA\n"},{"id":"478682","messageId":"ZJRAsU6LfSwFIdbw@nand.local","threadId":"59895","inReplyTo":"pull.1533.git.git.1687394795009.gitgitgadget@gmail.com","subject":"Re: [PATCH] docs: add git-hash-object -t option's possible valuesync-mailbox>","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-06-22T12:38:28Z","receivedAt":"2023-06-22T12:38:38Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Jun 22, 2023 at 12:46:34AM +0000, John Cai via GitGitGadget wrote:\n> From: John Cai \n>\n> For newer users of Git, the possible values of -t in git-hash-object may\n> not be apparent. In fact the current verbiage under NAME could\n> lead one to conclude that git-hash-object(1) can only be used to create\n> blobs.\n\nIn the above, these days we would say \"git hash-object\" instead of\n\"git-hash-object\" (but \"git-hash-object(1)\" is correct to refer to the\nmanual page).\n\nNot worth a reroll on its own, of course, but something to keep in mind\nfor the future.\n\nOtherwise, this patch looks good to me.\n\nThanks,\nTaylor\n"},{"id":"478717","messageId":"xmqqv8ffcd4w.fsf@gitster.g","threadId":"59895","inReplyTo":"ZJOc3Kd0vEEO6bUr@tapette.crustytoothpaste.net","subject":"Re: [PATCH] docs: add git-hash-object -t option's possible values","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-06-22T23:04:31Z","receivedAt":"2023-06-22T23:04:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" writes:\n\n> On 2023-06-22 at 00:46:34, John Cai via GitGitGadget wrote:\n>> From: John Cai \n>> \n>> For newer users of Git, the possible values of -t in git-hash-object may\n>> not be apparent. In fact the current verbiage under NAME could\n>> lead one to conclude that git-hash-object(1) can only be used to create\n>> blobs.\n>> \n>> Update the verbiage to make it clear the command can be used to write\n>> objects, not just blobs. Also add the possible values for -t.\n>\n> Sure, I think this is a good change. I'm of the opinion we should tell\n> people explicitly what the valid values are whenever there are a\n> reasonable number.\n\nStrictly speaking, the valid values become unbounded under\n--literally, but it is just for those who build and experiment with\nGit, not for end-users or toolsmiths, so I am OK with listing the\nfour object types here.\n\nThanks.\n"},{"id":"478718","messageId":"xmqqfs6jccqb.fsf_-_@gitster.g","threadId":"59895","inReplyTo":"ZJRAsU6LfSwFIdbw@nand.local","subject":"Re: [PATCH] docs: add git-hash-object -t option's possible values","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-06-22T23:13:16Z","receivedAt":"2023-06-22T23:13:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> On Thu, Jun 22, 2023 at 12:46:34AM +0000, John Cai via GitGitGadget wrote:\n>> From: John Cai \n>>\n>> For newer users of Git, the possible values of -t in git-hash-object may\n>> not be apparent. In fact the current verbiage under NAME could\n>> lead one to conclude that git-hash-object(1) can only be used to create\n>> blobs.\n\nWhile I do not oppose to the patch text that lists four object types\nexplicitly, I am not sure if the above is a reasonable justification\nto do so.\n\nI think the phrase \"default:\" in front of explicit singling out of\n\"blob\" in the description is sufficient to hint that \"blob\" is\nmerely one of the types it can create. Also why do we expect that\nnewer users of Git would be playing with hash-object before even\nlearning there are other three types (or only after reading the\none-line summary without description)? It almost smells like asking\nfor trouble.\n\nVerbiage refers to uses of too many words or excessively technical\nexpressions. I do not think a single-line summary of the command\nqualifies for one.\n\nSo, I like the patch text, but not the way it is sold with its\nproposed log message.\n\nThanks.\n"},{"id":"478738","messageId":"62B7F5FF-F85D-47C0-B553-F57B991D0BCC@gmail.com","threadId":"59895","inReplyTo":"xmqqfs6jccqb.fsf_-_@gitster.g","subject":"Re: [PATCH] docs: add git-hash-object -t option's possible values","fromName":"John Cai","fromEmail":"johncai86@gmail.com","sentAt":"2023-06-23T18:08:42Z","receivedAt":"2023-06-23T18:08:52Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"Hi Junio,\n\nOn 22 Jun 2023, at 19:13, Junio C Hamano wrote:\n\n> Taylor Blau writes:\n>\n>> On Thu, Jun 22, 2023 at 12:46:34AM +0000, John Cai via GitGitGadget wrote:\n>>> From: John Cai \n>>>\n>>> For newer users of Git, the possible values of -t in git-hash-object may\n>>> not be apparent. In fact the current verbiage under NAME could\n>>> lead one to conclude that git-hash-object(1) can only be used to create\n>>> blobs.\n>\n> While I do not oppose to the patch text that lists four object types\n> explicitly, I am not sure if the above is a reasonable justification\n> to do so.\n>\n> I think the phrase \"default:\" in front of explicit singling out of\n> \"blob\" in the description is sufficient to hint that \"blob\" is\n> merely one of the types it can create.\n\nI think the default does indicate that there are other types, but at least for\nmyself it created a bit of uncertainty as to what other types the command\naccepted. Of course, a quick test on the command line is sufficient to confirm\nthe support for commit, tree, and tag--but I still think the current verbiage\nleaves enough room for ambiguity, even for users of Git who are aware of all the\nobject types.\n\n> Also why do we expect thatnewer users of Git would be playing with hash-object\n> before even learning there are other three types (or only after reading the\n> one-line summary without description)? It almost smells like asking for\n> trouble.\n\nI do agree with this reasoning. \"newer users of Git\" does not sound like the\nright phrase to use.\n\n>\n> Verbiage refers to uses of too many words or excessively technical\n> expressions. I do not think a single-line summary of the command\n> qualifies for one.\n>\n> So, I like the patch text, but not the way it is sold with its\n> proposed log message.\n\nWill re-roll with updated text. Also, based on Taylor's feedback of\ngit-hash-object vs git hash-object.\n\n>\n> Thanks.\n\nthanks!\nJohn\n"},{"id":"478748","messageId":"pull.1533.v2.git.git.1687555504551.gitgitgadget@gmail.com","threadId":"59895","inReplyTo":"pull.1533.git.git.1687394795009.gitgitgadget@gmail.com","subject":"[PATCH v2] docs: add git hash-object -t option's possible values","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-06-23T21:25:04Z","receivedAt":"2023-06-23T21:25:48Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nThe verbiage under the NAME section for git hash-object could\nlead one to conclude that git hash-object can only be used to create\nblobs when in fact the description makes it clear that it can be used to\ncreate objects, not just blobs. Lets clarify this in the NAME text.\n\nFurther, the description for the option -t does not list out other types\nthat can be used. Let's make this explicit by listing out the different\nobject types.\n\nSigned-off-by: John Cai \n---\n docs: add git-hash-object -t option's possible values\n \n For newer users of Git, the possible values of -t in git-hash-object may\n not be apparent. In fact the current verbiage under NAME could lead one\n to conclude that git-hash-object(1) can only be used to create blobs.\n \n Update the verbiage to make it clear the command can be used to write\n objects, not just blobs. Also add the possible values for -t.\n \n Changes since v1:\n \n * updated verbiage of commit message\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1533%2Fjohn-cai%2Fjc%2Fhash-object-documentation-update-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1533/john-cai/jc/hash-object-documentation-update-v2\nPull-Request: https://github.com/git/git/pull/1533\n\nRange-diff vs v1:\n\n 1: 38515c660fb ! 1: 2483375ecb8 docs: add git-hash-object -t option's possible values\n @@ Metadata\n Author: John Cai \n \n ## Commit message ##\n - docs: add git-hash-object -t option's possible values\n + docs: add git hash-object -t option's possible values\n \n - For newer users of Git, the possible values of -t in git-hash-object may\n - not be apparent. In fact the current verbiage under NAME could\n - lead one to conclude that git-hash-object(1) can only be used to create\n - blobs.\n + The verbiage under the NAME section for git hash-object could\n + lead one to conclude that git hash-object can only be used to create\n + blobs when in fact the description makes it clear that it can be used to\n + create objects, not just blobs. Lets clarify this in the NAME text.\n \n - Update the verbiage to make it clear the command can be used to write\n - objects, not just blobs. Also add the possible values for -t.\n + Further, the description for the option -t does not list out other types\n + that can be used. Let's make this explicit by listing out the different\n + object types.\n \n Signed-off-by: John Cai \n \n\n\n Documentation/git-hash-object.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-hash-object.txt b/Documentation/git-hash-object.txt\nindex 472b5bb995b..404e339e170 100644\n--- a/Documentation/git-hash-object.txt\n+++ b/Documentation/git-hash-object.txt\n@@ -3,7 +3,7 @@ git-hash-object(1)\n \n NAME\n ----\n-git-hash-object - Compute object ID and optionally creates a blob from a file\n+git-hash-object - Compute object ID and optionally creates an object from a file\n \n \n SYNOPSIS\n@@ -25,7 +25,8 @@ OPTIONS\n -------\n \n -t ::\n-\tSpecify the type (default: \"blob\").\n+\tSpecify the type (default: \"blob\"). Possible values are `commit`,\n+\t`tree`, `blob`, and `tag`.\n \n -w::\n \tActually write the object into the object database.\n\nbase-commit: 6640c2d06d112675426cf436f0594f0e8c614848\n-- \ngitgitgadget\n"},{"id":"478752","messageId":"xmqq7crtam89.fsf@gitster.g","threadId":"59895","inReplyTo":"pull.1533.v2.git.git.1687555504551.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] docs: add git hash-object -t option's possible values","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-06-23T21:43:18Z","receivedAt":"2023-06-23T21:43:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"John Cai via GitGitGadget\" writes:\n\n> From: John Cai \n>\n> The verbiage under the NAME section for git hash-object could\n\nStil a verbiage?\n\n> lead one to conclude that git hash-object can only be used to create\n> blobs when in fact the description makes it clear that it can be used to\n> create objects, not just blobs. Lets clarify this in the NAME text.\n\n\"Lets\" -> \"Let's\". \"Let's clarify the one-line summary.\"\nSimilarly, \n\n The one-line summary for 'git hash-object' can mislead hasty\n readers to think that the command can only be used to ...\n\nor something, perhaps.\n\n> Further, the description for the option -t does not list out other types\n> that can be used. Let's make this explicit by listing out the different\n> object types.\n>\n> Signed-off-by: John Cai \n\nNice.\n\n> docs: add git-hash-object -t option's possible values\n> \n> For newer users of Git, the possible values of -t in git-hash-object may\n> not be apparent. In fact the current verbiage under NAME could lead one\n> to conclude that git-hash-object(1) can only be used to create blobs.\n> \n> Update the verbiage to make it clear the command can be used to write\n> objects, not just blobs. Also add the possible values for -t.\n\nWhat is this older version of the proposed log message?\n\n> Changes since v1:\n> \n> * updated verbiage of commit message\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1533%2Fjohn-cai%2Fjc%2Fhash-object-documentation-update-v2\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1533/john-cai/jc/hash-object-documentation-update-v2\n> Pull-Request: https://github.com/git/git/pull/1533\n>\n> Range-diff vs v1:\n>\n> 1: 38515c660fb ! 1: 2483375ecb8 docs: add git-hash-object -t option's possible values\n> @@ Metadata\n> Author: John Cai \n> \n> ## Commit message ##\n> - docs: add git-hash-object -t option's possible values\n> + docs: add git hash-object -t option's possible values\n> \n> - For newer users of Git, the possible values of -t in git-hash-object may\n> - not be apparent. In fact the current verbiage under NAME could\n> - lead one to conclude that git-hash-object(1) can only be used to create\n> - blobs.\n> + The verbiage under the NAME section for git hash-object could\n> + lead one to conclude that git hash-object can only be used to create\n> + blobs when in fact the description makes it clear that it can be used to\n> + create objects, not just blobs. Lets clarify this in the NAME text.\n> \n> - Update the verbiage to make it clear the command can be used to write\n> - objects, not just blobs. Also add the possible values for -t.\n> + Further, the description for the option -t does not list out other types\n> + that can be used. Let's make this explicit by listing out the different\n> + object types.\n> \n> Signed-off-by: John Cai \n> \n>\n>\n> Documentation/git-hash-object.txt | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-hash-object.txt b/Documentation/git-hash-object.txt\n> index 472b5bb995b..404e339e170 100644\n> --- a/Documentation/git-hash-object.txt\n> +++ b/Documentation/git-hash-object.txt\n> @@ -3,7 +3,7 @@ git-hash-object(1)\n> \n> NAME\n> ----\n> -git-hash-object - Compute object ID and optionally creates a blob from a file\n> +git-hash-object - Compute object ID and optionally creates an object from a file\n\nNot a new problem, but as we are updating the one-line summary,\nperhaps we should also do \"creates\" -> \"create\" to match \"Compute\".\n\n> \n> SYNOPSIS\n> @@ -25,7 +25,8 @@ OPTIONS\n> -------\n> \n> -t ::\n> -\tSpecify the type (default: \"blob\").\n> +\tSpecify the type (default: \"blob\"). Possible values are `commit`,\n> +\t`tree`, `blob`, and `tag`.\n\nNot a new problem, but \"-t \" alone is clear enough that it\nspecifies something called \"type\" already. If we are to explain\nit further, we should at least say something about the significance\nof that \"type\" thing. Perhaps \"Specify the type of the object to be\ncreated\" or something?\n\nThanks.\n"},{"id":"479002","messageId":"pull.1533.v3.git.git.1688004473941.gitgitgadget@gmail.com","threadId":"59895","inReplyTo":"pull.1533.v2.git.git.1687555504551.gitgitgadget@gmail.com","subject":"[PATCH v3] docs: add git hash-object -t option's possible values","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-06-29T02:07:53Z","receivedAt":"2023-06-29T02:08:01Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nThe summary under the NAME section for git hash-object can mislead\nreaders to conclude that the command can only be used to create blobs,\nwhereas the description makes it clear that it can be used to create\nobjects, not just blobs. Let's clarify the one-line summary.\n\nFurther, the description for the option -t does not list out other types\nthat can be used when creating objects. Let's make this explicit by\nlisting out the different object types.\n\nSigned-off-by: John Cai \n---\n docs: add git-hash-object -t option's possible values\n \n For newer users of Git, the possible values of -t in git-hash-object may\n not be apparent. In fact the current verbiage under NAME could lead one\n to conclude that git-hash-object(1) can only be used to create blobs.\n \n Update the verbiage to make it clear the command can be used to write\n objects, not just blobs. Also add the possible values for -t.\n \n Changes since v2:\n \n * grammatical corrections in command documentation.\n * clarify -t text by specifying what \"type\" is.\n \n Changes since v1:\n \n * updated verbiage of commit message\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1533%2Fjohn-cai%2Fjc%2Fhash-object-documentation-update-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1533/john-cai/jc/hash-object-documentation-update-v3\nPull-Request: https://github.com/git/git/pull/1533\n\nRange-diff vs v2:\n\n 1: 2483375ecb8 ! 1: 9e0bec41285 docs: add git hash-object -t option's possible values\n @@ Metadata\n ## Commit message ##\n docs: add git hash-object -t option's possible values\n \n - The verbiage under the NAME section for git hash-object could\n - lead one to conclude that git hash-object can only be used to create\n - blobs when in fact the description makes it clear that it can be used to\n - create objects, not just blobs. Lets clarify this in the NAME text.\n + The summary under the NAME section for git hash-object can mislead\n + readers to conclude that the command can only be used to create blobs,\n + whereas the description makes it clear that it can be used to create\n + objects, not just blobs. Let's clarify the one-line summary.\n \n Further, the description for the option -t does not list out other types\n - that can be used. Let's make this explicit by listing out the different\n - object types.\n + that can be used when creating objects. Let's make this explicit by\n + listing out the different object types.\n \n Signed-off-by: John Cai \n \n @@ Documentation/git-hash-object.txt: git-hash-object(1)\n NAME\n ----\n -git-hash-object - Compute object ID and optionally creates a blob from a file\n -+git-hash-object - Compute object ID and optionally creates an object from a file\n ++git-hash-object - Compute object ID and optionally create an object from a file\n \n \n SYNOPSIS\n @@ Documentation/git-hash-object.txt: OPTIONS\n \n -t ::\n -\tSpecify the type (default: \"blob\").\n -+\tSpecify the type (default: \"blob\"). Possible values are `commit`,\n -+\t`tree`, `blob`, and `tag`.\n ++\tSpecify the type of object to be created (default: \"blob\"). Possible\n ++\tvalues are `commit`, `tree`, `blob`, and `tag`.\n \n -w::\n \tActually write the object into the object database.\n\n\n Documentation/git-hash-object.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-hash-object.txt b/Documentation/git-hash-object.txt\nindex 472b5bb995b..8577f7a7d40 100644\n--- a/Documentation/git-hash-object.txt\n+++ b/Documentation/git-hash-object.txt\n@@ -3,7 +3,7 @@ git-hash-object(1)\n \n NAME\n ----\n-git-hash-object - Compute object ID and optionally creates a blob from a file\n+git-hash-object - Compute object ID and optionally create an object from a file\n \n \n SYNOPSIS\n@@ -25,7 +25,8 @@ OPTIONS\n -------\n \n -t ::\n-\tSpecify the type (default: \"blob\").\n+\tSpecify the type of object to be created (default: \"blob\"). Possible\n+\tvalues are `commit`, `tree`, `blob`, and `tag`.\n \n -w::\n \tActually write the object into the object database.\n\nbase-commit: 6640c2d06d112675426cf436f0594f0e8c614848\n-- \ngitgitgadget\n"},{"id":"479018","messageId":"xmqqilb69lto.fsf@gitster.g","threadId":"59895","inReplyTo":"pull.1533.v3.git.git.1688004473941.gitgitgadget@gmail.com","subject":"Re: [PATCH v3] docs: add git hash-object -t option's possible values","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-06-29T18:15:31Z","receivedAt":"2023-06-29T18:15:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"John Cai via GitGitGadget\" writes:\n\n> From: John Cai \n>\n> The summary under the NAME section for git hash-object can mislead\n> readers to conclude that the command can only be used to create blobs,\n> whereas the description makes it clear that it can be used to create\n> objects, not just blobs. Let's clarify the one-line summary.\n>\n> Further, the description for the option -t does not list out other types\n> that can be used when creating objects. Let's make this explicit by\n> listing out the different object types.\n>\n> Signed-off-by: John Cai \n> ---\n\nLooks good. Queued. Let's merge it down to 'next' and below.\n\nThanks.\n"}]}