{"thread":{"id":"59882","subject":"[BUG] git-web unable to show this commit properly?","startedAt":"2023-06-19T21:37:33Z","lastAt":"2023-06-19T23:02:01Z","messageCount":3,"participants":["Dexuan Cui","Andreas Schwab"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"478532","messageId":"SA1PR21MB1335BD64334ABD240C23C43ABF5FA@SA1PR21MB1335.namprd21.prod.outlook.com","threadId":"59882","inReplyTo":null,"subject":"[BUG] git-web unable to show this commit properly?","fromName":"Dexuan Cui","fromEmail":"decui@microsoft.com","sentAt":"2023-06-19T21:37:21Z","receivedAt":"2023-06-19T21:37:33Z","isPatch":false,"sender":{"key":"decui@microsoft.com","avatar":null},"body":"Hi,\n\"git show 122333d6bd229af279cdb35d1b874b71b3b9ccfb --stat\" shows the below:\n\ncommit 122333d6bd229af279cdb35d1b874b71b3b9ccfb\nAuthor: Nikolay Borisov <nik.borisov@suse.com>\nDate:   Fri May 5 15:03:32 2023 +0300\n\n    x86/tdx: Wrap exit reason with hcall_func()\n\n    TDX reuses VMEXIT \"reasons\" in its guest->host hypercall ABI.  This is\n    confusing because there might not be a VMEXIT involved at *all*.\n    These instances are supposed to document situation and reduce confusion\n    by wrapping VMEXIT reasons with hcall_func().\n\n    The decompression code does not follow this convention.\n\n    Unify the TDX decompression code with the other TDX use of VMEXIT reasons.\n    No functional changes.\n\n    Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>\n    Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>\n    Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>\n    Link: https://lore.kernel.org/all/20230505120332.1429957-1-nik.borisov%40suse.com\n\n arch/x86/boot/compressed/tdx.c    |  4 ++--\n arch/x86/coco/tdx/tdx.c           | 11 -----------\n arch/x86/include/asm/shared/tdx.h | 11 +++++++++++\n 3 files changed, 13 insertions(+), 13 deletions(-)\n\nBut the web interface only shows \" 1 files changed, 0 insertions, 11 deletions\" \nhttps://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/arch/x86/coco?id=122333d6bd229af279cdb35d1b874b71b3b9ccfb\n(Note: the correct info should be \"3 files changed, 13 insertions(+), 13 deletions(-)\", as shown above by git-show)\n\nLooks like this may have something to do with Rename Detection? But IMO the\nweb interface should at least show \"3 files changed\", otherwise it's confusing...\n\nThanks,\n-- Dexuan\n\n"},{"id":"478533","messageId":"87o7lb5cz1.fsf@igel.home","threadId":"59882","inReplyTo":"SA1PR21MB1335BD64334ABD240C23C43ABF5FA@SA1PR21MB1335.namprd21.prod.outlook.com","subject":"Re: [BUG] git-web unable to show this commit properly?","fromName":"Andreas Schwab","fromEmail":"schwab@linux-m68k.org","sentAt":"2023-06-19T22:00:50Z","receivedAt":"2023-06-19T22:08:14Z","isPatch":false,"sender":{"key":"schwab@linux-m68k.org","avatar":"https://avatars.githubusercontent.com/u/2175493?v=4"},"body":"On Jun 19 2023, Dexuan Cui wrote:\n\n> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/arch/x86/coco?id=122333d6bd229af279cdb35d1b874b71b3b9ccfb\n\nThat URL corresponds to this command:\n\ngit show 122333d6bd229af279cdb35d1b874b71b3b9ccfb -- arch/x86/coco\n\nIf you want to see the whole commit, use\nhttps://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit?id=122333d6bd229af279cdb35d1b874b71b3b9ccfb\n\n-- \nAndreas Schwab, schwab@linux-m68k.org\nGPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1\n\"And now for something completely different.\"\n"},{"id":"478534","messageId":"SA1PR21MB1335AACDE23D101DDE3D5568BF5FA@SA1PR21MB1335.namprd21.prod.outlook.com","threadId":"59882","inReplyTo":"87o7lb5cz1.fsf@igel.home","subject":"RE: [BUG] git-web unable to show this commit properly?","fromName":"Dexuan Cui","fromEmail":"decui@microsoft.com","sentAt":"2023-06-19T23:01:52Z","receivedAt":"2023-06-19T23:02:01Z","isPatch":false,"sender":{"key":"decui@microsoft.com","avatar":null},"body":"> From: Andreas Schwab <schwab@linux-m68k.org>\n> Sent: Monday, June 19, 2023 3:01 PM\n> To: Dexuan Cui <decui@microsoft.com>\n> Cc: 'git@vger.kernel.org' <git@vger.kernel.org>\n> Subject: Re: [BUG] git-web unable to show this commit properly?\n> \n> [You don't often get email from schwab@linux-m68k.org. Learn why this is\n> important at https://aka.ms/LearnAboutSenderIdentification ]\n> \n> On Jun 19 2023, Dexuan Cui wrote:\n>  ...\n> That URL corresponds to this command:\n> \n> git show 122333d6bd229af279cdb35d1b874b71b3b9ccfb -- arch/x86/coco\n\nOh, silly me! :-) I was checking the git-log for the folder from the web interface\nand forgot I was checking that folder only.\n\nThanks for pointing this out!\n"}]}