{"thread":{"id":"5987","subject":"git-imap-send and \"From \"","startedAt":"2006-10-21T16:51:17Z","lastAt":"2006-10-21T18:11:54Z","messageCount":4,"participants":["Andy Parkins","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"29518","messageId":"200610211751.21581.andyparkins@gmail.com","threadId":"5987","inReplyTo":null,"subject":"git-imap-send and \"From \"","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2006-10-21T16:51:17Z","receivedAt":"2006-10-21T16:51:17Z","isPatch":false,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"Hello,\n\nI've been playing around with git; made some simple patches for git and \nthought I would forward them to the mailing list.  I did this using\n\ngit-format-patch --stdout --signoff -M -B | git-imap-send\n\nWith the following in .gitconfig and courier-imap as the IMAP server.\n\n[imap]\n  Folder = \"INBOX.Drafts\"\n  Tunnel = \"ssh -q mailhost /usr/bin/imapd ./Maildir 2> /dev/null\"\n\nThis appeared to work as expected.  A nicely formatted patch appeared in my \ndrafts mailbox for checking and sending; which I did.  However, those emails \ncaused a few problems; like:\n\n\"Can you please not send your emails to \"unlisted recipients?\"  It\nbreaks my mail filtering and your mails don't end up going to my \"git\"\nfolder.\"\n\nAs far as I knew, I hadn't done this.  The email looked fine when I checked it \nin KMail.  So, I went back and had a look at the raw source of the patch \nemail that I'd sent and found this:\n\nFrom 0e3c0aefc3276bd271553d171ed9bcc52d85230e Mon Sep 17 00:00:00 2001\nFrom: Andy Parkins <andyparkins@gmail.com>\nDate: Fri, 20 Oct 2006 15:24:40 +0100\nSubject: [PATCH] Use email address only for looking up signing key in git-tag\n\nIt's that first line that's the problem.  It was generated by git-format-patch \nof course, however, I assume that it was intended to be stripped on the way \nto the IMAP server.  So,\n\n * Courier's /usr/bin/imapd should have stripped it and didn't\n * git-imap-send shouldn't have sent it\n\nCan anyone help me out with which it should be?  Or point me at the relevant \nRFC?\n\nWhile I was poking around I found that git is hard coded with\n\nprintf(\"From %s Mon Sep 17 00:00:00 2001\\n\", sha1);\n\nWas it intentional that the date be hard coded like that?\n\n\nAndy\n-- \nDr Andrew Parkins, M Eng (Hons), AMIEE\nandyparkins@gmail.com\n"},{"id":"29529","messageId":"20061021175519.GA7432@coredump.intra.peff.net","threadId":"5987","inReplyTo":"200610211751.21581.andyparkins@gmail.com","subject":"Re: git-imap-send and \"From \"","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2006-10-21T17:55:19Z","receivedAt":"2006-10-21T17:55:19Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Oct 21, 2006 at 05:51:17PM +0100, Andy Parkins wrote:\n\n> From 0e3c0aefc3276bd271553d171ed9bcc52d85230e Mon Sep 17 00:00:00 2001\n> From: Andy Parkins <andyparkins@gmail.com>\n> Date: Fri, 20 Oct 2006 15:24:40 +0100\n> Subject: [PATCH] Use email address only for looking up signing key in git-tag\n> \n> It's that first line that's the problem.  It was generated by\n> git-format-patch of course, however, I assume that it was intended to\n> be stripped on the way to the IMAP server.  So,\n\nThat makes sense; git-format-patch generates an mbox, not a raw message.\n\n>  * Courier's /usr/bin/imapd should have stripped it and didn't\n>  * git-imap-send shouldn't have sent it\n\ngit-imap-send shouldn't be sending it. The IMAP protocol works with\nRFC822 messages, not mboxes.\n\n> Can anyone help me out with which it should be?  Or point me at the relevant \n> RFC?\n\nRFC2060, section 6.3.11 (APPEND).\n\n-Peff\n"},{"id":"29531","messageId":"20061021180145.GA7983@coredump.intra.peff.net","threadId":"5987","inReplyTo":"20061021175519.GA7432@coredump.intra.peff.net","subject":"Re: git-imap-send and \"From \"","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2006-10-21T18:01:45Z","receivedAt":"2006-10-21T18:01:45Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Oct 21, 2006 at 01:55:19PM -0400, Jeff King wrote:\n\n> git-imap-send shouldn't be sending it. The IMAP protocol works with\n> RFC822 messages, not mboxes.\n\nFWIW, I just checked and git-imap-send does the right thing; it strips\nthe 'From ' line before sending to the imap server.\n\n-Peff\n"},{"id":"29533","messageId":"200610211911.54920.andyparkins@gmail.com","threadId":"5987","inReplyTo":"20061021175519.GA7432@coredump.intra.peff.net","subject":"Re: git-imap-send and \"From \"","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2006-10-21T18:11:54Z","receivedAt":"2006-10-21T18:11:54Z","isPatch":false,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Saturday 2006, October 21 18:55, Jeff King wrote:\n\n> git-imap-send shouldn't be sending it. The IMAP protocol works with\n> RFC822 messages, not mboxes.\n\nI grabbed the latest git; and started looking at fixing it.  It looks fixed to \nme; a quick \"git log imap-send.c\" found me commit \ne0b0830726286287744cc9e1a629a534bbe75452; which already fixes this problem.\n\nGoodness I love git :-)\n\n\nAndy\n\n-- \nDr Andrew Parkins, M Eng (Hons), AMIEE\nandyparkins@gmail.com\n"}]}