{"thread":{"id":"59869","subject":"What's cooking in git.git (Jun 2023, #04; Wed, 14)","startedAt":"2023-06-15T00:07:01Z","lastAt":"2023-06-19T16:57:35Z","messageCount":4,"participants":["Junio C Hamano","Linus Arver","Taylor Blau"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"478408","messageId":"xmqqedmdwput.fsf@gitster.g","threadId":"59869","inReplyTo":null,"subject":"What's cooking in git.git (Jun 2023, #04; Wed, 14)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-06-15T00:06:50Z","receivedAt":"2023-06-15T00:07:01Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking in my tree.  Commits\nprefixed with '+' are in 'next' (being in 'next' is a sign that a\ntopic is stable enough to be used and are candidate to be in a\nfuture release).  Commits prefixed with '-' are only in 'seen', and\naren't considered \"accepted\" at all and may be annotated with an URL\nto a message that raises issues but they are no means exhaustive.  A\ntopic without enough support may be discarded after a long period of\nno activity (of course they can be resubmit when new interests\narise).\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into or their mirrors.  Some\nrepositories have only a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://github.com/git/git/\n\thttps://gitlab.com/git-vcs/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/gitster/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are published in these repositories for\nconvenience (replace \"htmldocs\" with \"manpages\" for the manual\npages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\nRelease tarballs are available at:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[New Topics]\n\n* jc/notes-separator-fix (2023-06-13) 1 commit\n  (merged to 'next' on 2023-06-14 at 3321da32a9)\n + notes: do not access before the beginning of an array\n (this branch uses tl/notes-separator.)\n\n Fix to tl/notes-separator topic.\n\n Will merge to 'master'.\n source: <cover.1682671758.git.dyroneteng@gmail.com>\n\n\n* js/doc-unit-tests (2023-06-13) 1 commit\n - unit tests: Add a project plan document\n\n Process to add some form of low-level unit tests has started.\n\n Comments?  Filling in blanks?\n source: <8afdb215d7e10ca16a2ce8226b4127b3d8a2d971.1686352386.git.steadmon@google.com>\n\n\n* jt/doc-use-octal-with-printf (2023-06-13) 1 commit\n - CodingGuidelines: use octal escapes, not hex\n\n Suggest to refrain from using hex literals that are non-portable\n when writing printf(1) format strings.\n\n Will merge to 'next'.\n source: <20230614001558.277755-1-jonathantanmy@google.com>\n\n\n* js/defeat-ignore-submodules-config-with-explicit-addition (2023-06-14) 1 commit\n - diff-lib: honor override_submodule_config flag bit\n\n Even when diff.ignoreSubmodules tells us to ignore submodule\n changes, \"git commit\" with an index that already records changes to\n submodules should include the submodule changes in the resulting\n commit, but it did not.\n\n Will merge to 'next'.\n source: <20230614164856.3186012-2-sokcevic@google.com>\n\n--------------------------------------------------\n[Graduated to 'master']\n\n* gc/doc-cocci-updates (2023-04-27) 2 commits\n  (merged to 'next' on 2023-05-20 at 3fe237c1a8)\n + cocci: codify authoring and reviewing practices\n + cocci: add headings to and reword README\n\n Update documentation regarding Coccinelle patches.\n source: <pull.1495.v2.git.git.1682634143.gitgitgadget@gmail.com>\n\n\n* jc/diff-s-with-other-options (2023-05-05) 1 commit\n  (merged to 'next' on 2023-05-20 at dda3826a68)\n + diff: fix interaction between the \"-s\" option and other options\n\n The \"-s\" (silent, squelch) option of the \"diff\" family of commands\n did not interact with other options that specify the output format\n well.  This has been cleaned up so that it will clear all the\n formatting options given before.\n source: <20230505165952.335256-1-gitster@pobox.com>\n\n\n* jc/pack-ref-exclude-include (2023-05-12) 3 commits\n  (merged to 'next' on 2023-05-23 at 37333a2d00)\n + pack-refs: teach pack-refs --include option\n + pack-refs: teach --exclude option to exclude refs from being packed\n + docs: clarify git-pack-refs --all will pack all refs\n\n \"git pack-refs\" learns \"--include\" and \"--exclude\" to tweak the ref\n hierarchy to be packed using pattern matching.\n source: <pull.1501.v4.git.git.1683927282.gitgitgadget@gmail.com>\n\n\n* jk/format-patch-message-id-unleak (2023-05-19) 2 commits\n  (merged to 'next' on 2023-05-23 at 44b9e1ab91)\n + format-patch: free elements of rev.ref_message_ids list\n + format-patch: free rev.message_id when exiting\n\n Leakfix.\n source: <20230519000239.GA1975039@coredump.intra.peff.net>\n\n\n* kh/keep-tag-editmsg-upon-failure (2023-05-16) 3 commits\n  (merged to 'next' on 2023-05-19 at fc0fe3173d)\n + tag: keep the message file in case ref transaction fails\n + t/t7004-tag: add regression test for successful tag creation\n + doc: tag: document `TAG_EDITMSG`\n\n \"git tag\" learned to leave the \"$GIT_DIR/TAG_EDITMSG\" file when the\n command failed, so that the user can salvage what they typed.\n source: <cover.1684258780.git.code@khaugsbakk.name>\n\n\n* sa/doc-ls-remote (2023-05-19) 6 commits\n  (merged to 'next' on 2023-05-20 at d577bf75a0)\n + ls-remote doc: document the output format\n + ls-remote doc: explain what each example does\n + ls-remote doc: show peeled tags in examples\n + ls-remote doc: remove redundant --tags example\n + show-branch doc: say <ref>, not <reference>\n + show-ref doc: update for internal consistency\n\n Doc update.\n source: <pull.1471.v4.git.git.1684469874.gitgitgadget@gmail.com>\n\n\n* sl/diff-tree-sparse (2023-05-18) 1 commit\n  (merged to 'next' on 2023-05-24 at 5d4f2dec4d)\n + diff-tree: integrate with sparse index\n\n \"git diff-tree\" has been taught to take advantage of the\n sparse-index feature.\n cf. <2a2b7223-bb5d-65f9-95bb-9be45d329c87@github.com>\n source: <20230518154454.475487-1-cheskaqiqi@gmail.com>\n\n\n* zh/ls-files-format-atoms (2023-05-23) 1 commit\n  (merged to 'next' on 2023-05-24 at 116b11effb)\n + ls-files: align format atoms with ls-tree\n\n Some atoms that can be used in \"--format=<format>\" for \"git ls-tree\"\n were not supported by \"git ls-files\", even though they were relevant\n in the context of the latter.\n source: <pull.1533.v2.git.1684832418299.gitgitgadget@gmail.com>\n\n--------------------------------------------------\n[Stalled]\n\n* ed/fsmonitor-windows-named-pipe (2023-03-24) 1 commit\n - fsmonitor: handle differences between Windows named pipe functions\n\n Fix fsmonitor on Windows when the filesystem path contains certain\n characters.\n\n Expecting a reroll.\n cf. <b9cf67e4-22a7-2ff0-8310-9223bea10d6d@jeffhostetler.com>\n source: <pull.1503.git.1679678090412.gitgitgadget@gmail.com>\n\n\n* rn/sparse-diff-index (2023-04-10) 1 commit\n - diff-index: enable sparse index\n\n \"git diff-index\" command has been taught to work better with the\n sparse index.\n\n Expecting a reroll.\n cf. <62821012-4fc3-5ad8-695c-70f7ab14a8c9@github.com>\n source: <20230408112342.404318-1-nanth.raghul@gmail.com>\n\n\n* es/recurse-submodules-option-is-a-bool (2023-04-10) 1 commit\n - usage: clarify --recurse-submodules as a boolean\n\n The \"--[no-]recurse-submodules\" option of \"git checkout\" and others\n supported an undocumented syntax --recurse-submodules=<value> where\n the value can spell a Boolean in various ways.  The support for the\n syntax is being dropped.\n\n Expecting a reroll.\n cf. <ZDSTFwMFO7vbj/du@google.com>\n source: <ZDSTFwMFO7vbj/du@google.com>\n\n\n* tb/pack-bitmap-index-seek (2023-03-20) 6 commits\n - pack-bitmap.c: factor out `bitmap_index_seek_commit()`\n - pack-bitmap.c: use `bitmap_index_seek()` where possible\n - pack-bitmap.c: factor out manual `map_pos` manipulation\n - pack-bitmap.c: drop unnecessary 'inline's\n - pack-bitmap.c: hide bitmap internals in `read_be32()`\n - pack-bitmap.c: hide bitmap internals in `read_u8()`\n\n Clean-up the pack-bitmap codepath.\n\n Kicked back to 'seen' out of 'next'.\n There is a BUG() on data errors that needs to be fixed.\n source: <cover.1679342296.git.me@ttaylorr.com>\n\n\n* cb/checkout-same-branch-twice (2023-03-22) 2 commits\n - SQUASH??? the test marked to expect failure passes from day one\n - checkout/switch: disallow checking out same branch in multiple worktrees\n\n \"git checkout -B $branch\" failed to protect against checking out\n a branch that is checked out elsewhere, unlike \"git branch -f\" did.\n\n Expecting a hopefully minor and final reroll.\n cf. <CAPUEspj_Bh+LgYLnWfeBdcq_uV5Cbou-7H51GLFjzSa5Qzby9w@mail.gmail.com>\n source: <20230120113553.24655-1-carenas@gmail.com>\n\n\n* tk/pull-conflict-suggest-rebase-merge-not-rebase-true (2023-02-13) 1 commit\n - pull: conflict hint pull.rebase suggestion should offer \"merges\" vs \"true\"\n\n In an advice message after failed non-ff pull, we used to suggest\n setting pull.rebase=true, but these days pull.rebase=merges may be\n more inline with the original spirit of \"rebuild your side on top\n of theirs\".\n\n May want to discard.\n This is too much of a departure from the existing practice.\n cf. <CAMMLpeTPEoKVTbfc17w+Y9qn7jOGmQi_Ux0Y3sFW5QTgGWJ=SA@mail.gmail.com>\n cf. <CABPp-BGqAxKnxDRVN4cYMteLp33hvto07R3=TJBT5WubJT4+Og@mail.gmail.com>\n source: <pull.1474.git.1675614276549.gitgitgadget@gmail.com>\n\n\n* ab/tag-object-type-errors (2023-05-10) 4 commits\n - tag: don't emit potentially incorrect \"object is a X, not a Y\"\n - tag: don't misreport type of tagged objects in errors\n - object tests: add test for unexpected objects in tags\n - Merge branch 'jk/parse-object-type-mismatch' into ab/tag-object-type-errors\n\n Hardening checks around mismatched object types when one of those\n objects is a tag.\n source: <cover-v2-0.3-00000000000-20221230T011725Z-avarab@gmail.com>\n\n\n* ad/test-record-count-when-harness-is-in-use (2022-12-25) 1 commit\n - test-lib: allow storing counts with test harnesses\n\n Allow summary results from tests to be written to t/test-results\n directory even when a test harness like 'prove' is in use.\n\n Expecting a reroll.\n cf. <CABPp-BGoPuGCZw+9wCgdYyRR4Zf4y9Kun27GrQhtMdYWpOUsYQ@mail.gmail.com>\n source: <20221224225200.1027806-1-adam@dinwoodie.org>\n\n\n* so/diff-merges-more (2022-12-18) 5 commits\n - diff-merges: improve --diff-merges documentation\n - diff-merges: issue warning on lone '-m' option\n - diff-merges: support list of values for --diff-merges\n - diff-merges: implement log.diffMerges-m-imply-p config\n - diff-merges: implement [no-]hide option and log.diffMergesHide config\n\n Assorted updates to \"--diff-merges=X\" option.\n\n May want to discard.\n Breaking compatibility does not seem worth it.\n source: <20221217132955.108542-1-sorganov@gmail.com>\n\n\n* ab/imap-send-requires-curl (2023-02-02) 6 commits\n - imap-send: correctly report \"host\" when using \"tunnel\"\n - imap-send: remove old --no-curl codepath\n - imap-send: make --curl no-optional\n - imap-send: replace auto-probe libcurl with hard dependency\n - imap-send doc: the imap.sslVerify is used with imap.tunnel\n - imap-send: note \"auth_method\", not \"host\" on auth method failure\n\n Give a hard dependency on cURL library to build \"git imap-send\",\n and remove the code to interact with IMAP server without using cURL.\n\n Expecting a reroll.\n The 'tunnel' part is still iffy.\n cf. <230203.86bkmabfjr.gmgdl@evledraar.gmail.com>\n source: <cover-v2-0.6-00000000000-20230202T093706Z-avarab@gmail.com>\n\n\n* cw/submodule-status-in-parallel (2023-03-02) 6 commits\n - diff-lib: parallelize run_diff_files for submodules\n - diff-lib: refactor out diff_change logic\n - submodule: refactor is_submodule_modified()\n - submodule: move status parsing into function\n - submodule: rename strbuf variable\n - run-command: add on_stderr_output_fn to run_processes_parallel_opts\n\n \"git submodule status\" learned to run the comparison in submodule\n repositories in parallel.\n\n Expecting a reroll.\n cf. <CAFySSZDk05m6gU5-V1R+y3YnQ5PPduVW54+_gjBwD0rmacsLsw@mail.gmail.com>\n cf. <230307.865ybc273g.gmgdl@evledraar.gmail.com>\n source: <20230302215237.1473444-1-calvinwan@google.com>\n\n--------------------------------------------------\n[Cooking]\n\n* as/dtype-compilation-fix (2023-06-12) 1 commit\n - statinfo.h: move DTYPE defines from dir.h\n\n Compilation fix for platforms without D_TYPE in struct dirent.\n\n Will merge to 'next'.\n source: <20230606205935.3183276-1-asedeno@google.com>\n\n\n* la/docs-typofixes (2023-06-12) 1 commit\n - docs: typofixes\n\n Typofixes.\n\n Will merge to 'next'.\n source: <pull.1542.v2.git.1686166007816.gitgitgadget@gmail.com>\n\n\n* mh/mingw-case-sensitive-build (2023-06-12) 1 commit\n - mingw: use lowercase includes for some Windows headers\n\n Names of MinGW header files are spelled in mixed case in some\n source files, but the build host can be using case sensitive\n filesystem with header files with their name spelled in all\n lowercase.\n\n Needs review.\n source: <20230604211934.1365289-1-mh@glandium.org>\n\n\n* pb/complete-diff-options (2023-06-12) 25 commits\n - diff.c: mention completion above add_diff_options\n - completion: complete --remerge-diff\n - completion: complete --diff-merges, its options and --no-diff-merges\n - completion: move --pickaxe-{all,regex} to __git_diff_common_options\n - completion: complete --ws-error-highlight\n - completion: complete --unified\n - completion: complete --patch-with-raw\n - completion: complete --output-indicator-{context,new,old}\n - completion: complete --output\n - completion: complete --no-stat\n - completion: complete --no-relative\n - completion: complete --line-prefix\n - completion: complete --ita-invisible-in-index and --ita-visible-in-index\n - completion: complete --irreversible-delete\n - completion: complete --ignore-matching-lines\n - completion: complete --function-context\n - completion: complete --find-renames\n - completion: complete --find-object\n - completion: complete --find-copies\n - completion: complete --default-prefix\n - completion: complete --compact-summary\n - completion: complete --combined-all-paths\n - completion: complete --cc\n - completion: complete --break-rewrites\n - completion: add comments describing __git_diff_* globals\n\n Completion updates.\n\n Expecting a reroll.\n cf. <5cba334c-4d75-0dac-20c6-9e3def1f224a@gmail.com>\n source: <pull.1543.v2.git.1686574374.gitgitgadget@gmail.com>\n\n\n* rj/leakfixes (2023-06-12) 6 commits\n - branch: fix a leak in setup_tracking\n - branch: fix a leak in check_tracking_branch\n - branch: fix a leak in inherit_tracking\n - branch: fix a leak in dwim_and_setup_tracking\n - remote: fix a leak in query_matches_negative_refspec\n - config: fix a leak in git_config_copy_or_rename_section_in_file\n\n Leakfixes (subset)\n\n Will merge to 'next'.\n source: <9eb931e7-dd18-8ce8-4d4a-cf3d85066189@gmail.com>\n\n\n* rs/run-command-exec-error-on-noent (2023-06-12) 2 commits\n - run-command: report exec error even on ENOENT\n - t1800: loosen matching of error message for bad shebang\n\n Simplify error message when run-command fails to start a command.\n\n Will merge to 'next'.\n source: <14e1be60-3765-0ba5-00f5-2848bb57bf53@web.de>\n\n\n* sl/worktree-sparse (2023-06-12) 1 commit\n - worktree: integrate with sparse-index\n\n \"git worktree\" learned to work better with sparse index feature.\n\n Will merge to 'next'.\n source: <20230606172633.669916-1-cheskaqiqi@gmail.com>\n\n\n* tb/collect-pack-filenames-fix (2023-06-12) 1 commit\n - builtin/repack.c: only collect fully-formed packs\n\n Avoid breakage of \"git pack-objects --cruft\" due to inconsistency\n between the way the code enumerates packfiles in the repository.\n\n Will merge to 'next'?\n source: <20230607101617.ges6tnMry4E52lDGld43QgtNUsIS4YQq6w-t71hEfkQ@z>\n\n\n* tb/open-midx-bitmap-fallback (2023-06-12) 1 commit\n - pack-bitmap.c: gracefully degrade on failure to load MIDX'd pack\n\n Gracefully deal with a stale MIDX file that lists a packfile that\n no longer exists.\n\n Will merge to 'next'.\n source: <f123b68cb8a277fbf105b1789a84b9405a499b79.1686178854.git.me@ttaylorr.com>\n\n\n* tz/lib-gpg-prereq-fix (2023-06-12) 1 commit\n - t/lib-gpg: require GPGSSH for GPGSSH_VERIFYTIME prereq\n\n Test update.\n\n Will merge to 'next'.\n source: <20230606214707.55739-1-tmz@pobox.com>\n\n\n* jk/ci-use-clang-for-sanitizer-jobs (2023-06-03) 3 commits\n  (merged to 'next' on 2023-06-12 at f6d4c5aac6)\n + ci: drop linux-clang job\n + ci: run ASan/UBSan in a single job\n + ci: use clang for ASan/UBSan checks\n\n Clang's sanitizer implementation seems to work better than GCC's.\n\n Will merge to 'master'.\n source: <20230601180220.GA4167745@coredump.intra.peff.net>\n\n\n* jk/log-follow-with-non-literal-pathspec (2023-06-03) 3 commits\n  (merged to 'next' on 2023-06-13 at 6c864e2f8a)\n + diff: detect pathspec magic not supported by --follow\n + diff: factor out --follow pathspec check\n + pathspec: factor out magic-to-name function\n\n \"git [-c log.follow=true] log [--follow] ':(glob)f**'\" used to barf.\n\n Will merge to 'master'.\n source: <20230601173724.GA4158369@coredump.intra.peff.net>\n\n\n* kh/use-default-notes-doc (2023-06-06) 2 commits\n  (merged to 'next' on 2023-06-13 at ebfbf7a376)\n + notes: move the documentation to the struct\n + notes: update documentation for `use_default_notes`\n\n Doc update.\n\n Will merge to 'master'.\n source: <cover.1685958731.git.code@khaugsbakk.name>\n\n\n* ps/cat-file-null-output (2023-06-12) 5 commits\n  (merged to 'next' on 2023-06-14 at f879ffcbf0)\n + cat-file: add option '-Z' that delimits input and output with NUL\n + cat-file: simplify reading from standard input\n + strbuf: provide CRLF-aware helper to read until a specified delimiter\n + t1006: modernize test style to use `test_cmp`\n + t1006: don't strip timestamps from expected results\n\n \"git cat-file --batch\" and friends learned \"-Z\" that uses NUL\n delimiter for both input and output.\n\n Will merge to 'master'.\n source: <cover.1686028409.git.ps@pks.im>\n\n\n* tl/quote-problematic-arg-for-clarity (2023-06-03) 1 commit\n  (merged to 'next' on 2023-06-12 at 68851799e5)\n + surround %s with quotes when failed to lookup commit\n\n Error message fix.\n\n Will merge to 'master'.\n source: <1f7c62a8870433792076fae30d6c4dc4b61a00d8.1685366301.git.dyroneteng@gmail.com>\n\n\n* ds/add-i-color-configuration-fix (2023-06-12) 2 commits\n  (merged to 'next' on 2023-06-14 at 91eec092e0)\n + add: test use of brackets when color is disabled\n + add: check color.ui for interactive add\n\n The reimplemented \"git add -i\" did not honor color.ui configuration.\n\n Will merge to 'master'.\n source: <pull.1541.v2.git.1686061219078.gitgitgadget@gmail.com>\n\n\n* ks/ref-filter-signature (2023-06-06) 2 commits\n - ref-filter: add new \"signature\" atom\n - t/lib-gpg: introduce new prereq GPG2\n\n The \"git for-each-ref\" family of commands learned placeholders\n related to GPG signature verification.\n\n Needs review.\n source: <20230604185815.15761-1-five231003@gmail.com>\n\n\n* mh/commit-reach-get-reachable-plug-leak (2023-06-04) 1 commit\n  (merged to 'next' on 2023-06-12 at 7c58973941)\n + commit-reach: fix memory leak in get_reachable_subset()\n\n Plug memory leak.\n\n Will merge to 'master'.\n source: <20230603002819.1122129-1-mh@glandium.org>\n\n\n* ds/disable-replace-refs (2023-06-12) 3 commits\n  (merged to 'next' on 2023-06-14 at 82ba5a6ffa)\n + repository: create read_replace_refs setting\n + replace-objects: create wrapper around setting\n + repository: create disable_replace_refs()\n (this branch uses tb/pack-bitmap-traversal-with-boundary.)\n\n Introduce a mechanism to disable replace refs globally and per\n repository.\n\n Will merge to 'master'.\n source: <pull.1537.v3.git.1686057877.gitgitgadget@gmail.com>\n\n\n* tz/test-fix-pthreads-prereq (2023-05-26) 1 commit\n  (merged to 'next' on 2023-06-12 at 82d9529f2c)\n + trace2 tests: fix PTHREADS prereq\n\n Test fix.\n\n Will merge to 'master'.\n source: <20230525031218.3554586-1-tmz@pobox.com>\n\n\n* tz/test-ssh-verifytime-fix (2023-05-26) 1 commit\n  (merged to 'next' on 2023-06-12 at 3abad605d6)\n + t/lib-gpg: fix ssh-keygen -Y check-novalidate with openssh-9.0\n\n Test fix.\n\n Will merge to 'master'.\n source: <20230525031026.3554406-1-tmz@pobox.com>\n\n\n* vd/worktree-config-is-per-repository (2023-05-26) 3 commits\n  (merged to 'next' on 2023-06-13 at 339d281663)\n + repository: move 'repository_format_worktree_config' to repo scope\n + config: pass 'repo' directly to 'config_with_options()'\n + config: use gitdir to get worktree config\n\n The value of config.worktree is per-repository, but has been kept\n in a singleton global variable per process. This has been OK as\n most Git operations interacted with a single repository at a time,\n but not right for operations like recursive \"grep\" that want to\n access multiple repositories from a single process without forking.\n\n The global variable has been eliminated and made into a member in\n the per-repository data structure.\n\n Will merge to 'master'.\n cf. <3145f4f3-7bd4-8a1b-4943-11b7d22b60c6@github.com>\n cf. <kl6lr0qwno2q.fsf@chooglen-macbookpro.roam.corp.google.com>\n source: <pull.1536.v2.git.1685064781.gitgitgadget@gmail.com>\n\n\n* tb/submodule-null-deref-fix (2023-05-25) 1 commit\n  (merged to 'next' on 2023-06-13 at 5eb6a7948d)\n + builtin/submodule--helper.c: handle missing submodule URLs\n\n \"git submodule\" code trusted the data coming from the config (and\n the in-tree .gitmodules file) too much without validating, leading\n to NULL dereference if the user mucks with a repository (e.g.\n submodule.<name>.url is removed).  This has been corrected.\n\n Will merge to 'master'.\n source: <ae6cf3fa461b85e346f034371dae56a2790dfa20.1684957882.git.me@ttaylorr.com>\n\n\n* jc/test-modernization-2 (2023-05-23) 10 commits\n  (merged to 'next' on 2023-06-13 at e3ab8eea9a)\n + t9400-git-cvsserver-server: modernize test format\n + t9200-git-cvsexportcommit: modernize test format\n + t9104-git-svn-follow-parent: modernize test format\n + t9100-git-svn-basic: modernize test format\n + t7700-repack: modernize test format\n + t7600-merge: modernize test format\n + t7508-status: modernize test format\n + t7201-co: modernize test format\n + t7111-reset-table: modernize test format\n + t7110-reset-merge: modernize test format\n (this branch uses jc/test-modernization.)\n\n Test style updates.\n\n Will merge to 'master'.\n source: <pull.1514.git.git.1684599239.gitgitgadget@gmail.com>\n\n\n* jt/path-filter-fix (2023-06-13) 4 commits\n - commit-graph: new filter ver. that fixes murmur3\n - repo-settings: introduce commitgraph.changedPathsVersion\n - t4216: test changed path filters with high bit paths\n - gitformat-commit-graph: describe version 2 of BDAT\n\n The Bloom filter used for path limited history traversal was broken\n on systems whose \"char\" is unsigned; update the implementation and\n bump the format version to 2.\n\n Will merge to 'next'?\n source: <cover.1686677910.git.jonathantanmy@google.com>\n\n\n* tk/cherry-pick-sequence-requires-clean-worktree (2023-06-01) 1 commit\n - cherry-pick: refuse cherry-pick sequence if index is dirty\n\n \"git cherry-pick A\" that replays a single commit stopped before\n clobbering local modification, but \"git cherry-pick A..B\" did not,\n which has been corrected.\n\n Expecting a reroll.\n cf. <999f12b2-38d6-f446-e763-4985116ad37d@gmail.com>\n source: <pull.1535.v2.git.1685264889088.gitgitgadget@gmail.com>\n\n\n* mh/credential-libsecret-attrs (2023-05-17) 1 commit\n - credential/libsecret: store new attributes\n\n The way authentication related data other than passwords (e.g.\n oath token and password expiration data) are stored in libsecret\n keyrings has been rethought.\n\n Needs review.\n source: <pull.1469.v4.git.git.1684306540947.gitgitgadget@gmail.com>\n\n\n* ps/fetch-cleanups (2023-05-17) 9 commits\n  (merged to 'next' on 2023-06-12 at d15d335893)\n + fetch: use `fetch_config` to store \"submodule.fetchJobs\" value\n + fetch: use `fetch_config` to store \"fetch.parallel\" value\n + fetch: use `fetch_config` to store \"fetch.recurseSubmodules\" value\n + fetch: use `fetch_config` to store \"fetch.showForcedUpdates\" value\n + fetch: use `fetch_config` to store \"fetch.pruneTags\" value\n + fetch: use `fetch_config` to store \"fetch.prune\" value\n + fetch: pass through `fetch_config` directly\n + fetch: drop unneeded NULL-check for `remote_ref`\n + fetch: drop unused DISPLAY_FORMAT_UNKNOWN enum value\n\n Code clean-up.\n\n Will merge to 'master'.\n cf. <20230519002128.GD2442034@coredump.intra.peff.net>\n source: <cover.1684324059.git.ps@pks.im>\n\n\n* jc/test-modernization (2023-05-19) 20 commits\n  (merged to 'next' on 2023-06-13 at a61e7b7248)\n + t7101-reset-empty-subdirs: modernize test format\n + t6050-replace: modernize test format\n + t5306-pack-nobase: modernize test format\n + t5303-pack-corruption-resilience: modernize test format\n + t5301-sliding-window: modernize test format\n + t5300-pack-object: modernize test format\n + t4206-log-follow-harder-copies: modernize test format\n + t4202-log: modernize test format\n + t4004-diff-rename-symlink: modernize test format\n + t4003-diff-rename-1: modernize test format\n + t4002-diff-basic: modernize test format\n + t3903-stash: modernize test format\n + t3700-add: modernize test format\n + t3500-cherry: modernize test format\n + t1006-cat-file: modernize test format\n + t1002-read-tree-m-u-2way: modernize test format\n + t1001-read-tree-m-2way: modernize test format\n + t3210-pack-refs: modernize test format\n + t0030-stripspace: modernize test format\n + t0000-basic: modernize test format\n (this branch is used by jc/test-modernization-2.)\n\n Will merge to 'master'.\n source: <pull.1513.git.git.1684440205.gitgitgadget@gmail.com>\n\n\n* ja/worktree-orphan (2023-05-17) 8 commits\n  (merged to 'next' on 2023-06-14 at 25d508496b)\n + worktree add: emit warn when there is a bad HEAD\n + worktree add: extend DWIM to infer --orphan\n + worktree add: introduce \"try --orphan\" hint\n + worktree add: add --orphan flag\n + t2400: add tests to verify --quiet\n + t2400: refactor \"worktree add\" opt exclusion tests\n + t2400: cleanup created worktree in test\n + worktree add: include -B in usage docs\n\n 'git worktree add' learned how to create a worktree based on an\n orphaned branch with `--orphan`.\n\n Will merge to 'master'.\n source: <20230517214711.12467-1-jacobabel@nullpo.dev>\n\n\n* tb/refs-exclusion-and-packed-refs (2023-06-12) 16 commits\n - ls-refs.c: avoid enumerating hidden refs where possible\n - upload-pack.c: avoid enumerating hidden refs where possible\n - builtin/receive-pack.c: avoid enumerating hidden references\n - refs.h: let `for_each_namespaced_ref()` take excluded patterns\n - refs/packed-backend.c: ignore complicated hidden refs rules\n - revision.h: store hidden refs in a `strvec`\n - refs/packed-backend.c: add trace2 counters for jump list\n - refs/packed-backend.c: implement jump lists to avoid excluded pattern(s)\n - refs/packed-backend.c: refactor `find_reference_location()`\n - refs: plumb `exclude_patterns` argument throughout\n - builtin/for-each-ref.c: add `--exclude` option\n - ref-filter.c: parameterize match functions over patterns\n - ref-filter: add `ref_filter_clear()`\n - ref-filter: clear reachable list pointers after freeing\n - ref-filter.h: provide `REF_FILTER_INIT`\n - refs.c: rename `ref_filter`\n\n Enumerating refs in the packed-refs file, while excluding refs that\n match certain patterns, has been optimized.\n source: <cover.1686134440.git.me@ttaylorr.com>\n\n\n* en/header-split-cache-h-part-3 (2023-05-16) 29 commits\n  (merged to 'next' on 2023-06-13 at 56bcca52ac)\n + fsmonitor-ll.h: split this header out of fsmonitor.h\n + hash-ll, hashmap: move oidhash() to hash-ll\n + object-store-ll.h: split this header out of object-store.h\n + khash: name the structs that khash declares\n + merge-ll: rename from ll-merge\n + git-compat-util.h: remove unneccessary include of wildmatch.h\n + builtin.h: remove unneccessary includes\n + list-objects-filter-options.h: remove unneccessary include\n + diff.h: remove unnecessary include of oidset.h\n + repository: remove unnecessary include of path.h\n + log-tree: replace include of revision.h with simple forward declaration\n + cache.h: remove this no-longer-used header\n + read-cache*.h: move declarations for read-cache.c functions from cache.h\n + repository.h: move declaration of the_index from cache.h\n + merge.h: move declarations for merge.c from cache.h\n + diff.h: move declaration for global in diff.c from cache.h\n + preload-index.h: move declarations for preload-index.c from elsewhere\n + sparse-index.h: move declarations for sparse-index.c from cache.h\n + name-hash.h: move declarations for name-hash.c from cache.h\n + run-command.h: move declarations for run-command.c from cache.h\n + statinfo: move stat_{data,validity} functions from cache/read-cache\n + read-cache: move shared add/checkout/commit code\n + add: modify add_files_to_cache() to avoid globals\n + read-cache: move shared commit and ls-files code\n + setup: adopt shared init-db & clone code\n + init-db, clone: change unnecessary global into passed parameter\n + init-db: remove unnecessary global variable\n + init-db: document existing bug with core.bare in template config\n + Merge branch 'en/header-split-cache-h-part-2' into en/header-split-cache-h-part-3\n\n Header files cleanup.\n\n Will merge to 'master'.\n source: <pull.1525.v3.git.1684218848.gitgitgadget@gmail.com>\n\n\n* la/doc-interpret-trailers (2023-06-12) 9 commits\n  (merged to 'next' on 2023-06-14 at 64a59e71b3)\n + doc: trailer: add more examples in DESCRIPTION\n + doc: trailer: mention 'key' in DESCRIPTION\n + doc: trailer.<token>.command: emphasize deprecation\n + doc: trailer: use angle brackets for <token> and <value>\n + doc: trailer: remove redundant phrasing\n + doc: trailer: examples: avoid the word \"message\" by itself\n + doc: trailer: drop \"commit message part\" phrasing\n + doc: trailer: swap verb order\n + doc: trailer: fix grammar\n\n Doc update.\n\n Will merge to 'master'.\n source: <pull.1506.v3.git.git.1686017304.gitgitgadget@gmail.com>\n\n\n* cc/git-replay (2023-06-03) 15 commits\n - replay: stop assuming replayed branches do not diverge\n - replay: add --contained to rebase contained branches\n - replay: add --advance or 'cherry-pick' mode\n - replay: disallow revision specific options and pathspecs\n - replay: use standard revision ranges\n - replay: make it a minimal server side command\n - replay: remove HEAD related sanity check\n - replay: remove progress and info output\n - replay: add an important FIXME comment about gpg signing\n - replay: don't simplify history\n - replay: introduce pick_regular_commit()\n - replay: die() instead of failing assert()\n - replay: start using parse_options API\n - replay: introduce new builtin\n - t6429: remove switching aspects of fast-rebase\n\n source: <20230602102533.876905-1-christian.couder@gmail.com>\n\n\n* tb/gc-recent-object-hook (2023-06-12) 2 commits\n - gc: introduce `gc.recentObjectsHook`\n - reachable.c: extract `obj_is_recent()`\n\n \"git pack-objects\" learned to invoke a new hook program that\n enumerates extra objects to be used as anchoring points to keep\n otherwise unreachable objects in cruft packs.\n\n Will merge to 'next'.\n source: <cover.1686178684.git.me@ttaylorr.com>\n\n\n* ob/revert-of-revert (2023-05-05) 1 commit\n - sequencer: beautify subject of reverts of reverts\n\n Instead of \"Revert \"Revert \"original\"\", give \"Reapply \"original\"\"\n as the title for a revert of a revert.\n\n Expecting a hopefully final reroll.\n Looking much better, except for minor cosmetic issues.\n source: <20230428083528.1699221-1-oswald.buddenhagen@gmx.de>\n\n\n* cw/strbuf-cleanup (2023-06-12) 7 commits\n - strbuf: remove global variable\n - path: move related function to path\n - object-name: move related functions to object-name\n - credential-store: move related functions to credential-store file\n - abspath: move related functions to abspath\n - strbuf: clarify dependency\n - strbuf: clarify API boundary\n\n Move functions that are not about pure string manipulation out of\n strbuf.[ch]\n source: <20230606194720.2053551-1-calvinwan@google.com>\n\n\n* tl/notes-separator (2023-04-28) 6 commits\n  (merged to 'next' on 2023-05-06 at 598ed19c9b)\n + notes.c: introduce \"--[no-]stripspace\" option\n + notes.c: append separator instead of insert by pos\n + notes.c: introduce '--separator=<paragraph-break>' option\n + t3321: add test cases about the notes stripspace behavior\n + notes.c: use designated initializers for clarity\n + notes.c: cleanup 'strbuf_grow' call in 'append_edit'\n (this branch is used by jc/notes-separator-fix.)\n\n 'git notes append' was taught '--separator' to specify string to insert\n between paragraphs.\n\n Will merge to 'next' together with its fix-up.\n source: <cover.1682671758.git.dyroneteng@gmail.com>\n\n\n* pw/rebase-i-after-failure (2023-04-21) 6 commits\n - rebase -i: fix adding failed command to the todo list\n - rebase: fix rewritten list for failed pick\n - rebase --continue: refuse to commit after failed command\n - sequencer: factor out part of pick_commits()\n - rebase -i: remove patch file after conflict resolution\n - rebase -i: move unlink() calls\n\n Various fixes to the behaviour of \"rebase -i\" when the command got\n interrupted by conflicting changes.\n\n Expecting a reroll.\n cf. <xmqqsfcthrpb.fsf@gitster.g>\n cf. <1fd54422-b66a-c2e4-7cd7-934ea01190ad@gmail.com>\n source: <pull.1492.v2.git.1682089074.gitgitgadget@gmail.com>\n\n\n* tb/pack-bitmap-traversal-with-boundary (2023-05-08) 3 commits\n + pack-bitmap.c: use commit boundary during bitmap traversal\n + pack-bitmap.c: extract `fill_in_bitmap()`\n + object: add object_array initializer helper function\n (this branch is used by ds/disable-replace-refs.)\n\n The object traversal using reachability bitmap done by\n \"pack-object\" has been tweaked to take advantage of the fact that\n using \"boundary\" commits as representative of all the uninteresting\n ones can save quite a lot of object enumeration.\n\n Will merge to 'next'.\n source: <cover.1683567065.git.me@ttaylorr.com>\n\n\n* pb/complete-and-document-auto-merge-and-friends (2023-05-23) 6 commits\n  (merged to 'next' on 2023-06-13 at 46ca10d88d)\n + completion: complete AUTO_MERGE\n + Documentation: document AUTO_MERGE\n + git-merge.txt: modernize word choice in \"True merge\" section\n + completion: complete REVERT_HEAD and BISECT_HEAD\n + revisions.txt: document more special refs\n + revisions.txt: use description list for special refs\n\n Document more pseudo-refs and teach the command line completion\n machinery to complete AUTO_MERGE.\n\n Will merge to 'master'.\n source: <pull.1515.v2.git.1684783741.gitgitgadget@gmail.com>\n\n\n* mh/credential-password-expiry-libsecret (2023-05-05) 1 commit\n  (merged to 'next' on 2023-05-09 at fd898e3756)\n + credential/libsecret: support password_expiry_utc\n\n The libsecret credential helper learns to handle the password\n expiry time information.\n\n On hold.\n The database gets littered with entries whose expiration dates only differ.\n cf. <CAGJzqskMwOJkriH6serqdwAVYi+fftEL8ohJd-suP6v+OxB_bg@mail.gmail.com>\n source: <pull.1469.v3.git.git.1683270298313.gitgitgadget@gmail.com>\n"},{"id":"478423","messageId":"owlya5x1o20r.fsf@fine.c.googlers.com","threadId":"59869","inReplyTo":"xmqqedmdwput.fsf@gitster.g","subject":"Re: What's cooking in git.git (Jun 2023, #04; Wed, 14)","fromName":"Linus Arver","fromEmail":"linusa@google.com","sentAt":"2023-06-15T03:08:52Z","receivedAt":"2023-06-15T03:09:03Z","isPatch":false,"sender":{"key":"linus@ucla.edu","avatar":null},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> * la/docs-typofixes (2023-06-12) 1 commit\n>   - docs: typofixes\n\n>   Typofixes.\n\n>   Will merge to 'next'.\n>   source: <pull.1542.v2.git.1686166007816.gitgitgadget@gmail.com>\n\nI am in the middle of addressing some review comments and have rerolled\nto v4 [1] for the time being.\n\n[1]  \nhttps://lore.kernel.org/git/pull.1506.v4.git.git.1686797630.gitgitgadget@gmail.com/\n"},{"id":"478441","messageId":"owly7cs4oe4g.fsf@fine.c.googlers.com","threadId":"59869","inReplyTo":"owlya5x1o20r.fsf@fine.c.googlers.com","subject":"Re: What's cooking in git.git (Jun 2023, #04; Wed, 14)","fromName":"Linus Arver","fromEmail":"linusa@google.com","sentAt":"2023-06-15T16:59:43Z","receivedAt":"2023-06-15T17:00:29Z","isPatch":false,"sender":{"key":"linus@ucla.edu","avatar":null},"body":"Linus Arver <linusa@google.com> writes:\n\n> Junio C Hamano <gitster@pobox.com> writes:\n\n>> * la/docs-typofixes (2023-06-12) 1 commit\n>>    - docs: typofixes\n\n>>    Typofixes.\n\n>>    Will merge to 'next'.\n>>    source: <pull.1542.v2.git.1686166007816.gitgitgadget@gmail.com>\n\n> I am in the middle of addressing some review comments and have rerolled\n> to v4 [1] for the time being.\n\n> [1]\n> https://lore.kernel.org/git/pull.1506.v4.git.git.1686797630.gitgitgadget@gmail.com/\n\nv4 has been LGTM'd [1].\n\n[1]  \nhttps://lore.kernel.org/git/CAP8UFD3ryDoewoKnSWQcXE2H7OFn6aqK-D6Gjav=qXFGmUnHLw@mail.gmail.com/\n"},{"id":"478530","messageId":"ZJCI6FHtbuOKPlV1@nand.local","threadId":"59869","inReplyTo":"xmqqedmdwput.fsf@gitster.g","subject":"Re: What's cooking in git.git (Jun 2023, #04; Wed, 14)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-06-19T16:57:12Z","receivedAt":"2023-06-19T16:57:35Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Junio,\n\nI am back from a week off, and wanted to give an update on the status of\nmy outstanding topics. I'll be off next week, too, and then back on July\n5th onward.\n\nI plan on getting all of the ones with outstanding review comments\nreplied to and/or rerolled tomorrow.\n\nOn Wed, Jun 14, 2023 at 05:06:50PM -0700, Junio C Hamano wrote:\n> * tb/pack-bitmap-index-seek (2023-03-20) 6 commits\n>  - pack-bitmap.c: factor out `bitmap_index_seek_commit()`\n>  - pack-bitmap.c: use `bitmap_index_seek()` where possible\n>  - pack-bitmap.c: factor out manual `map_pos` manipulation\n>  - pack-bitmap.c: drop unnecessary 'inline's\n>  - pack-bitmap.c: hide bitmap internals in `read_be32()`\n>  - pack-bitmap.c: hide bitmap internals in `read_u8()`\n>\n>  Clean-up the pack-bitmap codepath.\n>\n>  Kicked back to 'seen' out of 'next'.\n>  There is a BUG() on data errors that needs to be fixed.\n>  source: <cover.1679342296.git.me@ttaylorr.com>\n\nLet's discard this one for now. It's not super high up on my to-do list\nand it's not worth the burden of carrying in 'seen'.\n\n> * tb/collect-pack-filenames-fix (2023-06-12) 1 commit\n>  - builtin/repack.c: only collect fully-formed packs\n>\n>  Avoid breakage of \"git pack-objects --cruft\" due to inconsistency\n>  between the way the code enumerates packfiles in the repository.\n>\n>  Will merge to 'next'?\n>  source: <20230607101617.ges6tnMry4E52lDGld43QgtNUsIS4YQq6w-t71hEfkQ@z>\n\nYes, this one is ready to go (and has been running at GitHub for a week\nor so, for what that's worth ;-)).\n\n> * tb/open-midx-bitmap-fallback (2023-06-12) 1 commit\n>  - pack-bitmap.c: gracefully degrade on failure to load MIDX'd pack\n>\n>  Gracefully deal with a stale MIDX file that lists a packfile that\n>  no longer exists.\n>\n>  Will merge to 'next'.\n>  source: <f123b68cb8a277fbf105b1789a84b9405a499b79.1686178854.git.me@ttaylorr.com>\n\nThanks. I am somewhat embarrassed to have not caught that when writing\nit, but better late than never.\n\n> * tb/submodule-null-deref-fix (2023-05-25) 1 commit\n>   (merged to 'next' on 2023-06-13 at 5eb6a7948d)\n>  + builtin/submodule--helper.c: handle missing submodule URLs\n>\n>  \"git submodule\" code trusted the data coming from the config (and\n>  the in-tree .gitmodules file) too much without validating, leading\n>  to NULL dereference if the user mucks with a repository (e.g.\n>  submodule.<name>.url is removed).  This has been corrected.\n>\n>  Will merge to 'master'.\n>  source: <ae6cf3fa461b85e346f034371dae56a2790dfa20.1684957882.git.me@ttaylorr.com>\n\nThanks for picking this one back up post-release.\n\n> * tb/refs-exclusion-and-packed-refs (2023-06-12) 16 commits\n>  - ls-refs.c: avoid enumerating hidden refs where possible\n>  - upload-pack.c: avoid enumerating hidden refs where possible\n>  - builtin/receive-pack.c: avoid enumerating hidden references\n>  - refs.h: let `for_each_namespaced_ref()` take excluded patterns\n>  - refs/packed-backend.c: ignore complicated hidden refs rules\n>  - revision.h: store hidden refs in a `strvec`\n>  - refs/packed-backend.c: add trace2 counters for jump list\n>  - refs/packed-backend.c: implement jump lists to avoid excluded pattern(s)\n>  - refs/packed-backend.c: refactor `find_reference_location()`\n>  - refs: plumb `exclude_patterns` argument throughout\n>  - builtin/for-each-ref.c: add `--exclude` option\n>  - ref-filter.c: parameterize match functions over patterns\n>  - ref-filter: add `ref_filter_clear()`\n>  - ref-filter: clear reachable list pointers after freeing\n>  - ref-filter.h: provide `REF_FILTER_INIT`\n>  - refs.c: rename `ref_filter`\n>\n>  Enumerating refs in the packed-refs file, while excluding refs that\n>  match certain patterns, has been optimized.\n>  source: <cover.1686134440.git.me@ttaylorr.com>\n\nThanks for your review on this one. I am just getting back from a week\nof vacation (and then off again next week, then back in early July). I\nhad intended to respond to your review today, but I didn't quite get to\nit today.\n\nOn my list for tomorrow, hopefully the rerolled version should be ready\nto pick up.\n\n> * tb/gc-recent-object-hook (2023-06-12) 2 commits\n>  - gc: introduce `gc.recentObjectsHook`\n>  - reachable.c: extract `obj_is_recent()`\n>\n>  \"git pack-objects\" learned to invoke a new hook program that\n>  enumerates extra objects to be used as anchoring points to keep\n>  otherwise unreachable objects in cruft packs.\n>\n>  Will merge to 'next'.\n>  source: <cover.1686178684.git.me@ttaylorr.com>\n\nThanks.\n\n> * tb/pack-bitmap-traversal-with-boundary (2023-05-08) 3 commits\n>  + pack-bitmap.c: use commit boundary during bitmap traversal\n>  + pack-bitmap.c: extract `fill_in_bitmap()`\n>  + object: add object_array initializer helper function\n>  (this branch is used by ds/disable-replace-refs.)\n>\n>  The object traversal using reachability bitmap done by\n>  \"pack-object\" has been tweaked to take advantage of the fact that\n>  using \"boundary\" commits as representative of all the uninteresting\n>  ones can save quite a lot of object enumeration.\n>\n>  Will merge to 'next'.\n>  source: <cover.1683567065.git.me@ttaylorr.com>\n\nThanks on this one, too.\n\nThanks,\nTaylor\n"}]}