{"thread":{"id":"59856","subject":"Re: [PATCH] builtin/repack.c: only collect fully-formed packs","startedAt":"2023-06-12T21:04:24Z","lastAt":"2023-06-12T21:04:24Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"478302","messageId":"xmqq4jnc9z16.fsf@gitster.g","threadId":"59856","inReplyTo":"20230607101617.ges6tnMry4E52lDGld43QgtNUsIS4YQq6w-t71hEfkQ@z","subject":"Re: [PATCH] builtin/repack.c: only collect fully-formed packs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-06-12T21:00:21Z","receivedAt":"2023-06-12T21:04:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau <me@ttaylorr.com> writes:\n\n> Fix the above by teaching `collect_pack_filenames()` to only collect\n> packs with their corresponding `*.idx` files in place, indicating that\n> those packs have been fully staged.\n\nHmph, after following the problem description (which by the way was\nvery well written), I expected to see \"collect_pack_filenames() is\ntaught to use get_all_packs() and then enumerate the names from the\nin-core packed_git structures---this way there is no possibility for\nthe two methods to produce inconsistent results\".\n\nBut that is not what is going on.  Rather, it is \"we still keep\nusing a separate readdir() loop, but made sure that the criteria to\ninclude a packfile in the result is identical to the logic currently\nused by the other function\", whose implication is that they can\ndiverge again.  I am somewhat puzzled.\n\nWill queue.  Thanks.\n"}]}