{"thread":{"id":"59791","subject":"[PATCH] trace2 tests: fix PTHREADS prereq","startedAt":"2023-05-25T03:12:38Z","lastAt":"2023-05-26T04:52:48Z","messageCount":2,"participants":["Todd Zullinger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"477710","messageId":"20230525031218.3554586-1-tmz@pobox.com","threadId":"59791","inReplyTo":null,"subject":"[PATCH] trace2 tests: fix PTHREADS prereq","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2023-05-25T03:12:07Z","receivedAt":"2023-05-25T03:12:38Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"The prereq guard added in 14903c8e92 (trace2 tests: guard pthread test\nwith \"PTHREAD\", 2022-11-24) lacks the S in PTHREADS, causing it to never\nbe satisfied.  Fix the spelling of the prereq.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\n t/t0211-trace2-perf.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\nindex b4e9135118..cfba686132 100755\n--- a/t/t0211-trace2-perf.sh\n+++ b/t/t0211-trace2-perf.sh\n@@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' '\n \thave_timer_event \"main\" \"timer\" \"test\" \"test1\" 5 actual\n '\n \n-test_expect_success PTHREAD 'stopwatch timer test/test2' '\n+test_expect_success PTHREADS 'stopwatch timer test/test2' '\n \ttest_when_finished \"rm trace.perf actual\" &&\n \ttest_config_global trace2.perfBrief 1 &&\n \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n@@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' '\n \thave_counter_event \"main\" \"counter\" \"test\" \"test1\" 15 actual\n '\n \n-test_expect_success PTHREAD 'global counter test/test2' '\n+test_expect_success PTHREADS 'global counter test/test2' '\n \ttest_when_finished \"rm trace.perf actual\" &&\n \ttest_config_global trace2.perfBrief 1 &&\n \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n"},{"id":"477729","messageId":"xmqqo7m7elt2.fsf@gitster.g","threadId":"59791","inReplyTo":"20230525031218.3554586-1-tmz@pobox.com","subject":"Re: [PATCH] trace2 tests: fix PTHREADS prereq","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-05-26T04:52:41Z","receivedAt":"2023-05-26T04:52:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> The prereq guard added in 14903c8e92 (trace2 tests: guard pthread test\n> with \"PTHREAD\", 2022-11-24) lacks the S in PTHREADS, causing it to never\n> be satisfied.  Fix the spelling of the prereq.\n\nNice spootting.  Thanks.\n"}]}