{"thread":{"id":"59748","subject":"[BUG_REPORT] `git submodule update` segfaults","startedAt":"2023-05-16T08:23:44Z","lastAt":"2023-05-16T08:23:44Z","messageCount":1,"participants":["Tribo Dar"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"477380","messageId":"CACJVABb6s+dH8CPs1-OGgwRwgyRRSMnenLCenBScis=ADUUuDA@mail.gmail.com","threadId":"59748","inReplyTo":null,"subject":"[BUG_REPORT] `git submodule update` segfaults","fromName":"Tribo Dar","fromEmail":"3bodar@gmail.com","sentAt":"2023-05-16T08:23:29Z","receivedAt":"2023-05-16T08:23:44Z","isPatch":false,"sender":{"key":"3bodar@gmail.com","avatar":null},"body":"What did you do before the bug happened? (Steps to reproduce your issue)\nRan `git submodule update` after commenting out the url field in both\n.gitmodules and the corresponding section for the submodule in .git/config.\n\nWhat did you expect to happen? (Expected behavior)\nGraceful handling of the situation.\n\nWhat happened instead? (Actual behavior)\nSegmentation fault.\n\nAnything else you want to add:\nThe segfault results from `sub->url` being NULL here (actual segfault\ncomes a couple calls further):\nhttps://github.com/git/git/blob/0df2c180904f6b709766f9c24669a9d01543f915/builtin/submodule--helper.c#LL2027C1-L2027C1\n\nPossibly relevant: a similar snippet being properly protected against\nnull-pointer dereferencing:\nhttps://github.com/git/git/blob/0df2c180904f6b709766f9c24669a9d01543f915/builtin/submodule--helper.c#L1243\n"}]}