{"thread":{"id":"59740","subject":"[PATCH] doc/git-config: add unit for http.lowSpeedLimit","startedAt":"2023-05-13T09:30:11Z","lastAt":"2023-05-15T07:03:11Z","messageCount":2,"participants":["Corentin Garcia via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"477254","messageId":"pull.1507.git.git.1683970203084.gitgitgadget@gmail.com","threadId":"59740","inReplyTo":null,"subject":"[PATCH] doc/git-config: add unit for http.lowSpeedLimit","fromName":"Corentin Garcia via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-05-13T09:30:02Z","receivedAt":"2023-05-13T09:30:11Z","isPatch":true,"sender":{"key":"name:Corentin Garcia","avatar":null},"body":"From: Corentin Garcia <corenting@gmail.com>\n\nAdd the unit (bytes per second) for http.lowSpeedLimit\nin the documentation.\n\nSigned-off-by: Corentin Garcia <corenting@gmail.com>\n---\n    doc/git-config: add unit for http.lowSpeedLimit\n    \n    Add the unit (bytes per second) for http.lowSpeedLimit in the\n    documentation.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1507%2Fcorenting%2Fmaster-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1507/corenting/master-v1\nPull-Request: https://github.com/git/git/pull/1507\n\n Documentation/config/http.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/config/http.txt b/Documentation/config/http.txt\nindex afeeccfbfa7..51a70781e58 100644\n--- a/Documentation/config/http.txt\n+++ b/Documentation/config/http.txt\n@@ -246,8 +246,9 @@ significantly since the entire buffer is allocated even for small\n pushes.\n \n http.lowSpeedLimit, http.lowSpeedTime::\n-\tIf the HTTP transfer speed is less than 'http.lowSpeedLimit'\n-\tfor longer than 'http.lowSpeedTime' seconds, the transfer is aborted.\n+\tIf the HTTP transfer speed, in bytes per second, is less than\n+\t'http.lowSpeedLimit' for longer than 'http.lowSpeedTime' seconds,\n+\tthe transfer is aborted.\n \tCan be overridden by the `GIT_HTTP_LOW_SPEED_LIMIT` and\n \t`GIT_HTTP_LOW_SPEED_TIME` environment variables.\n \n\nbase-commit: 5597cfdf47db94825213fefe78c4485e6a5702d8\n-- \ngitgitgadget\n"},{"id":"477276","messageId":"xmqqy1lq9iwc.fsf@gitster.g","threadId":"59740","inReplyTo":"pull.1507.git.git.1683970203084.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc/git-config: add unit for http.lowSpeedLimit","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-05-15T07:02:43Z","receivedAt":"2023-05-15T07:03:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Corentin Garcia via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Corentin Garcia <corenting@gmail.com>\n>\n> Add the unit (bytes per second) for http.lowSpeedLimit\n> in the documentation.\n>\n> Signed-off-by: Corentin Garcia <corenting@gmail.com>\n> ---\n\nSOunds good.\n\n>     doc/git-config: add unit for http.lowSpeedLimit\n>     \n>     Add the unit (bytes per second) for http.lowSpeedLimit in the\n>     documentation.\n\nYou do not have to repeat your log message here.\n\n> diff --git a/Documentation/config/http.txt b/Documentation/config/http.txt\n> index afeeccfbfa7..51a70781e58 100644\n> --- a/Documentation/config/http.txt\n> +++ b/Documentation/config/http.txt\n> @@ -246,8 +246,9 @@ significantly since the entire buffer is allocated even for small\n>  pushes.\n>  \n>  http.lowSpeedLimit, http.lowSpeedTime::\n> -\tIf the HTTP transfer speed is less than 'http.lowSpeedLimit'\n> -\tfor longer than 'http.lowSpeedTime' seconds, the transfer is aborted.\n> +\tIf the HTTP transfer speed, in bytes per second, is less than\n> +\t'http.lowSpeedLimit' for longer than 'http.lowSpeedTime' seconds,\n> +\tthe transfer is aborted.\n>  \tCan be overridden by the `GIT_HTTP_LOW_SPEED_LIMIT` and\n>  \t`GIT_HTTP_LOW_SPEED_TIME` environment variables.\n\nAs the variable is read with git_config_int(), this also allows the\nusual k/m/g suffix to scale, i.e. specifying it to 500k would mean\n500*1024 bytes.  I wonder if that is also worth documenting, or it\nis too obvious.\n\nLet's queue this patch as-is.  If somebody wants to elaborate on how\nthe numbers can be spelled, that can be done in a separate patch.\n\nThanks.\n\n"}]}