{"thread":{"id":"59716","subject":"[PATCH] test: rev-parse-upstream: add missing cmp","startedAt":"2023-05-09T00:02:51Z","lastAt":"2023-05-10T04:00:01Z","messageCount":2,"participants":["Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"476847","messageId":"20230509000246.1760327-1-felipe.contreras@gmail.com","threadId":"59716","inReplyTo":null,"subject":"[PATCH] test: rev-parse-upstream: add missing cmp","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2023-05-09T00:02:46Z","receivedAt":"2023-05-09T00:02:51Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"It seems pretty clear 5236fce6b4 (t1507: stop losing return codes of git\ncommands, 2019-12-20) missed a test_cmp.\n\nCc: Denton Liu <liu.denton@gmail.com>\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n t/t1507-rev-parse-upstream.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t1507-rev-parse-upstream.sh b/t/t1507-rev-parse-upstream.sh\nindex d94c72c672..cb9ef7e329 100755\n--- a/t/t1507-rev-parse-upstream.sh\n+++ b/t/t1507-rev-parse-upstream.sh\n@@ -97,7 +97,8 @@ test_expect_success 'my-side@{u} resolves to correct commit' '\n \tcommit_subject my-side >actual &&\n \ttest_cmp expect actual &&\n \techo 5 >expect &&\n-\tcommit_subject my-side@{u} >actual\n+\tcommit_subject my-side@{u} >actual &&\n+\ttest_cmp expect actual\n '\n \n test_expect_success 'not-tracking@{u} fails' '\n-- \n2.40.0+fc1\n\n"},{"id":"476944","messageId":"xmqqpm78zvo0.fsf@gitster.g","threadId":"59716","inReplyTo":"20230509000246.1760327-1-felipe.contreras@gmail.com","subject":"Re: [PATCH] test: rev-parse-upstream: add missing cmp","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-05-10T03:56:31Z","receivedAt":"2023-05-10T04:00:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras <felipe.contreras@gmail.com> writes:\n\n> It seems pretty clear 5236fce6b4 (t1507: stop losing return codes of git\n> commands, 2019-12-20) missed a test_cmp.\n>\n> Cc: Denton Liu <liu.denton@gmail.com>\n> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n> ---\n>  t/t1507-rev-parse-upstream.sh | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/t/t1507-rev-parse-upstream.sh b/t/t1507-rev-parse-upstream.sh\n> index d94c72c672..cb9ef7e329 100755\n> --- a/t/t1507-rev-parse-upstream.sh\n> +++ b/t/t1507-rev-parse-upstream.sh\n> @@ -97,7 +97,8 @@ test_expect_success 'my-side@{u} resolves to correct commit' '\n>  \tcommit_subject my-side >actual &&\n>  \ttest_cmp expect actual &&\n>  \techo 5 >expect &&\n> -\tcommit_subject my-side@{u} >actual\n> +\tcommit_subject my-side@{u} >actual &&\n> +\ttest_cmp expect actual\n>  '\n>  \n>  test_expect_success 'not-tracking@{u} fails' '\n\nGood eyes.\n\na93cbe8d (t1507: assert output of rev-parse, 2023-03-18) and wanted\nto do the same to this script, and the series that contains the\ncommit wanted to do the same to many other test scripts, but it\nseems to have missed this one.\n\nWill queue (on top of a93cbe8d, naturally).\n\nThanks.\n"}]}