{"thread":{"id":"59643","subject":"[PATCH] doc: remove asciidoctor hack","startedAt":"2023-04-24T14:52:25Z","lastAt":"2023-04-24T14:52:25Z","messageCount":1,"participants":["Felipe Contreras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"475919","messageId":"20230424145141.11964-1-felipe.contreras@gmail.com","threadId":"59643","inReplyTo":null,"subject":"[PATCH] doc: remove asciidoctor hack","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2023-04-24T14:51:41Z","receivedAt":"2023-04-24T14:52:25Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"The hack was added in 7a30134358 (asciidoctor-extensions: provide\n`<refmiscinfo/>`, 2019-09-16) in order to deal with the fact that\nasciidoctor doesn't pick up `manversion`, however, we don't require\n`manversion` anymore, since 9a09ed3229 (doc: simplify man version,\n2023-04-07).\n\nSo we can get rid of this hack without any functional changes.\n\nThe caveat is that we now require asciidoctor v1.5.7, which was released\n5 years ago.\n\nCc: Martin Ågren <martin.agren@gmail.com>\nCc: Jeff King <peff@peff.net>\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n Documentation/asciidoctor-extensions.rb | 17 -----------------\n 1 file changed, 17 deletions(-)\n\ndiff --git a/Documentation/asciidoctor-extensions.rb b/Documentation/asciidoctor-extensions.rb\nindex d906a00803..70a0956663 100644\n--- a/Documentation/asciidoctor-extensions.rb\n+++ b/Documentation/asciidoctor-extensions.rb\n@@ -23,26 +23,9 @@ module Git\n         end\n       end\n     end\n-\n-    class DocumentPostProcessor < Asciidoctor::Extensions::Postprocessor\n-      def process document, output\n-        if document.basebackend? 'docbook'\n-          mansource = document.attributes['mansource']\n-          manversion = document.attributes['manversion']\n-          manmanual = document.attributes['manmanual']\n-          new_tags = \"\" \\\n-            \"<refmiscinfo class=\\\"source\\\">#{mansource}</refmiscinfo>\\n\" \\\n-            \"<refmiscinfo class=\\\"version\\\">#{manversion}</refmiscinfo>\\n\" \\\n-            \"<refmiscinfo class=\\\"manual\\\">#{manmanual}</refmiscinfo>\\n\"\n-          output = output.sub(/<\\/refmeta>/, new_tags + \"</refmeta>\")\n-        end\n-        output\n-      end\n-    end\n   end\n end\n \n Asciidoctor::Extensions.register do\n   inline_macro Git::Documentation::LinkGitProcessor, :linkgit\n-  postprocessor Git::Documentation::DocumentPostProcessor\n end\n-- \n2.40.0+fc1\n\n"}]}