{"thread":{"id":"59490","subject":"[PATCH] p2000: remove stray '--sparse' flag from test","startedAt":"2023-03-28T20:09:29Z","lastAt":"2023-03-28T20:09:29Z","messageCount":1,"participants":["Derrick Stolee via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"474360","messageId":"pull.1505.git.1680034162144.gitgitgadget@gmail.com","threadId":"59490","inReplyTo":null,"subject":"[PATCH] p2000: remove stray '--sparse' flag from test","fromName":"Derrick Stolee via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-03-28T20:09:22Z","receivedAt":"2023-03-28T20:09:29Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"From: Derrick Stolee <derrickstolee@github.com>\n\nThis argument was added in 7cae7627c45 (builtin/grep.c: integrate with\nsparse index, 2022-09-22), but it was a carry-over from an earlier\nversion where the --sparse flag was added to the 'git grep' builtin.\nThis argument does not exist, so currently the\np2000-sparse-operations.sh performance test script fails when reaching\nthis step.\n\nWith this fix, the script works with these numbers for my copy of the\nGit source code repository:\n\nTest                                         HEAD\n------------------------------------------------------------\n2000.30: git grep --cached ... (full-v3)     0.34(1.20+0.14)\n2000.31: git grep --cached ... (full-v4)     0.31(1.15+0.13)\n2000.32: git grep --cached ... (sparse-v3)   0.26(1.13+0.12)\n2000.33: git grep --cached ... (sparse-v4)   0.27(1.13+0.12)\n\nSigned-off-by: Derrick Stolee <derrickstolee@github.com>\n---\n    p2000: remove stray '--sparse' flag from test\n    \n    I noticed this while testing Raghul's patch [1].\n    \n    [1]\n    https://lore.kernel.org/git/pull.1480.git.git.1679926829475.gitgitgadget@gmail.com/\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1505%2Fderrickstolee%2Fp2000-fix-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1505/derrickstolee/p2000-fix-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1505\n\n t/perf/p2000-sparse-operations.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/perf/p2000-sparse-operations.sh b/t/perf/p2000-sparse-operations.sh\nindex 3242cfe91a0..e4a132f5934 100755\n--- a/t/perf/p2000-sparse-operations.sh\n+++ b/t/perf/p2000-sparse-operations.sh\n@@ -124,6 +124,6 @@ test_perf_on_all git read-tree -mu HEAD\n test_perf_on_all git checkout-index -f --all\n test_perf_on_all git update-index --add --remove $SPARSE_CONE/a\n test_perf_on_all \"git rm -f $SPARSE_CONE/a && git checkout HEAD -- $SPARSE_CONE/a\"\n-test_perf_on_all git grep --cached --sparse bogus -- \"f2/f1/f1/*\"\n+test_perf_on_all git grep --cached bogus -- \"f2/f1/f1/*\"\n \n test_done\n\nbase-commit: 27d43aaaf50ef0ae014b88bba294f93658016a2e\n-- \ngitgitgadget\n"}]}