{"thread":{"id":"59456","subject":"[PATCH] sequencer: remove pointless rollback_lock_file()","startedAt":"2023-03-23T16:47:51Z","lastAt":"2023-03-24T14:51:08Z","messageCount":2,"participants":["Oswald Buddenhagen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"474011","messageId":"20230323162235.995529-1-oswald.buddenhagen@gmx.de","threadId":"59456","inReplyTo":null,"subject":"[PATCH] sequencer: remove pointless rollback_lock_file()","fromName":"Oswald Buddenhagen","fromEmail":"oswald.buddenhagen@gmx.de","sentAt":"2023-03-23T16:22:35Z","receivedAt":"2023-03-23T16:47:51Z","isPatch":true,"sender":{"key":"oswald.buddenhagen@gmx.de","avatar":"https://avatars.githubusercontent.com/u/812380?v=4"},"body":"The file is gone even if commit_lock_file() fails.\n\nSigned-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>\n---\n sequencer.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/sequencer.c b/sequencer.c\nindex 3be23d7ca2..2da9b9f890 100644\n--- a/sequencer.c\n+++ b/sequencer.c\n@@ -3676,7 +3676,6 @@ static int safe_append(const char *filename, const char *fmt, ...)\n \t}\n \tif (commit_lock_file(&lock) < 0) {\n \t\tstrbuf_release(&buf);\n-\t\trollback_lock_file(&lock);\n \t\treturn error(_(\"failed to finalize '%s'\"), filename);\n \t}\n \n-- \n2.40.0.152.g15d061e6df\n\n"},{"id":"474090","messageId":"xmqq8rfm5hk7.fsf@gitster.g","threadId":"59456","inReplyTo":"20230323162235.995529-1-oswald.buddenhagen@gmx.de","subject":"Re: [PATCH] sequencer: remove pointless rollback_lock_file()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-24T14:51:04Z","receivedAt":"2023-03-24T14:51:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:\n\n> The file is gone even if commit_lock_file() fails.\n\nGood spotting.  \n\nI glanced over hits from \"git grep -A6 commit_lock_file \\*.c\" to see\nif there is a similar mistake, but this seems to be the only one.\n\nWill queue.  Thanks.\n\n> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>\n> ---\n>  sequencer.c | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/sequencer.c b/sequencer.c\n> index 3be23d7ca2..2da9b9f890 100644\n> --- a/sequencer.c\n> +++ b/sequencer.c\n> @@ -3676,7 +3676,6 @@ static int safe_append(const char *filename, const char *fmt, ...)\n>  \t}\n>  \tif (commit_lock_file(&lock) < 0) {\n>  \t\tstrbuf_release(&buf);\n> -\t\trollback_lock_file(&lock);\n>  \t\treturn error(_(\"failed to finalize '%s'\"), filename);\n>  \t}\n"}]}