{"thread":{"id":"59370","subject":"[PATCH v2 0/2] test: cleanups of aggregate-results.sh","startedAt":"2023-03-09T17:30:39Z","lastAt":"2023-03-10T22:03:28Z","messageCount":5,"participants":["Felipe Contreras","Junio C Hamano","Eric Wong"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"473298","messageId":"20230309173032.959968-1-felipe.contreras@gmail.com","threadId":"59370","inReplyTo":null,"subject":"[PATCH v2 0/2] test: cleanups of aggregate-results.sh","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2023-03-09T17:30:30Z","receivedAt":"2023-03-09T17:30:39Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Basically $title.\n\nSince v1 I'm now passing the directory, instead of the file pattern as\nÆvar suggested.\n\nAlso, while at it, let's silence the print of the command.\n\nFelipe Contreras (2):\n test: simplify counts aggregation\n test: don't print aggregate-results command\n\n contrib/subtree/t/Makefile | 4 +---\n t/Makefile | 4 +---\n t/aggregate-results.sh | 2 +-\n 3 files changed, 3 insertions(+), 7 deletions(-)\n\n-- \n2.39.2\n\n"},{"id":"473299","messageId":"20230309173032.959968-2-felipe.contreras@gmail.com","threadId":"59370","inReplyTo":"20230309173032.959968-1-felipe.contreras@gmail.com","subject":"[PATCH v2 1/2] test: simplify counts aggregation","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2023-03-09T17:30:31Z","receivedAt":"2023-03-09T17:30:42Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"When the list of files as input was implemented in 6508eedf67\n(t/aggregate-results: accomodate systems with small max argument list\nlength, 2010-06-01), a much simpler solution wasn't considered.\n\nLet's just pass the directory as an argument.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/subtree/t/Makefile | 4 +---\n t/Makefile | 4 +---\n t/aggregate-results.sh | 2 +-\n 3 files changed, 3 insertions(+), 7 deletions(-)\n\ndiff --git a/contrib/subtree/t/Makefile b/contrib/subtree/t/Makefile\nindex 4655e0987b..aa204d43b6 100644\n--- a/contrib/subtree/t/Makefile\n+++ b/contrib/subtree/t/Makefile\n@@ -74,9 +74,7 @@ aggregate-results-and-cleanup: $(T)\n \t$(MAKE) clean\n \n aggregate-results:\n-\tfor f in '$(TEST_RESULTS_DIRECTORY_SQ)'/t*-*.counts; do \\\n-\t\techo \"$$f\"; \\\n-\tdone | '$(SHELL_PATH_SQ)' ../../../t/aggregate-results.sh\n+\t'$(SHELL_PATH_SQ)' ../../../t/aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'\n \n valgrind:\n \t$(MAKE) GIT_TEST_OPTS=\"$(GIT_TEST_OPTS) --valgrind\"\ndiff --git a/t/Makefile b/t/Makefile\nindex 2c2b252240..6ce79849e1 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -140,9 +140,7 @@ aggregate-results-and-cleanup: $(T)\n \t$(MAKE) clean\n \n aggregate-results:\n-\tfor f in '$(TEST_RESULTS_DIRECTORY_SQ)'/t*-*.counts; do \\\n-\t\techo \"$$f\"; \\\n-\tdone | '$(SHELL_PATH_SQ)' ./aggregate-results.sh\n+\t'$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'\n \n valgrind:\n \t$(MAKE) GIT_TEST_OPTS=\"$(GIT_TEST_OPTS) --valgrind\"\ndiff --git a/t/aggregate-results.sh b/t/aggregate-results.sh\nindex 7f2b83bdc8..6e3bcc4aec 100755\n--- a/t/aggregate-results.sh\n+++ b/t/aggregate-results.sh\n@@ -8,7 +8,7 @@ broken=0\n total=0\n missing_prereq=\n \n-while read file\n+for file in \"$1\"/t*-*.counts\n do\n \twhile read type value\n \tdo\n-- \n2.39.2\n\n"},{"id":"473300","messageId":"20230309173032.959968-3-felipe.contreras@gmail.com","threadId":"59370","inReplyTo":"20230309173032.959968-1-felipe.contreras@gmail.com","subject":"[PATCH v2 2/2] test: don't print aggregate-results command","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2023-03-09T17:30:32Z","receivedAt":"2023-03-09T17:30:48Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"There's no value in it.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/subtree/t/Makefile | 2 +-\n t/Makefile | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/subtree/t/Makefile b/contrib/subtree/t/Makefile\nindex aa204d43b6..093399c788 100644\n--- a/contrib/subtree/t/Makefile\n+++ b/contrib/subtree/t/Makefile\n@@ -74,7 +74,7 @@ aggregate-results-and-cleanup: $(T)\n \t$(MAKE) clean\n \n aggregate-results:\n-\t'$(SHELL_PATH_SQ)' ../../../t/aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'\n+\t@'$(SHELL_PATH_SQ)' ../../../t/aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'\n \n valgrind:\n \t$(MAKE) GIT_TEST_OPTS=\"$(GIT_TEST_OPTS) --valgrind\"\ndiff --git a/t/Makefile b/t/Makefile\nindex 6ce79849e1..88fa504957 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -140,7 +140,7 @@ aggregate-results-and-cleanup: $(T)\n \t$(MAKE) clean\n \n aggregate-results:\n-\t'$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'\n+\t@'$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'\n \n valgrind:\n \t$(MAKE) GIT_TEST_OPTS=\"$(GIT_TEST_OPTS) --valgrind\"\n-- \n2.39.2\n\n"},{"id":"473379","messageId":"xmqqa60k5ryc.fsf@gitster.g","threadId":"59370","inReplyTo":"20230309173032.959968-1-felipe.contreras@gmail.com","subject":"Re: [PATCH v2 0/2] test: cleanups of aggregate-results.sh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-10T19:25:47Z","receivedAt":"2023-03-10T19:25:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> Basically $title.\n>\n> Since v1 I'm now passing the directory, instead of the file pattern as\n> Ævar suggested.\n>\n> Also, while at it, let's silence the print of the command.\n>\n> Felipe Contreras (2):\n> test: simplify counts aggregation\n> test: don't print aggregate-results command\n>\n> contrib/subtree/t/Makefile | 4 +---\n> t/Makefile | 4 +---\n> t/aggregate-results.sh | 2 +-\n> 3 files changed, 3 insertions(+), 7 deletions(-)\n\nThese two look sensible. Any comments on them by reviewers on the\ninitial round?\n\nWill queue. Thanks, all.\n"},{"id":"473391","messageId":"20230310215113.M656422@dcvr","threadId":"59370","inReplyTo":"xmqqa60k5ryc.fsf@gitster.g","subject":"Re: [PATCH v2 0/2] test: cleanups of aggregate-results.sh","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2023-03-10T21:51:13Z","receivedAt":"2023-03-10T22:03:28Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> These two look sensible. Any comments on them by reviewers on the\n> initial round?\n\nLooks fine to me.\n"}]}