{"thread":{"id":"59332","subject":"[Failure] Re: git 2.40.0-rc1","startedAt":"2023-03-02T16:43:33Z","lastAt":"2023-03-02T20:50:27Z","messageCount":7,"participants":["rsbecker@nexbridge.com","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"472923","messageId":"000001d94d26$1e52a910$5af7fb30$@nexbridge.com","threadId":"59332","inReplyTo":null,"subject":"[Failure] Re: git 2.40.0-rc1","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2023-03-02T16:43:23Z","receivedAt":"2023-03-02T16:43:33Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"Hi All,\n\nGit 2.40.0-rc2 was a regression from rc1. The following new tests failed:\n\nt3206 - virtually all subtests failed. An example of this failure is a\nresults comparison in subtest 1 (seemingly relating to abbreviation):\n+ test_cmp expect actual\n--- expect 2023-03-02 16:39:23 +0000\n+++ actual 2023-03-02 16:39:23 +0000\n@@ -1,4 +1,4 @@\n-1: 4de457d = 1: 35b9b25 s/5/A/\n-2: fccce22 = 2: de345ab s/4/A/\n-3: 147e64e = 3: 9af6654 s/11/B/\n-4: a63e992 = 4: 2901f77 s/12/B/\n+1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:\n35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/\n+2: fccce22f8c95220a7283f047ecc6f042a54ad902 = 2:\nde345ab3de2b56a1e208e46197bb77829a6e1f3a s/4/A/\n+3: 147e64ef5365f843f378dcfd60c4b8115146a35a = 3:\n9af6654000a6c3235196f874c6fa58c970fcf233 s/11/B/\n+4: a63e992599e14e34a5664fe3f213fa8ad8977fe1 = 4:\n2901f773f3f322646e189b37ffe99a47ad6d456a s/12/B/\n\nt5562.13,14 failed on gzip problems. This is a transient failure and only\noccurs sometimes.\n\nRegards,\nRandall\n\n--\nBrief whoami: NonStop&UNIX developer since approximately\nUNIX(421664400)\nNonStop(211288444200000000)\n-- In real life, I talk too much.\n\n\n\n\n\n"},{"id":"472927","messageId":"xmqqh6v3j8n1.fsf@gitster.g","threadId":"59332","inReplyTo":"000001d94d26$1e52a910$5af7fb30$@nexbridge.com","subject":"Re: [Failure] Re: git 2.40.0-rc1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-02T18:44:18Z","receivedAt":"2023-03-02T18:44:26Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":" writes:\n\n> Git 2.40.0-rc2 was a regression from rc1. The following new tests failed:\n>\n> t3206 - virtually all subtests failed. An example of this failure is a\n> results comparison in subtest 1 (seemingly relating to abbreviation):\n> + test_cmp expect actual\n> --- expect 2023-03-02 16:39:23 +0000\n> +++ actual 2023-03-02 16:39:23 +0000\n> @@ -1,4 +1,4 @@\n> -1: 4de457d = 1: 35b9b25 s/5/A/\n> -2: fccce22 = 2: de345ab s/4/A/\n> -3: 147e64e = 3: 9af6654 s/11/B/\n> -4: a63e992 = 4: 2901f77 s/12/B/\n> +1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:\n> 35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/\n\nAre any big endian machines involved?\n\ncf. https://lore.kernel.org/git/Y%2F+paI8WGSmEbv%2Fw@pobox.com/\n"},{"id":"472928","messageId":"001a01d94d3f$04c2e460$0e48ad20$@nexbridge.com","threadId":"59332","inReplyTo":"xmqqh6v3j8n1.fsf@gitster.g","subject":"RE: [Failure] Re: git 2.40.0-rc1","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2023-03-02T19:41:38Z","receivedAt":"2023-03-02T19:41:50Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On Thursday, March 2, 2023 1:44 PM, Junio C Hamano wrote:\n> writes:\n>\n>> Git 2.40.0-rc2 was a regression from rc1. The following new tests failed:\n>>\n>> t3206 - virtually all subtests failed. An example of this failure is a\n>> results comparison in subtest 1 (seemingly relating to abbreviation):\n>> + test_cmp expect actual\n>> --- expect 2023-03-02 16:39:23 +0000\n>> +++ actual 2023-03-02 16:39:23 +0000\n>> @@ -1,4 +1,4 @@\n>> -1: 4de457d = 1: 35b9b25 s/5/A/\n>> -2: fccce22 = 2: de345ab s/4/A/\n>> -3: 147e64e = 3: 9af6654 s/11/B/\n>> -4: a63e992 = 4: 2901f77 s/12/B/\n>> +1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:\n>> 35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/\n>\n>Are any big endian machines involved?\n>\n>cf. https://lore.kernel.org/git/Y%2F+paI8WGSmEbv%2Fw@pobox.com/\n\nOh yes. All NonStop variants are big-endian. That hasn't changed the SHA-1\nsignatures though.\n\n"},{"id":"472929","messageId":"xmqq7cvzj5a5.fsf@gitster.g","threadId":"59332","inReplyTo":"xmqqh6v3j8n1.fsf@gitster.g","subject":"Re: [Failure] Re: git 2.40.0-rc1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-02T19:56:50Z","receivedAt":"2023-03-02T19:57:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> writes:\n>\n>> Git 2.40.0-rc2 was a regression from rc1. The following new tests failed:\n>>\n>> t3206 - virtually all subtests failed. An example of this failure is a\n>> results comparison in subtest 1 (seemingly relating to abbreviation):\n>> + test_cmp expect actual\n>> --- expect 2023-03-02 16:39:23 +0000\n>> +++ actual 2023-03-02 16:39:23 +0000\n>> @@ -1,4 +1,4 @@\n>> -1: 4de457d = 1: 35b9b25 s/5/A/\n>> -2: fccce22 = 2: de345ab s/4/A/\n>> -3: 147e64e = 3: 9af6654 s/11/B/\n>> -4: a63e992 = 4: 2901f77 s/12/B/\n>> +1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:\n>> 35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/\n>\n> Are any big endian machines involved?\n\nSorry, \"big endian machines\" -> \"machines whose char is unsigned\".\n\n>\n> cf. https://lore.kernel.org/git/Y%2F+paI8WGSmEbv%2Fw@pobox.com/\n"},{"id":"472930","messageId":"xmqq356mkjp1.fsf@gitster.g","threadId":"59332","inReplyTo":"001a01d94d3f$04c2e460$0e48ad20$@nexbridge.com","subject":"Re: [Failure] Re: git 2.40.0-rc1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-02T20:00:10Z","receivedAt":"2023-03-02T20:01:56Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":" writes:\n\n> On Thursday, March 2, 2023 1:44 PM, Junio C Hamano wrote:\n>> writes:\n>>\n>>> Git 2.40.0-rc2 was a regression from rc1. The following new tests failed:\n\nI think you are reporting -rc1 relative to -rc0.\n\n>>> t3206 - virtually all subtests failed. An example of this failure is a\n>>> results comparison in subtest 1 (seemingly relating to abbreviation):\n>>> + test_cmp expect actual\n>>> --- expect 2023-03-02 16:39:23 +0000\n>>> +++ actual 2023-03-02 16:39:23 +0000\n>>> @@ -1,4 +1,4 @@\n>>> -1: 4de457d = 1: 35b9b25 s/5/A/\n>>> -2: fccce22 = 2: de345ab s/4/A/\n>>> -3: 147e64e = 3: 9af6654 s/11/B/\n>>> -4: a63e992 = 4: 2901f77 s/12/B/\n>>> +1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:\n>>> 35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/\n>>\n>>Are any big endian machines involved?\n>>\n>>cf. https://lore.kernel.org/git/Y%2F+paI8WGSmEbv%2Fw@pobox.com/\n>\n> Oh yes. All NonStop variants are big-endian. That hasn't changed the SHA-1\n> signatures though.\n\nThere is a stupid sequence that slipped through the review\n\n\tchar c = structPtr->intMember;\n\n\tif (c < 0)\n\t\t... do something ...\n\nand where \"char\" is \"unsigned char\", the compiler thinks \"do\nsomething\" will never trigger and from there everything goes\nhaywire.\n\nThe tip of 'master' already has a fix (and no other changes as of\nthis writing), and will be part of -rc2.\n\nThanks.\n\n\n"},{"id":"472931","messageId":"001e01d94d42$c5213b50$4f63b1f0$@nexbridge.com","threadId":"59332","inReplyTo":"xmqq356mkjp1.fsf@gitster.g","subject":"RE: [Failure] Re: git 2.40.0-rc1","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2023-03-02T20:08:29Z","receivedAt":"2023-03-02T20:08:39Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On Thursday, March 2, 2023 3:00 PM, Junio C Hamano wrote:\n> writes:\n>\n>> On Thursday, March 2, 2023 1:44 PM, Junio C Hamano wrote:\n>>> writes:\n>>>\n>>>> Git 2.40.0-rc2 was a regression from rc1. The following new tests failed:\n>\n>I think you are reporting -rc1 relative to -rc0.\n>\n>>>> t3206 - virtually all subtests failed. An example of this failure is\n>>>> a results comparison in subtest 1 (seemingly relating to abbreviation):\n>>>> + test_cmp expect actual\n>>>> --- expect 2023-03-02 16:39:23 +0000\n>>>> +++ actual 2023-03-02 16:39:23 +0000\n>>>> @@ -1,4 +1,4 @@\n>>>> -1: 4de457d = 1: 35b9b25 s/5/A/\n>>>> -2: fccce22 = 2: de345ab s/4/A/\n>>>> -3: 147e64e = 3: 9af6654 s/11/B/\n>>>> -4: a63e992 = 4: 2901f77 s/12/B/\n>>>> +1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:\n>>>> 35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/\n>>>\n>>>Are any big endian machines involved?\n>>>\n>>>cf. https://lore.kernel.org/git/Y%2F+paI8WGSmEbv%2Fw@pobox.com/\n>>\n>> Oh yes. All NonStop variants are big-endian. That hasn't changed the\n>> SHA-1 signatures though.\n>\n>There is a stupid sequence that slipped through the review\n>\n>\tchar c = structPtr->intMember;\n>\n>\tif (c < 0)\n>\t\t... do something ...\n>\n>and where \"char\" is \"unsigned char\", the compiler thinks \"do something\" will never\n>trigger and from there everything goes haywire.\n>\n>The tip of 'master' already has a fix (and no other changes as of this writing), and\n>will be part of -rc2.\n\nThank you for the really fast fix on this ๐Ÿ˜Š.\n--Randall\n\n"},{"id":"472933","messageId":"xmqqy1oej2tu.fsf@gitster.g","threadId":"59332","inReplyTo":"001e01d94d42$c5213b50$4f63b1f0$@nexbridge.com","subject":"Re: [Failure] Re: git 2.40.0-rc1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-02T20:49:49Z","receivedAt":"2023-03-02T20:50:27Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":" writes:\n\n> On Thursday, March 2, 2023 3:00 PM, Junio C Hamano wrote:\n>> writes:\n>>\n>>> On Thursday, March 2, 2023 1:44 PM, Junio C Hamano wrote:\n>>>> writes:\n>>>>\n>>>>> Git 2.40.0-rc2 was a regression from rc1. The following new tests failed:\n>>\n>>I think you are reporting -rc1 relative to -rc0.\n>>\n>>>>> t3206 - virtually all subtests failed. An example of this failure is\n>>>>> a results comparison in subtest 1 (seemingly relating to abbreviation):\n>>>>> + test_cmp expect actual\n>>>>> --- expect 2023-03-02 16:39:23 +0000\n>>>>> +++ actual 2023-03-02 16:39:23 +0000\n>>>>> @@ -1,4 +1,4 @@\n>>>>> -1: 4de457d = 1: 35b9b25 s/5/A/\n>>>>> -2: fccce22 = 2: de345ab s/4/A/\n>>>>> -3: 147e64e = 3: 9af6654 s/11/B/\n>>>>> -4: a63e992 = 4: 2901f77 s/12/B/\n>>>>> +1: 4de457d2c0d218f48d66f45f9b30f3aa62562105 = 1:\n>>>>> 35b9b25f76d404d09a23e6c8efa96c3ce19e19aa s/5/A/\n>>>>\n>>>>Are any big endian machines involved?\n>>>>\n>>>>cf. https://lore.kernel.org/git/Y%2F+paI8WGSmEbv%2Fw@pobox.com/\n>>>\n>>> Oh yes. All NonStop variants are big-endian. That hasn't changed the\n>>> SHA-1 signatures though.\n>>\n>>There is a stupid sequence that slipped through the review\n>>\n>>\tchar c = structPtr->intMember;\n>>\n>>\tif (c < 0)\n>>\t\t... do something ...\n>>\n>>and where \"char\" is \"unsigned char\", the compiler thinks \"do something\" will never\n>>trigger and from there everything goes haywire.\n>>\n>>The tip of 'master' already has a fix (and no other changes as of this writing), and\n>>will be part of -rc2.\n>\n> Thank you for the really fast fix on this ๐Ÿ˜Š.\n> --Randall\n\nDon't thank me. It was Renรฉ Scharfe who caught and fixed it first,\nwhich happened a few days ago and the URL above was from yesterday.\n"}]}