{"thread":{"id":"59299","subject":"[GSOC] [PATCH 0/3] t9700:moderizen test scripts","startedAt":"2023-02-23T14:16:21Z","lastAt":"2023-02-23T14:16:32Z","messageCount":4,"participants":["Zhang Yi"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"472548","messageId":"20230223141520.1967625-1-18994118902@163.com","threadId":"59299","inReplyTo":null,"subject":"[GSOC] [PATCH 0/3] t9700:moderizen test scripts","fromName":"Zhang Yi","fromEmail":"18994118902@163.com","sentAt":"2023-02-23T14:15:17Z","receivedAt":"2023-02-23T14:16:21Z","isPatch":true,"sender":{"key":"18994118902@163.com","avatar":"https://avatars.githubusercontent.com/u/48300302?v=4"},"body":"The style of t9700-perl-git.sh is old.There are 3 things need improve:\n* A title is not on the same line with test_expect_success command.\n* A test body is indented by whitespaces.\n* There are whitespaces after redirect operators.\n\n---\nThanks for all suggestions.\n\nZhang Yi (3):\n  t9700:fix title style\n  t9700:change indents to TAB\n  t9700:delete whitespaces after redirect operators\n\n t/t9700-perl-git.sh | 61 ++++++++++++++++++++++-----------------------\n 1 file changed, 30 insertions(+), 31 deletions(-)\n\n-- \n2.29.0-rc0\n\n"},{"id":"472549","messageId":"20230223141520.1967625-3-18994118902@163.com","threadId":"59299","inReplyTo":"20230223141520.1967625-1-18994118902@163.com","subject":"[GSOC] [PATCH v2 2/3] t9700:change indents to TAB","fromName":"Zhang Yi","fromEmail":"18994118902@163.com","sentAt":"2023-02-23T14:15:19Z","receivedAt":"2023-02-23T14:16:29Z","isPatch":true,"sender":{"key":"18994118902@163.com","avatar":"https://avatars.githubusercontent.com/u/48300302?v=4"},"body":"The body of one test script in t9700-perl-git.sh is indented by spaces\nwhile others are indented by TAB.And test bodies should be indented with\nTAB, not spaces.\n\nReplace all space indents by TAB.\n\nSigned-off-by: Zhang Yi <18994118902@163.com>\n---\n t/t9700-perl-git.sh | 58 ++++++++++++++++++++++-----------------------\n 1 file changed, 29 insertions(+), 29 deletions(-)\n\ndiff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh\nindex 3f6396ef63..671875a3fc 100755\n--- a/t/t9700-perl-git.sh\n+++ b/t/t9700-perl-git.sh\n@@ -14,35 +14,35 @@ skip_all_if_no_Test_More\n # set up test repository\n \n test_expect_success 'set up test repository' '\n-     echo \"test file 1\" > file1 &&\n-     echo \"test file 2\" > file2 &&\n-     mkdir directory1 &&\n-     echo \"in directory1\" >> directory1/file &&\n-     mkdir directory2 &&\n-     echo \"in directory2\" >> directory2/file &&\n-     git add . &&\n-     git commit -m \"first commit\" &&\n-\n-     echo \"new file in subdir 2\" > directory2/file2 &&\n-     git add . &&\n-     git commit -m \"commit in directory2\" &&\n-\n-     echo \"changed file 1\" > file1 &&\n-     git commit -a -m \"second commit\" &&\n-\n-     git config --add color.test.slot1 green &&\n-     git config --add test.string value &&\n-     git config --add test.dupstring value1 &&\n-     git config --add test.dupstring value2 &&\n-     git config --add test.booltrue true &&\n-     git config --add test.boolfalse no &&\n-     git config --add test.boolother other &&\n-     git config --add test.int 2k &&\n-     git config --add test.path \"~/foo\" &&\n-     git config --add test.pathexpanded \"$HOME/foo\" &&\n-     git config --add test.pathmulti foo &&\n-     git config --add test.pathmulti bar\n-     '\n+\techo \"test file 1\" > file1 &&\n+\techo \"test file 2\" > file2 &&\n+\tmkdir directory1 &&\n+\techo \"in directory1\" >> directory1/file &&\n+\tmkdir directory2 &&\n+\techo \"in directory2\" >> directory2/file &&\n+\tgit add . &&\n+\tgit commit -m \"first commit\" &&\n+\n+\techo \"new file in subdir 2\" > directory2/file2 &&\n+\tgit add . &&\n+\tgit commit -m \"commit in directory2\" &&\n+\n+\techo \"changed file 1\" > file1 &&\n+\tgit commit -a -m \"second commit\" &&\n+\n+\tgit config --add color.test.slot1 green &&\n+\tgit config --add test.string value &&\n+\tgit config --add test.dupstring value1 &&\n+\tgit config --add test.dupstring value2 &&\n+\tgit config --add test.booltrue true &&\n+\tgit config --add test.boolfalse no &&\n+\tgit config --add test.boolother other &&\n+\tgit config --add test.int 2k &&\n+\tgit config --add test.path \"~/foo\" &&\n+\tgit config --add test.pathexpanded \"$HOME/foo\" &&\n+\tgit config --add test.pathmulti foo &&\n+\tgit config --add test.pathmulti bar\n+'\n \n test_expect_success 'set up bare repository' '\n \tgit init --bare bare.git\n-- \n2.29.0-rc0\n\n"},{"id":"472550","messageId":"20230223141520.1967625-2-18994118902@163.com","threadId":"59299","inReplyTo":"20230223141520.1967625-1-18994118902@163.com","subject":"[GSOC] [PATCH v2 1/3] t9700:fix title style","fromName":"Zhang Yi","fromEmail":"18994118902@163.com","sentAt":"2023-02-23T14:15:18Z","receivedAt":"2023-02-23T14:16:31Z","isPatch":true,"sender":{"key":"18994118902@163.com","avatar":"https://avatars.githubusercontent.com/u/48300302?v=4"},"body":"One title in t9700-perl-git.sh is in old style where the\ntest_expect_success command and test title are written on\nseparate lines.\n\nCombine the test_expect_success command and the title in one line.\n\nSigned-off-by: Zhang Yi <18994118902@163.com>\n---\n t/t9700-perl-git.sh | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh\nindex b105d6d9d5..3f6396ef63 100755\n--- a/t/t9700-perl-git.sh\n+++ b/t/t9700-perl-git.sh\n@@ -13,9 +13,8 @@ skip_all_if_no_Test_More\n \n # set up test repository\n \n-test_expect_success \\\n-    'set up test repository' \\\n-    'echo \"test file 1\" > file1 &&\n+test_expect_success 'set up test repository' '\n+     echo \"test file 1\" > file1 &&\n      echo \"test file 2\" > file2 &&\n      mkdir directory1 &&\n      echo \"in directory1\" >> directory1/file &&\n-- \n2.29.0-rc0\n\n"},{"id":"472551","messageId":"20230223141520.1967625-4-18994118902@163.com","threadId":"59299","inReplyTo":"20230223141520.1967625-1-18994118902@163.com","subject":"[GSOC] [PATCH v2 3/3] t9700:delete whitespaces after redirect operators","fromName":"Zhang Yi","fromEmail":"18994118902@163.com","sentAt":"2023-02-23T14:15:20Z","receivedAt":"2023-02-23T14:16:32Z","isPatch":true,"sender":{"key":"18994118902@163.com","avatar":"https://avatars.githubusercontent.com/u/48300302?v=4"},"body":"There are whitespaces after redirect operators,which is a deprecated\nstyle.\n\nDelete whitespaces after redirect operators.\n\nSigned-off-by: Zhang Yi <18994118902@163.com>\n---\n t/t9700-perl-git.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh\nindex 671875a3fc..ccc8212d73 100755\n--- a/t/t9700-perl-git.sh\n+++ b/t/t9700-perl-git.sh\n@@ -14,20 +14,20 @@ skip_all_if_no_Test_More\n # set up test repository\n \n test_expect_success 'set up test repository' '\n-\techo \"test file 1\" > file1 &&\n-\techo \"test file 2\" > file2 &&\n+\techo \"test file 1\" >file1 &&\n+\techo \"test file 2\" >file2 &&\n \tmkdir directory1 &&\n-\techo \"in directory1\" >> directory1/file &&\n+\techo \"in directory1\" >>directory1/file &&\n \tmkdir directory2 &&\n-\techo \"in directory2\" >> directory2/file &&\n+\techo \"in directory2\" >>directory2/file &&\n \tgit add . &&\n \tgit commit -m \"first commit\" &&\n \n-\techo \"new file in subdir 2\" > directory2/file2 &&\n+\techo \"new file in subdir 2\" >directory2/file2 &&\n \tgit add . &&\n \tgit commit -m \"commit in directory2\" &&\n \n-\techo \"changed file 1\" > file1 &&\n+\techo \"changed file 1\" >file1 &&\n \tgit commit -a -m \"second commit\" &&\n \n \tgit config --add color.test.slot1 green &&\n-- \n2.29.0-rc0\n\n"}]}