{"thread":{"id":"59275","subject":"[GSOC][PATCH] t4121: modernize test style","startedAt":"2023-02-20T23:52:24Z","lastAt":"2023-02-22T05:19:30Z","messageCount":13,"participants":["Vivan Garg","Victoria Dye","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"472360","messageId":"20230220235121.34375-1-gvivan6@gmail.com","threadId":"59275","inReplyTo":null,"subject":"[GSOC][PATCH] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-20T23:51:21Z","receivedAt":"2023-02-20T23:52:24Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"Test scripts in file t4121-apply-diffs.sh are written in old style,\nwhere the test_expect_success command and test title are written on\nseparate lines\n\nSigned-off-by: Vivan Garg <gvivan6@gmail.com>\n---\nGreetings, my name is Vivan Garg. I am currently pursuing a double major\nin computer science and finance at the University of Waterloo in Canada. \nI am currently completing my third software developer internship at Morgan\nStanley. As part of my coursework, I studied C and shell scripting, which \nI then applied in internships and personal projects. C++ is the programming \nlanguage that I am most comfortable with right now. Please feel free to \naddress me as Vivan, and my pronouns are he/him/his. I meet the requirements \nfor GSOC participation. So far, I've either read or skimmed the following \ndocuments based on prior knowledge: Submitting patches, Coding guidelines, \nMyfirstcontribution.txt, gittutorial, Giteveryday, readme, Hacking-Git, \nGeneral-Microproject-Information, SoC-2023-Ideas, and \nGeneral-Application-Information. I'm looking forward to having a fantastic \ntime here! \n\n t/t4121-apply-diffs.sh | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t4121-apply-diffs.sh b/t/t4121-apply-diffs.sh\nindex a80cec9d11..2ff38ededa 100755\n--- a/t/t4121-apply-diffs.sh\n+++ b/t/t4121-apply-diffs.sh\n@@ -16,8 +16,8 @@ echo '1\n 7\n 8' >file\n \n-test_expect_success 'setup' \\\n-\t'git add file &&\n+test_expect_success 'setup' '\n+\tgit add file &&\n \tgit commit -q -m 1 &&\n \tgit checkout -b test &&\n \tmv file file.tmp &&\n@@ -27,10 +27,11 @@ test_expect_success 'setup' \\\n \tgit commit -a -q -m 2 &&\n \techo 9 >>file &&\n \tgit commit -a -q -m 3 &&\n-\tgit checkout main'\n+\tgit checkout main\n+'\n \n-test_expect_success \\\n-\t'check if contextually independent diffs for the same file apply' \\\n-\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n+test_expect_success 'check if contextually independent diffs for the same file apply' '\n+\t( git diff test~2 test~1 && git diff test~1 test~0 )| git apply\n+'\n \n test_done\n-- \n2.37.0 (Apple Git-136)\n\n"},{"id":"472383","messageId":"38cb184d-e47a-2129-a93e-16ffd2afe67a@github.com","threadId":"59275","inReplyTo":"20230220235121.34375-1-gvivan6@gmail.com","subject":"Re: [GSOC][PATCH] t4121: modernize test style","fromName":"Victoria Dye","fromEmail":"vdye@github.com","sentAt":"2023-02-21T17:22:12Z","receivedAt":"2023-02-21T17:22:27Z","isPatch":true,"sender":{"key":"vdye@github.com","avatar":"https://avatars.githubusercontent.com/u/3619353?v=4"},"body":"Vivan Garg wrote:\n> Test scripts in file t4121-apply-diffs.sh are written in old style,\n> where the test_expect_success command and test title are written on\n> separate lines\n\nnit: period at the end of the sentence (s/lines/lines.)\n\nAlso, this commit message explains *why* you're making the change, but not\nwhat the commit actually does (that is, update the tests to adhere to the\nnew style). Would you mind adding a note about that to the message?\n\n> \n> Signed-off-by: Vivan Garg <gvivan6@gmail.com>\n> ---\n> Greetings, my name is Vivan Garg. I am currently pursuing a double major\n> in computer science and finance at the University of Waterloo in Canada. \n> I am currently completing my third software developer internship at Morgan\n> Stanley. As part of my coursework, I studied C and shell scripting, which \n> I then applied in internships and personal projects. C++ is the programming \n> language that I am most comfortable with right now. Please feel free to \n> address me as Vivan, and my pronouns are he/him/his. I meet the requirements \n> for GSOC participation. So far, I've either read or skimmed the following \n> documents based on prior knowledge: Submitting patches, Coding guidelines, \n> Myfirstcontribution.txt, gittutorial, Giteveryday, readme, Hacking-Git, \n> General-Microproject-Information, SoC-2023-Ideas, and \n> General-Application-Information. I'm looking forward to having a fantastic \n> time here! \n\nWelcome to the Git community, and thanks for your contribution! :) \n\n> \n>  t/t4121-apply-diffs.sh | 13 +++++++------\n>  1 file changed, 7 insertions(+), 6 deletions(-)\n> \n> diff --git a/t/t4121-apply-diffs.sh b/t/t4121-apply-diffs.sh\n> index a80cec9d11..2ff38ededa 100755\n> --- a/t/t4121-apply-diffs.sh\n> +++ b/t/t4121-apply-diffs.sh\n> @@ -16,8 +16,8 @@ echo '1\n>  7\n>  8' >file\n>  \n> -test_expect_success 'setup' \\\n> -\t'git add file &&\n> +test_expect_success 'setup' '\n> +\tgit add file &&\n>  \tgit commit -q -m 1 &&\n>  \tgit checkout -b test &&\n>  \tmv file file.tmp &&\n> @@ -27,10 +27,11 @@ test_expect_success 'setup' \\\n>  \tgit commit -a -q -m 2 &&\n>  \techo 9 >>file &&\n>  \tgit commit -a -q -m 3 &&\n> -\tgit checkout main'\n> +\tgit checkout main\n> +'\n\nThis test looks good.\n\n>  \n> -test_expect_success \\\n> -\t'check if contextually independent diffs for the same file apply' \\\n> -\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n> +test_expect_success 'check if contextually independent diffs for the same file apply' '\n> +\t( git diff test~2 test~1 && git diff test~1 test~0 )| git apply\n> +'\n\nAs for this one, the test is correctly updated to the new style (per the\nmicroproject prompt). However, the spacing around the '|' is a little weird\n- I think there should be a space after ')'. On your next re-roll, could you\nfix that spacing (in this patch is fine - it's not a substantial enough\nchange to warrant its own commit)?\n\n>  \n>  test_done\n\n"},{"id":"472394","messageId":"CADupsJNPVm13iSv84SXpqtP8Dhm_-htPTr59yPs_J=aQzs2FwQ@mail.gmail.com","threadId":"59275","inReplyTo":"38cb184d-e47a-2129-a93e-16ffd2afe67a@github.com","subject":"Re: [GSOC][PATCH] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"v.garg.work@gmail.com","sentAt":"2023-02-21T19:48:54Z","receivedAt":"2023-02-21T19:49:11Z","isPatch":true,"sender":{"key":"v.garg.work@gmail.com","avatar":null},"body":"On Tue, Feb 21, 2023 at 10:27 AM Victoria Dye <vdye@github.com> wrote:\n>\n> nit: period at the end of the sentence (s/lines/lines.)\n>\n> Also, this commit message explains *why* you're making the change, but not\n> what the commit actually does (that is, update the tests to adhere to the\n> new style). Would you mind adding a note about that to the message?\n\nFor sure! Is it correct that I will need to amend the commit message\nand send out a v2 of the patch?\n> >\n> > -test_expect_success \\\n> > -     'check if contextually independent diffs for the same file apply' \\\n> > -     '( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n> > +test_expect_success 'check if contextually independent diffs for the same file apply' '\n> > +     ( git diff test~2 test~1 && git diff test~1 test~0 )| git apply\n> > +'\n>\n> As for this one, the test is correctly updated to the new style (per the\n> microproject prompt). However, the spacing around the '|' is a little weird\n> - I think there should be a space after ')'. On your next re-roll, could you\n> fix that spacing (in this patch is fine - it's not a substantial enough\n> change to warrant its own commit)?\n\nI'm not sure what you mean by \"next re-roll,\" are you referring to v2? But\nthen you said it was fine in this patch, so I'm confused. If I am going to be\nsending a v2, couldn't I just revert the last commit and add this change to the\nsame commit?\n"},{"id":"472400","messageId":"xmqq8rgqeplt.fsf@gitster.g","threadId":"59275","inReplyTo":"CADupsJNPVm13iSv84SXpqtP8Dhm_-htPTr59yPs_J=aQzs2FwQ@mail.gmail.com","subject":"Re: [GSOC][PATCH] t4121: modernize test style","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-02-21T20:21:50Z","receivedAt":"2023-02-21T20:21:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Vivan Garg <v.garg.work@gmail.com> writes:\n\n> I'm not sure what you mean by \"next re-roll,\" are you referring to v2? But\n> then you said it was fine in this patch, so I'm confused. If I am going to be\n> sending a v2, couldn't I just revert the last commit and add this change to the\n> same commit?\n\nI am not Victoria, but I think\n\n * You had two (or more) changes in your patch.\n\n * She found one of them is good.\n\n * The other one(s) were found lacking.\n\nWhen a patch is reviewed and found to be lacking (as a whole), and\nif you agree with the issues pointed out by the review(s), you'd\nredo the patch (with either \"commit --amend\" for a single patch, or\n\"rebase -i\" for a series with multiple patches), and produce v2, as\nif v1 never happened.  The act of doing so is colloquially called\n\"to reroll\".\n\nDocumentation/MyFirstContribution.txt::[[now-what]] may have more\ndetails.\n\nThanks.\n"},{"id":"472401","messageId":"20230221212753.85371-1-gvivan6@gmail.com","threadId":"59275","inReplyTo":"xmqq8rgqeplt.fsf@gitster.g","subject":"[GSOC][PATCH v2 0/1] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-21T21:27:52Z","receivedAt":"2023-02-21T21:29:09Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"Edited the commit message to add what the commit does and added a period at the end of the sentence.\n\nAdded a space after the closing bracket in the second test.\n\nVivan Garg (1):\n  t4121: modernize test style\n\n t/t4121-apply-diffs.sh | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\nRange-diff against v1:\n1:  61f1ed51f4 ! 1:  77fded7759 t4121: modernize test style\n    @@ Commit message\n     \n         Test scripts in file t4121-apply-diffs.sh are written in old style,\n         where the test_expect_success command and test title are written on\n    -    separate lines\n    +    separate lines, therefore update the tests to adhere to the new\n    +    style.\n     \n         Signed-off-by: Vivan Garg <gvivan6@gmail.com>\n     \n    @@ t/t4121-apply-diffs.sh: test_expect_success 'setup' \\\n     -\t'check if contextually independent diffs for the same file apply' \\\n     -\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n     +test_expect_success 'check if contextually independent diffs for the same file apply' '\n    -+\t( git diff test~2 test~1 && git diff test~1 test~0 )| git apply\n    ++\t( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply\n     +'\n      \n      test_done\n-- \n2.37.0 (Apple Git-136)\n\n"},{"id":"472403","messageId":"20230221212753.85371-2-gvivan6@gmail.com","threadId":"59275","inReplyTo":"20230221212753.85371-1-gvivan6@gmail.com","subject":"[GSOC][PATCH v2 1/1] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-21T21:27:53Z","receivedAt":"2023-02-21T21:30:12Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"Test scripts in file t4121-apply-diffs.sh are written in old style,\nwhere the test_expect_success command and test title are written on\nseparate lines, therefore update the tests to adhere to the new\nstyle.\n\nSigned-off-by: Vivan Garg <gvivan6@gmail.com>\n---\n t/t4121-apply-diffs.sh | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t4121-apply-diffs.sh b/t/t4121-apply-diffs.sh\nindex a80cec9d11..f1cc42ff71 100755\n--- a/t/t4121-apply-diffs.sh\n+++ b/t/t4121-apply-diffs.sh\n@@ -16,8 +16,8 @@ echo '1\n 7\n 8' >file\n \n-test_expect_success 'setup' \\\n-\t'git add file &&\n+test_expect_success 'setup' '\n+\tgit add file &&\n \tgit commit -q -m 1 &&\n \tgit checkout -b test &&\n \tmv file file.tmp &&\n@@ -27,10 +27,11 @@ test_expect_success 'setup' \\\n \tgit commit -a -q -m 2 &&\n \techo 9 >>file &&\n \tgit commit -a -q -m 3 &&\n-\tgit checkout main'\n+\tgit checkout main\n+'\n \n-test_expect_success \\\n-\t'check if contextually independent diffs for the same file apply' \\\n-\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n+test_expect_success 'check if contextually independent diffs for the same file apply' '\n+\t( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply\n+'\n \n test_done\n-- \n2.37.0 (Apple Git-136)\n\n"},{"id":"472405","messageId":"20230221213526.85591-1-gvivan6@gmail.com","threadId":"59275","inReplyTo":"20230220235121.34375-1-gvivan6@gmail.com","subject":"[GSOC][PATCH v2 0/1] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-21T21:35:25Z","receivedAt":"2023-02-21T21:35:39Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"Edited the commit message to add what the commit does and added a period at the end of the sentence.\n\nAdded a space after the closing bracket in the second test.\n\nVivan Garg (1):\n  t4121: modernize test style\n\n t/t4121-apply-diffs.sh | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\nRange-diff against v1:\n1:  61f1ed51f4 ! 1:  77fded7759 t4121: modernize test style\n    @@ Commit message\n     \n         Test scripts in file t4121-apply-diffs.sh are written in old style,\n         where the test_expect_success command and test title are written on\n    -    separate lines\n    +    separate lines, therefore update the tests to adhere to the new\n    +    style.\n     \n         Signed-off-by: Vivan Garg <gvivan6@gmail.com>\n     \n    @@ t/t4121-apply-diffs.sh: test_expect_success 'setup' \\\n     -\t'check if contextually independent diffs for the same file apply' \\\n     -\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n     +test_expect_success 'check if contextually independent diffs for the same file apply' '\n    -+\t( git diff test~2 test~1 && git diff test~1 test~0 )| git apply\n    ++\t( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply\n     +'\n      \n      test_done\n-- \n2.37.0 (Apple Git-136)\n\n"},{"id":"472406","messageId":"20230221213526.85591-2-gvivan6@gmail.com","threadId":"59275","inReplyTo":"20230221213526.85591-1-gvivan6@gmail.com","subject":"[GSOC][PATCH v2 1/1] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-21T21:35:26Z","receivedAt":"2023-02-21T21:36:22Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"Test scripts in file t4121-apply-diffs.sh are written in old style,\nwhere the test_expect_success command and test title are written on\nseparate lines, therefore update the tests to adhere to the new\nstyle.\n\nSigned-off-by: Vivan Garg <gvivan6@gmail.com>\n---\n t/t4121-apply-diffs.sh | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t4121-apply-diffs.sh b/t/t4121-apply-diffs.sh\nindex a80cec9d11..f1cc42ff71 100755\n--- a/t/t4121-apply-diffs.sh\n+++ b/t/t4121-apply-diffs.sh\n@@ -16,8 +16,8 @@ echo '1\n 7\n 8' >file\n \n-test_expect_success 'setup' \\\n-\t'git add file &&\n+test_expect_success 'setup' '\n+\tgit add file &&\n \tgit commit -q -m 1 &&\n \tgit checkout -b test &&\n \tmv file file.tmp &&\n@@ -27,10 +27,11 @@ test_expect_success 'setup' \\\n \tgit commit -a -q -m 2 &&\n \techo 9 >>file &&\n \tgit commit -a -q -m 3 &&\n-\tgit checkout main'\n+\tgit checkout main\n+'\n \n-test_expect_success \\\n-\t'check if contextually independent diffs for the same file apply' \\\n-\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n+test_expect_success 'check if contextually independent diffs for the same file apply' '\n+\t( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply\n+'\n \n test_done\n-- \n2.37.0 (Apple Git-136)\n\n"},{"id":"472408","messageId":"20230221214653.85830-1-gvivan6@gmail.com","threadId":"59275","inReplyTo":"20230220235121.34375-1-gvivan6@gmail.com","subject":"[GSOC][PATCH v2 0/1] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-21T21:46:52Z","receivedAt":"2023-02-21T21:47:01Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"Edited the commit message to add what the commit does and added a period at the end of the sentence.\n\nAdded a space after the closing bracket in the second test.\n\nVivan Garg (1):\n  t4121: modernize test style\n\n t/t4121-apply-diffs.sh | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\nRange-diff against v1:\n1:  61f1ed51f4 ! 1:  77fded7759 t4121: modernize test style\n    @@ Commit message\n     \n         Test scripts in file t4121-apply-diffs.sh are written in old style,\n         where the test_expect_success command and test title are written on\n    -    separate lines\n    +    separate lines, therefore update the tests to adhere to the new\n    +    style.\n     \n         Signed-off-by: Vivan Garg <gvivan6@gmail.com>\n     \n    @@ t/t4121-apply-diffs.sh: test_expect_success 'setup' \\\n     -\t'check if contextually independent diffs for the same file apply' \\\n     -\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n     +test_expect_success 'check if contextually independent diffs for the same file apply' '\n    -+\t( git diff test~2 test~1 && git diff test~1 test~0 )| git apply\n    ++\t( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply\n     +'\n      \n      test_done\n-- \n2.37.0 (Apple Git-136)\n\n"},{"id":"472409","messageId":"20230221214653.85830-2-gvivan6@gmail.com","threadId":"59275","inReplyTo":"20230221214653.85830-1-gvivan6@gmail.com","subject":"[GSOC][PATCH v2 1/1] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-21T21:46:53Z","receivedAt":"2023-02-21T21:47:10Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"Test scripts in file t4121-apply-diffs.sh are written in old style,\nwhere the test_expect_success command and test title are written on\nseparate lines, therefore update the tests to adhere to the new\nstyle.\n\nSigned-off-by: Vivan Garg <gvivan6@gmail.com>\n---\n t/t4121-apply-diffs.sh | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t4121-apply-diffs.sh b/t/t4121-apply-diffs.sh\nindex a80cec9d11..f1cc42ff71 100755\n--- a/t/t4121-apply-diffs.sh\n+++ b/t/t4121-apply-diffs.sh\n@@ -16,8 +16,8 @@ echo '1\n 7\n 8' >file\n \n-test_expect_success 'setup' \\\n-\t'git add file &&\n+test_expect_success 'setup' '\n+\tgit add file &&\n \tgit commit -q -m 1 &&\n \tgit checkout -b test &&\n \tmv file file.tmp &&\n@@ -27,10 +27,11 @@ test_expect_success 'setup' \\\n \tgit commit -a -q -m 2 &&\n \techo 9 >>file &&\n \tgit commit -a -q -m 3 &&\n-\tgit checkout main'\n+\tgit checkout main\n+'\n \n-test_expect_success \\\n-\t'check if contextually independent diffs for the same file apply' \\\n-\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n+test_expect_success 'check if contextually independent diffs for the same file apply' '\n+\t( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply\n+'\n \n test_done\n-- \n2.37.0 (Apple Git-136)\n\n"},{"id":"472412","messageId":"77734da5-e711-f653-b022-ba3b26823701@github.com","threadId":"59275","inReplyTo":"20230221214653.85830-2-gvivan6@gmail.com","subject":"Re: [GSOC][PATCH v2 1/1] t4121: modernize test style","fromName":"Victoria Dye","fromEmail":"vdye@github.com","sentAt":"2023-02-21T22:05:48Z","receivedAt":"2023-02-21T22:05:55Z","isPatch":true,"sender":{"key":"vdye@github.com","avatar":"https://avatars.githubusercontent.com/u/3619353?v=4"},"body":"Vivan Garg wrote:\n> Test scripts in file t4121-apply-diffs.sh are written in old style,\n> where the test_expect_success command and test title are written on\n> separate lines, therefore update the tests to adhere to the new\n> style.\n\nThe new commit message is sufficiently descriptive, thanks for updating. In\nterms of readability, it is a bit of a run-on sentence (the comma after\n\"lines\" could be a period, i.e. \"...separate lines. Therefore, update\nthe...\"). I don't think it needs to be updated, but it's something to keep\nin mind for future contributions. :) \n\n> \n> Signed-off-by: Vivan Garg <gvivan6@gmail.com>\n> ---\n>  t/t4121-apply-diffs.sh | 13 +++++++------\n>  1 file changed, 7 insertions(+), 6 deletions(-)\n> \n> diff --git a/t/t4121-apply-diffs.sh b/t/t4121-apply-diffs.sh\n> index a80cec9d11..f1cc42ff71 100755\n> --- a/t/t4121-apply-diffs.sh\n> +++ b/t/t4121-apply-diffs.sh\n> @@ -16,8 +16,8 @@ echo '1\n>  7\n>  8' >file\n>  \n> -test_expect_success 'setup' \\\n> -\t'git add file &&\n> +test_expect_success 'setup' '\n> +\tgit add file &&\n>  \tgit commit -q -m 1 &&\n>  \tgit checkout -b test &&\n>  \tmv file file.tmp &&\n> @@ -27,10 +27,11 @@ test_expect_success 'setup' \\\n>  \tgit commit -a -q -m 2 &&\n>  \techo 9 >>file &&\n>  \tgit commit -a -q -m 3 &&\n> -\tgit checkout main'\n> +\tgit checkout main\n> +'\n>  \n> -test_expect_success \\\n> -\t'check if contextually independent diffs for the same file apply' \\\n> -\t'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'\n> +test_expect_success 'check if contextually independent diffs for the same file apply' '\n> +\t( git diff test~2 test~1 && git diff test~1 test~0 ) | git apply\n> +'\n\nWhitespace looks good here. I think this is ready-to-merge; thanks!\n\n>  \n>  test_done\n\n"},{"id":"472416","messageId":"CADupsJMGgOzrd7L+Et=5t0a9vXNpZqhT4qzFi_7YbHwMMR6KWg@mail.gmail.com","threadId":"59275","inReplyTo":"77734da5-e711-f653-b022-ba3b26823701@github.com","subject":"Re: [GSOC][PATCH v2 1/1] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"v.garg.work@gmail.com","sentAt":"2023-02-21T22:34:34Z","receivedAt":"2023-02-21T22:34:50Z","isPatch":true,"sender":{"key":"v.garg.work@gmail.com","avatar":null},"body":"On Tue, Feb 21, 2023 at 3:17 PM Victoria Dye <vdye@github.com> wrote:\n\n> The new commit message is sufficiently descriptive, thanks for updating. In\n> terms of readability, it is a bit of a run-on sentence (the comma after\n> \"lines\" could be a period, i.e. \"...separate lines. Therefore, update\n> the...\"). I don't think it needs to be updated, but it's something to keep\n> in mind for future contributions. :)\n\nI've taken note of it. Thanks!\n\n> Whitespace looks good here. I think this is ready-to-merge; thanks!\n\nThanks again for the review!\n"},{"id":"472433","messageId":"CACzddJrZ8YdJ72ng3UpMGN9CJx0qW1+fZfyi3q01z2487V8fxw@mail.gmail.com","threadId":"59275","inReplyTo":"xmqq8rgqeplt.fsf@gitster.g","subject":"Re: [GSOC][PATCH] t4121: modernize test style","fromName":"Vivan Garg","fromEmail":"gvivan6@gmail.com","sentAt":"2023-02-22T05:19:14Z","receivedAt":"2023-02-22T05:19:30Z","isPatch":true,"sender":{"key":"gvivan6@gmail.com","avatar":null},"body":"On Tue, Feb 21, 2023 at 1:21 PM Junio C Hamano <gitster@pobox.com> wrote:\n\n> I am not Victoria, but I think\n>\n>  * You had two (or more) changes in your patch.\n>\n>  * She found one of them is good.\n>\n>  * The other one(s) were found lacking.\n>\n> When a patch is reviewed and found to be lacking (as a whole), and\n> if you agree with the issues pointed out by the review(s), you'd\n> redo the patch (with either \"commit --amend\" for a single patch, or\n> \"rebase -i\" for a series with multiple patches), and produce v2, as\n> if v1 never happened.  The act of doing so is colloquially called\n> \"to reroll\".\n>\n> Documentation/MyFirstContribution.txt::[[now-what]] may have more\n> details.\n>\n> Thanks.\n\nThat makes sense. Thanks for the clarification!\n"}]}