{"thread":{"id":"5924","subject":"[PATCH] Fix tracing when GIT_TRACE is set to an empty string.","startedAt":"2006-10-14T14:05:25Z","lastAt":"2006-10-14T19:55:32Z","messageCount":3,"participants":["Christian Couder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"28763","messageId":"20061014160525.c013e6d2.chriscool@tuxfamily.org","threadId":"5924","inReplyTo":null,"subject":"[PATCH] Fix tracing when GIT_TRACE is set to an empty string.","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2006-10-14T14:05:25Z","receivedAt":"2006-10-14T14:05:25Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n trace.c |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/trace.c b/trace.c\nindex f9efc91..495e5ed 100644\n--- a/trace.c\n+++ b/trace.c\n@@ -55,7 +55,8 @@ static int get_trace_fd(int *need_close)\n {\n \tchar *trace = getenv(\"GIT_TRACE\");\n \n-\tif (!trace || !strcmp(trace, \"0\") || !strcasecmp(trace, \"false\"))\n+\tif (!trace || !strcmp(trace, \"\") ||\n+\t    !strcmp(trace, \"0\") || !strcasecmp(trace, \"false\"))\n \t\treturn 0;\n \tif (!strcmp(trace, \"1\") || !strcasecmp(trace, \"true\"))\n \t\treturn STDERR_FILENO;\n-- \n1.4.3.rc2.gadba\n"},{"id":"28769","messageId":"7vodseahty.fsf@assigned-by-dhcp.cox.net","threadId":"5924","inReplyTo":"20061014160525.c013e6d2.chriscool@tuxfamily.org","subject":"Re: [PATCH] Fix tracing when GIT_TRACE is set to an empty string.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-14T18:11:05Z","receivedAt":"2006-10-14T18:11:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder <chriscool@tuxfamily.org> writes:\n\n> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n> ---\n>  trace.c |    3 ++-\n>  1 files changed, 2 insertions(+), 1 deletions(-)\n>\n> diff --git a/trace.c b/trace.c\n> index f9efc91..495e5ed 100644\n> --- a/trace.c\n> +++ b/trace.c\n> @@ -55,7 +55,8 @@ static int get_trace_fd(int *need_close)\n>  {\n>  \tchar *trace = getenv(\"GIT_TRACE\");\n>  \n> -\tif (!trace || !strcmp(trace, \"0\") || !strcasecmp(trace, \"false\"))\n> +\tif (!trace || !strcmp(trace, \"\") ||\n> +\t    !strcmp(trace, \"0\") || !strcasecmp(trace, \"false\"))\n>  \t\treturn 0;\n>  \tif (!strcmp(trace, \"1\") || !strcasecmp(trace, \"true\"))\n>  \t\treturn STDERR_FILENO;\n> -- \n> 1.4.3.rc2.gadba\n\nThis means that\n\n\tGIT_TRACE= git-foo\nand\n\tunset GIT_TRACE ; git-foo\n\nshould behave the same way, right?\n\nIf so that sounds sensible.\n"},{"id":"28772","messageId":"200610142155.32816.chriscool@tuxfamily.org","threadId":"5924","inReplyTo":"7vodseahty.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix tracing when GIT_TRACE is set to an empty string.","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2006-10-14T19:55:32Z","receivedAt":"2006-10-14T19:55:32Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Junio C Hamano wrote:\n> Christian Couder <chriscool@tuxfamily.org> writes:\n> > Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n> > ---\n> >  trace.c |    3 ++-\n> >  1 files changed, 2 insertions(+), 1 deletions(-)\n> >\n> > diff --git a/trace.c b/trace.c\n> > index f9efc91..495e5ed 100644\n> > --- a/trace.c\n> > +++ b/trace.c\n> > @@ -55,7 +55,8 @@ static int get_trace_fd(int *need_close)\n> >  {\n> >  \tchar *trace = getenv(\"GIT_TRACE\");\n> >\n> > -\tif (!trace || !strcmp(trace, \"0\") || !strcasecmp(trace, \"false\"))\n> > +\tif (!trace || !strcmp(trace, \"\") ||\n> > +\t    !strcmp(trace, \"0\") || !strcasecmp(trace, \"false\"))\n> >  \t\treturn 0;\n> >  \tif (!strcmp(trace, \"1\") || !strcasecmp(trace, \"true\"))\n> >  \t\treturn STDERR_FILENO;\n> > --\n> > 1.4.3.rc2.gadba\n>\n> This means that\n>\n> \tGIT_TRACE= git-foo\n> and\n> \tunset GIT_TRACE ; git-foo\n>\n> should behave the same way, right?\n\nYes, that's the goal of this patch.\n\n> If so that sounds sensible.\n\nThanks,\nChristian.\n"}]}