{"thread":{"id":"59196","subject":"[PATCH] t5000: modernise archive and :(glob) test","startedAt":"2023-02-04T20:41:32Z","lastAt":"2023-02-05T18:10:32Z","messageCount":2,"participants":["Kostya Farber","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"471501","messageId":"20230204204124.80741-1-kostya.farber@gmail.com","threadId":"59196","inReplyTo":null,"subject":"[PATCH] t5000: modernise archive and :(glob) test","fromName":"Kostya Farber","fromEmail":"kostya.farber@gmail.com","sentAt":"2023-02-04T20:41:24Z","receivedAt":"2023-02-04T20:41:32Z","isPatch":true,"sender":{"key":"kostya.farber@gmail.com","avatar":"https://avatars.githubusercontent.com/u/73378227?v=4"},"body":"To match present day coding guiding codelines let's:\n\n- use <<-EOF, so we can indent all lines to the\n  the same level for this test\n\n- use <<\\EOF to notify the reader that no interpolation\n  is exepected in the body\n\nSigned-off-by: Kostya Farber <kostya.farber@gmail.com>\n---\n t/t5000-tar-tree.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\nindex d473048138..eb3214bc17 100755\n--- a/t/t5000-tar-tree.sh\n+++ b/t/t5000-tar-tree.sh\n@@ -402,11 +402,11 @@ test_expect_success GZIP 'extract tgz file (external gzip)' '\n \n test_expect_success 'archive and :(glob)' '\n \tgit archive -v HEAD -- \":(glob)**/sh\" >/dev/null 2>actual &&\n-\tcat >expect <<EOF &&\n-a/\n-a/bin/\n-a/bin/sh\n-EOF\n+\tcat >expect <<-\\EOF &&\n+\ta/\n+\ta/bin/\n+\ta/bin/sh\n+\tEOF\n \ttest_cmp expect actual\n '\n \n-- \n2.39.0\n\n"},{"id":"471534","messageId":"CAPig+cQrGHuqmmWvqBNs2PKEp_KPrVKVcZyJ3u7akS4BrpA4dw@mail.gmail.com","threadId":"59196","inReplyTo":"20230204204124.80741-1-kostya.farber@gmail.com","subject":"Re: [PATCH] t5000: modernise archive and :(glob) test","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2023-02-05T18:10:17Z","receivedAt":"2023-02-05T18:10:32Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sat, Feb 4, 2023 at 3:54 PM Kostya Farber <kostya.farber@gmail.com> wrote:\n> To match present day coding guiding codelines let's:\n\nWe can probably just say \"coding guidelines\" rather than \"coding\nguiding codelines\".\n\n> - use <<-EOF, so we can indent all lines to the\n>   the same level for this test\n>\n> - use <<\\EOF to notify the reader that no interpolation\n>   is exepected in the body\n\ns/exepected/expected/\n\n> Signed-off-by: Kostya Farber <kostya.farber@gmail.com>\n> ---\n\nFor other reviewers who may not have been following along, this is a\nsuggested replacement[1] to a rejected (by me[2]) GSoC\nmicroproject[3].\n\n> diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\n> @@ -402,11 +402,11 @@ test_expect_success GZIP 'extract tgz file (external gzip)' '\n>  test_expect_success 'archive and :(glob)' '\n>         git archive -v HEAD -- \":(glob)**/sh\" >/dev/null 2>actual &&\n> -       cat >expect <<EOF &&\n> -a/\n> -a/bin/\n> -a/bin/sh\n> -EOF\n> +       cat >expect <<-\\EOF &&\n> +       a/\n> +       a/bin/\n> +       a/bin/sh\n> +       EOF\n>         test_cmp expect actual\n>  '\n\nThanks, these changes look fine.\n\n[1]: https://lore.kernel.org/git/CAPig+cR+1bxgitSmJ47PxD=CPxJjMh5Vm+zRdVU8iEo9pvtutw@mail.gmail.com/\n[2]: https://lore.kernel.org/git/CAPig+cTC4TUK2NXFmP6ymEYYjYAmCSd53dzFhKn0ido8x6uh1Q@mail.gmail.com/\n[3]: https://lore.kernel.org/git/20230202202557.19297-1-kostya.farber@gmail.com/\n"}]}