{"thread":{"id":"5917","subject":"[PATCH] git-svn: fix commits over svn+ssh://","startedAt":"2006-10-14T09:02:37Z","lastAt":"2006-10-14T14:57:51Z","messageCount":2,"participants":["Eric Wong","Pierre HABOUZIT"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"28754","messageId":"11608165571212-git-send-email-normalperson@yhbt.net","threadId":"5917","inReplyTo":null,"subject":"[PATCH] git-svn: fix commits over svn+ssh://","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-10-14T09:02:37Z","receivedAt":"2006-10-14T09:02:37Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Once a get_commit_editor has been called from an SVN session, RA\nlayer operations are not allowed (well, unless you're using\nfile:// or http(s)://).  So we'll pass an alternate SVN::Ra\nobject to our editor object for running 'check-path'.\n\nThis should fix commits over svnserve (svn:// without ssh, too).\n\nCloses Debian bug #392702, thanks to Pierre Habouzit for\nreporting the bug.\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n---\n git-svn.perl |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex a128d90..0f968c8 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -536,7 +536,7 @@ sub commit_lib {\n \t\t\t$SVN = libsvn_connect($repo);\n \t\t\tmy $ed = SVN::Git::Editor->new(\n \t\t\t\t\t{\tr => $r_last,\n-\t\t\t\t\t\tra => $SVN,\n+\t\t\t\t\t\tra => $SVN_LOG,\n \t\t\t\t\t\tc => $c,\n \t\t\t\t\t\tsvn_path => $SVN_PATH\n \t\t\t\t\t},\n@@ -832,7 +832,7 @@ sub commit_diff {\n \t$SVN ||= libsvn_connect($repo);\n \tmy @lock = $SVN::Core::VERSION ge '1.2.0' ? (undef, 0) : ();\n \tmy $ed = SVN::Git::Editor->new({\tr => $SVN->get_latest_revnum,\n-\t\t\t\t\t\tra => $SVN, c => $tb,\n+\t\t\t\t\t\tra => $SVN_LOG, c => $tb,\n \t\t\t\t\t\tsvn_path => $SVN_PATH\n \t\t\t\t\t},\n \t\t\t\t$SVN->get_commit_editor($_message,\n-- \n1.4.3.rc2.g1cbb0\n"},{"id":"28764","messageId":"20061014145751.GA8840@hades.madism.org","threadId":"5917","inReplyTo":"11608165571212-git-send-email-normalperson@yhbt.net","subject":"[PATCH] Re: git-svn: fix commits over svn+ssh://","fromName":"Pierre HABOUZIT","fromEmail":"madcoder@debian.org","sentAt":"2006-10-14T14:57:51Z","receivedAt":"2006-10-14T14:57:51Z","isPatch":true,"sender":{"key":"madcoder@debian.org","avatar":"https://avatars.githubusercontent.com/u/44708?v=4"},"body":"  I confirm that fixes it indeed.\n\nOn Sat, Oct 14, 2006 at 02:02:37AM -0700, Eric Wong wrote:\n> Once a get_commit_editor has been called from an SVN session, RA\n> layer operations are not allowed (well, unless you're using\n> file:// or http(s)://).  So we'll pass an alternate SVN::Ra\n> object to our editor object for running 'check-path'.\n> \n> This should fix commits over svnserve (svn:// without ssh, too).\n> \n> Closes Debian bug #392702, thanks to Pierre Habouzit for\n> reporting the bug.\n> \n> Signed-off-by: Eric Wong <normalperson@yhbt.net>\n> ---\n>  git-svn.perl |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index a128d90..0f968c8 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -536,7 +536,7 @@ sub commit_lib {\n>  \t\t\t$SVN = libsvn_connect($repo);\n>  \t\t\tmy $ed = SVN::Git::Editor->new(\n>  \t\t\t\t\t{\tr => $r_last,\n> -\t\t\t\t\t\tra => $SVN,\n> +\t\t\t\t\t\tra => $SVN_LOG,\n>  \t\t\t\t\t\tc => $c,\n>  \t\t\t\t\t\tsvn_path => $SVN_PATH\n>  \t\t\t\t\t},\n> @@ -832,7 +832,7 @@ sub commit_diff {\n>  \t$SVN ||= libsvn_connect($repo);\n>  \tmy @lock = $SVN::Core::VERSION ge '1.2.0' ? (undef, 0) : ();\n>  \tmy $ed = SVN::Git::Editor->new({\tr => $SVN->get_latest_revnum,\n> -\t\t\t\t\t\tra => $SVN, c => $tb,\n> +\t\t\t\t\t\tra => $SVN_LOG, c => $tb,\n>  \t\t\t\t\t\tsvn_path => $SVN_PATH\n>  \t\t\t\t\t},\n>  \t\t\t\t$SVN->get_commit_editor($_message,\n-- \n·O·  Pierre Habouzit\n··O                                                madcoder@debian.org\nOOO                                                http://www.madism.org\n"}]}