{"thread":{"id":"59120","subject":"Is GGG mislabeling topics?","startedAt":"2023-01-19T17:32:21Z","lastAt":"2023-02-02T17:06:17Z","messageCount":3,"participants":["Junio C Hamano","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"470715","messageId":"xmqqpmba1ld4.fsf@gitster.g","threadId":"59120","inReplyTo":null,"subject":"Is GGG mislabeling topics?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-01-19T17:32:07Z","receivedAt":"2023-01-19T17:32:21Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"These comments from GGG bot\n\n    https://github.com/git/git/pull/1435#issuecomment-1386301994\n    https://github.com/git/git/pull/1435#issuecomment-1386302018\n\nadd 'next' and 'seen' labels, citing merges e3ead5f and c52b021\nrespectively, but these merges are of a topic that has little to do\nwith this pull request (#1435).  Is this expected?\n\n"},{"id":"471364","messageId":"52c9ed08-43c3-80c6-32f6-42209b799af6@gmx.de","threadId":"59120","inReplyTo":"xmqqpmba1ld4.fsf@gitster.g","subject":"Re: Is GGG mislabeling topics?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2023-02-02T14:20:24Z","receivedAt":"2023-02-02T14:20:36Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Thu, 19 Jan 2023, Junio C Hamano wrote:\n\n> These comments from GGG bot\n>\n>     https://github.com/git/git/pull/1435#issuecomment-1386301994\n>     https://github.com/git/git/pull/1435#issuecomment-1386302018\n>\n> add 'next' and 'seen' labels, citing merges e3ead5f and c52b021\n> respectively, but these merges are of a topic that has little to do\n> with this pull request (#1435).  Is this expected?\n\nSince I could not make `amlog` work reliably for GitGitGadget (and you\nwill recall that it was not for lack of trying, not by _any_ stretch of\nimagination, I really, really put in a few weeks and it just turned out\nthat there was no way to come up with a 100% correct record of mappings\nbetween patches on the Git mailing list and the commits in git/git), the\nbest I could do was to use `range-diff` to identify which patches made it\nupstream, and what the upstream OIDs are.\n\nWhat you see in action is that this is imperfect. Because in the absence\nof actual git/git commits that correspond to the GitGitGadget Pull\nRequests' commits, `range-diff` will even identify replacements or\nalternative patches as the git/git commits corresponding to the PR.\n\nI don't see how this could be made robust without forcing you to adopt\ndifferent processes than you are using right now.\n\nCiao,\nJohannes\n"},{"id":"471374","messageId":"xmqqk010uhdr.fsf@gitster.g","threadId":"59120","inReplyTo":"52c9ed08-43c3-80c6-32f6-42209b799af6@gmx.de","subject":"Re: Is GGG mislabeling topics?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-02-02T17:06:08Z","receivedAt":"2023-02-02T17:06:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> On Thu, 19 Jan 2023, Junio C Hamano wrote:\n>\n>> These comments from GGG bot\n>>\n>>     https://github.com/git/git/pull/1435#issuecomment-1386301994\n>>     https://github.com/git/git/pull/1435#issuecomment-1386302018\n>>\n>> add 'next' and 'seen' labels, citing merges e3ead5f and c52b021\n>> respectively, but these merges are of a topic that has little to do\n>> with this pull request (#1435).  Is this expected?\n>\n> Since I could not make `amlog` work reliably for GitGitGadget ...\n\n\"git rev-list e3ead5f^..e3ead5f\" (as the comment claims that GGG saw\ne3ead5f merged this topic) should be able to identify the individual\ncommits merged, in this case three topmost commits from Peff leading\nto 6c065f72 (http: support CURLOPT_PROTOCOLS_STR, 2023-01-16).\n\n> What you see in action is that this is imperfect. Because in the absence\n> of actual git/git commits that correspond to the GitGitGadget Pull\n> Requests' commits, `range-diff` will even identify replacements or\n> alternative patches as the git/git commits corresponding to the PR.\n\nHmph, so the three topmost commits were mistaken to match the\npatch(es) on this branch.  That's sort-of understandable but not\nvery satisfactory.\n\nAnd amlog seems to know the message ID that resulted in that topmost\ncommit that was merged to 'next'.\n\n    $ git notes --ref notes/amlog show e3ead5f^2\n    Message-Id: <Y8YQUD8bMHc4Lmph@coredump.intra.peff.net>\n\nPerhaps GGG can be told to recognise that it is not one of the\nmessages it sent out before, or something?\n\n"}]}