{"thread":{"id":"59063","subject":"[PATCH] git-bisect-lk2009: update java code conventions link","startedAt":"2023-01-10T08:39:14Z","lastAt":"2023-01-10T12:27:38Z","messageCount":5,"participants":["Andrei Rybak","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"470049","messageId":"20230110083801.186789-1-rybak.a.v@gmail.com","threadId":"59063","inReplyTo":null,"subject":"[PATCH] git-bisect-lk2009: update java code conventions link","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2023-01-10T08:38:01Z","receivedAt":"2023-01-10T08:39:14Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"A reference to Java Code Conventions in git-bisect-lk2009.txt uses an\noutdated URL that redirects to table of contents for the conventions.\nThe actual claim about \"80%\" that this reference backs up is on the\nfirst page of the conventions:\n\n https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html\n\nUse this newer URL and its title in the reference.\n\nSigned-off-by: Andrei Rybak \n---\n Documentation/git-bisect-lk2009.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt\nindex f3d9566c89..36168792ee 100644\n--- a/Documentation/git-bisect-lk2009.txt\n+++ b/Documentation/git-bisect-lk2009.txt\n@@ -1348,7 +1348,7 @@ References\n ----------\n \n - [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'. Nist Planning Report 02-3], see Executive Summary and Chapter 8.\n-- [[[2]]] http://www.oracle.com/technetwork/java/codeconvtoc-136057.html['Code Conventions for the Java Programming Language'. Sun Microsystems.]\n+- [[[2]]] https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html['Code Conventions for the Java Programming Language: 1. Introduction'. Sun Microsystems.]\n - [[[3]]] https://en.wikipedia.org/wiki/Software_maintenance['Software maintenance'. Wikipedia.]\n - [[[4]]] https://lore.kernel.org/git/7vps5xsbwp.fsf_-_@assigned-by-dhcp.cox.net/[Junio C Hamano. 'Automated bisect success story'.]\n - [[[5]]] https://lwn.net/Articles/317154/[Christian Couder. 'Fully automated bisecting with \"git bisect run\"'. LWN.net.]\n-- \n2.38.1\n\n"},{"id":"470052","messageId":"20230110093251.193552-1-rybak.a.v@gmail.com","threadId":"59063","inReplyTo":"20230110083801.186789-1-rybak.a.v@gmail.com","subject":"[PATCH v2 0/2] update references in git-bisect-lk2009.txt","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2023-01-10T09:32:49Z","receivedAt":"2023-01-10T09:33:16Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"While double-checking the patch I noticed that nist.gov link is also dead.\n\nChanges since v1:\n\n * new second patch which fixes nist report link\n\nAndrei Rybak (2):\n git-bisect-lk2009: update java code conventions link\n git-bisect-lk2009: update nist report link\n\n Documentation/git-bisect-lk2009.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n-- \n2.38.1\n\n"},{"id":"470053","messageId":"20230110093251.193552-2-rybak.a.v@gmail.com","threadId":"59063","inReplyTo":"20230110093251.193552-1-rybak.a.v@gmail.com","subject":"[PATCH v2 1/2] git-bisect-lk2009: update java code conventions link","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2023-01-10T09:32:50Z","receivedAt":"2023-01-10T09:33:19Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"A reference to Java Code Conventions in git-bisect-lk2009.txt uses an\noutdated URL that redirects to table of contents for the conventions.\nThe actual claim about \"80%\" that this reference backs up is on the\nfirst page of the conventions:\n\n https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html\n\nUse this newer URL and its title in the reference.\n\nSigned-off-by: Andrei Rybak \n---\n Documentation/git-bisect-lk2009.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt\nindex f3d9566c89..36168792ee 100644\n--- a/Documentation/git-bisect-lk2009.txt\n+++ b/Documentation/git-bisect-lk2009.txt\n@@ -1348,7 +1348,7 @@ References\n ----------\n \n - [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'. Nist Planning Report 02-3], see Executive Summary and Chapter 8.\n-- [[[2]]] http://www.oracle.com/technetwork/java/codeconvtoc-136057.html['Code Conventions for the Java Programming Language'. Sun Microsystems.]\n+- [[[2]]] https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html['Code Conventions for the Java Programming Language: 1. Introduction'. Sun Microsystems.]\n - [[[3]]] https://en.wikipedia.org/wiki/Software_maintenance['Software maintenance'. Wikipedia.]\n - [[[4]]] https://lore.kernel.org/git/7vps5xsbwp.fsf_-_@assigned-by-dhcp.cox.net/[Junio C Hamano. 'Automated bisect success story'.]\n - [[[5]]] https://lwn.net/Articles/317154/[Christian Couder. 'Fully automated bisecting with \"git bisect run\"'. LWN.net.]\n-- \n2.38.1\n\n"},{"id":"470054","messageId":"20230110093251.193552-3-rybak.a.v@gmail.com","threadId":"59063","inReplyTo":"20230110093251.193552-1-rybak.a.v@gmail.com","subject":"[PATCH v2 2/2] git-bisect-lk2009: update nist report link","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2023-01-10T09:32:51Z","receivedAt":"2023-01-10T09:33:49Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"Commit d656218a83 (docs/bisect-lk2009: update nist report link,\n2017-04-20) replaced a dead link to news release on nist.gov. However,\nthis might be confusing to the reader (like myself) because the article\ngit-bisect-lk2009.txt quotes from the news release but the exact quote\ncannot be found in the full report. In addition to that, the link added\nin 2017 is also dead in 2023.\n\nReplace the reference to nist.gov with an version of the original NIST\nnews release archived to the Wayback Machine. Include also an updated\nlink to a live version of the full report.\n\nSigned-off-by: Andrei Rybak \n---\n Documentation/git-bisect-lk2009.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\nI wasn't sure about inclusion of links to https://web.archive.org, but there is\na single precedent already in \"Documentation/gitcore-tutorial.txt\".\n\ndiff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt\nindex 36168792ee..0bc165788e 100644\n--- a/Documentation/git-bisect-lk2009.txt\n+++ b/Documentation/git-bisect-lk2009.txt\n@@ -1347,7 +1347,7 @@ author to given a talk and for publishing this paper.\n References\n ----------\n \n-- [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'. Nist Planning Report 02-3], see Executive Summary and Chapter 8.\n+- [[[1]]] https://web.archive.org/web/20091206032101/http://www.nist.gov/public_affairs/releases/n02-10.htm['Software Errors Cost U.S. Economy $59.5 Billion Annually'. Nist News Release.] See also https://www.nist.gov/system/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'. Nist Planning Report 02-3], Executive Summary and Chapter 8.\n - [[[2]]] https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html['Code Conventions for the Java Programming Language: 1. Introduction'. Sun Microsystems.]\n - [[[3]]] https://en.wikipedia.org/wiki/Software_maintenance['Software maintenance'. Wikipedia.]\n - [[[4]]] https://lore.kernel.org/git/7vps5xsbwp.fsf_-_@assigned-by-dhcp.cox.net/[Junio C Hamano. 'Automated bisect success story'.]\n-- \n2.38.1\n\n"},{"id":"470060","messageId":"Y71ZdbH0H3LkILHp@coredump.intra.peff.net","threadId":"59063","inReplyTo":"20230110093251.193552-3-rybak.a.v@gmail.com","subject":"Re: [PATCH v2 2/2] git-bisect-lk2009: update nist report link","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2023-01-10T12:26:29Z","receivedAt":"2023-01-10T12:27:38Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jan 10, 2023 at 10:32:51AM +0100, Andrei Rybak wrote:\n\n> Commit d656218a83 (docs/bisect-lk2009: update nist report link,\n> 2017-04-20) replaced a dead link to news release on nist.gov. However,\n> this might be confusing to the reader (like myself) because the article\n> git-bisect-lk2009.txt quotes from the news release but the exact quote\n> cannot be found in the full report. In addition to that, the link added\n> in 2017 is also dead in 2023.\n> \n> Replace the reference to nist.gov with an version of the original NIST\n> news release archived to the Wayback Machine. Include also an updated\n> link to a live version of the full report.\n\nBoth this and the other patch seem reasonable to me.\n\n> I wasn't sure about inclusion of links to https://web.archive.org, but there is\n> a single precedent already in \"Documentation/gitcore-tutorial.txt\".\n\nI think it's a good match for this kind of link. The point is to cite a\nhistorical artifact, and if archive.org is the only way to get the artifact,\nthen that's what we should do. Arguably it's what I should have done in\nd656218a83 in the first place.\n\n> --- a/Documentation/git-bisect-lk2009.txt\n> +++ b/Documentation/git-bisect-lk2009.txt\n> @@ -1347,7 +1347,7 @@ author to given a talk and for publishing this paper.\n> References\n> ----------\n> \n> -- [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'. Nist Planning Report 02-3], see Executive Summary and Chapter 8.\n> +- [[[1]]] https://web.archive.org/web/20091206032101/http://www.nist.gov/public_affairs/releases/n02-10.htm['Software Errors Cost U.S. Economy $59.5 Billion Annually'. Nist News Release.] See also https://www.nist.gov/system/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'. Nist Planning Report 02-3], Executive Summary and Chapter 8.\n\nThe link target given to archive.org is for http, not https. I guess it\ndoesn't really matter as they archived the same content back then, and\nthe actual browser connection to archive.org will be over https. And\nyours is more historically accurate. ;)\n\n-Peff\n"}]}