{"thread":{"id":"58961","subject":"[PATCH] e-mail workflow: Message-ID is spelled with ID in both capital letters","startedAt":"2022-12-16T01:47:25Z","lastAt":"2023-04-07T19:34:12Z","messageCount":3,"participants":["Junio C Hamano","Elijah Newren","M Hickford"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"469153","messageId":"xmqqsfhgnmqg.fsf@gitster.g","threadId":"58961","inReplyTo":null,"subject":"[PATCH] e-mail workflow: Message-ID is spelled with ID in both capital letters","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-12-16T01:47:19Z","receivedAt":"2022-12-16T01:47:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"We used to write \"Message-Id:\" and \"Message-ID:\" pretty much\ninterchangeably, and the header name is defined to be case\ninsensitive by the RFCs, but the canonical form \"Message-ID:\" is\nused throughout the RFC documents, so let's imitate it ourselves.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n Documentation/MyFirstContribution.txt | 14 +++----\n Documentation/git-format-patch.txt    |  4 +-\n Documentation/git-send-email.txt      |  2 +-\n git-send-email.perl                   |  4 +-\n log-tree.c                            |  2 +-\n mailinfo.c                            |  4 +-\n t/t4014-format-patch.sh               | 56 +++++++++++++--------------\n t/t4150-am.sh                         |  8 ++--\n t/t4258/mbox                          |  2 +-\n t/t5100/msg0002                       |  2 +-\n t/t5100/msg0003                       |  2 +-\n t/t5100/msg0012--message-id           |  2 +-\n t/t5100/quoted-cr.mbox                |  4 +-\n t/t5100/sample.mbox                   |  6 +--\n t/t9001-send-email.sh                 | 38 +++++++++---------\n 15 files changed, 75 insertions(+), 75 deletions(-)\n\ndiff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt\nindex ccfd0cb5f3..2f8b7d597f 100644\n--- a/Documentation/MyFirstContribution.txt\n+++ b/Documentation/MyFirstContribution.txt\n@@ -1171,21 +1171,21 @@ between your last version and now, if it's something significant. You do not\n need the exact same body in your second cover letter; focus on explaining to\n reviewers the changes you've made that may not be as visible.\n \n-You will also need to go and find the Message-Id of your previous cover letter.\n+You will also need to go and find the Message-ID of your previous cover letter.\n You can either note it when you send the first series, from the output of `git\n send-email`, or you can look it up on the\n https://lore.kernel.org/git[mailing list]. Find your cover letter in the\n-archives, click on it, then click \"permalink\" or \"raw\" to reveal the Message-Id\n+archives, click on it, then click \"permalink\" or \"raw\" to reveal the Message-ID\n header. It should match:\n \n ----\n-Message-Id: <foo.12345.author@example.com>\n+Message-ID: <foo.12345.author@example.com>\n ----\n \n-Your Message-Id is `<foo.12345.author@example.com>`. This example will be used\n-below as well; make sure to replace it with the correct Message-Id for your\n-**previous cover letter** - that is, if you're sending v2, use the Message-Id\n-from v1; if you're sending v3, use the Message-Id from v2.\n+Your Message-ID is `<foo.12345.author@example.com>`. This example will be used\n+below as well; make sure to replace it with the correct Message-ID for your\n+**previous cover letter** - that is, if you're sending v2, use the Message-ID\n+from v1; if you're sending v3, use the Message-ID from v2.\n \n While you're looking at the email, you should also note who is CC'd, as it's\n common practice in the mailing list to keep all CCs on a thread. You can add\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex dfcc7da4c2..508f3ae2c0 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -99,7 +99,7 @@ To omit patch numbers from the subject, use `-N`.\n \n If given `--thread`, `git-format-patch` will generate `In-Reply-To` and\n `References` headers to make the second and subsequent patch mails appear\n-as replies to the first mail; this also generates a `Message-Id` header to\n+as replies to the first mail; this also generates a `Message-ID` header to\n reference.\n \n OPTIONS\n@@ -163,7 +163,7 @@ include::diff-options.txt[]\n --no-thread::\n \tControls addition of `In-Reply-To` and `References` headers to\n \tmake the second and subsequent mails appear as replies to the\n-\tfirst.  Also controls generation of the `Message-Id` header to\n+\tfirst.  Also controls generation of the `Message-ID` header to\n \treference.\n +\n The optional <style> argument can be either `shallow` or `deep`.\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 765b2df853..b0f438ec99 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -93,7 +93,7 @@ See the CONFIGURATION section for `sendemail.multiEdit`.\n \n --in-reply-to=<identifier>::\n \tMake the first mail (or all the mails with `--no-thread`) appear as a\n-\treply to the given Message-Id, which avoids breaking threads to\n+\treply to the given Message-ID, which avoids breaking threads to\n \tprovide a new patch series.\n \tThe second and subsequent emails will be sent as replies according to\n \tthe `--[no-]chain-reply-to` setting.\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 5861e99a6e..092b8938c8 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -1530,7 +1530,7 @@ sub send_message {\n To: $to${ccline}\n Subject: $subject\n Date: $date\n-Message-Id: $message_id\n+Message-ID: $message_id\n \";\n \tif ($use_xmailer) {\n \t\t$header .= \"X-Mailer: git-send-email $gitversion\\n\";\n@@ -1825,7 +1825,7 @@ sub process_file {\n \t\t\t\t$has_mime_version = 1;\n \t\t\t\tpush @xh, $_;\n \t\t\t}\n-\t\t\telsif (/^Message-Id: (.*)/i) {\n+\t\t\telsif (/^Message-ID: (.*)/i) {\n \t\t\t\t$message_id = $1;\n \t\t\t}\n \t\t\telsif (/^Content-Transfer-Encoding: (.*)/i) {\ndiff --git a/log-tree.c b/log-tree.c\nindex 1dd5fcbf7b..bbaf26c6b6 100644\n--- a/log-tree.c\n+++ b/log-tree.c\n@@ -440,7 +440,7 @@ void log_write_email_headers(struct rev_info *opt, struct commit *commit,\n \tfprintf(opt->diffopt.file, \"From %s Mon Sep 17 00:00:00 2001\\n\", name);\n \tgraph_show_oneline(opt->graph);\n \tif (opt->message_id) {\n-\t\tfprintf(opt->diffopt.file, \"Message-Id: <%s>\\n\", opt->message_id);\n+\t\tfprintf(opt->diffopt.file, \"Message-ID: <%s>\\n\", opt->message_id);\n \t\tgraph_show_oneline(opt->graph);\n \t}\n \tif (opt->ref_message_ids && opt->ref_message_ids->nr > 0) {\ndiff --git a/mailinfo.c b/mailinfo.c\nindex 833d28612f..580c2316a9 100644\n--- a/mailinfo.c\n+++ b/mailinfo.c\n@@ -597,7 +597,7 @@ static int check_header(struct mailinfo *mi,\n \t\tret = 1;\n \t\tgoto check_header_out;\n \t}\n-\tif (parse_header(line, \"Message-Id\", mi, &sb)) {\n+\tif (parse_header(line, \"Message-ID\", mi, &sb)) {\n \t\tif (mi->add_message_id)\n \t\t\tmi->message_id = strbuf_detach(&sb, NULL);\n \t\tret = 1;\n@@ -829,7 +829,7 @@ static int handle_commit_msg(struct mailinfo *mi, struct strbuf *line)\n \tif (patchbreak(line)) {\n \t\tif (mi->message_id)\n \t\t\tstrbuf_addf(&mi->log_message,\n-\t\t\t\t    \"Message-Id: %s\\n\", mi->message_id);\n+\t\t\t\t    \"Message-ID: %s\\n\", mi->message_id);\n \t\treturn 1;\n \t}\n \ndiff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\nindex de1da4673d..533d21fcaf 100755\n--- a/t/t4014-format-patch.sh\n+++ b/t/t4014-format-patch.sh\n@@ -445,13 +445,13 @@ test_expect_success 'no threading' '\n \n cat >expect.thread <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n ---\n-Message-Id: <1>\n+Message-ID: <1>\n In-Reply-To: <0>\n References: <0>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <0>\n References: <0>\n EOF\n@@ -462,15 +462,15 @@ test_expect_success 'thread' '\n \n cat >expect.in-reply-to <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n In-Reply-To: <1>\n References: <1>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <1>\n References: <1>\n ---\n-Message-Id: <3>\n+Message-ID: <3>\n In-Reply-To: <1>\n References: <1>\n EOF\n@@ -482,17 +482,17 @@ test_expect_success 'thread in-reply-to' '\n \n cat >expect.cover-letter <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n ---\n-Message-Id: <1>\n+Message-ID: <1>\n In-Reply-To: <0>\n References: <0>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <0>\n References: <0>\n ---\n-Message-Id: <3>\n+Message-ID: <3>\n In-Reply-To: <0>\n References: <0>\n EOF\n@@ -503,21 +503,21 @@ test_expect_success 'thread cover-letter' '\n \n cat >expect.cl-irt <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n In-Reply-To: <1>\n References: <1>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <0>\n References: <1>\n \t<0>\n ---\n-Message-Id: <3>\n+Message-ID: <3>\n In-Reply-To: <0>\n References: <1>\n \t<0>\n ---\n-Message-Id: <4>\n+Message-ID: <4>\n In-Reply-To: <0>\n References: <1>\n \t<0>\n@@ -535,13 +535,13 @@ test_expect_success 'thread explicit shallow' '\n \n cat >expect.deep <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n ---\n-Message-Id: <1>\n+Message-ID: <1>\n In-Reply-To: <0>\n References: <0>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <1>\n References: <0>\n \t<1>\n@@ -553,16 +553,16 @@ test_expect_success 'thread deep' '\n \n cat >expect.deep-irt <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n In-Reply-To: <1>\n References: <1>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <0>\n References: <1>\n \t<0>\n ---\n-Message-Id: <3>\n+Message-ID: <3>\n In-Reply-To: <2>\n References: <1>\n \t<0>\n@@ -576,18 +576,18 @@ test_expect_success 'thread deep in-reply-to' '\n \n cat >expect.deep-cl <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n ---\n-Message-Id: <1>\n+Message-ID: <1>\n In-Reply-To: <0>\n References: <0>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <1>\n References: <0>\n \t<1>\n ---\n-Message-Id: <3>\n+Message-ID: <3>\n In-Reply-To: <2>\n References: <0>\n \t<1>\n@@ -600,22 +600,22 @@ test_expect_success 'thread deep cover-letter' '\n \n cat >expect.deep-cl-irt <<EOF\n ---\n-Message-Id: <0>\n+Message-ID: <0>\n In-Reply-To: <1>\n References: <1>\n ---\n-Message-Id: <2>\n+Message-ID: <2>\n In-Reply-To: <0>\n References: <1>\n \t<0>\n ---\n-Message-Id: <3>\n+Message-ID: <3>\n In-Reply-To: <2>\n References: <1>\n \t<0>\n \t<2>\n ---\n-Message-Id: <4>\n+Message-ID: <4>\n In-Reply-To: <3>\n References: <1>\n \t<0>\ndiff --git a/t/t4150-am.sh b/t/t4150-am.sh\nindex cdad4b6880..95b48103b8 100755\n--- a/t/t4150-am.sh\n+++ b/t/t4150-am.sh\n@@ -103,7 +103,7 @@ test_expect_success setup '\n \n \tgit format-patch --stdout first >patch1 &&\n \t{\n-\t\techo \"Message-Id: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\" &&\n+\t\techo \"Message-ID: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\" &&\n \t\techo \"X-Fake-Field: Line One\" &&\n \t\techo \"X-Fake-Field: Line Two\" &&\n \t\techo \"X-Fake-Field: Line Three\" &&\n@@ -910,7 +910,7 @@ test_expect_success 'am --message-id really adds the message id' '\n \tgit am --message-id patch1.eml &&\n \ttest_path_is_missing .git/rebase-apply &&\n \tgit cat-file commit HEAD | tail -n1 >actual &&\n-\tgrep Message-Id patch1.eml >expected &&\n+\tgrep Message-ID patch1.eml >expected &&\n \ttest_cmp expected actual\n '\n \n@@ -922,7 +922,7 @@ test_expect_success 'am.messageid really adds the message id' '\n \tgit am patch1.eml &&\n \ttest_path_is_missing .git/rebase-apply &&\n \tgit cat-file commit HEAD | tail -n1 >actual &&\n-\tgrep Message-Id patch1.eml >expected &&\n+\tgrep Message-ID patch1.eml >expected &&\n \ttest_cmp expected actual\n '\n \n@@ -933,7 +933,7 @@ test_expect_success 'am --message-id -s signs off after the message id' '\n \tgit am -s --message-id patch1.eml &&\n \ttest_path_is_missing .git/rebase-apply &&\n \tgit cat-file commit HEAD | tail -n2 | head -n1 >actual &&\n-\tgrep Message-Id patch1.eml >expected &&\n+\tgrep Message-ID patch1.eml >expected &&\n \ttest_cmp expected actual\n '\n \ndiff --git a/t/t4258/mbox b/t/t4258/mbox\nindex c62819f3d2..1ae528ba78 100644\n--- a/t/t4258/mbox\n+++ b/t/t4258/mbox\n@@ -2,7 +2,7 @@ From: A U Thor <mail@example.com>\n To: list@example.org\n Subject: [PATCH v2] sample\n Date: Mon,  3 Aug 2020 22:40:55 +0700\n-Message-Id: <msg-id@example.com>\n+Message-ID: <msg-id@example.com>\n Content-Type: text/plain; charset=\"utf-8\"\n Content-Transfer-Encoding: base64\n \ndiff --git a/t/t5100/msg0002 b/t/t5100/msg0002\nindex e2546ec733..1089382425 100644\n--- a/t/t5100/msg0002\n+++ b/t/t5100/msg0002\n@@ -3,7 +3,7 @@ message:\n \n From: Nit Picker <nit.picker@example.net>\n Subject: foo is too old\n-Message-Id: <nitpicker.12121212@example.net>\n+Message-ID: <nitpicker.12121212@example.net>\n \n Hopefully this would fix the problem stated there.\n \ndiff --git a/t/t5100/msg0003 b/t/t5100/msg0003\nindex 1ac68101b1..3402b534a6 100644\n--- a/t/t5100/msg0003\n+++ b/t/t5100/msg0003\n@@ -3,7 +3,7 @@ message:\n \n From: Nit Picker <nit.picker@example.net>\n Subject: foo is too old\n-Message-Id: <nitpicker.12121212@example.net>\n+Message-ID: <nitpicker.12121212@example.net>\n \n Hopefully this would fix the problem stated there.\n \ndiff --git a/t/t5100/msg0012--message-id b/t/t5100/msg0012--message-id\nindex 376e26e9ae..44482958ce 100644\n--- a/t/t5100/msg0012--message-id\n+++ b/t/t5100/msg0012--message-id\n@@ -5,4 +5,4 @@ docutils заменён на python-docutils\n python-docutils. В то время как сам rest2web не нужен.\n \n Signed-off-by: Dmitriy Blinov <bda@mnsspb.ru>\n-Message-Id: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\n+Message-ID: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\ndiff --git a/t/t5100/quoted-cr.mbox b/t/t5100/quoted-cr.mbox\nindex 909021bb7a..a529d4de08 100644\n--- a/t/t5100/quoted-cr.mbox\n+++ b/t/t5100/quoted-cr.mbox\n@@ -3,7 +3,7 @@ From: A U Thor <mail@example.com>\n To: list@example.org\n Subject: [PATCH v2] sample\n Date: Mon,  3 Aug 2020 22:40:55 +0700\n-Message-Id: <msg-id@example.com>\n+Message-ID: <msg-id@example.com>\n Content-Type: text/plain; charset=\"utf-8\"\n Content-Transfer-Encoding: base64\n \n@@ -27,7 +27,7 @@ From: A U Thor <mail@example.com>\n To: list@example.org\n Subject: [PATCH v2] sample\n Date: Mon,  3 Aug 2020 22:40:55 +0700\n-Message-Id: <msg-id2@example.com>\n+Message-ID: <msg-id2@example.com>\n Content-Type: text/plain; charset=\"utf-8\"\n Content-Transfer-Encoding: base64\n \ndiff --git a/t/t5100/sample.mbox b/t/t5100/sample.mbox\nindex 6d4d0e4474..4a54ee5171 100644\n--- a/t/t5100/sample.mbox\n+++ b/t/t5100/sample.mbox\n@@ -35,7 +35,7 @@ message:\n \n From: Nit Picker <nit.picker@example.net>\n Subject: foo is too old\n-Message-Id: <nitpicker.12121212@example.net>\n+Message-ID: <nitpicker.12121212@example.net>\n \n Hopefully this would fix the problem stated there.\n \n@@ -78,7 +78,7 @@ message:\n \n From: Nit Picker <nit.picker@example.net>\n Subject: foo is too old\n-Message-Id: <nitpicker.12121212@example.net>\n+Message-ID: <nitpicker.12121212@example.net>\n \n Hopefully this would fix the problem stated there.\n \n@@ -508,7 +508,7 @@ From bda@mnsspb.ru Wed Nov 12 17:54:41 2008\n From: Dmitriy Blinov <bda@mnsspb.ru>\n To: navy-patches@dinar.mns.mnsspb.ru\n Date: Wed, 12 Nov 2008 17:54:41 +0300\n-Message-Id: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\n+Message-ID: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\n X-Mailer: git-send-email 1.5.6.5\n MIME-Version: 1.0\n Content-Type: text/plain;\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 1130ef21b3..5c2c282d08 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -12,7 +12,7 @@ PREREQ=\"PERL\"\n \n replace_variable_fields () {\n \tsed\t-e \"s/^\\(Date:\\).*/\\1 DATE-STRING/\" \\\n-\t\t-e \"s/^\\(Message-Id:\\).*/\\1 MESSAGE-ID-STRING/\" \\\n+\t\t-e \"s/^\\(Message-ID:\\).*/\\1 MESSAGE-ID-STRING/\" \\\n \t\t-e \"s/^\\(X-Mailer:\\).*/\\1 X-MAILER-STRING/\"\n }\n \n@@ -225,7 +225,7 @@ Cc: cc@example.com,\n \ttwo@example.com\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n In-Reply-To: <unique-message-id@example.com>\n References: <unique-message-id@example.com>\n@@ -617,7 +617,7 @@ test_expect_success $PREREQ 'In-Reply-To without --chain-reply-to' '\n \tsed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt1 >actual &&\n \ttest_cmp expect actual &&\n \t# Second and subsequent messages are replies to the first one\n-\tsed -n -e \"s/^Message-Id: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n+\tsed -n -e \"s/^Message-ID: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n \tsed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt2 >actual &&\n \ttest_cmp expect actual &&\n \tsed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt3 >actual &&\n@@ -637,10 +637,10 @@ test_expect_success $PREREQ 'In-Reply-To with --chain-reply-to' '\n \t\t2>errors &&\n \tsed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt1 >actual &&\n \ttest_cmp expect actual &&\n-\tsed -n -e \"s/^Message-Id: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n+\tsed -n -e \"s/^Message-ID: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n \tsed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt2 >actual &&\n \ttest_cmp expect actual &&\n-\tsed -n -e \"s/^Message-Id: *\\(.*\\)/\\1/p\" msgtxt2 >expect &&\n+\tsed -n -e \"s/^Message-ID: *\\(.*\\)/\\1/p\" msgtxt2 >expect &&\n \tsed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt3 >actual &&\n \ttest_cmp expect actual\n '\n@@ -713,7 +713,7 @@ Cc: cc@example.com,\n \ttwo@example.com\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -759,7 +759,7 @@ Cc: A <author@example.com>,\n \ttwo@example.com\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -796,7 +796,7 @@ Cc: A <author@example.com>,\n \tC O Mitter <committer@example.com>\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -824,7 +824,7 @@ From: Example <from@example.com>\n To: to@example.com\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -860,7 +860,7 @@ Cc: A <author@example.com>,\n \tcc-cmd@example.com\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -893,7 +893,7 @@ Cc: A <author@example.com>,\n \ttwo@example.com\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -926,7 +926,7 @@ Cc: A <author@example.com>,\n \ttwo@example.com\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -963,7 +963,7 @@ Cc: A <author@example.com>,\n \tC O Mitter <committer@example.com>\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -993,7 +993,7 @@ Cc: A <author@example.com>,\n \tC O Mitter <committer@example.com>\n Subject: [PATCH 1/1] Second.\n Date: DATE-STRING\n-Message-Id: MESSAGE-ID-STRING\n+Message-ID: MESSAGE-ID-STRING\n X-Mailer: X-MAILER-STRING\n MIME-Version: 1.0\n Content-Transfer-Encoding: 8bit\n@@ -1478,7 +1478,7 @@ test_expect_success $PREREQ 'To headers from files reset each patch' '\n test_expect_success $PREREQ 'setup expect' '\n cat >email-using-8bit <<\\EOF\n From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n-Message-Id: <bogus-message-id@example.com>\n+Message-ID: <bogus-message-id@example.com>\n From: author@example.com\n Date: Sat, 12 Jun 2010 15:53:58 +0200\n Subject: subject goes here\n@@ -1564,7 +1564,7 @@ test_expect_success $PREREQ '--8bit-encoding overrides sendemail.8bitEncoding' '\n test_expect_success $PREREQ 'setup expect' '\n \tcat >email-using-8bit <<-\\EOF\n \tFrom fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n-\tMessage-Id: <bogus-message-id@example.com>\n+\tMessage-ID: <bogus-message-id@example.com>\n \tFrom: author@example.com\n \tDate: Sat, 12 Jun 2010 15:53:58 +0200\n \tSubject: Dieser Betreff enthält auch einen Umlaut!\n@@ -1593,7 +1593,7 @@ test_expect_success $PREREQ '--8bit-encoding also treats subject' '\n test_expect_success $PREREQ 'setup expect' '\n \tcat >email-using-8bit <<-\\EOF\n \tFrom fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n-\tMessage-Id: <bogus-message-id@example.com>\n+\tMessage-ID: <bogus-message-id@example.com>\n \tFrom: A U Thor <author@example.com>\n \tDate: Sat, 12 Jun 2010 15:53:58 +0200\n \tContent-Type: text/plain; charset=UTF-8\n@@ -1674,7 +1674,7 @@ test_expect_success $PREREQ '8-bit and sendemail.transferencoding=base64' '\n test_expect_success $PREREQ 'setup expect' '\n \tcat >email-using-qp <<-\\EOF\n \tFrom fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n-\tMessage-Id: <bogus-message-id@example.com>\n+\tMessage-ID: <bogus-message-id@example.com>\n \tFrom: A U Thor <author@example.com>\n \tDate: Sat, 12 Jun 2010 15:53:58 +0200\n \tMIME-Version: 1.0\n@@ -1700,7 +1700,7 @@ test_expect_success $PREREQ 'convert from quoted-printable to base64' '\n test_expect_success $PREREQ 'setup expect' \"\n tr -d '\\\\015' | tr '%' '\\\\015' >email-using-crlf <<EOF\n From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n-Message-Id: <bogus-message-id@example.com>\n+Message-ID: <bogus-message-id@example.com>\n From: A U Thor <author@example.com>\n Date: Sat, 12 Jun 2010 15:53:58 +0200\n Content-Type: text/plain; charset=UTF-8\n-- \n2.39.0-56-g57e2c6ebbe\n\n"},{"id":"474641","messageId":"CABPp-BEToCojKF6kGXfjPZVYnYa4JxG+2ggNFD18uo01srGniw@mail.gmail.com","threadId":"58961","inReplyTo":"xmqqsfhgnmqg.fsf@gitster.g","subject":"Re: [PATCH] e-mail workflow: Message-ID is spelled with ID in both capital letters","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2023-04-01T19:48:52Z","receivedAt":"2023-04-01T19:49:14Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Thu, Dec 15, 2022 at 6:03 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> We used to write \"Message-Id:\" and \"Message-ID:\" pretty much\n> interchangeably, and the header name is defined to be case\n> insensitive by the RFCs, but the canonical form \"Message-ID:\" is\n> used throughout the RFC documents, so let's imitate it ourselves.\n>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> ---\n>\n>  Documentation/MyFirstContribution.txt | 14 +++----\n>  Documentation/git-format-patch.txt    |  4 +-\n>  Documentation/git-send-email.txt      |  2 +-\n>  git-send-email.perl                   |  4 +-\n>  log-tree.c                            |  2 +-\n>  mailinfo.c                            |  4 +-\n>  t/t4014-format-patch.sh               | 56 +++++++++++++--------------\n>  t/t4150-am.sh                         |  8 ++--\n>  t/t4258/mbox                          |  2 +-\n>  t/t5100/msg0002                       |  2 +-\n>  t/t5100/msg0003                       |  2 +-\n>  t/t5100/msg0012--message-id           |  2 +-\n>  t/t5100/quoted-cr.mbox                |  4 +-\n>  t/t5100/sample.mbox                   |  6 +--\n>  t/t9001-send-email.sh                 | 38 +++++++++---------\n>  15 files changed, 75 insertions(+), 75 deletions(-)\n>\n> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt\n> index ccfd0cb5f3..2f8b7d597f 100644\n> --- a/Documentation/MyFirstContribution.txt\n> +++ b/Documentation/MyFirstContribution.txt\n> @@ -1171,21 +1171,21 @@ between your last version and now, if it's something significant. You do not\n>  need the exact same body in your second cover letter; focus on explaining to\n>  reviewers the changes you've made that may not be as visible.\n>\n> -You will also need to go and find the Message-Id of your previous cover letter.\n> +You will also need to go and find the Message-ID of your previous cover letter.\n>  You can either note it when you send the first series, from the output of `git\n>  send-email`, or you can look it up on the\n>  https://lore.kernel.org/git[mailing list]. Find your cover letter in the\n> -archives, click on it, then click \"permalink\" or \"raw\" to reveal the Message-Id\n> +archives, click on it, then click \"permalink\" or \"raw\" to reveal the Message-ID\n>  header. It should match:\n>\n>  ----\n> -Message-Id: <foo.12345.author@example.com>\n> +Message-ID: <foo.12345.author@example.com>\n>  ----\n>\n> -Your Message-Id is `<foo.12345.author@example.com>`. This example will be used\n> -below as well; make sure to replace it with the correct Message-Id for your\n> -**previous cover letter** - that is, if you're sending v2, use the Message-Id\n> -from v1; if you're sending v3, use the Message-Id from v2.\n> +Your Message-ID is `<foo.12345.author@example.com>`. This example will be used\n> +below as well; make sure to replace it with the correct Message-ID for your\n> +**previous cover letter** - that is, if you're sending v2, use the Message-ID\n> +from v1; if you're sending v3, use the Message-ID from v2.\n>\n>  While you're looking at the email, you should also note who is CC'd, as it's\n>  common practice in the mailing list to keep all CCs on a thread. You can add\n> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\n> index dfcc7da4c2..508f3ae2c0 100644\n> --- a/Documentation/git-format-patch.txt\n> +++ b/Documentation/git-format-patch.txt\n> @@ -99,7 +99,7 @@ To omit patch numbers from the subject, use `-N`.\n>\n>  If given `--thread`, `git-format-patch` will generate `In-Reply-To` and\n>  `References` headers to make the second and subsequent patch mails appear\n> -as replies to the first mail; this also generates a `Message-Id` header to\n> +as replies to the first mail; this also generates a `Message-ID` header to\n>  reference.\n>\n>  OPTIONS\n> @@ -163,7 +163,7 @@ include::diff-options.txt[]\n>  --no-thread::\n>         Controls addition of `In-Reply-To` and `References` headers to\n>         make the second and subsequent mails appear as replies to the\n> -       first.  Also controls generation of the `Message-Id` header to\n> +       first.  Also controls generation of the `Message-ID` header to\n>         reference.\n>  +\n>  The optional <style> argument can be either `shallow` or `deep`.\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index 765b2df853..b0f438ec99 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -93,7 +93,7 @@ See the CONFIGURATION section for `sendemail.multiEdit`.\n>\n>  --in-reply-to=<identifier>::\n>         Make the first mail (or all the mails with `--no-thread`) appear as a\n> -       reply to the given Message-Id, which avoids breaking threads to\n> +       reply to the given Message-ID, which avoids breaking threads to\n>         provide a new patch series.\n>         The second and subsequent emails will be sent as replies according to\n>         the `--[no-]chain-reply-to` setting.\n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index 5861e99a6e..092b8938c8 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -1530,7 +1530,7 @@ sub send_message {\n>  To: $to${ccline}\n>  Subject: $subject\n>  Date: $date\n> -Message-Id: $message_id\n> +Message-ID: $message_id\n>  \";\n>         if ($use_xmailer) {\n>                 $header .= \"X-Mailer: git-send-email $gitversion\\n\";\n> @@ -1825,7 +1825,7 @@ sub process_file {\n>                                 $has_mime_version = 1;\n>                                 push @xh, $_;\n>                         }\n> -                       elsif (/^Message-Id: (.*)/i) {\n> +                       elsif (/^Message-ID: (.*)/i) {\n>                                 $message_id = $1;\n>                         }\n>                         elsif (/^Content-Transfer-Encoding: (.*)/i) {\n> diff --git a/log-tree.c b/log-tree.c\n> index 1dd5fcbf7b..bbaf26c6b6 100644\n> --- a/log-tree.c\n> +++ b/log-tree.c\n> @@ -440,7 +440,7 @@ void log_write_email_headers(struct rev_info *opt, struct commit *commit,\n>         fprintf(opt->diffopt.file, \"From %s Mon Sep 17 00:00:00 2001\\n\", name);\n>         graph_show_oneline(opt->graph);\n>         if (opt->message_id) {\n> -               fprintf(opt->diffopt.file, \"Message-Id: <%s>\\n\", opt->message_id);\n> +               fprintf(opt->diffopt.file, \"Message-ID: <%s>\\n\", opt->message_id);\n>                 graph_show_oneline(opt->graph);\n>         }\n>         if (opt->ref_message_ids && opt->ref_message_ids->nr > 0) {\n> diff --git a/mailinfo.c b/mailinfo.c\n> index 833d28612f..580c2316a9 100644\n> --- a/mailinfo.c\n> +++ b/mailinfo.c\n> @@ -597,7 +597,7 @@ static int check_header(struct mailinfo *mi,\n>                 ret = 1;\n>                 goto check_header_out;\n>         }\n> -       if (parse_header(line, \"Message-Id\", mi, &sb)) {\n> +       if (parse_header(line, \"Message-ID\", mi, &sb)) {\n>                 if (mi->add_message_id)\n>                         mi->message_id = strbuf_detach(&sb, NULL);\n>                 ret = 1;\n> @@ -829,7 +829,7 @@ static int handle_commit_msg(struct mailinfo *mi, struct strbuf *line)\n>         if (patchbreak(line)) {\n>                 if (mi->message_id)\n>                         strbuf_addf(&mi->log_message,\n> -                                   \"Message-Id: %s\\n\", mi->message_id);\n> +                                   \"Message-ID: %s\\n\", mi->message_id);\n>                 return 1;\n>         }\n>\n> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\n> index de1da4673d..533d21fcaf 100755\n> --- a/t/t4014-format-patch.sh\n> +++ b/t/t4014-format-patch.sh\n> @@ -445,13 +445,13 @@ test_expect_success 'no threading' '\n>\n>  cat >expect.thread <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  ---\n> -Message-Id: <1>\n> +Message-ID: <1>\n>  In-Reply-To: <0>\n>  References: <0>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <0>\n>  References: <0>\n>  EOF\n> @@ -462,15 +462,15 @@ test_expect_success 'thread' '\n>\n>  cat >expect.in-reply-to <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  In-Reply-To: <1>\n>  References: <1>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <1>\n>  References: <1>\n>  ---\n> -Message-Id: <3>\n> +Message-ID: <3>\n>  In-Reply-To: <1>\n>  References: <1>\n>  EOF\n> @@ -482,17 +482,17 @@ test_expect_success 'thread in-reply-to' '\n>\n>  cat >expect.cover-letter <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  ---\n> -Message-Id: <1>\n> +Message-ID: <1>\n>  In-Reply-To: <0>\n>  References: <0>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <0>\n>  References: <0>\n>  ---\n> -Message-Id: <3>\n> +Message-ID: <3>\n>  In-Reply-To: <0>\n>  References: <0>\n>  EOF\n> @@ -503,21 +503,21 @@ test_expect_success 'thread cover-letter' '\n>\n>  cat >expect.cl-irt <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  In-Reply-To: <1>\n>  References: <1>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <0>\n>  References: <1>\n>         <0>\n>  ---\n> -Message-Id: <3>\n> +Message-ID: <3>\n>  In-Reply-To: <0>\n>  References: <1>\n>         <0>\n>  ---\n> -Message-Id: <4>\n> +Message-ID: <4>\n>  In-Reply-To: <0>\n>  References: <1>\n>         <0>\n> @@ -535,13 +535,13 @@ test_expect_success 'thread explicit shallow' '\n>\n>  cat >expect.deep <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  ---\n> -Message-Id: <1>\n> +Message-ID: <1>\n>  In-Reply-To: <0>\n>  References: <0>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <1>\n>  References: <0>\n>         <1>\n> @@ -553,16 +553,16 @@ test_expect_success 'thread deep' '\n>\n>  cat >expect.deep-irt <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  In-Reply-To: <1>\n>  References: <1>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <0>\n>  References: <1>\n>         <0>\n>  ---\n> -Message-Id: <3>\n> +Message-ID: <3>\n>  In-Reply-To: <2>\n>  References: <1>\n>         <0>\n> @@ -576,18 +576,18 @@ test_expect_success 'thread deep in-reply-to' '\n>\n>  cat >expect.deep-cl <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  ---\n> -Message-Id: <1>\n> +Message-ID: <1>\n>  In-Reply-To: <0>\n>  References: <0>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <1>\n>  References: <0>\n>         <1>\n>  ---\n> -Message-Id: <3>\n> +Message-ID: <3>\n>  In-Reply-To: <2>\n>  References: <0>\n>         <1>\n> @@ -600,22 +600,22 @@ test_expect_success 'thread deep cover-letter' '\n>\n>  cat >expect.deep-cl-irt <<EOF\n>  ---\n> -Message-Id: <0>\n> +Message-ID: <0>\n>  In-Reply-To: <1>\n>  References: <1>\n>  ---\n> -Message-Id: <2>\n> +Message-ID: <2>\n>  In-Reply-To: <0>\n>  References: <1>\n>         <0>\n>  ---\n> -Message-Id: <3>\n> +Message-ID: <3>\n>  In-Reply-To: <2>\n>  References: <1>\n>         <0>\n>         <2>\n>  ---\n> -Message-Id: <4>\n> +Message-ID: <4>\n>  In-Reply-To: <3>\n>  References: <1>\n>         <0>\n> diff --git a/t/t4150-am.sh b/t/t4150-am.sh\n> index cdad4b6880..95b48103b8 100755\n> --- a/t/t4150-am.sh\n> +++ b/t/t4150-am.sh\n> @@ -103,7 +103,7 @@ test_expect_success setup '\n>\n>         git format-patch --stdout first >patch1 &&\n>         {\n> -               echo \"Message-Id: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\" &&\n> +               echo \"Message-ID: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\" &&\n>                 echo \"X-Fake-Field: Line One\" &&\n>                 echo \"X-Fake-Field: Line Two\" &&\n>                 echo \"X-Fake-Field: Line Three\" &&\n> @@ -910,7 +910,7 @@ test_expect_success 'am --message-id really adds the message id' '\n>         git am --message-id patch1.eml &&\n>         test_path_is_missing .git/rebase-apply &&\n>         git cat-file commit HEAD | tail -n1 >actual &&\n> -       grep Message-Id patch1.eml >expected &&\n> +       grep Message-ID patch1.eml >expected &&\n>         test_cmp expected actual\n>  '\n>\n> @@ -922,7 +922,7 @@ test_expect_success 'am.messageid really adds the message id' '\n>         git am patch1.eml &&\n>         test_path_is_missing .git/rebase-apply &&\n>         git cat-file commit HEAD | tail -n1 >actual &&\n> -       grep Message-Id patch1.eml >expected &&\n> +       grep Message-ID patch1.eml >expected &&\n>         test_cmp expected actual\n>  '\n>\n> @@ -933,7 +933,7 @@ test_expect_success 'am --message-id -s signs off after the message id' '\n>         git am -s --message-id patch1.eml &&\n>         test_path_is_missing .git/rebase-apply &&\n>         git cat-file commit HEAD | tail -n2 | head -n1 >actual &&\n> -       grep Message-Id patch1.eml >expected &&\n> +       grep Message-ID patch1.eml >expected &&\n>         test_cmp expected actual\n>  '\n>\n> diff --git a/t/t4258/mbox b/t/t4258/mbox\n> index c62819f3d2..1ae528ba78 100644\n> --- a/t/t4258/mbox\n> +++ b/t/t4258/mbox\n> @@ -2,7 +2,7 @@ From: A U Thor <mail@example.com>\n>  To: list@example.org\n>  Subject: [PATCH v2] sample\n>  Date: Mon,  3 Aug 2020 22:40:55 +0700\n> -Message-Id: <msg-id@example.com>\n> +Message-ID: <msg-id@example.com>\n>  Content-Type: text/plain; charset=\"utf-8\"\n>  Content-Transfer-Encoding: base64\n>\n> diff --git a/t/t5100/msg0002 b/t/t5100/msg0002\n> index e2546ec733..1089382425 100644\n> --- a/t/t5100/msg0002\n> +++ b/t/t5100/msg0002\n> @@ -3,7 +3,7 @@ message:\n>\n>  From: Nit Picker <nit.picker@example.net>\n>  Subject: foo is too old\n> -Message-Id: <nitpicker.12121212@example.net>\n> +Message-ID: <nitpicker.12121212@example.net>\n>\n>  Hopefully this would fix the problem stated there.\n>\n> diff --git a/t/t5100/msg0003 b/t/t5100/msg0003\n> index 1ac68101b1..3402b534a6 100644\n> --- a/t/t5100/msg0003\n> +++ b/t/t5100/msg0003\n> @@ -3,7 +3,7 @@ message:\n>\n>  From: Nit Picker <nit.picker@example.net>\n>  Subject: foo is too old\n> -Message-Id: <nitpicker.12121212@example.net>\n> +Message-ID: <nitpicker.12121212@example.net>\n>\n>  Hopefully this would fix the problem stated there.\n>\n> diff --git a/t/t5100/msg0012--message-id b/t/t5100/msg0012--message-id\n> index 376e26e9ae..44482958ce 100644\n> --- a/t/t5100/msg0012--message-id\n> +++ b/t/t5100/msg0012--message-id\n> @@ -5,4 +5,4 @@ docutils заменён на python-docutils\n>  python-docutils. В то время как сам rest2web не нужен.\n>\n>  Signed-off-by: Dmitriy Blinov <bda@mnsspb.ru>\n> -Message-Id: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\n> +Message-ID: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\n> diff --git a/t/t5100/quoted-cr.mbox b/t/t5100/quoted-cr.mbox\n> index 909021bb7a..a529d4de08 100644\n> --- a/t/t5100/quoted-cr.mbox\n> +++ b/t/t5100/quoted-cr.mbox\n> @@ -3,7 +3,7 @@ From: A U Thor <mail@example.com>\n>  To: list@example.org\n>  Subject: [PATCH v2] sample\n>  Date: Mon,  3 Aug 2020 22:40:55 +0700\n> -Message-Id: <msg-id@example.com>\n> +Message-ID: <msg-id@example.com>\n>  Content-Type: text/plain; charset=\"utf-8\"\n>  Content-Transfer-Encoding: base64\n>\n> @@ -27,7 +27,7 @@ From: A U Thor <mail@example.com>\n>  To: list@example.org\n>  Subject: [PATCH v2] sample\n>  Date: Mon,  3 Aug 2020 22:40:55 +0700\n> -Message-Id: <msg-id2@example.com>\n> +Message-ID: <msg-id2@example.com>\n>  Content-Type: text/plain; charset=\"utf-8\"\n>  Content-Transfer-Encoding: base64\n>\n> diff --git a/t/t5100/sample.mbox b/t/t5100/sample.mbox\n> index 6d4d0e4474..4a54ee5171 100644\n> --- a/t/t5100/sample.mbox\n> +++ b/t/t5100/sample.mbox\n> @@ -35,7 +35,7 @@ message:\n>\n>  From: Nit Picker <nit.picker@example.net>\n>  Subject: foo is too old\n> -Message-Id: <nitpicker.12121212@example.net>\n> +Message-ID: <nitpicker.12121212@example.net>\n>\n>  Hopefully this would fix the problem stated there.\n>\n> @@ -78,7 +78,7 @@ message:\n>\n>  From: Nit Picker <nit.picker@example.net>\n>  Subject: foo is too old\n> -Message-Id: <nitpicker.12121212@example.net>\n> +Message-ID: <nitpicker.12121212@example.net>\n>\n>  Hopefully this would fix the problem stated there.\n>\n> @@ -508,7 +508,7 @@ From bda@mnsspb.ru Wed Nov 12 17:54:41 2008\n>  From: Dmitriy Blinov <bda@mnsspb.ru>\n>  To: navy-patches@dinar.mns.mnsspb.ru\n>  Date: Wed, 12 Nov 2008 17:54:41 +0300\n> -Message-Id: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\n> +Message-ID: <1226501681-24923-1-git-send-email-bda@mnsspb.ru>\n>  X-Mailer: git-send-email 1.5.6.5\n>  MIME-Version: 1.0\n>  Content-Type: text/plain;\n> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\n> index 1130ef21b3..5c2c282d08 100755\n> --- a/t/t9001-send-email.sh\n> +++ b/t/t9001-send-email.sh\n> @@ -12,7 +12,7 @@ PREREQ=\"PERL\"\n>\n>  replace_variable_fields () {\n>         sed     -e \"s/^\\(Date:\\).*/\\1 DATE-STRING/\" \\\n> -               -e \"s/^\\(Message-Id:\\).*/\\1 MESSAGE-ID-STRING/\" \\\n> +               -e \"s/^\\(Message-ID:\\).*/\\1 MESSAGE-ID-STRING/\" \\\n>                 -e \"s/^\\(X-Mailer:\\).*/\\1 X-MAILER-STRING/\"\n>  }\n>\n> @@ -225,7 +225,7 @@ Cc: cc@example.com,\n>         two@example.com\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  In-Reply-To: <unique-message-id@example.com>\n>  References: <unique-message-id@example.com>\n> @@ -617,7 +617,7 @@ test_expect_success $PREREQ 'In-Reply-To without --chain-reply-to' '\n>         sed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt1 >actual &&\n>         test_cmp expect actual &&\n>         # Second and subsequent messages are replies to the first one\n> -       sed -n -e \"s/^Message-Id: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n> +       sed -n -e \"s/^Message-ID: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n>         sed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt2 >actual &&\n>         test_cmp expect actual &&\n>         sed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt3 >actual &&\n> @@ -637,10 +637,10 @@ test_expect_success $PREREQ 'In-Reply-To with --chain-reply-to' '\n>                 2>errors &&\n>         sed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt1 >actual &&\n>         test_cmp expect actual &&\n> -       sed -n -e \"s/^Message-Id: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n> +       sed -n -e \"s/^Message-ID: *\\(.*\\)/\\1/p\" msgtxt1 >expect &&\n>         sed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt2 >actual &&\n>         test_cmp expect actual &&\n> -       sed -n -e \"s/^Message-Id: *\\(.*\\)/\\1/p\" msgtxt2 >expect &&\n> +       sed -n -e \"s/^Message-ID: *\\(.*\\)/\\1/p\" msgtxt2 >expect &&\n>         sed -n -e \"s/^In-Reply-To: *\\(.*\\)/\\1/p\" msgtxt3 >actual &&\n>         test_cmp expect actual\n>  '\n> @@ -713,7 +713,7 @@ Cc: cc@example.com,\n>         two@example.com\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -759,7 +759,7 @@ Cc: A <author@example.com>,\n>         two@example.com\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -796,7 +796,7 @@ Cc: A <author@example.com>,\n>         C O Mitter <committer@example.com>\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -824,7 +824,7 @@ From: Example <from@example.com>\n>  To: to@example.com\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -860,7 +860,7 @@ Cc: A <author@example.com>,\n>         cc-cmd@example.com\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -893,7 +893,7 @@ Cc: A <author@example.com>,\n>         two@example.com\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -926,7 +926,7 @@ Cc: A <author@example.com>,\n>         two@example.com\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -963,7 +963,7 @@ Cc: A <author@example.com>,\n>         C O Mitter <committer@example.com>\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -993,7 +993,7 @@ Cc: A <author@example.com>,\n>         C O Mitter <committer@example.com>\n>  Subject: [PATCH 1/1] Second.\n>  Date: DATE-STRING\n> -Message-Id: MESSAGE-ID-STRING\n> +Message-ID: MESSAGE-ID-STRING\n>  X-Mailer: X-MAILER-STRING\n>  MIME-Version: 1.0\n>  Content-Transfer-Encoding: 8bit\n> @@ -1478,7 +1478,7 @@ test_expect_success $PREREQ 'To headers from files reset each patch' '\n>  test_expect_success $PREREQ 'setup expect' '\n>  cat >email-using-8bit <<\\EOF\n>  From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n> -Message-Id: <bogus-message-id@example.com>\n> +Message-ID: <bogus-message-id@example.com>\n>  From: author@example.com\n>  Date: Sat, 12 Jun 2010 15:53:58 +0200\n>  Subject: subject goes here\n> @@ -1564,7 +1564,7 @@ test_expect_success $PREREQ '--8bit-encoding overrides sendemail.8bitEncoding' '\n>  test_expect_success $PREREQ 'setup expect' '\n>         cat >email-using-8bit <<-\\EOF\n>         From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n> -       Message-Id: <bogus-message-id@example.com>\n> +       Message-ID: <bogus-message-id@example.com>\n>         From: author@example.com\n>         Date: Sat, 12 Jun 2010 15:53:58 +0200\n>         Subject: Dieser Betreff enthält auch einen Umlaut!\n> @@ -1593,7 +1593,7 @@ test_expect_success $PREREQ '--8bit-encoding also treats subject' '\n>  test_expect_success $PREREQ 'setup expect' '\n>         cat >email-using-8bit <<-\\EOF\n>         From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n> -       Message-Id: <bogus-message-id@example.com>\n> +       Message-ID: <bogus-message-id@example.com>\n>         From: A U Thor <author@example.com>\n>         Date: Sat, 12 Jun 2010 15:53:58 +0200\n>         Content-Type: text/plain; charset=UTF-8\n> @@ -1674,7 +1674,7 @@ test_expect_success $PREREQ '8-bit and sendemail.transferencoding=base64' '\n>  test_expect_success $PREREQ 'setup expect' '\n>         cat >email-using-qp <<-\\EOF\n>         From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n> -       Message-Id: <bogus-message-id@example.com>\n> +       Message-ID: <bogus-message-id@example.com>\n>         From: A U Thor <author@example.com>\n>         Date: Sat, 12 Jun 2010 15:53:58 +0200\n>         MIME-Version: 1.0\n> @@ -1700,7 +1700,7 @@ test_expect_success $PREREQ 'convert from quoted-printable to base64' '\n>  test_expect_success $PREREQ 'setup expect' \"\n>  tr -d '\\\\015' | tr '%' '\\\\015' >email-using-crlf <<EOF\n>  From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001\n> -Message-Id: <bogus-message-id@example.com>\n> +Message-ID: <bogus-message-id@example.com>\n>  From: A U Thor <author@example.com>\n>  Date: Sat, 12 Jun 2010 15:53:58 +0200\n>  Content-Type: text/plain; charset=UTF-8\n> --\n> 2.39.0-56-g57e2c6ebbe\n\nFound this patch mentioned with the state Needs Review in What's\nCooking.  I looked through the RFC to verify they use Message-ID as\nyou state, the logic makes sense to me, and I reviewed the patch\n(`--color-words=.` is very helpful).  I do note that we have a few\nMessage-Id left after this -- both in old release notes, and in the\nt/t4256/1/mailinfo.c(.orig)? files, but we don't want to change the\nformer and the latter is just testcase sample code.  So, looks good to\nme:\n\nReviewed-by: Elijah Newren <newren@gmail.com>\n"},{"id":"475018","messageId":"20230407193333.1620-1-mirth.hickford@gmail.com","threadId":"58961","inReplyTo":"xmqqsfhgnmqg.fsf@gitster.g","subject":"Re: [PATCH] e-mail workflow: Message-ID is spelled with ID in both capital letters","fromName":"M Hickford","fromEmail":"mirth.hickford@gmail.com","sentAt":"2023-04-07T19:33:33Z","receivedAt":"2023-04-07T19:34:12Z","isPatch":true,"sender":{"key":"mirth.hickford@gmail.com","avatar":"https://avatars.githubusercontent.com/u/105314?v=4"},"body":"LGTM\n\nReviewed-by: mirth.hickford@gmail.com\n"}]}