{"thread":{"id":"58920","subject":"[PATCH] Fix a couple of typos in the v2.39.0 release notes","startedAt":"2022-12-08T14:48:15Z","lastAt":"2022-12-09T02:02:18Z","messageCount":2,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"468787","messageId":"pull.1442.git.1670510887255.gitgitgadget@gmail.com","threadId":"58920","inReplyTo":null,"subject":"[PATCH] Fix a couple of typos in the v2.39.0 release notes","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-12-08T14:48:07Z","receivedAt":"2022-12-08T14:48:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nSigned-off-by: Johannes Schindelin \n---\n Fix a couple of typos in the v2.39.0 release notes\n \n I cheated: I used VS Code's \"Code Spell Checker\" ;-)\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1442%2Fdscho%2Frelease-notes-typos-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1442/dscho/release-notes-typos-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1442\n\n Documentation/RelNotes/2.39.0.txt | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/RelNotes/2.39.0.txt b/Documentation/RelNotes/2.39.0.txt\nindex 3b8b0c010f9..1eb16534776 100644\n--- a/Documentation/RelNotes/2.39.0.txt\n+++ b/Documentation/RelNotes/2.39.0.txt\n@@ -194,7 +194,7 @@ Fixes since v2.38\n * Force C locale while running tests around httpd to make sure we can\n find expected error messages in the log.\n \n- * Fix a logic in \"mailinfo -b\" that miscomputed the length of a\n+ * Fix a logic in \"mailinfo -b\" that mis-computed the length of a\n substring, which lead to an out-of-bounds access.\n \n * The codepath to sign learned to report errors when it fails to read\n@@ -214,7 +214,7 @@ Fixes since v2.38\n * Clarify that \"the sentence after : prefix does not begin with\n a capital letter\" rule applies only to the commit title.\n \n- * \"git branch --edit-description\" on an unborh branch misleadingly\n+ * \"git branch --edit-description\" on an unborn branch misleadingly\n said that no such branch exists, which has been corrected.\n \n * Work around older clang that warns against C99 zero initialization\n@@ -264,7 +264,7 @@ Fixes since v2.38\n \n * \"git diff --stat\" etc. were invented back when everything was ASCII\n and strlen() was a way to measure the display width of a string;\n- adjust them to compute the display width assuming UTF-8 pathnames.\n+ adjust them to compute the display width assuming UTF-8 path names.\n (merge ce8529b2bb tb/diffstat-with-utf8-strwidth later to maint).\n \n * \"git branch --edit-description\" can exit with status -1 which is\n@@ -289,7 +289,7 @@ Fixes since v2.38\n option now implies --reapply-cherry-picks and --no-fork-point\n options.\n \n- * The way \"git repack\" creared temporary files when it received a\n+ * The way \"git repack\" created temporary files when it received a\n signal was prone to deadlocking, which has been corrected.\n \n * Various tests exercising the transfer.credentialsInUrl\n\nbase-commit: 2e71cbbddd64695d43383c25c7a054ac4ff86882\n-- \ngitgitgadget\n"},{"id":"468813","messageId":"xmqqwn711gir.fsf@gitster.g","threadId":"58920","inReplyTo":"pull.1442.git.1670510887255.gitgitgadget@gmail.com","subject":"Re: [PATCH] Fix a couple of typos in the v2.39.0 release notes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-12-09T02:02:04Z","receivedAt":"2022-12-09T02:02:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> From: Johannes Schindelin \n>\n> Signed-off-by: Johannes Schindelin \n> ---\n> Fix a couple of typos in the v2.39.0 release notes\n> \n> I cheated: I used VS Code's \"Code Spell Checker\" ;-)\n\nCheating is good. Automation is good. Thanks.\n\n> diff --git a/Documentation/RelNotes/2.39.0.txt b/Documentation/RelNotes/2.39.0.txt\n> index 3b8b0c010f9..1eb16534776 100644\n> --- a/Documentation/RelNotes/2.39.0.txt\n> +++ b/Documentation/RelNotes/2.39.0.txt\n> @@ -194,7 +194,7 @@ Fixes since v2.38\n> * Force C locale while running tests around httpd to make sure we can\n> find expected error messages in the log.\n> \n> - * Fix a logic in \"mailinfo -b\" that miscomputed the length of a\n> + * Fix a logic in \"mailinfo -b\" that mis-computed the length of a\n\nI'd scatch this, as we'd rather keep a spelling that we can even\nfind at https://m-w.com/dictionary/miscompute without the dash in\nbetween.\n\n> @@ -214,7 +214,7 @@ Fixes since v2.38\n> * Clarify that \"the sentence after : prefix does not begin with\n> a capital letter\" rule applies only to the commit title.\n> \n> - * \"git branch --edit-description\" on an unborh branch misleadingly\n> + * \"git branch --edit-description\" on an unborn branch misleadingly\n\nThanks. 'h' and 'n' not just sit next to each other on my keyboard,\nthey look somewhat similar ;-)\n\n> @@ -264,7 +264,7 @@ Fixes since v2.38\n> \n> * \"git diff --stat\" etc. were invented back when everything was ASCII\n> and strlen() was a way to measure the display width of a string;\n> - adjust them to compute the display width assuming UTF-8 pathnames.\n> + adjust them to compute the display width assuming UTF-8 path names.\n> (merge ce8529b2bb tb/diffstat-with-utf8-strwidth later to maint).\n\nI dunno. Even without trying to get accurate counts, we can see the\ngeneral trend of which one we prefer:\n\n $ git grep -e 'pathname' Documentation ':!Documentation/RelNotes' | wc -l\n 124\n $ git grep -e 'path name' Documentation ':!Documentation/RelNotes' | wc -l\n 28\n\t\nIn the above, RelNotes/ subhierarchy is excluded to avoid counting _my_\npreference too much.\n\nI didn't manage to find any authoritative reference, but the snippets\ngiven on a query\n\nhttps://letmegooglethat.com/?q=%22pathname%22%20vs%20%22path%20name%22\n\nwere fun. I even saw some claims that \"pathnames are sometimes\nspelled as path names\", which is pretty much in line with what I saw\nin these snippets.\n\n> * \"git branch --edit-description\" can exit with status -1 which is\n> @@ -289,7 +289,7 @@ Fixes since v2.38\n> option now implies --reapply-cherry-picks and --no-fork-point\n> options.\n> \n> - * The way \"git repack\" creared temporary files when it received a\n> + * The way \"git repack\" created temporary files when it received a\n\nThanks. That's another good one.\n\n"}]}