{"thread":{"id":"58909","subject":"[PATCH] CI: upgrade to macos-12, and pin OSX version","startedAt":"2022-12-06T19:58:06Z","lastAt":"2022-12-07T00:58:45Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"468637","messageId":"patch-1.1-4c1dcc89e7a-20221206T195552Z-avarab@gmail.com","threadId":"58909","inReplyTo":null,"subject":"[PATCH] CI: upgrade to macos-12, and pin OSX version","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-12-06T19:57:56Z","receivedAt":"2022-12-06T19:58:06Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Per [1] and the warnings our CI is emitting GitHub is phasing in\n\"macos-12\" as their \"macos-latest\".\n\nAs with [2], let's pin our image to a specific version so that we're\nnot having it swept from under us, and our upgrade cycle can be more\npredictable than whenever GitHub changes their images.\n\n1. https://github.com/actions/runner-images/issues/6384\n2. 0178420b9ca (github-actions: run gcc-8 on ubuntu-20.04 image,\n   2022-11-25)\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nThis is intended as a sibling to\nhttps://lore.kernel.org/git/xmqq1qpd9bys.fsf@gitster.g/, and along\nwith another change I'm about to submit should make the CI warning\nfree.\n\n .github/workflows/main.yml | 4 ++--\n ci/install-dependencies.sh | 2 +-\n ci/lib.sh                  | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 9afacfa0b33..1ac11648854 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -238,11 +238,11 @@ jobs:\n             pool: ubuntu-20.04\n           - jobname: osx-clang\n             cc: clang\n-            pool: macos-latest\n+            pool: macos-12\n           - jobname: osx-gcc\n             cc: gcc\n             cc_package: gcc-9\n-            pool: macos-latest\n+            pool: macos-12\n           - jobname: linux-gcc-default\n             cc: gcc\n             pool: ubuntu-latest\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex d8fafc8ed2d..4f407530d30 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -30,7 +30,7 @@ ubuntu-*)\n \t\tcp git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs .\n \tpopd\n \t;;\n-macos-latest)\n+macos-*)\n \texport HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_INSTALL_CLEANUP=1\n \t# Uncomment this if you want to run perf tests:\n \t# brew install gnu-time\ndiff --git a/ci/lib.sh b/ci/lib.sh\nindex cb30699f34d..706e3ba7e93 100755\n--- a/ci/lib.sh\n+++ b/ci/lib.sh\n@@ -252,7 +252,7 @@ ubuntu-*)\n \tGIT_LFS_PATH=\"$HOME/custom/git-lfs\"\n \texport PATH=\"$GIT_LFS_PATH:$P4_PATH:$PATH\"\n \t;;\n-macos-latest)\n+macos-*)\n \tif [ \"$jobname\" = osx-gcc ]\n \tthen\n \t\tMAKEFLAGS=\"$MAKEFLAGS PYTHON_PATH=$(which python3)\"\n-- \n2.39.0.rc2.1017.g5f0c708352f\n\n"},{"id":"468661","messageId":"Y4/lPmD5Dldn/USd@nand.local","threadId":"58909","inReplyTo":"patch-1.1-4c1dcc89e7a-20221206T195552Z-avarab@gmail.com","subject":"Re: [PATCH] CI: upgrade to macos-12, and pin OSX version","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-12-07T00:58:38Z","receivedAt":"2022-12-07T00:58:45Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Dec 06, 2022 at 08:57:56PM +0100, Ævar Arnfjörð Bjarmason wrote:\n>  .github/workflows/main.yml | 4 ++--\n>  ci/install-dependencies.sh | 2 +-\n>  ci/lib.sh                  | 2 +-\n>  3 files changed, 4 insertions(+), 4 deletions(-)\n\nAll looks very reasonable to me. I'm glad that we're not going to be\nsubject to any more random CI breakage than necessary when GitHub\npublishes new images.\n\nOn the flip-side, we'll have to remember to bump these ourselves, but\nmacOS releases are infrequent enough that it doesn't seem like that big\nof a deal to me.\n\nSo I'm in favor of this change, too Thanks for working on both of these.\n\n\nThanks,\nTaylor\n"}]}