{"thread":{"id":"5890","subject":"[PATCH] gitweb: Do not automatically append \" git\" to custom site name","startedAt":"2006-10-11T20:22:28Z","lastAt":"2006-10-24T03:18:39Z","messageCount":4,"participants":["Petr Baudis","Jakub Narebski","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"28626","messageId":"20061011202228.27279.97423.stgit@rover","threadId":"5890","inReplyTo":null,"subject":"[PATCH] gitweb: Do not automatically append \" git\" to custom site name","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-11T20:22:28Z","receivedAt":"2006-10-11T20:22:28Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"If you customized the site name, you probably do not want the \" git\"\nappended so that the page title is not bastardized; I want repo.or.cz pages\ntitled \"Public Git Hosting\", not \"Public Git Hosting git\" (what's hosting\nwhat?).\n\nThis slightly changes the $site_name semantics but only very\ninsignificantly.\n\nSigned-off-by: Petr Baudis <pasky@suse.cz>\n---\n\n gitweb/gitweb.perl |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c2dfdab..d165fdc 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -39,7 +39,7 @@ our $home_link_str = \"++GITWEB_HOME_LINK\n \n # name of your site or organization to appear in page titles\n # replace this with something more descriptive for clearer bookmarks\n-our $site_name = \"++GITWEB_SITENAME++\" || $ENV{'SERVER_NAME'} || \"Untitled\";\n+our $site_name = \"++GITWEB_SITENAME++\" || \"$ENV{'SERVER_NAME'} Git\" || \"Untitled Git\";\n \n # filename of html text to include at top of each page\n our $site_header = \"++GITWEB_SITE_HEADER++\";\n@@ -1455,7 +1455,7 @@ sub git_header_html {\n \tmy $status = shift || \"200 OK\";\n \tmy $expires = shift;\n \n-\tmy $title = \"$site_name git\";\n+\tmy $title = \"$site_name\";\n \tif (defined $project) {\n \t\t$title .= \" - $project\";\n \t\tif (defined $action) {\n@@ -3842,7 +3842,7 @@ sub git_opml {\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n <opml version=\"1.0\">\n <head>\n-  <title>$site_name Git OPML Export</title>\n+  <title>$site_name OPML Export</title>\n </head>\n <body>\n <outline text=\"git RSS feeds\">\n"},{"id":"28629","messageId":"egjkbc$ht$1@sea.gmane.org","threadId":"5890","inReplyTo":"20061011202228.27279.97423.stgit@rover","subject":"Re: [PATCH] gitweb: Do not automatically append \" git\" to custom site name","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-11T20:31:42Z","receivedAt":"2006-10-11T20:31:42Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Petr Baudis wrote:\n\n> +our $site_name = \"++GITWEB_SITENAME++\" || \"$ENV{'SERVER_NAME'} Git\" || \"Untitled Git\";\n\nI'd use perhaps \"[$ENV{'SERVER_NAME'}] Git\".\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"28641","messageId":"20061011220621.GA4041@coredump.intra.peff.net","threadId":"5890","inReplyTo":"20061011202228.27279.97423.stgit@rover","subject":"Re: [PATCH] gitweb: Do not automatically append \" git\" to custom site name","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2006-10-11T22:06:21Z","receivedAt":"2006-10-11T22:06:21Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Oct 11, 2006 at 10:22:28PM +0200, Petr Baudis wrote:\n\n> +our $site_name = \"++GITWEB_SITENAME++\" || \"$ENV{'SERVER_NAME'} Git\" || \"Untitled Git\";\n\nThis will never show \"Untitled\" (instead it shows \" Git\") and will cause\na perl warning if $ENV{SERVER_NAME} is not defined and warnings are\nenabled (which tye are in gitweb).\n\nI think this is what you want:\n\nour $site_name = \"++GITWEB_SITENAME++\" ||\n                 ($ENV{SERVER_NAME} || \"Untitled\") . \" Git\";\n\n-Peff\n"},{"id":"29799","messageId":"20061024031838.3323.14282.stgit@rover","threadId":"5890","inReplyTo":"20061011220621.GA4041@coredump.intra.peff.net","subject":"[PATCH] gitweb: Do not automatically append \" git\" to custom site name","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-24T03:18:39Z","receivedAt":"2006-10-24T03:18:39Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"If you customized the site name, you probably do not want the \" git\"\nappended so that the page title is not bastardized; I want repo.or.cz pages\ntitled \"Public Git Hosting\", not \"Public Git Hosting git\" (what's hosting\nwhat?).\n\nThis slightly changes the $site_name semantics but only very\ninsignificantly.\n\nSigned-off-by: Petr Baudis <pasky@suse.cz>\n---\n\n gitweb/gitweb.perl |    7 ++++---\n 1 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex e77fc11..1e80f43 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -39,7 +39,8 @@ our $home_link_str = \"++GITWEB_HOME_LINK\n \n # name of your site or organization to appear in page titles\n # replace this with something more descriptive for clearer bookmarks\n-our $site_name = \"++GITWEB_SITENAME++\" || $ENV{'SERVER_NAME'} || \"Untitled\";\n+our $site_name = \"++GITWEB_SITENAME++\"\n+                 || ($ENV{'SERVER_NAME'} || \"Untitled\") . \" Git\";\n \n # filename of html text to include at top of each page\n our $site_header = \"++GITWEB_SITE_HEADER++\";\n@@ -1433,7 +1434,7 @@ sub git_header_html {\n \tmy $status = shift || \"200 OK\";\n \tmy $expires = shift;\n \n-\tmy $title = \"$site_name git\";\n+\tmy $title = \"$site_name\";\n \tif (defined $project) {\n \t\t$title .= \" - $project\";\n \t\tif (defined $action) {\n@@ -3847,7 +3848,7 @@ sub git_opml {\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n <opml version=\"1.0\">\n <head>\n-  <title>$site_name Git OPML Export</title>\n+  <title>$site_name OPML Export</title>\n </head>\n <body>\n <outline text=\"git RSS feeds\">\n"}]}